- 19 Apr, 2018 1 commit
-
-
blackst0ne authored
In `arel 7.0` (`7.1.4` version is used for rails5) there were introduced some changes that break our code in the `User#manageable_groups` method. The problem is that `arel_table[:id].in(Arel::Nodes::SqlLiteral)` generates wrong `IN ()` construction. The selection for `IN` is missing: => "\"namespaces\".\"id\" IN (0)" That caused such spec errors for the `rails5` branch: ``` 4) User groups with child groups #manageable_groups does not include duplicates if a membership was added for the subgroup Failure/Error: expect(user.manageable_groups).to contain_exactly(group, subgroup) expected collection contained: [#<Group id:232 @group29>, #<Group id:234 @group29/group30>] actual collection contained: [] the missing elements were: [#<Group id:232 @group29>, #<Group id:234 @group29/group30>] # ./spec/models/user_spec.rb:699:in `block (5 levels) in <top (required)>' # ./spec/spec_helper.rb:188:in `block (2 levels) in <top (required)>' # /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec/retry.rb:112:in `block in run' # /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec/retry.rb:101:in `loop' # /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec/retry.rb:101:in `run' # /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry' # /var/lib/gems/2.3.0/gems/rspec-retry-0.4.6/lib/rspec/retry.rb:30:in `block (2 levels) in setup' ``` This commit changes `User#manageable_groups` in the way to drop the usage of `Arel::Nodes::SqlLiteral` and adds usage of raw SQL query. This change should be updated when we're migrated to Rails 5.2 because arel was fixed in `9.0.0` (which is used in Rails 5.2).
-
- 11 Apr, 2018 39 commits
-
-
Robert Speicher authored
Fix finding wiki file when Gitaly is enabled Closes gitaly#1126 See merge request gitlab-org/gitlab-ce!18317
-
Nick Thomas authored
[CE Backport] Propagate broadcast messages to secondaries See merge request gitlab-org/gitlab-ce!18324
-
Michael Kozono authored
-
Clement Ho authored
Limit dropdown toggle width for protected branches / tags See merge request gitlab-org/gitlab-ce!18212
-
Clement Ho authored
Document example for sprintf without escaping See merge request gitlab-org/gitlab-ce!16712
-
Clement Ho authored
Add i18n and update specs for UnresolvedDiscussions vue component See merge request gitlab-org/gitlab-ce!17866
-
Clement Ho authored
Vertical misalignment of login box header Closes #41748 See merge request gitlab-org/gitlab-ce!16275
-
Clement Ho authored
Add possibility to filter Karma spec files by path Closes #40899 See merge request gitlab-org/gitlab-ce!16102
-
Filipa Lacerda authored
Move TimeTrackingEstimateOnlyPane vue component See merge request gitlab-org/gitlab-ce!18318
-
Takuya Noguchi authored
-
Yorick Peterse authored
[Rails5] Update Event#subclass_from_attributes method See merge request gitlab-org/gitlab-ce!18312
-
🚄 Job van der Voort 🚀 authored
Link Monitor docs to the front page Closes #45006 See merge request gitlab-org/gitlab-ce!18314
-
George Tsiolis authored
-
Ahmad Sherif authored
Fixes gitaly#1126
-
Rémy Coutable authored
Resolve "tree/master shows incorrect CI build status" Closes #44541 See merge request gitlab-org/gitlab-ce!17995
-
Lin Jen-Shin authored
-
Clement Ho authored
Replace vue resource with axios for pipeline details page See merge request gitlab-org/gitlab-ce!18285
-
Filipa Lacerda authored
-
Douwe Maan authored
Client implementation for InfoAttributes See merge request gitlab-org/gitlab-ce!18261
-
Grzegorz Bizon authored
Resolve "Illustration for the case where the job has finished and the log was erased" Closes #45159 See merge request gitlab-org/gitlab-ce!18253
-
Achilleas Pipinellis authored
-
Zeger-Jan van de Weg authored
Clients can now request the attributes from `$GIT_DIR/info/attributes` through Gitaly. The Gitaly migration is described in gitlab-org/gitaly#1082. The parser algorithm was implemented in a way it could handle both file contents or a File handle, and both were already tested. Other than that, using the boy scout rule, I've removed a class, InfoAttributes, as it was delegating everything to the parser and therefor wasn't really needed in my opinion.
-
Winnie Hellmann authored
-
Grzegorz Bizon authored
Resolve "Clean outdated flaky specs from the flaky specs report" Closes #37721 See merge request gitlab-org/gitlab-ce!18196
-
Rémy Coutable authored
Replace the `project/issues/milestones.feature` spinach test with an rspec analog See merge request gitlab-org/gitlab-ce!18300
-
blackst0ne authored
-
Rémy Coutable authored
Replace the `project/commits/branches.feature` spinach test with an rspec analog See merge request gitlab-org/gitlab-ce!18302
-
blackst0ne authored
-
Fatih Acet authored
Resolve "When editing a comment in an issue, the preview mode is toggled in the main textarea" Closes #44697 See merge request gitlab-org/gitlab-ce!18303
-
Simon Knox authored
-
blackst0ne authored
In Rails 5.0 the `ActiveRecord::Inheritance::subclass_from_attributes` method was updated. Now it calls the `find_sti_class` method [1] which is overriden in the `Event` model and returns needed class (`Event` vs `PushEvent`). [1]: https://github.com/rails/rails/blob/5-0-stable/activerecord/lib/active_record/inheritance.rb#L209 This commit fixes the errors like ``` 143) User#contributed_projects doesn't include IDs for unrelated projects Failure/Error: action = attrs.with_indifferent_access[inheritance_column].to_i NoMethodError: undefined method `with_indifferent_access' for nil:NilClass # ./app/models/event.rb:118:in `subclass_from_attributes' ``` which are raised on the `RAILS5=1 rspec ...` command.
-
Rémy Coutable authored
Branch with a commit detection defaults to Gitaly See merge request gitlab-org/gitlab-ce!18304
-
Rémy Coutable authored
Tag with a commit detection defaults to Gitaly See merge request gitlab-org/gitlab-ce!18305
-
Kamil Trzciński authored
Fix file-specific variables collection item option Closes gitlab-ee#5444 See merge request gitlab-org/gitlab-ce!18307
-
Grzegorz Bizon authored
-
Tim Zallmann authored
Fixed markdown preview in IDE not working for new files See merge request gitlab-org/gitlab-ce!18287
-
Douwe Maan authored
[Rails5] Fix admin/application_settings_controller See merge request gitlab-org/gitlab-ce!18275
-
Zeger-Jan van de Weg authored
By default this was an OPT_IN RPC, and now graduates to OPT_OUT as the acceptance testing was successful in: gitaly#1009 This follows the conventions of our [migration process](https://gitlab.com/gitlab-org/gitaly/blob/master/doc/MIGRATION_PROCESS.md)
-
Zeger-Jan van de Weg authored
By default this was an OPT_IN RPC, and now graduates to OPT_OUT as the acceptance testing was successful in: https://gitlab.com/gitlab-org/gitaly/issues/1008 This follows the conventions of our [migration process](https://gitlab.com/gitlab-org/gitaly/blob/master/doc/MIGRATION_PROCESS.md)
-