An error occurred fetching the project authors.
  1. 02 Jun, 2016 4 commits
  2. 01 Jun, 2016 2 commits
    • Yorick Peterse's avatar
      Refactor Participable · 580d2501
      Yorick Peterse authored
      There are several changes to this module:
      
      1. The use of an explicit stack in Participable#participants
      2. Proc behaviour has been changed
      3. Batch permissions checking
      
      == Explicit Stack
      
      Participable#participants no longer uses recursion to process "self" and
      all child objects, instead it uses an Array and processes objects in
      breadth-first order. This allows us to for example create a single
      Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using
      a ReferenceExtractor removes the need for running potentially many SQL
      queries every time a Proc is called on a new object.
      
      == Proc Behaviour Changed
      
      Previously a Proc in Participable was expected to return an Array of
      User instances. This has been changed and instead it's now expected that
      a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return
      value of the Proc is ignored.
      
      == Permissions Checking
      
      The method Participable#participants uses
      Ability.users_that_can_read_project to check if the returned users have
      access to the project of "self" _without_ running multiple SQL queries
      for every user.
      580d2501
    • Z.J. van de Weg's avatar
      Incorportate feedback · 91a7b933
      Z.J. van de Weg authored
      91a7b933
  3. 31 May, 2016 2 commits
  4. 24 May, 2016 5 commits
  5. 12 May, 2016 1 commit
  6. 10 May, 2016 1 commit
  7. 09 May, 2016 1 commit
  8. 06 May, 2016 2 commits
  9. 20 Apr, 2016 5 commits
  10. 19 Apr, 2016 1 commit
  11. 02 Apr, 2016 1 commit
  12. 30 Mar, 2016 1 commit
  13. 21 Mar, 2016 1 commit
  14. 19 Mar, 2016 2 commits
  15. 15 Mar, 2016 2 commits
    • Rémy Coutable's avatar
      Improving the original label-subscribing implementation · 54ec7e95
      Rémy Coutable authored
      1. Make the "subscribed" text in Issuable sidebar reflect the labels
         subscription status
      
      2. Current user mut be logged-in to toggle issue/MR/label subscription
      54ec7e95
    • Timothy Andrew's avatar
      Original implementation to allow users to subscribe to labels · 0444fa56
      Timothy Andrew authored
      1. Allow subscribing (the current user) to a label
      
      - Refactor the `Subscription` coffeescript class
        - The main change is that it accepts a container, and conducts all
          DOM queries within its scope. We need this because the labels
          page has multiple instances of `Subscription` on the same page.
      
      2. Creating an issue or MR with labels notifies users subscribed to those labels
      
      - Label `has_many` subscribers through subscriptions.
      
      3. Adding a label to an issue or MR notifies users subscribed to those labels
      
      - This only applies to subscribers of the label that has just been
        added, not all labels for the issue.
      0444fa56
  16. 11 Mar, 2016 1 commit
  17. 07 Mar, 2016 1 commit
  18. 05 Mar, 2016 1 commit
  19. 02 Mar, 2016 1 commit
  20. 22 Feb, 2016 2 commits
  21. 17 Feb, 2016 1 commit
  22. 16 Feb, 2016 1 commit
  23. 15 Feb, 2016 1 commit
    • Rémy Coutable's avatar
      Fix the "x of y" displayed at the top of Issuables' sidebar · 54613b6a
      Rémy Coutable authored
      1. We now display the index of the current issuable among all its project's
      issuables, of the same type and with the same state.
      2. Also, refactored a bit the Issuable helpers into a new IssuablesHelper
      module.
      3. Added acceptance specs for the sidebar counter.
      54613b6a