When filtering issues with a search string in a group, we observed on GitLab.com
that Postgres was using an inefficient query plan, preferring the (global)
trigram indexes on description and title, rather than using a filter on the
restricted set of issues within the group.

Change the callers of the IssuableFinder to use a CTE in this case to fence the
rest of the query from the LIKE filters, so that the optimiser is forced to
perform the filter in the order we prefer.

This will only force the use of a CTE when:

1. The use_cte_for_search params is truthy.
2. We are using Postgres.
3. We have passed the `search` param.

The third item is important - searching issues using the search box does not use
the finder in this way, but contructs a query and appends `full_search` to
that. For some reason, this query does not suffer from the same issue.

Currenly, we only pass this param when filtering issuables (issues or MRs) in a
group context.

We had `item_project_ids` to help make slow queries on the dashboard faster, but
this isn't necessary any more - the queries are plenty fast, and we forbid
searching the dashboard without filters.

Backport changes in some EE service objects

See merge request gitlab-org/gitlab-ce!19119

Resolve "Missing Accept button for terms of service"

Closes #46585

See merge request gitlab-org/gitlab-ce!19156

[CE-backbport] Render a 403 when showing an access denied message

See merge request gitlab-org/gitlab-ce!19415

Fix Fog mocking

Closes #47300

See merge request gitlab-org/gitlab-ce!19425

Eliminate N+1 queries with authors and push_data_payload in Events API

See merge request gitlab-org/gitlab-ce!19347

Fix Missing bottom line and padding for form headers

Closes #47277

See merge request gitlab-org/gitlab-ce!19410

QA fixes or improvements don't need an exception request

See merge request gitlab-org/gitlab-ce!19426

Rephrase Merge Request Maintainer Edit

See merge request gitlab-org/gitlab-ce!19061

Optimise runner update cached info

See merge request gitlab-org/gitlab-ce!19187

Resolve "Active tab for new project doesn't change properly"

Closes #47146

See merge request gitlab-org/gitlab-ce!19408

Add Davy Defaud as French proofreader

See merge request gitlab-org/gitlab-ce!19428

Fix an N+1 in avatar URLs

Closes #43114

See merge request gitlab-org/gitlab-ce!18488

Resolve "Huge artifacts block"

Closes #41772

See merge request gitlab-org/gitlab-ce!19421

Signed-off-by: Rémy Coutable <remy@rymai.me>

Fix layout in admin edit user form

Closes #47230

See merge request gitlab-org/gitlab-ce!19409

Signed-off-by: Rémy Coutable <remy@rymai.me>

Fixing dead link in the readme file

See merge request gitlab-org/gitlab-ce!19393

This is tricky: the query was being run in
`ObjectStorage::Extension::RecordsUploads#retrieve_from_store!`, but we can't
just add batch loading there, because the `#upload=` method there would use the
result immediately, making the batch only have one item.

Instead, we can pre-emptively add an item to the batch whenever an avatarable
object is initialized, and then reuse that batch item in
`#retrieve_from_store!`. However, this also has problems:

1. There is a lot of logic in `Avatarable#retrieve_upload_from_batch`.
2. Some of that logic constructs a 'fake' model for the batch key. This should
   be fine, because of ActiveRecord's override of `#==`, but it relies on that
   staying the same.

Add Configuration team to the list

See merge request gitlab-org/gitlab-ce!19416

Prevent Gitaly WriteConfig log noise

Closes gitaly#1221

See merge request gitlab-org/gitlab-ce!19375

Add background migrations to archive legacy job traces

Closes #46642

See merge request gitlab-org/gitlab-ce!19194

Also verify if extending would override a class method

See merge request gitlab-org/gitlab-ce!19377

Resolve "NoMethodError: undefined method `previous_changes' for nil:NilClass"

Closes #46452

See merge request gitlab-org/gitlab-ce!19190

Perform pull request IO work outside a transaction

See merge request gitlab-org/gitlab-ce!19372

Update security products job and artifact names in documentation.

See merge request gitlab-org/gitlab-ce!19315

Support rails5 in postgres indexes function and fix some migrations

Closes #46236

See merge request gitlab-org/gitlab-ce!19400

Fix Rubocop offense in build specs

See merge request gitlab-org/gitlab-ce!19419

Optimise pages service calling

See merge request gitlab-org/gitlab-ce!19388

Bring CE-EE parity to app/services/projects/update_service.rb

See merge request gitlab-org/gitlab-ce!19117