An error occurred fetching the project authors.
  1. 05 Jun, 2018 1 commit
    • Oswaldo Ferreira's avatar
      Adjust insufficient diff hunks being persisted on NoteDiffFile · f4673919
      Oswaldo Ferreira authored
      This currently causes 500's errors when loading the MR page
      (Discussion) in a few scenarios.
      
      We were not considering detailed diff headers such as
      "--- a/doc/update/mysql_to_postgresql.md\n+++ b/doc/update/mysql_to_postgresql.md"
      to crop the diff. In order to address it, we're now using
      Gitlab::Diff::Parser, clean the diffs and builds Gitlab::Diff::Line objects
      we can iterate and filter on.
      f4673919
  2. 24 May, 2018 1 commit
    • Oswaldo Ferreira's avatar
      Persist truncated note diffs on a new table · bb8f2520
      Oswaldo Ferreira authored
      We request Gitaly in a N+1 manner to build discussion diffs. Once the diffs are from different revisions, it's hard to make a single request to the service in order to build the whole response.
      With this change we solve this problem and simplify a lot fetching this piece of info.
      bb8f2520
  3. 16 Mar, 2018 1 commit
  4. 04 Jan, 2018 1 commit
    • Sean McGivern's avatar
      Fix error when viewing diffs without blobs · 528b5eeb
      Sean McGivern authored
      Old merge requests can have diffs without corresponding blobs. (This also may be
      possible for commit diffs in corrupt repositories.)
      
      We can't use the `&.` operator on the blobs, because the blob objects are never
      nil, but `BatchLoader` instances that delegate to `Blob`. We can't use
      `Object#try`, because `Blob` doesn't inherit from `Object`.
      
      `BatchLoader` provides a `__sync` method that returns the delegated object, but
      using `itself` also works because it's forwarded, and will work for
      non-`BatchLoader` instances too. So the simplest solution is to just use that
      with the `&.` operator.
      528b5eeb
  5. 22 Dec, 2017 1 commit
  6. 21 Nov, 2017 1 commit
  7. 13 Oct, 2017 3 commits
  8. 07 Oct, 2017 1 commit
  9. 21 Sep, 2017 1 commit
  10. 24 Aug, 2017 1 commit
    • Sean McGivern's avatar
      Show un-highlighted diffs when blobs are the same · e8525e10
      Sean McGivern authored
      For some old merge requests, we don't have enough information to figure out the
      old blob and the new blob for the file. This means that we can't highlight the
      diff correctly, but we can still display it without highlighting.
      e8525e10
  11. 22 Aug, 2017 1 commit
    • Sean McGivern's avatar
      Always return a simple diff viewer · b0f09406
      Sean McGivern authored
      We didn't have a fallback case before, because we believed the conditions were
      exhaustive. They weren't, so we can always fallback to not previewing.
      b0f09406
  12. 31 Jul, 2017 1 commit
  13. 14 Jun, 2017 1 commit
  14. 08 Jun, 2017 2 commits
  15. 23 May, 2017 3 commits
  16. 28 Nov, 2016 1 commit
  17. 25 Nov, 2016 2 commits
    • hhoopes's avatar
      Add keyword arguments to truncated_diff method · a761c59a
      hhoopes authored
      * Added keyword arguments to truncated_diff_lines method to allow for using highlighting or not (html templates vs. text)
      * Tweaked templates for consistency and format appropriateness
      a761c59a
    • hhoopes's avatar
      Change diff highlight/truncate for reusability · f928dba9
      hhoopes authored
      Previously the `truncated_diff_lines` method for outputting a discussion diff took in already highlighted lines, which meant it wasn't reuseable for truncating ANY lines. In the way it was used, it also meant that for any email truncation, the whole diff was being highlighted before being truncated, meaning wasted time highlighting lines that wouldn't even be used (granted, they were being memoized, so perhaps this wasn't that great of an issue). I refactored truncation away from highlighting, in order to truncate formatted diffs for text templates in email, using `>`s to designate each line, but otherwise retaining the parsing already done to create `diff_lines`.
      
      Additionally, while notes on merge requests or commits had already been tested, there was no existing test for notes on a diff on an MR or commit. Added mailer tests for such, and a unit test for truncating diff lines.
      f928dba9
  18. 14 Nov, 2016 1 commit
  19. 10 Nov, 2016 1 commit
  20. 17 Oct, 2016 1 commit
  21. 03 Aug, 2016 2 commits
  22. 18 Jul, 2016 1 commit
  23. 08 Jul, 2016 1 commit
    • Sean McGivern's avatar
      Collapse large diffs by default · b6b26692
      Sean McGivern authored
      When rendering a list of diff files, skip those where the diff is over
      10 KB and provide an endpoint to render individually instead.
      b6b26692
  24. 06 Jul, 2016 6 commits
  25. 18 Mar, 2016 1 commit
  26. 03 Mar, 2016 1 commit
  27. 20 Jan, 2016 2 commits