An error occurred fetching the project authors.
- 05 Jun, 2018 1 commit
-
-
Oswaldo Ferreira authored
This currently causes 500's errors when loading the MR page (Discussion) in a few scenarios. We were not considering detailed diff headers such as "--- a/doc/update/mysql_to_postgresql.md\n+++ b/doc/update/mysql_to_postgresql.md" to crop the diff. In order to address it, we're now using Gitlab::Diff::Parser, clean the diffs and builds Gitlab::Diff::Line objects we can iterate and filter on.
-
- 24 May, 2018 1 commit
-
-
Oswaldo Ferreira authored
We request Gitaly in a N+1 manner to build discussion diffs. Once the diffs are from different revisions, it's hard to make a single request to the service in order to build the whole response. With this change we solve this problem and simplify a lot fetching this piece of info.
-
- 16 Mar, 2018 1 commit
-
-
Sean McGivern authored
These can be a `BatchLoader` which is proxying a nil, while not being concrete nils themselves.
-
- 04 Jan, 2018 1 commit
-
-
Sean McGivern authored
Old merge requests can have diffs without corresponding blobs. (This also may be possible for commit diffs in corrupt repositories.) We can't use the `&.` operator on the blobs, because the blob objects are never nil, but `BatchLoader` instances that delegate to `Blob`. We can't use `Object#try`, because `Blob` doesn't inherit from `Object`. `BatchLoader` provides a `__sync` method that returns the delegated object, but using `itself` also works because it's forwarded, and will work for non-`BatchLoader` instances too. So the simplest solution is to just use that with the `&.` operator.
-
- 22 Dec, 2017 1 commit
-
-
Douwe Maan authored
Improve performance of DiffDiscussion#truncated_diff_lines and DiffNote#diff_line by removing expensive diff position calculation and comparison
-
- 21 Nov, 2017 1 commit
-
-
Zeger-Jan van de Weg authored
After installing a new gem, batch-loader, a construct can be used to queue data to be fetched in bulk. The gem was also introduced in both gitlab-org/gitlab-ce!14680 and gitlab-org/gitlab-ce!14846, but those mrs are not merged yet. For the generation of diffs, both the old blob and the new blob need to be loaded. This for every file in the diff, too. Now we collect all these so we do 1 fetch. Three `.allow_n_plus_1_calls` have been removed, which I expect to be valid, but this needs to be confirmed by a full CI run. Possibly closes: - https://gitlab.com/gitlab-org/gitlab-ce/issues/37445 - https://gitlab.com/gitlab-org/gitlab-ce/issues/37599 - https://gitlab.com/gitlab-org/gitlab-ce/issues/37431
-
- 13 Oct, 2017 3 commits
-
-
Alejandro Rodríguez authored
Having a distinct class just for that was a bit overkill
-
Alejandro Rodríguez authored
Rename classes to (hopefully) clearer names while we're doing that.
-
Alejandro Rodríguez authored
-
- 07 Oct, 2017 1 commit
-
-
Felipe Artur authored
-
- 21 Sep, 2017 1 commit
-
-
Ahmad Sherif authored
Closes gitaly#524
-
- 24 Aug, 2017 1 commit
-
-
Sean McGivern authored
For some old merge requests, we don't have enough information to figure out the old blob and the new blob for the file. This means that we can't highlight the diff correctly, but we can still display it without highlighting.
-
- 22 Aug, 2017 1 commit
-
-
Sean McGivern authored
We didn't have a fallback case before, because we believed the conditions were exhaustive. They weren't, so we can always fallback to not previewing.
-
- 31 Jul, 2017 1 commit
-
-
Jacob Vosmaer authored
-
- 14 Jun, 2017 1 commit
-
-
Douwe Maan authored
-
- 08 Jun, 2017 2 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- 23 May, 2017 3 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
Douwe Maan authored
-
- 28 Nov, 2016 1 commit
-
-
Sean McGivern authored
-
- 25 Nov, 2016 2 commits
-
-
hhoopes authored
* Added keyword arguments to truncated_diff_lines method to allow for using highlighting or not (html templates vs. text) * Tweaked templates for consistency and format appropriateness
-
hhoopes authored
Previously the `truncated_diff_lines` method for outputting a discussion diff took in already highlighted lines, which meant it wasn't reuseable for truncating ANY lines. In the way it was used, it also meant that for any email truncation, the whole diff was being highlighted before being truncated, meaning wasted time highlighting lines that wouldn't even be used (granted, they were being memoized, so perhaps this wasn't that great of an issue). I refactored truncation away from highlighting, in order to truncate formatted diffs for text templates in email, using `>`s to designate each line, but otherwise retaining the parsing already done to create `diff_lines`. Additionally, while notes on merge requests or commits had already been tested, there was no existing test for notes on a diff on an MR or commit. Added mailer tests for such, and a unit test for truncating diff lines.
-
- 14 Nov, 2016 1 commit
-
-
Stan Hu authored
Steps to reproduce: 1. Start with a repo with an image 2. Add a commit to delete the image 3. Add another commit to replace the image with another image In a diff comparison, we really just compare about what the image was before the diff, not the direct parent of the last commit. This MR fixes that. Closes #3893, gitlab-org/gitlab-ee#678 Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 10 Nov, 2016 1 commit
-
-
Adam Niedzielski authored
In this case comparing old_path and new_path is not enough because there are two entires that match.
-
- 17 Oct, 2016 1 commit
-
-
Adam Niedzielski authored
In this specific case using file_path as a cache key is not enough, because there are two entries with the same path. Closes #21610.
-
- 03 Aug, 2016 2 commits
-
-
Paco Guzman authored
Instead calling diff_collection.count use diff_collection.size which is cache on the diff_collection
-
Paco Guzman authored
Introducing the concept of SafeDiffs which relates diffs with UI highlighting.
-
- 18 Jul, 2016 1 commit
-
-
Paco Guzman authored
-
- 08 Jul, 2016 1 commit
-
-
Sean McGivern authored
When rendering a list of diff files, skip those where the diff is over 10 KB and provide an endpoint to render individually instead.
-
- 06 Jul, 2016 6 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
Douwe Maan authored
Extract parts of LegacyDiffNote into DiffOnNote concern and move part of responsibility to other classes
-
Douwe Maan authored
-
Douwe Maan authored
-
Douwe Maan authored
-
- 18 Mar, 2016 1 commit
-
-
Yorick Peterse authored
This builds on the changes introduced in https://gitlab.com/gitlab-org/gitlab_git/merge_requests/72 and results in merge requests with large diffs (e.g. due to them containing minified CSS) loading much faster.
-
- 03 Mar, 2016 1 commit
-
-
Jacob Vosmaer authored
-
- 20 Jan, 2016 2 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-