merge conflict: revision change

master/bt5/slapos_cloud/SkinTemplateItem/portal_skins/slapos_cloud/Person_findPartition.xml

@@ -53,6 +53,7 @@
             <value> <string encoding="cdata"><![CDATA[
 
 import random\n
+from Products.ZSQLCatalog.SQLCatalog import SimpleQuery\n
 person = context\n
 \n
 computer_partition = None\n
@@ -75,17 +76,17 @@ else:\n
 explicit_location = False\n
 if "computer_guid" in filter_kw:\n
   explicit_location = True\n
-  query_kw["parent_reference"] = filter_kw.pop("computer_guid")\n
+  query_kw["parent_reference"] = SimpleQuery(parent_reference=filter_kw.pop("computer_guid"))\n
 \n
 if "instance_guid" in filter_kw:\n
   explicit_location = True\n
   portal = context.getPortalObject()\n
   instance_guid = filter_kw.pop("instance_guid")\n
-  query_kw["aggregate_related_reference"] = instance_guid\n
+  query_kw["aggregate_related_reference"] = SimpleQuery(aggregate_related_reference=instance_guid)\n
 \n
 if \'network_guid\' in filter_kw:\n
   network_guid = filter_kw.pop(\'network_guid\')\n
-  query_kw["default_subordination_reference"] = network_guid\n
+  query_kw["default_subordination_reference"] = SimpleQuery(default_subordination_reference=network_guid)\n
 \n
 computer_base_category_list = [\n
   \'group\',\n

master/bt5/slapos_cloud/TestTemplateItem/testSlapOSCloudWorkflow.py

@@ -1914,6 +1914,26 @@ class TestSlapOSCoreSoftwareInstanceRequest(testSlapOSMixin):
         requested_instance2.getSlaXml())
     self.assertEqual(bang_amount+1, self._countBang(requested_instance))
 
+  def test_update_connection_bang_requester(self):
+    request_kw = self.request_kw.copy()
+
+    request_kw['software_title'] = self.generateNewSoftwareTitle()
+    self.software_instance.requestInstance(**request_kw)
+
+    requested_instance = self.software_instance.REQUEST.get(
+        'request_instance')
+
+    self.tic()
+
+    bang_amount = self._countBang(self.software_instance)
+
+    connection_xml = self.generateSafeXml()
+    requested_instance.updateConnection(connection_xml=connection_xml)
+
+    transaction.commit()
+
+    self.assertEqual(bang_amount+1, self._countBang(self.software_instance))
+
 class TestSlapOSCorePersonRequest(testSlapOSMixin):
 
   def afterSetUp(self):

master/bt5/slapos_cloud/WorkflowTemplateItem/portal_workflow/instance_slap_interface_workflow/scripts/RequestedInstance_bangResquesterInstance.xml

+<?xml version="1.0"?>
+<ZopeData>
+  <record id="1" aka="AAAAAAAAAAE=">
+    <pickle>
+      <global name="PythonScript" module="Products.PythonScripts.PythonScript"/>
+    </pickle>
+    <pickle>
+      <dictionary>
+        <item>
+            <key> <string>Script_magic</string> </key>
+            <value> <int>3</int> </value>
+        </item>
+        <item>
+            <key> <string>_bind_names</string> </key>
+            <value>
+              <object>
+                <klass>
+                  <global name="NameAssignments" module="Shared.DC.Scripts.Bindings"/>
+                </klass>
+                <tuple/>
+                <state>
+                  <dictionary>
+                    <item>
+                        <key> <string>_asgns</string> </key>
+                        <value>
+                          <dictionary>
+                            <item>
+                                <key> <string>name_container</string> </key>
+                                <value> <string>container</string> </value>
+                            </item>
+                            <item>
+                                <key> <string>name_context</string> </key>
+                                <value> <string>context</string> </value>
+                            </item>
+                            <item>
+                                <key> <string>name_m_self</string> </key>
+                                <value> <string>script</string> </value>
+                            </item>
+                            <item>
+                                <key> <string>name_subpath</string> </key>
+                                <value> <string>traverse_subpath</string> </value>
+                            </item>
+                          </dictionary>
+                        </value>
+                    </item>
+                  </dictionary>
+                </state>
+              </object>
+            </value>
+        </item>
+        <item>
+            <key> <string>_body</string> </key>
+            <value> <string>instance = state_change[\'object\']\n
+portal = instance.getPortalObject()\n
+\n
+for requester_instance in portal.portal_catalog(\n
+    portal_type="Software Instance",\n
+    default_predecessor_uid=instance.getUid()):\n
+  requester_instance.getObject().bang(\n
+    bang_tree=False,\n
+    comment="%s parameters changed" % instance.getRelativeUrl())\n
+</string> </value>
+        </item>
+        <item>
+            <key> <string>_params</string> </key>
+            <value> <string>state_change</string> </value>
+        </item>
+        <item>
+            <key> <string>id</string> </key>
+            <value> <string>RequestedInstance_bangResquesterInstance</string> </value>
+        </item>
+      </dictionary>
+    </pickle>
+  </record>
+</ZopeData>

master/bt5/slapos_cloud/WorkflowTemplateItem/portal_workflow/instance_slap_interface_workflow/transitions/update_connection.xml

@@ -46,7 +46,7 @@
         </item>
         <item>
             <key> <string>script_name</string> </key>
-            <value> <string></string> </value>
+            <value> <string>RequestedInstance_bangResquesterInstance</string> </value>
         </item>
         <item>
             <key> <string>title</string> </key>

master/bt5/slapos_cloud/bt/revision

-296
+296
\ No newline at end of file
+

master/bt5/slapos_hypermedia/SkinTemplateItem/portal_skins/slapos_hypermedia/Computer_getHateoas.xml

@@ -80,7 +80,7 @@ else:\n
                   "type": "application/vnd.slapos.org.hal+json; class=slapos.org.computer" },\n
 \n
         "http://slapos.org/reg/software": {\n
-          "href": "%s/Computer_getHateoasSoftwareList" % context.absolute_url(),\n
+          "href": "%s/Computer_getHateoasSoftwareInstallationList" % context.absolute_url(),\n
           "type": "application/vnd.slapos.org.hal+json; class=slapos.org.collection",\n
         },\n
 \n

master/bt5/slapos_hypermedia/SkinTemplateItem/portal_skins/slapos_hypermedia/Computer_getHateoasSoftwareList.xml → master/bt5/slapos_hypermedia/SkinTemplateItem/portal_skins/slapos_hypermedia/Computer_getHateoasSoftwareInstallationList.xml

@@ -80,12 +80,13 @@ else:\n
 \n
   for sql_obj in context.getPortalObject().portal_catalog(\n
                                                  portal_type=\'Software Installation\',\n
-                                                 aggregate_relative_url=context.getRelativeUrl(),\n
+                                                 default_aggregate_uid=context.getUid(),\n
+                                                 validation_state=\'validated\',\n
                                                  ):\n
     obj = sql_obj.getObject()\n
     result_dict[\'_links\'][\'item\'].append({\n
-      \'href\': \'%s/Software_getHateoas\' % obj.absolute_url(),\n
-      \'type\': \'application/vnd.slapos.org.hal+json; class=slapos.org.software\',\n
+      \'href\': \'%s/SoftwareInstallation_getHateoas\' % obj.absolute_url(),\n
+      \'type\': \'application/vnd.slapos.org.hal+json; class=slapos.org.software_installation\',\n
     })\n
 \n
   response.setHeader(\'Content-Type\', type)\n
@@ -98,7 +99,7 @@ else:\n
         </item>
         <item>
             <key> <string>id</string> </key>
-            <value> <string>Computer_getHateoasSoftwareList</string> </value>
+            <value> <string>Computer_getHateoasSoftwareInstallationList</string> </value>
         </item>
       </dictionary>
     </pickle>

master/bt5/slapos_hypermedia/SkinTemplateItem/portal_skins/slapos_hypermedia/Person_getHateoasComputerList.xml

@@ -80,7 +80,7 @@ else:\n
 \n
   for sql_obj in context.getPortalObject().portal_catalog(\n
                                                  portal_type="Computer",\n
-                                                 source_administration_uid=context.getUid(),\n
+                                                 default_source_administration_uid=context.getUid(),\n
                                                  ):\n
     obj = sql_obj.getObject()\n
     result_dict[\'_links\'][\'item\'].append({\n

master/bt5/slapos_hypermedia/SkinTemplateItem/portal_skins/slapos_hypermedia/Software_getHateoas.xml → master/bt5/slapos_hypermedia/SkinTemplateItem/portal_skins/slapos_hypermedia/SoftwareInstallation_getHateoas.xml

@@ -56,7 +56,7 @@ if REQUEST is None:\n
   raise Unauthorized\n
 \n
 response = REQUEST.RESPONSE\n
-type = \'application/vnd.slapos.org.hal+json; class=slapos.org.software\'\n
+type = \'application/vnd.slapos.org.hal+json; class=slapos.org.software_installation\'\n
 \n
 if REQUEST.other[\'method\'] != "GET":\n
   response.setStatus(405)\n
@@ -78,15 +78,17 @@ else:\n
 \n
   import json\n
   result_dict = {\n
-      \'_class\': \'slapos.org.software\',\n
+      \'_class\': \'slapos.org.software_installation\',\n
       \'title\': context.getTitle(),\n
-      \'software_url\': context.getUrlString(),\n
       \'status\': state,\n
       \'_links\': {\n
         "self": { "href": context.Base_getRequestUrl(),\n
-                  "type": "application/vnd.slapos.org.hal+json; class=slapos.org.software" },\n
+                  "type": "application/vnd.slapos.org.hal+json; class=slapos.org.software_installation" },\n
       },\n
     }\n
+  url_string = context.getUrlString(None)\n
+  if url_string is not None:\n
+    result_dict["_links"]["software_release"] = { "href": url_string }\n
 \n
   response.setHeader(\'Content-Type\', type)\n
   return json.dumps(result_dict)\n
@@ -98,7 +100,7 @@ else:\n
         </item>
         <item>
             <key> <string>id</string> </key>
-            <value> <string>Software_getHateoas</string> </value>
+            <value> <string>SoftwareInstallation_getHateoas</string> </value>
         </item>
       </dictionary>
     </pickle>

master/bt5/slapos_hypermedia/TestTemplateItem/testSlapOSHypermediaScenario.py

@@ -322,7 +322,7 @@ class TestSlapOSHypermediaPersonScenario(testSlapOSMixin):
     # Get user's software
     #####################################################
     content_type = "application/vnd.slapos.org.hal+json; " \
-                   "class=slapos.org.software"
+                   "class=slapos.org.software_installation"
     software_link_dict = software_collection_hal['_links']\
         ['item'][0]
 

master/bt5/slapos_hypermedia/bt/revision

-3
+4
\ No newline at end of file

slapos.cfg.example

@@ -54,6 +54,7 @@ download-binary-dir-url = http://www.shacache.org/shadir
 #   Yingjie Xu
 #   Gabriel Monnerat
 #   Lukasz Nowak
+#   Marco Mariani
 #   Test Agent Signature
 signature-certificate-list =
   -----BEGIN CERTIFICATE-----
@@ -148,6 +149,19 @@ signature-certificate-list =
   Vd0Ozh79JSRpkrdI8R/NRQ2XPHAo+29TT70=
   -----END CERTIFICATE-----
   -----BEGIN CERTIFICATE-----
+  MIIB9jCCAV+gAwIBAgIJAL9FOtBJZBqAMA0GCSqGSIb3DQEBBQUAMBMxETAPBgNV
+  BAMMCENPTVAtOTIyMCAXDTEyMDkyNjE2MDkwM1oYDzIxMTIwOTAyMTYwOTAzWjAT
+  MREwDwYDVQQDDAhDT01QLTkyMjCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEA
+  wlGVd6qOsc2xrtAQ5/rpflzS14/84SE/joaujMw2GGk6EFVSOcqKLq1TnHxkcCkv
+  nv1NYRPK/hpQOIKcGC1f+DvXXpMJI29R/rt2b2/y1oolxXonSVigBtCQlSyDoOFN
+  6LBX84CI5aYMvy3mqJCvfGEFBaPqze/PVugq9IpgZg0CAwEAAaNQME4wHQYDVR0O
+  BBYEFJ7HWyzVKkeSYnSK4FIwcdyng/tRMB8GA1UdIwQYMBaAFJ7HWyzVKkeSYnSK
+  4FIwcdyng/tRMAwGA1UdEwQFMAMBAf8wDQYJKoZIhvcNAQEFBQADgYEAZQWob2ki
+  ie6h90FgSctozXrotb8NIis2MtLIj+WonE0wSqYefxwBmAGjB9cfWz/sNamhM4rn
+  BP1A2ojVhF6hOE1qvTP5YxcGXOoYTrEQSuDF1hn12WlA4vqIAz1f+4CiMJNlXPwh
+  7N+X2kvRpHdXAHkBOxX3j34AeCZrSpu/yDQ=
+  -----END CERTIFICATE-----
+  -----BEGIN CERTIFICATE-----
   MIIB9jCCAV+gAwIBAgIJAKRvzcy7OH0UMA0GCSqGSIb3DQEBBQUAMBMxETAPBgNV
   BAMMCENPTVAtNzcyMCAXDTEyMDgxMDE1NDI1MVoYDzIxMTIwNzE3MTU0MjUxWjAT
   MREwDwYDVQQDDAhDT01QLTc3MjCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEA

slapos/cli/cache.py

@@ -10,7 +10,7 @@ import sys
 import prettytable
 
 from slapos.grid import networkcache
-from slapos.grid.distribution import patched_linux_distribution
+from slapos.grid.distribution import distribution_tuple
 from slapos.cli.config import ConfigCommand
 
 
@@ -76,7 +76,7 @@ def do_lookup(logger, cache_dir, software_url):
 
     pt = prettytable.PrettyTable(['distribution', 'version', 'id', 'compatible?'])
 
-    linux_distribution = patched_linux_distribution()
+    linux_distribution = distribution_tuple()
 
     for os in ostable:
         compatible = 'yes' if networkcache.os_matches(os, linux_distribution) else 'no'

slapos/cli/command.py

@@ -23,7 +23,7 @@ class Command(cliff.command.Command):
 def must_be_root(func):
     @functools.wraps(func)
     def inner(self, *args, **kw):
-        if os.getuid() != 0:
+        if sys.platform != 'cygwin' and os.getuid() != 0:
             self.app.log.error('This slapos command must be run as root.')
             sys.exit(5)
         return func(self, *args, **kw)

slapos/cli/entry.py

 # -*- coding: utf-8 -*-
 
 import argparse
+import codecs
 import collections
+import locale
 import logging
 import sys
 
@@ -114,6 +116,30 @@ class SlapOSApp(cliff.app.App):
             command_manager=SlapOSCommandManager('slapos.cli'),
         )
 
+    def _set_streams(self, stdin, stdout, stderr):
+        try:
+            # SlapOS: might fail in some systems
+            locale.setlocale(locale.LC_ALL, '')
+        except locale.Error:
+            pass
+
+        if sys.version_info[:2] == (2, 6):
+            # Configure the input and output streams. If a stream is
+            # provided, it must be configured correctly by the
+            # caller. If not, make sure the versions of the standard
+            # streams used by default are wrapped with encodings. This
+            # works around a problem with Python 2.6 fixed in 2.7 and
+            # later (http://hg.python.org/cpython/rev/e60ef17561dc/).
+            lang, encoding = locale.getdefaultlocale()
+            encoding = getattr(sys.stdout, 'encoding', None) or encoding
+            self.stdin = stdin or codecs.getreader(encoding)(sys.stdin)
+            self.stdout = stdout or codecs.getwriter(encoding)(sys.stdout)
+            self.stderr = stderr or codecs.getwriter(encoding)(sys.stderr)
+        else:
+            self.stdin = stdin or sys.stdin
+            self.stdout = stdout or sys.stdout
+            self.stderr = stderr or sys.stderr
+
     def build_option_parser(self, *args, **kw):
         kw.setdefault('argparse_kwargs', {})
         kw['argparse_kwargs']['conflict_handler'] = 'resolve'

slapos/cli/format.py

@@ -57,6 +57,8 @@ class FormatCommand(ConfigCommand):
                         help="Don't actually do anything"
                              " (default: %(default)s)")
 
+        ap.add_argument('-c', '--console',
+                        help="Console output (obsolete)")
         return ap
 
     @must_be_root

slapos/format.py

@@ -844,7 +844,7 @@ class Interface(object):
 
   def addIPv4LocalAddress(self, addr=None):
     """Adds local IPv4 address in ipv4_local_network"""
-    netmask = '255.255.255.254' if sys.platform == 'cygwin' \
+    netmask = str(netaddr.IPNetwork(self.ipv4_local_network).netmask) if sys.platform == 'cygwin' \
              else '255.255.255.255'
     local_address_list = self.getIPv4LocalAddressList()
     if addr is None:
@@ -1211,7 +1211,7 @@ class FormatConfig(object):
 
     # check root
     # XXX in the new CLI, this is checked by the @must_be_root decorator.
-    if root_needed and os.getuid() != 0:
+    if sys.platform != 'cygwin' and root_needed and os.getuid() != 0:
       message = "Root rights are needed"
       self.logger.error(message)
       sys.stderr.write(message + '\n')

slapos/grid/SlapObject.py

@@ -220,7 +220,8 @@ class Software(object):
           # but you can change it for development purposes.
 
           [buildout]
-          extends = {url}
+          extends =
+            {url}
           """.format(url=url)))
     self._set_ownership(buildout_cfg)
 

slapos/grid/distribution.py

@@ -13,6 +13,9 @@ patched_linux_distribution(...):
         see http://bugs.python.org/issue9514
 
     otherwise, Ubuntu will always be reported as an unstable Debian, regardless of the version.
+
+distribution_tuple()
+    returns a (distname, version, id) tuple under linux or cygwin
 """
 
 import platform
@@ -62,3 +65,10 @@ def patched_linux_distribution(distname='', version='', id='',
             pass
 
     return platform.linux_distribution(distname, version, id, supported_dists, full_distribution_name)
+
+
+def distribution_tuple():
+    if platform.system().startswith('CYGWIN_'):
+        return (platform.system(), platform.platform(), '')
+    else:
+        return patched_linux_distribution()

slapos/grid/networkcache.py

@@ -18,7 +18,7 @@ import platform
 import shutil
 import traceback
 
-from slapos.grid.distribution import os_matches, patched_linux_distribution
+from slapos.grid.distribution import os_matches, distribution_tuple
 
 try:
     try:
@@ -88,7 +88,7 @@ def download_network_cached(cache_url, dir_url, software_url, software_root,
                 if tags.get('machine') != platform.machine():
                     continue
                 if not os_matches(ast.literal_eval(tags.get('os')),
-                                  patched_linux_distribution()):
+                                  distribution_tuple()):
                     continue
                 if tags.get('software_url') != software_url:
                     continue
@@ -134,7 +134,7 @@ def upload_network_cached(software_root, software_url, cached_key,
       software_url=software_url,
       software_root=software_root,
       machine=platform.machine(),
-      os=str(patched_linux_distribution())
+      os=str(distribution_tuple())
     )
 
     f = open(path, 'r')

slapos/grid/slapgrid.py

@@ -627,6 +627,11 @@ class Slapgrid(object):
       logger=self.logger)
 
     computer_partition_state = computer_partition.getState()
+
+    # XXX this line breaks 37 tests
+    # self.logger.info('  Instance type: %s' % computer_partition.getType())
+    self.logger.info('  Instance status: %s' % computer_partition_state)
+
     if computer_partition_state == COMPUTER_PARTITION_STARTED_STATE:
       local_partition.install()
       computer_partition.available()
@@ -635,6 +640,8 @@ class Slapgrid(object):
       computer_partition.started()
     elif computer_partition_state == COMPUTER_PARTITION_STOPPED_STATE:
       try:
+        # We want to process the partition, even if stopped, because it should
+        # propagate the state to children if any.
         local_partition.install()
         computer_partition.available()
       finally:

slapos/slap/interface/slap.py

@@ -222,6 +222,11 @@ class IComputerPartition(IBuildoutController, IRequester):
     The contained values are connection parameters of a compute partition.
     """
 
+  def getType():
+    """
+    Returns the Software Type of the instance.
+    """
+
   def setUsage(usage_log):
     """
     Associate a usage log to the computer partition.

slapos/slap/slap.py

@@ -482,6 +482,18 @@ class ComputerPartition(SlapRequester):
       raise ResourceNotReady()
     return self._requested_state
 
+  def getType(self):
+    """
+    return the Software Type of the instance.
+    Raise RessourceNotReady if not present.
+    """
+    # XXX: software type should not belong to the parameter dict.
+    software_type = self.getInstanceParameterDict().get(
+        'slap_software_type', None)
+    if not software_type:
+      raise ResourceNotReady()
+    return software_type
+
   def getInstanceParameterDict(self):
     return getattr(self, '_parameter_dict', None) or {}
 

slapos/tests/slapformat.py

@@ -270,7 +270,7 @@ class TestComputer(SlapformatMixin):
     self.assertEqual([
       'ip addr list bridge',
       'groupadd slapsoft',
-      'useradd -d /software_root -g slapsoft -s /bin/false slapsoft -r'
+      'useradd -d /software_root -g slapsoft slapsoft -r'
       ],
       self.fakeCallAndRead.external_command_list)
 
@@ -308,7 +308,7 @@ class TestComputer(SlapformatMixin):
     self.assertEqual([
       'ip addr list bridge',
       'groupadd slapsoft',
-      'useradd -d /software_root -g slapsoft -s /bin/false slapsoft -r'
+      'useradd -d /software_root -g slapsoft slapsoft -r'
       ],
       self.fakeCallAndRead.external_command_list)
 
@@ -363,9 +363,9 @@ class TestComputer(SlapformatMixin):
     self.assertEqual([
       'ip addr list bridge',
       'groupadd slapsoft',
-      'useradd -d /software_root -g slapsoft -s /bin/false slapsoft -r',
+      'useradd -d /software_root -g slapsoft slapsoft -r',
       'groupadd testuser',
-      'useradd -d /instance_root/partition -g testuser -s /bin/false -G slapsoft testuser -r',
+      'useradd -d /instance_root/partition -g testuser -G slapsoft testuser -r',
       'tunctl -t tap -u testuser',
       'ip link set tap up',
       'brctl show',
@@ -452,9 +452,9 @@ class TestComputer(SlapformatMixin):
     self.assertEqual([
       # 'ip addr list bridge',
       'groupadd slapsoft',
-      'useradd -d /software_root -g slapsoft -s /bin/false slapsoft -r',
+      'useradd -d /software_root -g slapsoft slapsoft -r',
       'groupadd testuser',
-      'useradd -d /instance_root/partition -g testuser -s /bin/false -G slapsoft testuser -r',
+      'useradd -d /instance_root/partition -g testuser -G slapsoft testuser -r',
       # 'ip addr add ip/255.255.255.255 dev bridge',
       # 'ip addr list bridge',
       # 'ip addr add ip/ffff:ffff:ffff:ffff:: dev bridge',
@@ -533,7 +533,7 @@ class TestUser(SlapformatMixin):
 
     self.assertEqual([
       'groupadd doesnotexistsyet',
-      'useradd -d /doesnotexistsyet -g doesnotexistsyet -s /bin/false '\
+      'useradd -d /doesnotexistsyet -g doesnotexistsyet '\
         'doesnotexistsyet -r'
     ],
       self.fakeCallAndRead.external_command_list)
@@ -546,7 +546,7 @@ class TestUser(SlapformatMixin):
 
     self.assertEqual([
       'groupadd doesnotexistsyet',
-      'useradd -d /doesnotexistsyet -g doesnotexistsyet -s /bin/false -G '\
+      'useradd -d /doesnotexistsyet -g doesnotexistsyet -G '\
         'additionalgroup1,additionalgroup2 doesnotexistsyet -r'
       ],
       self.fakeCallAndRead.external_command_list)
@@ -559,7 +559,7 @@ class TestUser(SlapformatMixin):
     user.create()
 
     self.assertEqual([
-      'useradd -d /testuser -g testuser -s /bin/false testuser -r'
+      'useradd -d /testuser -g testuser testuser -r'
     ],
       self.fakeCallAndRead.external_command_list)
 
@@ -573,7 +573,7 @@ class TestUser(SlapformatMixin):
 
     self.assertEqual([
       'groupadd testuser',
-      'usermod -d /testuser -g testuser -s /bin/false -G '\
+      'usermod -d /testuser -g testuser -G '\
         'additionalgroup1,additionalgroup2 testuser'
     ],
       self.fakeCallAndRead.external_command_list)
@@ -587,7 +587,7 @@ class TestUser(SlapformatMixin):
 
     self.assertEqual([
       'groupadd testuser',
-      'usermod -d /testuser -g testuser -s /bin/false testuser'
+      'usermod -d /testuser -g testuser testuser'
     ],
       self.fakeCallAndRead.external_command_list)
 
@@ -601,7 +601,7 @@ class TestUser(SlapformatMixin):
     user.create()
 
     self.assertEqual([
-      'usermod -d /testuser -g testuser -s /bin/false testuser'
+      'usermod -d /testuser -g testuser testuser'
     ],
       self.fakeCallAndRead.external_command_list)
 

slapos/version.py

 
-version = '1.0.0rc4'
+version = '1.0.0rc5'