1. 24 Jan, 2018 2 commits
    • Boxiang Sun's avatar
      erp5_officejs_support_request, erp5_post: Pass follow-up by value · c49cf8d8
      Boxiang Sun authored
      Avoids the double-nonsense of looking the document up by path inside callee (!)
      using the catalog (!!).
      Also, follow naming conventions: variables containing documents should end
      in _value, not in _object.
      
      Vincent Pelletier:
      - commit message
      - remove unrelated change
      - squash similar similar-intent commits even though they apply to
        different BTs
      c49cf8d8
    • Vincent Pelletier's avatar
      all: Avoid trivial direct calls to {recursiveI,i}mmediateReindexObject · ab9e0f93
      Vincent Pelletier authored
      These methods must not be called synchronously:
      - they can break catalog by not being careful enough about other
        reindexations which may happen in parallel. See the serialization_tag
        mechanism for more.
      - indexation gets executed in the security context of the user causing the
        call, which may lead to an indexation result different from what happens
        when indexation happens with an all-accesses user.
      These lines of code (some even commented-out) give a bad example. Replace
      them with safe equivalents.
      ab9e0f93
  2. 22 Jan, 2018 2 commits
  3. 19 Jan, 2018 3 commits
  4. 18 Jan, 2018 11 commits
  5. 17 Jan, 2018 7 commits
  6. 16 Jan, 2018 1 commit
    • Georgios Dagkakis's avatar
      erp5_calendar: Make Presence Request more user-friendly in parameterisation and appearance. · 4362cfe2
      Georgios Dagkakis authored
      This is equivalent to work done for Leave Request, at:
      185285c4
      (merge_request 493)
      
      Follow a simple / non-simple approach, like for Task and its lines.
      
      In default case, user would need only one Presence Request Period, which can be edited directly on PresenceRequest_view. So, in this case, hide the Listbox containing the Presence Request Periods and have default_presence_request_period being created / edited on background, which will acquire quantity, resource, start_date and stop_date from what is set at the view of the Parent.
      In case one or more Presence Request Period are added manually, user would get listbox with sub-objects, and editing should be done directly on them, i.e. fields like my_default_presence_request_period_start_date will be disabled fromPresenceRequest_view.
      
      Additionally, now Presence Request has its own:
      start_date: equal to the minimum start_date of all Presence Request Periods
      stop_date: equal to the maximum stop_date of all Presence Request Periods
      
      These values are set by interaction on Presence Request Period, triggered on setStartDate, _setStopDate. This helps so that presence_request_module listbox can have sortable dates.
      
      Commit contains also test
      
      /reviewed-on !541
      4362cfe2
  7. 15 Jan, 2018 5 commits
  8. 12 Jan, 2018 1 commit
  9. 11 Jan, 2018 8 commits