- 13 Sep, 2019 15 commits
-
-
Jérome Perrin authored
Fix remaining functional test failures and drop a few more code that become unused now that we have a `setFile` command. Because firefox 68 executes event handlers for events triggered on disabled elements ( https://phabricator.services.mozilla.com/D10000 ), Zelenium is also adapted to mimic the behaviour we had with firefox 52 (and chrome behavior) of not executing event hander. TODO: * [x] `testContributeTab` sometimes displays Converted, sometimes Converting. I wonder if we can wait for something to make the test deterministic, otherwise we can assert a regexp. * [x] `erp5_web_renderjs_ui_test:testFunctionalRJSCore` ( discussed in nexedi/erp5@05b9c4af (comment 87278) ) * [x] someone update test nodes to use new firefox. * [x] understand why with firefox 58 selenium sends clicks on disabled button. /reviewed-on nexedi/erp5!922
-
Vincent Pelletier authored
Volatile attributes may disappear from one statement to the next. Make code reliable by moving it one level up the call stack, removing the need for volatile attributes. _setId and _postCopy get back to their original "copy of OFS.CopySupport" status (see comment at beginning of file).
-
Vincent Pelletier authored
-
Vincent Pelletier authored
This BT contains the same category twice.
-
Vincent Pelletier authored
Bank Account, Currency{, Module}, Currency Exchange {Cell,Line} already exist in erp5_base, which is a dependency of this Business Template at least through erp5_trade. "composition" and "variation" Base Categories exist in erp5_pdm, which is a dependency of this Business Template via erp5_trade. "site" Base Category exists in erp5_base, which is a dependency of this Business Template via erp5_trade.
-
Vincent Pelletier authored
classification is already provided by erp5_dms, which is a dependency of this BT already.
-
Vincent Pelletier authored
requirement is also present in erp5_project. So add a dependency on that BT and remove the duplication.
-
Vincent Pelletier authored
This BT achieved the rare feat of containing the same document twice.
-
Vincent Pelletier authored
region/europe/western_europe is also present in erp5_tiosafe_test, which is already installed in the same unit test. So add a dependency on that BT and remove the duplication.
-
Vincent Pelletier authored
currency_module/euro is also present in erp5_tiosafe_test, which is already installed in the same unit test. So add a dependency on that BT and remove the duplication.
-
Kazuhiko Shiozaki authored
Vincent Pelletier: - Disable timeout by default.
-
Kazuhiko Shiozaki authored
Vincent Pelletier: - Ignore TimerService-originated publication requests. - Add copyright headers. - Disable timeout by default. - Give a meaning to requested negative deadlines. - Docstrings. - Assorted simplifications.
-
Rafael Monnerat authored
The Assigments are only relevant if the User is based on Person Document, on SlapOS, an user come from a Computer or a Software Instance Document. This change makes the document compatible with other kinds of Users, as Assigment is overkill for Non-Person cases, as the presence of ERP5 Login is enough to determinate the User existence. The other alternative would be re-factorize to not duplicate code, which seems not the intention of how this code was written. /cc @jerome, @kazuhiko /reviewed-on nexedi/erp5!458
-
Vincent Pelletier authored
Simpler, and reduces the exposure of exc_info (which can be tricky to use in other contexts).
-
Vincent Pelletier authored
-
- 12 Sep, 2019 6 commits
-
-
Jérome Perrin authored
When we updated Firefox from 52 to 68, the behavior of firefox changed. With 52, when calling element.dispatchEvent on a disabled element, the event handlers were not executed, but in 68 they are.
-
Julien Muchembled authored
-
Julien Muchembled authored
Unlike Medusa, WSGI does not do it.
-
Vincent Pelletier authored
-
Vincent Pelletier authored
-
Vincent Pelletier authored
Both the dummy method_id and the actually-used grouping_method_id.
-
- 11 Sep, 2019 2 commits
-
-
Julien Muchembled authored
Without this commit, it felt back to the timerserver egg.
-
Ivan Tyagov authored
-
- 10 Sep, 2019 11 commits
-
-
Jérome Perrin authored
* Depending on conversion server speed, document will be Converted or Converting. Assert that the state match Convert(ing|ed) to accept both. * prefer assert* instead of verify* to terminate test execution on first failed assertion. * use more specific xpath instead of asserting that text is present in the page. * checking that URL matches the previous URL interpreted as a regexp was not working for IPv6 URL with brackets (because of the meaning of regular expression). Because what we want here is to check that URL starts with previously stored URL, check with a glob: expression, that should be also compatible with IPv6 URLs.
-
Jérome Perrin authored
Rename the test for PDFJS introduced in b58995c9 to testCheckPDFPreview Repair original testCheckPDFThumbnail by updating the link name from Preview to Thumbnail, as a follow up to fe83821b
-
Jérome Perrin authored
-
Jérome Perrin authored
we are now using setFile selenium command to upload file from an URL.
-
Jérome Perrin authored
this test is running with FCK Editor as preferred text editor
-
Jérome Perrin authored
This was for very old firefox and have been ineffective for years. This reverts part of 2fcab04e , which for some reason was patching doType that was not used because defined in user-extensions.
-
Jérome Perrin authored
When test fails because of assertion failure inside an iframe, it's also helpful to dump iframe content as well.
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Ivan Tyagov authored
-
Jérome Perrin authored
HAL JSON uses JSON, which uses UTF-8, but properties of ERP5 documents does not enforce any specific encoding, so if we happen to have documents with string properties that are not UTF-8 compatible, they could not be queried with HAL JSON (json.dumps was raising UnicodeError) This pre-process field default properties and document title to make sure they can be serialized as json. This assumes that configuration (form definition, actions, ...) will be valid UTF-8, but just does extra effort to make sure "broken" data can be displayed without error. /reviewed-on !928
-
- 09 Sep, 2019 6 commits
-
-
Arnaud Fontaine authored
ZODB Components: 'Migrate Components from Filesystem to ZODB' view: Fix ListBox to display selected ones first. In this context, 'selected' means classes found by introspecting Portal Type Class MRO. This was not sorted properly only for filesystem Products.
-
Arnaud Fontaine authored
ZODB Components: Do not automatically validate when importing from FS as imports have to be adjusted manually.
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
Besides not being actually needed, checkPythonSourceCode() was called on all temp_objects created for migrate_component_from_filesystem Business Template Action.
-