Commit 148c0948 authored by Rusty Russell's avatar Rusty Russell

typesafe: fix warnings with gcc's -Wcast-qual

Don't implicitly cast away const in the tests.
parent 3d27344a
......@@ -14,6 +14,7 @@ static void my_callback(char *p)
int main(int argc, char *argv[])
{
char str[] = "hello world";
#ifdef FAIL
int *p;
#if !HAVE_TYPEOF||!HAVE_BUILTIN_CHOOSE_EXPR||!HAVE_BUILTIN_TYPES_COMPATIBLE_P
......@@ -25,7 +26,7 @@ int main(int argc, char *argv[])
p = NULL;
/* This should work always. */
register_callback(my_callback, "hello world");
register_callback(my_callback, str);
/* This will fail with FAIL defined */
register_callback(my_callback, p);
......
......@@ -3,7 +3,7 @@
/* NULL args for callback function should be OK for _exact and _def. */
static void _register_callback(void (*cb)(void *arg), void *arg)
static void _register_callback(void (*cb)(const void *arg), const void *arg)
{
}
......
......@@ -41,9 +41,10 @@ static void my_callback_post(/*const*/ char *p, int x)
int main(int argc, char *argv[])
{
register_callback(my_callback, "hello world");
register_callback_def(my_callback, "hello world");
register_callback_pre(my_callback_pre, "hello world");
register_callback_post(my_callback_post, "hello world");
char p[] = "hello world";
register_callback(my_callback, p);
register_callback_def(my_callback, p);
register_callback_pre(my_callback_pre, p);
register_callback_post(my_callback_post, p);
return 0;
}
......@@ -39,8 +39,9 @@ static void my_callback_post(/* volatile */ char *p, int x)
int main(int argc, char *argv[])
{
register_callback(my_callback, "hello world");
register_callback_pre(my_callback_pre, "hello world");
register_callback_post(my_callback_post, "hello world");
char p[] = "hello world";
register_callback(my_callback, p);
register_callback_pre(my_callback_pre, p);
register_callback_post(my_callback_post, p);
return 0;
}
......@@ -38,8 +38,9 @@ static void my_callback_post(/*const*/ char *p, int x)
int main(int argc, char *argv[])
{
register_callback(my_callback, "hello world");
register_callback_pre(my_callback_pre, "hello world");
register_callback_post(my_callback_post, "hello world");
char p[] = "hello world";
register_callback(my_callback, p);
register_callback_pre(my_callback_pre, p);
register_callback_post(my_callback_post, p);
return 0;
}
#include <ccan/typesafe_cb/typesafe_cb.h>
#include <string.h>
#include <stdint.h>
#include <ccan/tap/tap.h>
static char dummy = 0;
......@@ -49,7 +50,8 @@ static void my_callback_onearg_const(const char *p)
static void my_callback_onearg_volatile(volatile char *p)
{
ok1(strcmp((char *)p, "hello world") == 0);
/* Double cast avoids warning on gcc's -Wcast-qual */
ok1(strcmp((char *)(intptr_t)p, "hello world") == 0);
}
static void my_callback_preargs(int a, int b, char *p)
......@@ -103,53 +105,57 @@ static void my_callback_postargs_volatile(volatile char *p, int a, int b)
struct callback_onearg
{
void (*fn)(void *arg);
void *arg;
const void *arg;
};
struct callback_onearg cb_onearg
= { typesafe_cb(void, my_callback_onearg, "hello world"), "hello world" };
= { typesafe_cb(void, my_callback_onearg, (char *)(intptr_t)"hello world"),
"hello world" };
struct callback_preargs
{
void (*fn)(int a, int b, void *arg);
void *arg;
const void *arg;
};
struct callback_preargs cb_preargs
= { typesafe_cb_preargs(void, my_callback_preargs, "hi", int, int), "hi" };
= { typesafe_cb_preargs(void, my_callback_preargs,
(char *)(intptr_t)"hi", int, int), "hi" };
struct callback_postargs
{
void (*fn)(void *arg, int a, int b);
void *arg;
const void *arg;
};
struct callback_postargs cb_postargs
= { typesafe_cb_postargs(void, my_callback_postargs, "hi", int, int), "hi" };
= { typesafe_cb_postargs(void, my_callback_postargs,
(char *)(intptr_t)"hi", int, int), "hi" };
int main(int argc, char *argv[])
{
void *p = &dummy;
unsigned long l = (unsigned long)p;
char str[] = "hello world";
plan_tests(2 + 3 + 3 + 3);
set_some_value(p);
set_some_value(l);
callback_onearg(my_callback_onearg, "hello world");
callback_onearg(my_callback_onearg_const, "hello world");
callback_onearg(my_callback_onearg_volatile, "hello world");
callback_onearg(my_callback_onearg, str);
callback_onearg(my_callback_onearg_const, str);
callback_onearg(my_callback_onearg_volatile, str);
callback_preargs(my_callback_preargs, "hello world");
callback_preargs(my_callback_preargs, str);
#if 0 /* FIXME */
callback_preargs(my_callback_preargs_const, "hello world");
callback_preargs(my_callback_preargs_volatile, "hello world");
callback_preargs(my_callback_preargs_const, str);
callback_preargs(my_callback_preargs_volatile, str);
#endif
callback_postargs(my_callback_postargs, "hello world");
callback_postargs(my_callback_postargs, str);
#if 0 /* FIXME */
callback_postargs(my_callback_postargs_const, "hello world");
callback_postargs(my_callback_postargs_volatile, "hello world");
callback_postargs(my_callback_postargs_const, str);
callback_postargs(my_callback_postargs_volatile, str);
#endif
return exit_status();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment