- 15 May, 2014 2 commits
-
-
Julien Muchembled authored
Not only for performance, but also because they would break documents on which asComposedDocument is used.
-
Kazuhiko Shiozaki authored
-
- 14 May, 2014 2 commits
-
-
Julien Muchembled authored
This implements dependency resolution to sort amount generator lines so that a base_amount is never contributed after it was applied. Before, it was required to sort manually using int_index or float_index, which can be difficult for a human when there are many lines spreaded over different containers (which are merged by composition). Another problematic case is when a set of lines is configured by a user (like discounts & fees) and must all be applied before other lines (taxes) that are installed elsewhere by the developer: how to reliably make sure the latter have index values that are already greater than those entered by the user ? Setting int_index or float_index is now only useful for lines: - with same reference: only the maching one with lowest index is taken into account (commit 68ec6bda) - applying to intermediate values of some base_amount (commit 10be013b) The difficult part to solve dependencies is that the calculation for a given base_amount may trigger the application of other base_amount, and so on recursively. In order to support this case, amount generator lines are first applied on a dummy amount, and getGeneratedAmountQuantity must be call unconditionally for all dependent base_amount. So optimizing like return 3 <= delivery_amount.getGeneratedAmountQuantity('base_amount/1') \ or 1 <= delivery_amount.getGeneratedAmountQuantity('base_amount/2') is wrong except if 'base_amount/2' is only contributed by the movement or if you sort manually with indices. Dependency resolution has precedence over indices. But since the sort is stable, lines will remain sorted by index if it respects dependencies.
-
Julien Muchembled authored
Preliminary commit only to indent a big section of code.
-
- 13 May, 2014 7 commits
-
-
Julien Muchembled authored
-
Julien Muchembled authored
-
Julien Muchembled authored
Before we dropped amounts with quantity=0 and we stopped doing that because it broke expand. However, there's still one case when such amount can be ignored, i.e. when there's no base_application set on the amount generator.
-
Julien Muchembled authored
-
Julien Muchembled authored
When a user explicitely enters 0 on a Trade Model Line, total price must be 0 no matter what is set on the resource.
-
Julien Muchembled authored
Default getPriceCalculationOperandDict script calls getPricingVariable type-based script directly if variable_additional_price is not 0.
-
Julien Muchembled authored
-
- 12 May, 2014 3 commits
-
-
Vincent Pelletier authored
-
Jérome Perrin authored
-
Jérome Perrin authored
-
- 09 May, 2014 2 commits
-
-
Ivan Tyagov authored
Redirect to absolute url of respective Web Section so if 'Renderer ID' is set (as usually when a web section is used for forum) the UI displays iforum UI which is not the case when default 'view' of Web Section is used if we redirect to using form_id. As thread is show immediately correct message to not confuse users.
-
Julien Muchembled authored
-
- 07 May, 2014 2 commits
-
-
Julien Muchembled authored
If an object has no uid yet and has no acquisition context to the portal, getUid() fails. Default is derived from id(aq_base(ob)) which is even more efficient. The method on XMLObject was also redundant because it inherited the same one from Base.
-
Kazuhiko Shiozaki authored
also readAsciiFile normilises CRLF/CR/LF.
-
- 06 May, 2014 2 commits
-
-
Sebastien Robin authored
-
Sebastien Robin authored
-
- 05 May, 2014 1 commit
-
-
Sebastien Robin authored
-
- 01 May, 2014 1 commit
-
-
Kazuhiko Shiozaki authored
-
- 30 Apr, 2014 13 commits
-
-
Vincent Pelletier authored
Accelerates (at least) Person's jump_to_accounting action.
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Kazuhiko Shiozaki authored
-
Vincent Pelletier authored
-
Vincent Pelletier authored
Also, factorise related key string generation.
-
Vincent Pelletier authored
Also, use xrange as it's faster than range even for short sequences.
-
Vincent Pelletier authored
Also, get rid of single-use locals and unneeded list copy.
-
Vincent Pelletier authored
These related keys override auto-generated ones without adding any value. Also, they are not declared as related keys, so declaration is auto-generated and may not match ZSQLMethod parameters, causing errors.
-
Vincent Pelletier authored
Although it should never happen in normal use, it may happen during an upgrade when property sheets fail creating accessors (ex: broken object because portal type moved to a different Business Template).
-
Vincent Pelletier authored
-
Vincent Pelletier authored
Also, avoid reindexing when object is not modified.
- 29 Apr, 2014 2 commits
-
-
Jérome Perrin authored
This also fixes the problem that in recent pytz common_timezones is a LazyList that does not work in restricted python
-
Kazuhiko Shiozaki authored
make FTPConnector.getFile binary mode by default, because ascii mode only works with utf-8 encoding. also propagate binary mode to SFTPClient.file().
-
- 28 Apr, 2014 3 commits
-
-
Vincent Pelletier authored
-
Kazuhiko Shiozaki authored
-
Sebastien Robin authored
-