git: Fixed unusual but potent race condition

config/setup/tls.go

@@ -82,7 +82,7 @@ func TLS(c *Controller) (middleware.Middleware, error) {
 }
 
 // Map of supported protocols
-// SSLv3 will be not supported in next release
+// SSLv3 will be not supported in future release
 // HTTP/2 only supports TLS 1.2 and higher
 var supportedProtocols = map[string]uint16{
 	"ssl3.0": tls.VersionSSL30,

middleware/git/git.go

@@ -62,8 +62,9 @@ type Repo struct {
 func (r *Repo) Pull() error {
 	r.Lock()
 	defer r.Unlock()
-	// if it is less than interval since last pull, return
-	if time.Since(r.lastPull) <= r.Interval {
+
+	// prevent a pull if the last one was less than 5 seconds ago
+	if time.Since(r.lastPull) < 5*time.Second {
 		return nil
 	}