As per https://github.com/mholt/caddy/issues/317

Some programs (Node.js, supervisor, etc.) open a stdin pipe by default and don't use it, causing Caddy to block. It is their error, but we have to try to accommodate unfortunately. To fix this more universally, parent must explicitly set -conf to "stdin" to read from pipe.

Since a directive can appear on multiple lines, the object syntax wasn't working well. This also fixes several other serialization bugs.

The error channel used when starting all the servers must be buffered so that, even if there are no errors at startup, the returns that insert into the error channel will not be blocked, since after startup, nobody is reading that channel anymore.

Wrote tests for browse.go and redir.go

The base path being optional in the Caddyfile is convenient when you just want the whole site to be markdown-enabled. The other change is to always generate links... this is because an index page for markdown files may not be statically generated, but it should still show links. Commit 09341fca was a regression, and this fixes it.

It can take a few seconds...

use log instead of fmt to obey the -log flag

fixed data races in websockets

Also we're not messing with log flags anymore during parsing. Timestamps could come in handy, plus concurrent logging is going on now.

Previously, if a listener fails to bind (for example), there was a race in caddy.go between unblocking the startup waitgroup and returning the error and putting it into errChan. Now, an error is returned directly into errChan and the closing of the startup waitgroup is defered until after that return takes place.

Log file can also be stdout or stderr. Log output is disabled by default now, which makes it more feasible to add more log statements to trace program flow in debugging situations.

add helpful suggestion to identify problem

This is known to happen if another program spawns Caddy with a stdin pipe but does not close its write end of Caddy's stdin.

Lint pacification

pass all tests

respond to maintainer comments

reinstate assignment of t

correct typo

correct typo

pass linter some more

Fix regression: Ensure TLS defaults are added by LE handlers.

If the -host flag is used, we might still have to set up Let's Encrypt, so this change is necessary.

Fixed bug where manually specifying port 443 disabled TLS (whoops); otherHostHasScheme was the culprit, since it would return true even if it was the same config that had that scheme.

Also, an error at startup (if not a restart) is now fatal, rather than keeping a half-alive zombie server.

Let's Encrypt