Commit 2c3fc4fa authored by Stefan Behnel's avatar Stefan Behnel

minor code cleanup in PrimaryCmpNode

parent 297ce833
...@@ -8904,7 +8904,6 @@ class PrimaryCmpNode(ExprNode, CmpNode): ...@@ -8904,7 +8904,6 @@ class PrimaryCmpNode(ExprNode, CmpNode):
elif self.find_special_bool_compare_function(env, self.operand1): elif self.find_special_bool_compare_function(env, self.operand1):
common_type = None # if coercion needed, the method call above has already done it common_type = None # if coercion needed, the method call above has already done it
self.is_pycmp = False # result is bint self.is_pycmp = False # result is bint
self.is_temp = True # must check for error return
else: else:
common_type = self.find_common_type(env, self.operator, self.operand1) common_type = self.find_common_type(env, self.operator, self.operand1)
self.is_pycmp = common_type.is_pyobject self.is_pycmp = common_type.is_pyobject
...@@ -8926,7 +8925,8 @@ class PrimaryCmpNode(ExprNode, CmpNode): ...@@ -8926,7 +8925,8 @@ class PrimaryCmpNode(ExprNode, CmpNode):
while cdr: while cdr:
cdr.type = self.type cdr.type = self.type
cdr = cdr.cascade cdr = cdr.cascade
if self.is_pycmp or self.cascade: if self.is_pycmp or self.cascade or self.special_bool_cmp_function:
# 1) owned reference, 2) reused value, 3) potential function error return value
self.is_temp = 1 self.is_temp = 1
def analyse_cpp_comparison(self, env): def analyse_cpp_comparison(self, env):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment