Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Labels
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Commits
Open sidebar
nexedi
cython
Commits
95b0fa5a
Commit
95b0fa5a
authored
Aug 18, 2020
by
Xavier Thompson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Fix cypclass refcount on arrays" to fix temps never being freed
This reverts commit
45d8df5a
.
parent
cb6bf446
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
10 deletions
+3
-10
Cython/Compiler/ExprNodes.py
Cython/Compiler/ExprNodes.py
+3
-10
No files found.
Cython/Compiler/ExprNodes.py
View file @
95b0fa5a
...
@@ -4356,16 +4356,9 @@ class IndexNode(_IndexingBaseNode):
...
@@ -4356,16 +4356,9 @@ class IndexNode(_IndexingBaseNode):
code
.
putln
(
code
.
putln
(
"%s = %s;"
%
(
self
.
result
(),
rhs
.
result
()))
"%s = %s;"
%
(
self
.
result
(),
rhs
.
result
()))
if
self
.
type
.
is_cyp_class
:
self
.
generate_subexpr_disposal_code
(
code
)
# This hack is due to the fact cypclass objects are ref-counted, so
self
.
free_subexpr_temps
(
code
)
# they goes into temps, but their assignment code is a simple C assignment,
rhs
.
generate_disposal_code
(
code
)
# which doesn't incref the temp.
# So we are effectively absorbing a reference in this case.
rhs
.
generate_post_assignment_code
(
code
)
else
:
self
.
generate_subexpr_disposal_code
(
code
)
self
.
free_subexpr_temps
(
code
)
rhs
.
generate_disposal_code
(
code
)
rhs
.
free_temps
(
code
)
rhs
.
free_temps
(
code
)
def
_check_byte_value
(
self
,
code
,
rhs
):
def
_check_byte_value
(
self
,
code
,
rhs
):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment