Fix Cy_Ref cypclass smart pointer metafunction causing 'incomplete type' compilation error

a1127594 · Xavier Thompson · 0760a6ab · a1127594
Commit a1127594 authored Sep 09, 2020 by Xavier Thompson
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 6 deletions

Cython/Utility/CyObjects.cpp Cython/Utility/CyObjects.cpp +3 -6

No files found.
--- a/Cython/Utility/CyObjects.cpp
+++ b/Cython/Utility/CyObjects.cpp
@@ -256,17 +256,14 @@
        };
        }

-        template <typename T, bool = std::is_convertible<T*, CyObject*>::value>
-        struct Cy_Ref_t {};
-
        template <typename T>
-        struct Cy_Ref_t<T, true> {
+        struct Cy_Ref_t {
            using type = Cy_Ref_impl<T>;
        };

        template <typename T>
-        struct Cy_Ref_t<T, false> {
-            using type = T;
+        struct Cy_Ref_t<Cy_Ref_impl<T>> {
+            using type = Cy_Ref_impl<T>;
        };

        template <typename T>