Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Labels
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Commits
Open sidebar
nexedi
cython
Commits
d01f6d4a
Commit
d01f6d4a
authored
Sep 23, 2017
by
Robert Bradshaw
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Avoid copying C++ classes when passing constructor arguments.
parent
b6500f58
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
26 additions
and
1 deletion
+26
-1
Cython/Compiler/ModuleNode.py
Cython/Compiler/ModuleNode.py
+1
-1
Cython/Compiler/Symtab.py
Cython/Compiler/Symtab.py
+10
-0
tests/run/cpp_classes_def.pyx
tests/run/cpp_classes_def.pyx
+15
-0
No files found.
Cython/Compiler/ModuleNode.py
View file @
d01f6d4a
...
...
@@ -905,7 +905,7 @@ class ModuleNode(Nodes.Node, Nodes.BlockNode):
if
constructor
:
arg_decls
=
[]
arg_names
=
[]
for
arg
in
constructor
.
type
.
args
[:
len
(
constructor
.
type
.
args
)
-
constructor
.
type
.
optional_arg_count
]:
for
arg
in
constructor
.
type
.
original_
args
[:
len
(
constructor
.
type
.
args
)
-
constructor
.
type
.
optional_arg_count
]:
arg_decls
.
append
(
arg
.
declaration_code
())
arg_names
.
append
(
arg
.
cname
)
if
constructor
.
type
.
optional_arg_count
:
...
...
Cython/Compiler/Symtab.py
View file @
d01f6d4a
...
...
@@ -2311,6 +2311,16 @@ class CppClassScope(Scope):
cname
=
"%s__init__%s"
%
(
Naming
.
func_prefix
,
class_name
)
name
=
'<init>'
type
.
return_type
=
PyrexTypes
.
CVoidType
()
# This is called by the actual constructor, but need to support
# arguments that cannot by called by value.
type
.
original_args
=
type
.
args
def
maybe_ref
(
arg
):
if
arg
.
type
.
is_cpp_class
and
not
arg
.
type
.
is_reference
:
return
PyrexTypes
.
CFuncTypeArg
(
arg
.
name
,
PyrexTypes
.
c_ref_type
(
arg
.
type
),
arg
.
pos
)
else
:
return
arg
type
.
args
=
[
maybe_ref
(
arg
)
for
arg
in
type
.
args
]
elif
name
==
'__dealloc__'
and
cname
is
None
:
cname
=
"%s__dealloc__%s"
%
(
Naming
.
func_prefix
,
class_name
)
name
=
'<del>'
...
...
tests/run/cpp_classes_def.pyx
View file @
d01f6d4a
...
...
@@ -6,6 +6,7 @@ cdef double pi
from
math
import
pi
from
libc.math
cimport
sin
,
cos
from
libcpp
cimport
bool
from
libcpp.memory
cimport
unique_ptr
from
libcpp.vector
cimport
vector
from
cython.operator
cimport
dereference
as
deref
...
...
@@ -222,3 +223,17 @@ def test_CppClassWithObjectMemberCopyAssign(name):
print
"Alive in vector"
,
v
[
0
].
o
v
.
clear
()
print
"Nothing alive."
cdef
cppclass
UncopyableConstructorArgument
:
unique_ptr
[
vector
[
int
]]
member
__init__
(
unique_ptr
[
vector
[
int
]]
arg
):
this
.
member
.
reset
(
arg
.
release
())
def
test_uncopyable_constructor_argument
():
"""
>>> test_uncopyable_constructor_argument()
"""
cdef
UncopyableConstructorArgument
*
c
=
new
UncopyableConstructorArgument
(
unique_ptr
[
vector
[
int
]](
new
vector
[
int
]()))
del
c
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment