• Jérome Perrin's avatar
    Fix code depending on python2 __hash__ · 0ed7ff48
    Jérome Perrin authored
    With python2, iterating on a dictionary or a set always produces the same result,
    although this is not a documented behavior. On python3 this is not the case,
    because the hashing algorithm is random by default, which can also be set using [`PYTHONHASHSEED`](https://docs.python.org/3/using/cmdline.html#envvar-PYTHONHASHSEED). On SlapOS, this is done with slapos!1535 
    
    This fixes the parts where ERP5 code depends on python2 order, mostly tests, but also places
    where we iterate on a dictionary or set. Most of the time, the fix has been to sort so that
    the order is deterministic regardless of the hash algorithm randomization, but sometimes we
    had to extend a bit the configuration where the order was really important. We did this after
    discovering the problematic areas by running tests multiple times with different hash randomization
    seeds. It's not impossible that changing from "default python2 order" to "sorted" reveals some
    more problems in custom configurations, but this would mean that the configuration must be 
    adjusted to use explicit order instead of being lucky with the default python2 order.
    
    The main pattern was the use of `edit` method which edits properties in an order that is a bit
    constrained with the `edit_order` mechanism, because some properties depend on other properties,
    so it's important to set them in order. This extends a bit the `edit_order` mechanism to specify
    more properties that were edited in the right order with `PYTHONHASHSEED=0` by chance.
    
    This also extends delivery builders to edit properties in order defined in the equivalence tester,
    most equivalence tester were already properly configured, except the `start_date` and `stop_date`
    from delivery level movement groups. That probably only matters for some specific test assertions,
    but in practice this was visible in a lot of failing tests.
    
    Some visible changes are that:
     - workflows are now sorted alphabetically on history tab
     - properties are now sorted alphabetically on the diff view of history tab
     - business templates are installed in the order of dependencies and in alphabetic order when they
      are not constrained.
    
    See merge request !1882
    0ed7ff48
SQLCatalog.py 93.9 KB