Commit 14831fae authored by Sebastien Robin's avatar Sebastien Robin

erp5_pdm: show first newest movement in movement history dialog

User is usually interested by last movement in stock, not by several
months/years old movement. Thus display first fresh movement, and user
could then go to next pages to see oldest movements if needed.
parent a3437c62
Pipeline #28853 failed with stage
in 0 seconds
history_list = context.getMovementHistoryList(**kw)
reverse_list = []
for x in history_list:
reverse_list.insert(0, x)
return reverse_list
<?xml version="1.0"?>
<ZopeData>
<record id="1" aka="AAAAAAAAAAE=">
<pickle>
<global name="PythonScript" module="Products.PythonScripts.PythonScript"/>
</pickle>
<pickle>
<dictionary>
<item>
<key> <string>Script_magic</string> </key>
<value> <int>3</int> </value>
</item>
<item>
<key> <string>_bind_names</string> </key>
<value>
<object>
<klass>
<global name="NameAssignments" module="Shared.DC.Scripts.Bindings"/>
</klass>
<tuple/>
<state>
<dictionary>
<item>
<key> <string>_asgns</string> </key>
<value>
<dictionary>
<item>
<key> <string>name_container</string> </key>
<value> <string>container</string> </value>
</item>
<item>
<key> <string>name_context</string> </key>
<value> <string>context</string> </value>
</item>
<item>
<key> <string>name_m_self</string> </key>
<value> <string>script</string> </value>
</item>
<item>
<key> <string>name_subpath</string> </key>
<value> <string>traverse_subpath</string> </value>
</item>
</dictionary>
</value>
</item>
</dictionary>
</state>
</object>
</value>
</item>
<item>
<key> <string>_params</string> </key>
<value> <string>**kw</string> </value>
</item>
<item>
<key> <string>id</string> </key>
<value> <string>Resource_getReversedMovementHistoryList</string> </value>
</item>
</dictionary>
</pickle>
</record>
</ZopeData>
......@@ -561,7 +561,7 @@
<dictionary>
<item>
<key> <string>method_name</string> </key>
<value> <string>getMovementHistoryList</string> </value>
<value> <string>Resource_getReversedMovementHistoryList</string> </value>
</item>
</dictionary>
</pickle>
......
  • @seb could you update this commit with an up to date erp5, in order to publish the expected xml output?

    The issue was posted by this test

  • mentioned in commit e6291b73

    Toggle commit list
  • I'm wondering why we don't use the "normal" sort functionality of listbox ? With this change, the date column is sortable, so if this implementation just reverse the order, image and image will behave differently than in other listboxs.

    PS: similar change (but more global) was discussed in !1305

    Edited by Jérome Perrin
  • I'm wondering what to do here, if we change the order, I feel it would be much better to just change in the listbox, because as said in the previous comment the buttons showing the sort order would work as expected and I think this would also look a bit better when there are more than 1000 movements (because getMovementHistoryList has a limit of 1000).

    @romain do you think we should revert for now ?

  • I also do not understand why the sort parameter of the listbox was not used.

    If getMovementHistoryList has a limit of 1000, this commit is not usable anyway. I also agree to revert, and change the listbox's default sort.

  • mentioned in commit 2a9e29ee

    Toggle commit list
  • mentioned in commit 589ab631

    Toggle commit list
  • mentioned in commit b5124bd9

    Toggle commit list
  • mentioned in commit e8d20966

    Toggle commit list
  • Thanks, I did e8d20966 and b5124bd9

  • Jérome Perrin @jerome

    mentioned in merge request !1305

    ·

    mentioned in merge request !1305

    Toggle commit list
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment