erp5_web_jabber_client: fix app manifest

bt5/erp5_web_jabber_client/PathTemplateItem/web_page_module/jabber_gadget_jabberclient_appcache.xml

@@ -192,6 +192,9 @@ connection/gadget_jabberconnection.js\n
 connection/strophe.js\n
 connection/renderjs.js\n
 connection/rsvp.js\n
+gadget_translation.html\n
+gadget_translation.js\n
+gadget_translation_data.js\n
 NETWORK:\n
 *</string> </value>
         </item>
@@ -334,7 +337,7 @@ NETWORK:\n
                   </item>
                   <item>
                       <key> <string>serial</string> </key>
-                      <value> <string>992.52841.31789.31726</string> </value>
+                      <value> <string>992.52842.38595.15479</string> </value>
                   </item>
                   <item>
                       <key> <string>state</string> </key>
@@ -352,7 +355,7 @@ NETWORK:\n
                           </tuple>
                           <state>
                             <tuple>
-                              <float>1623950075.33</float>
+                              <float>1624562316.54</float>
                               <string>UTC</string>
                             </tuple>
                           </state>

[Jérome Perrin]

Do we need this ? I thought that jabber client does not use translation. If it uses translations, it needs to be a different gadget, because gadget_translation.html is for the "default" ERP5JS web site (renderjs_runner). Since !1151 (merged) the translation gadgets are automatically generated from the web sites configuration.

What must be happening with upgrader in the test is something like this, during first upgrader run:

• check web_site_module/jabber's cache manifest to see if every resource referenced by cache manifest is modified before the cache manifest. It's not, so upgrader update the cache manifest modification date
• check if translation is up-to-date for web_site_module/renderjs_runner. It's not, so upgrader regenerate gadget_translation_data.js

That test run upgrader again and expect that everything is OK, but on the second upgrader run:

• check web_site_module/jabber's cache manifest to see if every resource referenced by cache manifest is modified before the cache manifest. It's not, because gadget_translation_data.js was updated on first upgrader run.

I guess it's something like this, but I have not verified. I think our two options are either to not add gadget_translation_data.js in application cache manifest here (do we need ? also, I thought we no longer used appcache because browsers no longer support it) or, if we need translations, to use a different translation gadget for jabber web site, like we do for example for support request web site

[Roque]

Hi @jerome, jabber app remained untouched for years: the current app version is from Feb 2019. While working on a different topic (appstore website) I had to update some configuration json in all the apps and re-generate their zip files. Jabber zip generation was broken due to these missing elements (translation gadgets) in its manifest, so I did a quick fix to make the exporter work again.

It is not my intention to refactor jabber or update it right now, but this discussion about the translation will be very useful for a future jabber update. And this update will include also to get rid of old appcache and move to SW.

[Jérome Perrin]

Hello @rporchetto thank you for feedback. I don't know if that was clear, I started this discussion because tests are broken on master: https://nexedijs.erp5.net/#/test_result_module/20210625-B011D4D0 . The erp5_officejs seems to be a consequence of this change, the erp5_web_jabber_client failure, I don't know.

If we are not actively working on jabberclient, we should do the minimal to get test working again, maybe removing these lines from appcache, I don't know.

[Roque]

Sorry, I didn't understand the test was failing. I'm checking in order to fix it. Thank you.

[Jérome Perrin]

Good, thanks a lot !