erp5testnode: clean up old instance root folder

This is backward compatibility code for previous commit.

erp5/util/testnode/SlapOSControler.py

@@ -26,6 +26,7 @@
 ##############################################################################
 import os
 import pkg_resources
+import shutil
 import slapos.slap
 import subprocess
 import time
@@ -53,6 +54,7 @@ class SlapOSControler(object):
       createFolder(shared)
       self.shared_part_list = self.shared_part_list + [shared]
 
+    self.old_instance_root = os.path.join(working_directory, 'inst')
     self.instance_root = os.path.join(working_directory, 'i')
     self.slapos_config = os.path.join(working_directory, 'slapos.cfg')
     self.proxy_database = os.path.join(working_directory, 'proxy.db')
@@ -277,6 +279,7 @@ class SlapOSControler(object):
       self._resetSoftware()
     else:
       createFolder(self.software_root)
+    shutil.rmtree(self.old_instance_root, True) # BBB
     instance_root = self.instance_root
     # Delete any existing partition in order to not get its data (ex.
     # MySQL DB content) from previous runs. To support changes of partition

[Jérome Perrin]

Shouldn't we use erp5.util.testnode.Utils.rmtree here ?

with software release test suites, there are probably files/folders with permissions issues.

/cc @xavier_thompson

[Julien Muchembled]

Oops. And we wanted to release erp5.util quickly.

Fixed in master. I think we can wait to release.

[Xavier Thompson]

slapos!992 (merged) depends on erp5.util being released.