Commit 3fcff6e7 authored by Jérome Perrin's avatar Jérome Perrin

web: pylint (py3)

parent 16342900
...@@ -442,7 +442,7 @@ class WebSection(Domain, DocumentExtensibleTraversableMixin): ...@@ -442,7 +442,7 @@ class WebSection(Domain, DocumentExtensibleTraversableMixin):
return result return result
def _edit(self, **kw): def _edit(self, *args, **kw):
# XXX it is unclear if we should keep this behavior in other potential subclasses. # XXX it is unclear if we should keep this behavior in other potential subclasses.
# Probably yes. # Probably yes.
if self.getPortalType() in WEB_SECTION_PORTAL_TYPE_TUPLE: if self.getPortalType() in WEB_SECTION_PORTAL_TYPE_TUPLE:
...@@ -453,4 +453,4 @@ class WebSection(Domain, DocumentExtensibleTraversableMixin): ...@@ -453,4 +453,4 @@ class WebSection(Domain, DocumentExtensibleTraversableMixin):
else: else:
# cleanup beforeTraverse hooks that may exist after this document was cloned. # cleanup beforeTraverse hooks that may exist after this document was cloned.
self._cleanupBeforeTraverseHooks() self._cleanupBeforeTraverseHooks()
super(WebSection, self)._edit(**kw) super(WebSection, self)._edit(*args, **kw)
...@@ -60,6 +60,9 @@ class HtmlParseHelper(HTMLParser): ...@@ -60,6 +60,9 @@ class HtmlParseHelper(HTMLParser):
self.result.append(("pi", data)) self.result.append(("pi", data))
def unknown_decl(self, data): def unknown_decl(self, data):
self.result.append(("unknown_decl", data)) self.result.append(("unknown_decl", data))
def error(self, message):
raise ValueError(message)
def parseHtml(text): def parseHtml(text):
""" """
......
...@@ -194,7 +194,7 @@ def handleHrefObject(obj, src, default_mimetype="text/html", default_data=b"<p>L ...@@ -194,7 +194,7 @@ def handleHrefObject(obj, src, default_mimetype="text/html", default_data=b"<p>L
data = bytes(obj.data or b"") data = bytes(obj.data or b"")
else: else:
data = getattr(obj, "getData", lambda: bytes(obj))() or b"" data = getattr(obj, "getData", lambda: bytes(obj))() or b""
if six.PY2 and isinstance(data, unicode): if six.PY2 and isinstance(data, unicode): # pylint:disable=undefined-variable
data = data.encode("utf-8") data = data.encode("utf-8")
assert isinstance(data, bytes) assert isinstance(data, bytes)
return handleLinkedData(mime, data, src) return handleLinkedData(mime, data, src)
...@@ -205,7 +205,7 @@ def handleHrefObject(obj, src, default_mimetype="text/html", default_data=b"<p>L ...@@ -205,7 +205,7 @@ def handleHrefObject(obj, src, default_mimetype="text/html", default_data=b"<p>L
# use the same behavior as when we call a script from browser URL bar. # use the same behavior as when we call a script from browser URL bar.
if not hasattr(obj, "getPortalType") and callable(obj): if not hasattr(obj, "getPortalType") and callable(obj):
mime, data = "text/html", obj() mime, data = "text/html", obj()
if six.PY2 and isinstance(data, unicode): if six.PY2 and isinstance(data, unicode): # pylint:disable=undefined-variable
data = data.encode("utf-8") data = data.encode("utf-8")
return handleLinkedData(mime, data, src) return handleLinkedData(mime, data, src)
......
...@@ -148,7 +148,9 @@ for attachment in attachment_list: ...@@ -148,7 +148,9 @@ for attachment in attachment_list:
for key, value in attachment.get("add_header_list", []): for key, value in attachment.get("add_header_list", []):
part.add_header(key, value) part.add_header(key, value)
if attachment.get("filename", None) is not None: if attachment.get("filename", None) is not None:
part.add_header("Content-Disposition", "attachment", attachment["filename"]) # XXX disable too-many-function-args because there is no error with this code,
# but it might just be not tested.
part.add_header("Content-Disposition", "attachment", attachment["filename"]) # pylint:disable=too-many-function-args
outer.attach(part) outer.attach(part)
#return outer.as_string() #return outer.as_string()
......
...@@ -1343,6 +1343,7 @@ Hé Hé Hé!""", page.asText().strip()) ...@@ -1343,6 +1343,7 @@ Hé Hé Hé!""", page.asText().strip())
conditional_get_response = requests.get( conditional_get_response = requests.get(
web_section.absolute_url(), web_section.absolute_url(),
headers={'If-Modified-Since': DateTime().utcdatetime().strftime('%a, %d %b %Y %H:%M:%S UTC')}, headers={'If-Modified-Since': DateTime().utcdatetime().strftime('%a, %d %b %Y %H:%M:%S UTC')},
timeout=5,
) )
self.assertEqual(conditional_get_response.status_code, 304) self.assertEqual(conditional_get_response.status_code, 304)
self.assertIn('Cache-Control', conditional_get_response.headers) self.assertIn('Cache-Control', conditional_get_response.headers)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment