erp5_base: renames the "journal" base category into "ledger"

bt5/erp5_base/CategoryTemplateItem/portal_categories/journal.xml → bt5/erp5_base/CategoryTemplateItem/portal_categories/ledger.xml

@@ -41,17 +41,17 @@
             <key> <string>categories</string> </key>
             <value>
               <tuple>
-                <string>journal</string>
+                <string>ledger</string>
               </tuple>
             </value>
         </item>
         <item>
             <key> <string>description</string> </key>
-            <value> <string>Journal is used to split deliveries of the same type in different subsets.</string> </value>
+            <value> <string>Ledger is used to split movements, deliveries, or orders of the same type in different subsets. It will replace the "journal" base category which is less generic</string> </value>
         </item>
         <item>
             <key> <string>id</string> </key>
-            <value> <string>journal</string> </value>
+            <value> <string>ledger</string> </value>
         </item>
         <item>
             <key> <string>portal_type</string> </key>
@@ -59,7 +59,7 @@
         </item>
         <item>
             <key> <string>title</string> </key>
-            <value> <string>Journal</string> </value>
+            <value> <string>Ledger</string> </value>
         </item>
       </dictionary>
     </pickle>

bt5/erp5_base/bt/template_base_category_list

@@ -19,7 +19,7 @@ gender
 grade
 group
 insurance_coverage
-journal
+ledger
 legal_parent
 marital_status
 market_segment
@@ -46,4 +46,4 @@ subordination
 successor
 trade_phase
 update_frequency
-use
\ No newline at end of file
+use

[Jérome Perrin]

I don't think you should use the future tense here. Also, I guess it is not needed to note here that it replaces journal, since journal was not much used.

Also, is that description correct ? Is it really applicable to movements ?

[Nicolas Wavrant]

My bad.... At first, I thought I will keep both the base categories ledger and journal, and progressively move to ledger. In fact, the post-upgrade will apply and fix the script constraint TemplateToolCategoryNameConstraint, which will update all the objects having the ledger base category defined as a property, including movements.

https://lab.nexedi.com/nexedi/erp5/blob/d892c344f41bca1d906cc2cbd6f46d3f6765b1d3/bt5/erp5_upgrader/SkinTemplateItem/portal_skins/erp5_upgrader/TemplateTool_checkCategoryNameConsistency.xml

The upgrade will be done only if this script contains the migration information : https://lab.nexedi.com/nexedi/erp5/blob/d892c344f41bca1d906cc2cbd6f46d3f6765b1d3/bt5/erp5_upgrader/SkinTemplateItem/portal_skins/erp5_upgrader/Base_getUpgradeCategoryNameList.xml

Is there some concern about movements ?

[Jérome Perrin]

OK, thanks for explanation. It would be better to rewrite this comment then.

My understanding of the design was: movements have a use and deliveries have a journal. I see journal was renamed to ledger. Is it also extended to be applied to movements ? if yes, what is the difference between use and ledger for movements ? Sorry for all the questions, this might be documented somewhere I missed.

[Nicolas Wavrant]

As far as I know, the "use" base category is not used for movements, but for products and services. Now, i think that "ledger" and "use" behave the same for their respective portal types

[Jérome Perrin]

use is for both resources and movements. For example, on resources it could mean for example "this product can be used for purchases, sales or sales from online shop" ie. we define the possible uses. On a movement it would means "this time, this product it was a purchase". The use selected on the movement must be one of the uses available from the resource.

Currently in the UI, ledger is used on tasks and task reports, ie. deliveries but not movements.

[Nicolas Wavrant]

The ledger category is not extended to be applied to movements : I just updated the Movement property sheet. The journal category has been added to movements at the same time the category was created : a5a3f17c Maybe @jm can tell us more about it.

I think we can see "use" as the possible uses of a movement, when "journal"/"ledger" is more a category to gather movements together. For exemple, I will use this category to create different Accounting Transactions documents per establishment, gathering the movements from the pay sheet transactions of the current period. Indeed, I define the Ledger on the delivery, and it will be inherited by the Transaction Lines.