fixup! erp5_core: reindex recursively only if indexable children type exists...

fixup! erp5_core: reindex recursively only if indexable children type exists in Base_reindexObjectSecurity.
Co-authored-by: Xiaowu Zhang <xiaowu.zhang@nexedi.com>
Reviewed-by: Jérome Perrin <jerome@nexedi.com>

bt5/erp5_core_test/TestTemplateItem/portal_components/test.erp5.testERP5Core.py

@@ -866,3 +866,11 @@ class TestERP5Core(ERP5TypeTestCase, ZopeTestCase.Functional):
       1,
       len(self.portal.portal_catalog(uid=person2.getUid())),
     )
+
+  def test_ERP5Site_testisInstanceIndexable(self):
+    for portal_type_id in ('Base Type', 'Person'):
+      portal_type = getattr(self.portal.portal_types, portal_type_id)
+      self.assertTrue(portal_type.isInstanceIndexable())
+    for portal_type_id in ('Catalog', 'Solver Process'):
+      portal_type = getattr(self.portal.portal_types, portal_type_id)
+      self.assertFalse(portal_type.isInstanceIndexable())

product/ERP5/bootstrap/erp5_core/SkinTemplateItem/portal_skins/erp5_core/Base_reindexObjectSecurity.py

@@ -5,7 +5,7 @@
 type_tool = context.getPortalObject().portal_types
 for portal_type_name in context.getTypeInfo().getTypeAllowedContentTypeList():
   type_ = getattr(type_tool, portal_type_name)
-  if type_.getTypeAcquireLocalRole() and type_.isIndexable():
+  if type_.getTypeAcquireLocalRole() and type_.isInstanceIndexable():
     reindex = context.recursiveReindexObject
     break
 else:

product/ERP5Type/ERP5Type.py

@@ -360,13 +360,15 @@ class ERP5TypeInformation(XMLObject,
       permission = self.permission or 'Add portal content'
       return getSecurityManager().checkPermission(permission, container)
 
-    security.declarePublic('isIndexable')
-    def isIndexable(self):
+    security.declarePublic('isInstanceIndexable')
+    def isInstanceIndexable(self):
       """Test if an instance is indexable by default
       """
       portal = self.getPortalObject()
       klass = portal.portal_types.getPortalTypeClass(self.getId())
-      return klass.isIndexable()
+      if klass.__isghost__:
+        klass.loadClass()
+      return bool(klass.isIndexable)
 
     security.declarePublic('constructTempInstance')
     def constructTempInstance(self, container, id, *args, **kw ):