Skip to content

erp5
erp5
Commit 9d0e6a4a authored by Jérome Perrin's avatar Jérome Perrin
Browse files
Options

ui_test_core: replace form to update reference snapshot by a download link 

In case of snapshot test failure, we generated a form in a data:test/html
link. This was working on chrome at the time, but it no longer work these
days, probably because we switched to Same-Site cookie for authentication.
Anyway, this also had the problem that it's not so convenient to use
when updating the reference from the actual screenshot took from the
test running on test node.

These change this to generate a simple download link, and the workflow to
update reference snapshot becomes to click this link to get the new image,
upload it to development zope instance and re-export the business template.
parent c6bcde6d
Pipeline #20840 failed with stage
    Hide whitespace changes
    Inline Side-by-side
    Showing with 27 additions and 178 deletions
    bt5/erp5_ui_test_core/SkinTemplateItem/portal_skins/erp5_ui_test_core/Zuite_updateReferenceImage.py deleted 100644 → 0
    View file @ c6bcde6d
    from StringIO import StringIO
    portal = context.getPortalObject()
    image_file = StringIO(image_data.replace('data:image/png;base64,', '').decode('base64'))
    image_path = [p for p in image_path.split('/') if p]
    existing = portal.restrictedTraverse(image_path, None)
    if existing is None:
    container = portal.restrictedTraverse(image_path[:-1])
    container.manage_addProduct['OFSP'].manage_addImage(
    image_path[-1],
    image_file,
    '')
    else:
    existing.manage_upload(image_file)
    return "reference image at {} updated".format('/'.join(image_path))
    bt5/erp5_ui_test_core/SkinTemplateItem/portal_skins/erp5_ui_test_core/Zuite_updateReferenceImage.xml deleted 100644 → 0
    View file @ c6bcde6d
    <?xml version="1.0"?>
    <ZopeData>
    <record id="1" aka="AAAAAAAAAAE=">
    <pickle>
    <global name="PythonScript" module="Products.PythonScripts.PythonScript"/>
    </pickle>
    <pickle>
    <dictionary>
    <item>
    <key> <string>Script_magic</string> </key>
    <value> <int>3</int> </value>
    </item>
    <item>
    <key> <string>_bind_names</string> </key>
    <value>
    <object>
    <klass>
    <global name="NameAssignments" module="Shared.DC.Scripts.Bindings"/>
    </klass>
    <tuple/>
    <state>
    <dictionary>
    <item>
    <key> <string>_asgns</string> </key>
    <value>
    <dictionary>
    <item>
    <key> <string>name_container</string> </key>
    <value> <string>container</string> </value>
    </item>
    <item>
    <key> <string>name_context</string> </key>
    <value> <string>context</string> </value>
    </item>
    <item>
    <key> <string>name_m_self</string> </key>
    <value> <string>script</string> </value>
    </item>
    <item>
    <key> <string>name_subpath</string> </key>
    <value> <string>traverse_subpath</string> </value>
    </item>
    </dictionary>
    </value>
    </item>
    </dictionary>
    </state>
    </object>
    </value>
    </item>
    <item>
    <key> <string>_params</string> </key>
    <value> <string>image_data, image_path</string> </value>
    </item>
    <item>
    <key> <string>id</string> </key>
    <value> <string>Zuite_updateReferenceImage</string> </value>
    </item>
    </dictionary>
    </pickle>
    </record>
    </ZopeData>
    bt5/erp5_ui_test_core/SkinTemplateItem/portal_skins/erp5_ui_test_core/user-extensions.js.js
    View file @ 9d0e6a4a
    ...@@ -209,74 +209,6 @@ function generateElement(tagName, childList, attributeDict, textContent) { ...@@ -209,74 +209,6 @@ function generateElement(tagName, childList, attributeDict, textContent) {
    return element; return element;
    } }
    /**
    * Generate an HTML form to update the reference snapshot
    *
    * @param {string} referenceImageURL relative URL of the reference image
    * @param {string} newImageData the new image data, base64 encoded
    * @return {Promise<string>} the base64 encoded html form
    */
    function generateUpdateForm(referenceImageURL, newImageData) {
    return new Promise((resolve, reject) => {
    var fr = new FileReader();
    fr.onerror = reject;
    fr.onload = () => resolve(fr.result);
    fr.readAsDataURL(
    new Blob(
    [
    generateElement('html', [
    generateElement('body', [
    generateElement('p', [
    document.createTextNode('Replacing this old snapshot:'),
    generateElement('br'),
    generateElement('img', [], {
    src: location.origin + referenceImageURL,
    alt: 'reference image'
    }),
    generateElement('br'),
    document.createTextNode('with this new snapshot:'),
    generateElement('br'),
    generateElement('img', [], {
    src: newImageData,
    alt: 'new image'
    })
    ]),
    generateElement(
    'form',
    [
    generateElement('input', [], {
    type: 'hidden',
    name: 'image_data',
    value: newImageData
    }),
    generateElement('input', [], {
    type: 'hidden',
    name: 'image_path',
    value: referenceImageURL
    }),
    generateElement('input', [], {
    type: 'submit',
    value: 'Update Reference Snapshot'
    })
    ],
    {
    action:
    location.origin +
    '/' +
    referenceImageURL.split('/')[1] + // ERP5 portal
    '/Zuite_updateReferenceImage',
    method: 'POST'
    }
    )
    ])
    ]).innerHTML
    ],
    { type: 'text/html' }
    )
    );
    });
    }
    /** /**
    * verify that the rendering of the element `locator` matches the previously saved reference. * verify that the rendering of the element `locator` matches the previously saved reference.
    * *
    ...@@ -360,35 +292,33 @@ Selenium.prototype.doVerifyImageMatchSnapshot = ( ...@@ -360,35 +292,33 @@ Selenium.prototype.doVerifyImageMatchSnapshot = (
    }) })
    .then(diff => { .then(diff => {
    if (diff.rawMisMatchPercentage > misMatchToleranceFloat) { if (diff.rawMisMatchPercentage > misMatchToleranceFloat) {
    return generateUpdateForm(referenceImageURL, actual).then( htmlTestRunner.currentTest.currentRow.trElement
    updateReferenceImageForm => { .querySelector('td')
    htmlTestRunner.currentTest.currentRow.trElement .appendChild(
    .querySelector('td') generateElement('div', [
    .appendChild( document.createTextNode('Image differences:'),
    generateElement('div', [ generateElement('br'),
    document.createTextNode('Image differences:'), generateElement('img', [], {
    generateElement('br'), src: diff.getImageDataUrl(),
    generateElement('img', [], { alt: 'Image differences'
    src: diff.getImageDataUrl(), }),
    alt: 'Image differences' generateElement('br'),
    }), document.createTextNode('Click '),
    generateElement('br'), generateElement('a', [document.createTextNode('here')], {
    document.createTextNode('Click '), href: actual,
    generateElement( download: referenceImageURL.split('/').pop(),
    'a', }),
    [document.createTextNode('here')], document.createTextNode(' to download actual image for '),
    { generateElement('code', [
    href: updateReferenceImageForm generateElement('a', [
    } document.createTextNode(referenceImageURL),
    ), ],
    document.createTextNode( { href: referenceImageURL + '/manage_main' }
    ' to update reference snapshot.' )
    ) ])
    ]) ])
    ); );
    throw new Error('Images are ' + diff.misMatchPercentage + '% different'); throw new Error('Images are ' + diff.misMatchPercentage + '% different');
    }
    );
    } }
    }); });
    })); }));
    ......
    Markdown is supported
    0% or
    You are about to add 0 people to the discussion. Proceed with caution.
    Finish editing this message first!
    Please register or to comment
    GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7