- 28 Nov, 2019 31 commits
-
-
Jérome Perrin authored
There are no testVifib (at least not in nexedi/erp5 repository) and there is only one testLive that there is no reason to skip.
-
Jérome Perrin authored
This test never ran because we skip testLive*
-
Jérome Perrin authored
erp5_ingestion contained a skin folder for tests, with some proxy fields depending on erp5_web. There was a proper test dependency to erp5_web, but in static analysis check we now check the skin folders, so it's no longer allowed to have some skin folder that are broken without test dependencies but not supposed to be used outside of tests.
-
Jérome Perrin authored
Since this was using proxy fields from erp5_crm, add dependency on CRM. Update to the new name of CRM field library.
-
Jérome Perrin authored
nuvalidator complains that: Bad value “true” for attribute “autoplay” on element “video” This could probably be switched to VideoField now.
-
Jérome Perrin authored
Unlike other attributes managed in video field, preload [1] is not a boolean attribute, so setting preload="preload" was invalid HTML5. On the field, we can only configure video_preload as a boolean attribute, setting preload="auto" when true and not setting preload when False seems the closest meaning of True/False. [1] https://html.spec.whatwg.org/multipage/media.html#attr-media-preload
-
Jérome Perrin authored
IntegrationSite_view/my_source_payment is a proxyfield to a field in erp5_accounting.
-
Jérome Perrin authored
It uses proxy fields from erp5_crm
-
Jérome Perrin authored
'base_view_document_selection' 'Base_viewDocumentList/listbox': set(['erp5_core']) 'Project_viewDocumentList/listbox': set(['erp5_web_project']) 'project_module_selection' 'ProjectModule_viewProjectList/listbox': set(['erp5_project']) 'ProjectModule_viewProjectManagementList/listbox': set(['erp5_web_project'])
-
Jérome Perrin authored
These selection names were already used in other business templates: 'web_page_module_view_web_page_list_selection' 'WebPageModule_viewWebPageListAsJioForCodemirror/listbox': set(['erp5_officejs_codemirror']) 'WebPageModule_viewWebPageListAsJioForTextEditor/listbox': set(['erp5_text_editor']) 'WebPageModule_viewWebPageList/listbox': set(['erp5_web']) 'DocumentModule_viewDocumentListAsJioForPdfViewer/listbox': set(['erp5_officejs_pdf_viewer']) 'image_selection' 'WebPageModule_viewWebPageListAsJioForSvgEditor/listbox': set(['erp5_officejs_svg_editor']) 'ImageModule_viewImageList/listbox': set(['erp5_dms'])
-
Jérome Perrin authored
Module is an acceptable prefix for modules Introduce a list of skins IDs that does not match our conventions but are acceptable because this is what external API are calling.
-
Jérome Perrin authored
This `o` was an unused variable. The initial intention was probably this.
-
Jérome Perrin authored
The general approach is: - replace deprecated lambdas with list comprehensions - remove unused variables/imports - replace dangerous arguments [] with () - replace dangerous arguments {} with None and "if None -> {}" - replace builtin names with something similar - when really no other choice, line-disable the messages Now that all problems reported by pylint are fixed, enable coding style test.
-
Jérome Perrin authored
These scripts are not used and does not respect naming conventions or have pylint errors.
-
Jérome Perrin authored
PropertySheetChild is not an acceptable prefix, use Base as the context is used. Technically, this uses the "id as reference" mixin, but this mixin is a bit special as it has takes the suffix as parameter and does not reside in mixin module, so we just use Base as a prefix.
-
Jérome Perrin authored
FieldValidator is not an acceptable prefix, Base_validateDialogConfirmation seems better
-
Jérome Perrin authored
Rounding scripts: Planning is not an acceptable prefix, this script is called on the current context, so let's use Base_ as a prefix. Planning_roundBoundToMinute → Base_roundPlanningBoxBoundToMinute Planning_roundBoundToDay → Base_roundPlanningBoxBoundToDay Planning_roundBoundToInt → Base_roundPlanningBoxBoundToInt
-
Jérome Perrin authored
-
Jérome Perrin authored
Without this, subclassing defining this method will have arguments-differ pylint warning because the signature of Base._checkConsistency is different.
-
Jérome Perrin authored
These scripts are used to check the site configuration and also in CodingStyleTest. This is just the minimal so that CodingStyleTest can run, but this could be extended to several scripts currently in erp5_toolbox skinfolder of erp5_forge which overlaps with erp5_administration. Also, regarding CodingStyleTest, it seems that erp5_administration contain a lot of things, so we may want to extract a smaller business template containing only the scripts used for static analysis of business template.
-
Jérome Perrin authored
We want this check to run on all components.
-
Jérome Perrin authored
Some portal types such as Business Template were not tested by testXHTML because this tests started by modules and recursively tests views based on allowed content types. Because of this approach, types that are not created in a module but in a tool were never tested. With unittest, the only way to dynamically add test methods to a class is to generate a test class in test_suite function. At this stage, the ERP5 site is not created yet, so the test had to introspects business templates XML. This now uses a slightly different approach, instead of finding modules and chain of allowed content types from business template XML, we only use business template to introspect the list of actions. The lookup of the appropriate containers is no longer done before setup by static analysis of business templates XML, but later once the site is created, by dynamic analysis of the modules and allowed content types on the running ERP5 site during the test method. If we don't find a chain of portal types, we create the test document in portal_trash, a tool without filter of content types. This way, we can test all views of all portal types. This revealed a few problems: - we need developer role to create components in portal_components, for this we add developer role to the current user. - Delivery Cell portal type looks not used, there are no container accepting it. We don't test delivery cell views for this reason. - VCS view on business template needs preferences and working copy setup. We just mark this test as expected failure for now. - Solver Decision has a form conditionnaly displayed when there's a relation to a solver, but this test does not evaluate action conditions and does not allow to call a script (that would made it possible to modify the document so that the condition is true). For now we also mark this as expected failure.
-
Jérome Perrin authored
Delivery Cell is not really used these days and cannot be created in testXHTML, so drop these useless views. For reference, the same views still exists on all other movements portal types, so we don't "loose anything important" by removing the views here.
-
Jérome Perrin authored
The corresponding form, BudgetTransfer_viewBudgetTransferLine does not exist, so mark view as not visible for now so that it's not tested.
-
Jérome Perrin authored
This redirects to another site, so it is not really a view action. This also confuses testXHTML.
-
Jérome Perrin authored
-
Jérome Perrin authored
Maybe what's missing is an interaction to update cache internals with updateCache when a cache is added, but that's enough to make TestXHTML pass now.
-
Jérome Perrin authored
DublinCore was missing, so getCompactTitle was causing AttributeError _baseGetTranslatedTitle
-
Jérome Perrin authored
When listboxs has an editable field, but the field is non editable, it produces a markup like: <a href="link to the line"><EditableField/></a> This is fine for most fields, but some editable fields are rendered as an <input> even if they are not editable - this is the case for CheckBoxField. To prevent rendering <a><input></a> which is not valid HTML, configure the enabled field as non-editable on alarm list view, with this change listbox treats the field as an editable field and just render the field as <EditableField/> without the <a>. To keep the same visual appearance of having a disabled checkbox field, make this field disabled with extra.
-
Jérome Perrin authored
-
Jérome Perrin authored
The action was in erp5_core, but the form in erp5_forge. Move the action in erp5_forge. The listbox list method was raising error because it was using catalog with unsupported installation_state=. Change to use contentValues instead. This listbox had "Listbox" as a title, use "History" instead, which makes a little more sense in this context.
-
- 27 Nov, 2019 8 commits
-
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
Keep the same panel/header links than on form_view.
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Vincent Pelletier authored
Translation table seems to be often picked before other conditions by MariaDB's query planner. When there is at least one other condition on a query which require a join (ex: category-based relation, delivery-table-based date comparison, ...) this may not be the most efficient execution plan. Instead, put translation lookup into its own separate query, in a way similar to security_uid lookup. This way, two separate execution plans can be used to execute the overall operation. One drawback is that the new query does not know of any portal_type condition, so all possible original values are listed along with their respective portal types. This does not seem to affect query performance, and on most common (and simple) cases where a translated value is used, like module listboxes, the query planner should be able to eliminate irrelevant entries as such queries are already expected to provide a list of relevant portal types and to lack condition nesting. Preserve custom related keys: these are used when selecting or sorting, while the scriptable keys are used when applying a condition. Note on UI tests: mass workflow transition listbox is not supposed to be sorted. It's bad that these tests all rely on row order, and also bad that they all check the whole listbox. They should pick the line they care about and not check the rest - except for one test whose purpose would be to check the whole list anyway.
-
Vincent Pelletier authored
Add support for "like" auto-detection and use as default comparison operator. Allows mimicking KeywordKey and DefaultKey with 2 parameters, in addition to already-supported simple SearchKey.
-
- 26 Nov, 2019 1 commit
-
-
Gabriel Monnerat authored
-