1. 26 Sep, 2022 14 commits
  2. 23 Sep, 2022 4 commits
  3. 22 Sep, 2022 2 commits
  4. 21 Sep, 2022 5 commits
  5. 20 Sep, 2022 2 commits
  6. 16 Sep, 2022 3 commits
  7. 15 Sep, 2022 5 commits
    • Jérome Perrin's avatar
      Arrow categories types · adcb959e
      Jérome Perrin authored
      See merge request !1665
      adcb959e
    • Jérome Perrin's avatar
      simulation: introduce MovementGeneratorMixin._updateGeneratedMovementList · 93a0f39f
      Jérome Perrin authored
      This allows custom movement generators to set ad-hoc properties on
      generated movements depending on properties of the corresponding
      input movement.
      
      There was already _getUpdatePropertyDict which is similar, but was
      sometimes not enough because it can only be use to set extra
      properties on all movements.
      
      As a result, when we needed a rule with custom properties on
      generated movements, we resorted to overriding getGeneratedMovementList
      and duplicating the full logic of the method. Existing cases have
      been updated to use the new _updateGeneratedMovementList and in the
      case of InventoryAssetPriceAccountingRuleMovementGenerator we no
      longer need to duplicate the logic.
      
      Also remove the comment suggesting overriding getGeneratedMovementList
      in subclasses, now several "extension" methods exists, so it should
      not be needed to override getGeneratedMovementList, every needs
      should be coverred by defining _updateGeneratedMovementList or
      _getUpdatePropertyDict
      93a0f39f
    • Jérome Perrin's avatar
      ERP5Type/patches/User: drop BasicUser.allowed patch · 6c6a8098
      Jérome Perrin authored
      This patch does not seem necessary
      6c6a8098
    • Jérome Perrin's avatar
    • Jérome Perrin's avatar
      fix some typos · b010e977
      Jérome Perrin authored
      b010e977
  8. 14 Sep, 2022 1 commit
    • Vincent Pelletier's avatar
      Products.CMFActivity.Activity.SQLBase: Drop "FOR UPDATE". · 89aa2a6b
      Vincent Pelletier authored
      This SELECT option was added when the UPDATE query was split into a
      SELECT + UPDATE query pair, in order to try to avoid deadlocks in mariadb.
        commit 7daaf0a5
        Author: Vincent Pelletier <vincent@nexedi.com>
        Date:   Fri Jun 7 16:53:11 2013 +0200
      
            Work around poor UPDATE use of index.
      That was not completely successful, and another attempt was since made,
      which further ipmproved the situation:
        commit e21aa47f601a98f767e2d3e8490b20b7f409933c
        Author: Vincent Pelletier <vincent@nexedi.com>
        Date:   Fri Sep 17 11:34:46 2021 +0900
      
            CMFActivity.Activity.SQLBase: Reduce the number of deadlocks
      
      This change made the "FOR UPDATE" option obsolete: there should be
      virtually no parallelism between the SELECT and UPDATE queries.
      By which I mean only 3rd-party accesses (like an admin on a mysql console)
      would bypass the SQL lock, causing index-update-level locking issues.
      
      Checking now, I see that removing "FOR UPDATE" on the "node>0" query makes
      that query (with LIMIT 30) run about 5 times faster:
      With FOR UPDATE:    0.509s
      Without FOR UPDATE: 0.090s
      This difference is enough to cause significant activity starvation on a
      63-processing-nodes cluster where such activities run in about 1s, just
      because of the amount of contention on the SQL lock, itself because of the
      duration of every execution of this query.
      
      So remove this now-redundant option.
      
      It is expected that this will improve activity processing performance in
      general, beyond just the starvation issue which led to this discovery.
      89aa2a6b
  9. 13 Sep, 2022 1 commit
    • Xiaowu Zhang's avatar
      erp5_crm: new sale opportunity workflow · cc8740c6
      Xiaowu Zhang authored
      Draft: The first state when we create a new Sale Opportunity.
      
      Open: All information of the Sale Opportunity is entered such as prospect's contact email, questions, etc
      
      Suspended: We replied to prospect, waiting for their return.
      
      Closed: The Sale opportunity is either 1) accepted by prospect, turn into a Sale Order; or 2) Clearly rejected by prospect.
      
      Expired: No return/ news from prospect for some time.
      
      Deleted: in case added by mistake, so user can delete it
      cc8740c6
  10. 09 Sep, 2022 1 commit
  11. 07 Sep, 2022 2 commits