- 28 Jun, 2017 4 commits
-
-
Vincent Pelletier authored
Query has a higher overhead than SimpleQuery, and should be avoided wherever possible. Also, get rid of two unnecessary intermediate ComplexQuery levels. There are a few remaining Query uses here, which should go away soon.
-
Vincent Pelletier authored
Also, use valid base categories for not-in-preferred_predicate_category_list test. Also, improve coding style. Also, after changing preferred predicate category list, only reindex the module containing predicates instead of the whole site, to reduce test duration.
-
Vincent Pelletier authored
This ZSQLMethod is shadowing the one ERP5Catalog is trying to use, and it has a table list incompatible in 2 ways: - it joins again with catalog, despite only being used to pick the uid, which ERP5Catalog stopped doing for auto-generated related keys - it is actually a chained related key: resource, then use. But "resource_use" exists as a Base Category, and is accessible (but broken until this change) as "default_resource_use_uid" (for example).
-
Vincent Pelletier authored
aggregate_uid can be auto-generated with one less join, and chosen ZSQLMethod name gets in the way of auto-generated related key (default_aggregate_uid and the like).
-
- 26 Jun, 2017 3 commits
-
-
Jérome Perrin authored
* Remove include_empty_item: We always want an empty item in dialogs * Remove include_gap_in_path: This was always true simplify code a little bit.
-
Jérome Perrin authored
* There was another level of cache in Account_hashGapItemList * Category title was used in AccountModule_getAvailableGapList
-
Vincent Pelletier authored
Unlike other database adaptors, memcache adaptors can be shared among transactions. So pool them in order to reduce the number of connections established to memcached servers. And as the connections handle thread-safety internally (by inheriting from threading.local), threads can share the same connection instance. Also, do not create a new connector each time we get disconnected, just reconnect. Also, memcached internally retries connection, so no need to retry it ourselves. Also, do not log when failing to update & delete entries in cache server: this is a racy cache, each read much be checked anyway, so failed writes are just business as usual. Also, document a bit more why we catch "any" exception happening during finish, and specify base exception class following python coding best practices. Also, use named constant for loggin levels for remaining log directives. Also, display traceback when catching a connection issue during __getitem__, as the original exception gets converted into a KeyError.
-
- 23 Jun, 2017 4 commits
-
-
Jérome Perrin authored
-
Vincent Bechu authored
/reviewed-on nexedi/erp5!305
-
Jérome Perrin authored
This includes two parts, first is to change the condition for an organisation to be able to use the bank accounts from organisations from parent groups. This is useful for the case where organisations from subgroups does not represent different legal entities but simply some "business units". The condition for that have always been: if organisation does not contain bank account, this organisation can use bank accounts from the parent groups. To be consistent with other places, such a closing accounting periods or setting grouping references, change the condition to: if the organisation does not contain accounting periods, this organisation can use bank accounts from parent organisations. The behavior should not change much and allow to create bank accounts or cash registers that can be used only in one sub-group organisation. Second part is about making it visually easier to understand which organisation the bank account belong to by adding some non-selectable options in the select for the organisations. This is only enabled when available bank accounts are not all contained in the same organisation. ![Screenshot_2017-06-19_at_15.24.35](/uploads/dc538645bb79a00f25444547d524635f/Screenshot_2017-06-19_at_15.24.35.png) /reviewed-on nexedi/erp5!299
-
Jérome Perrin authored
This is fix for #20170614-26135D "Bank Reconciliation only show transactions for the selected organisation" At the same time, we stop using `portal_catalog.getObject` in `erp5_bank_reconciliation`. /reviewed-on !297
-
- 22 Jun, 2017 5 commits
-
-
Sebastien Robin authored
By default in ERP5 all fields are not mandatory
-
Eugene Shen authored
-
Eugene Shen authored
-
Eugene Shen authored
Add transparent SVG and PNG icons to the manifest, rename all functions following the Nexedi conventions, link to the TodoMVC homepage, move Handlebars template to head, and rename all files from tutorial_officejs_* to officejs_todomvc_*.
-
Eugene Shen authored
-
- 21 Jun, 2017 6 commits
-
-
Tomáš Peterka authored
Fixes failing tests because of always showing "No work to be done" in worklist (lazy bug) Test Results 20170621-6D7F8E4B /reviewed-on nexedi/erp5!304
-
Vincent Bechu authored
-
Vincent Bechu authored
/reviewed-on nexedi/erp5!303
-
Vincent Bechu authored
/reviewed-on nexedi/erp5!302
-
Jérome Perrin authored
-
Jérome Perrin authored
Name is unchanged, but it will use Products.ERP5Type.Utils.checkPythonSourceCode which uses pylint.
-
- 20 Jun, 2017 3 commits
-
-
Vincent Bechu authored
/reviewed-on nexedi/erp5!301
-
Vincent Bechu authored
-
Vincent Bechu authored
-
- 19 Jun, 2017 11 commits
-
-
Vincent Bechu authored
-
Vincent Bechu authored
-
Vincent Bechu authored
-
Vincent Bechu authored
-
Tristan Cavelier authored
-
Tomáš Peterka authored
/reviewed-on !296
-
Tomáš Peterka authored
-
Jérome Perrin authored
-
Jérome Perrin authored
The condition for an organisation to be able to use bank account from other organisations higher in the group hierarchy should not be the presence of bank account in this organisation, but whether or not it acts as an independant accounting entity, and this is defined by the presence of accounting periods.
-
Jérome Perrin authored
Section bank account item list script was using `parent_strict_group_uid` related key but in 772033ed we removed `parent_strict_group_uid` related key and added support to generate `strict_parent_group_uid` related key. In that case, *Section Bank Account* field on payment transaction was empty ![Screenshot_2017-06-16_at_18.54.33](/uploads/4f439bf14fb8b4d54df80031d281ce7a/Screenshot_2017-06-16_at_18.54.33.png) The `TypeError: Unknown columns ['parent_strict_group_uid']` was only in the log files, because we are still ignoring errors in TALES. I'm adding tests to cover this script, it's logic should have been tested anyway. /reviewed-on nexedi/erp5!295
-
Jérome Perrin authored
See discussions in nexedi/erp5!257 from background. Here we try to reduce the differences in indexation methods that use `DELETE` and then `INSERT` (the one who does not always index the same number of rows). In `z_catalog_predicate_list` the `DELETE` was missing, so in the case of predicate which stopped being a predicate, that predicate was never removed from the table. /reviewed-on nexedi/erp5!294
-
- 16 Jun, 2017 4 commits
-
-
Tomáš Peterka authored
-
Iliya Manolov authored
@Tyagov @luke /reviewed-on nexedi/erp5!288
-
Jérome Perrin authored
getObject is not public API. Bonus is we can do one query for all uids
-
Jérome Perrin authored
Since it's allowed for multiple sections from same group to post transactions on the bank account from the parent sections, the bank reconciliation should use the same logic to be able to reconcile transactions from any section.
-