- 04 Jun, 2021 6 commits
-
-
Jérome Perrin authored
We received a few support requests from users who are able to change their password but not to log-in afterwards. These users probably copy and pasted their user name with an extra leading or trailing space. In the reset password dialog, these spaces are stripped, because Formulator by default strips the input (unless "whitespace preserve" is on, but we usually don't set it except in text areas). Historically we have been completely avoiding the extra spaces and made the login/user_id case insensitive, because login and user id were the same thing and there have been issues when looking up user id in mariadb because of mariadb collations, so we took the easy way of saying "logins are case sensitives and spaces also mater", but with separate login / user id, this can be revisited, because the login is only used to check the password and find an user ID. Stripping spaces from logins is a common thing these days (google, twitter, facebook strip logins) which simplifies user experience and reduces support. The risk of conflicts seems very low, if users are created with ERP5 Forms Formulator already had stripped the login anyway. After this change in case of two user names ('alice' and ' alice ') conflict, none of them would be able to login. We keep compatibility with users with trailing spaces, so if there is only a user named ' alice ', without other users that would conflict (for example 'alice' or ' alice'), this user remain able to login anyway. This last part is probably not so important in reality, it is for compatibility with testPasswordTool.TestPasswordTool.test_login_with_trailing_space
-
Jérome Perrin authored
-
Jérome Perrin authored
Rename this column from "Sale Trade Condition" to "Trade Condition", so that it can be used also for purchase and internal trade conditions.
-
Jérome Perrin authored
- update for ERP5JS compatibility - prevent an error with "Select Payments" update action, when limit was empty - export to generate SEPA credit transfer ( pain.001.001.02 ) - new mode in "Select Payment" to select planned/confirmed payment and validate them at the same time - allow selecting lines individually in "Select Payments" - allow filtering by third party in "Select Payments" (only supported in xhtml_style for now) - fix issue that Deliver transaction leaves PTG in Delivering state - french translations See merge request nexedi/erp5!1400
-
Jérome Perrin authored
Changes following up nexedi/slapos!985 It seems the logo is a bit bigger, or at least a bit different See merge request nexedi/erp5!1424
-
Jérome Perrin authored
When running OCR, we sometimes have issues because processing is "too heavy": - [x] use 2 or 3 Go of disk space for a one page PDF created by erp5_document_scanner, because we convert pdf -> png -> tiff before sending to tesseract. Modern Ghostscript supports running tesseract directly, so we use it if it's available. - [x] use 300% of CPU. Fixed by setting `OMP_THREAD_LIMIT` when running tesseract. This will only apply when OCR from Images. OCR embedded in Ghostscript does not seem to need this. - [x] ... and often crash, so is restarted. This is fixed by updated tesseract. Updates of ghostscript and tesseract are part of nexedi/slapos!985 See merge request nexedi/erp5!1420
-
- 03 Jun, 2021 2 commits
-
-
Jérome Perrin authored
By relying on PIL after our monkey-patched OFS.Image.getImageInfo. We keep this monkey-patch for now, because it adds supports to svg See merge request nexedi/erp5!1426
-
Jérome Perrin authored
Since 7f32f8cd (erp5_dms: Add PDF Reader using the pdf.js, 2016-06-24) we have a PDF preview with a javascript PDF view, which is much better way of viewing PDF. This commit made the Thumbnail preview obsolete, also it does not really work on ERP5JS, so remove the thumbnail preview.
-
- 02 Jun, 2021 14 commits
-
-
Julien Muchembled authored
See commit ec3c9cbc.
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
payment transaction group workflow's deliver action is a two step delivery, which "start delivery" and wait for an interaction to finish the delivery. Add a default interaction workflow which finishes the delivery immediately, otherwise the payment transaction group stay in delivering state when user use the Deliver workflow action.
-
Jérome Perrin authored
For same reasons as f692aa61 ([erp5_bank_reconciliation] Rename your_mode field, to prevent naming conflict in hal, 2019-10-23)
-
Jérome Perrin authored
Enable the "select column" of the listbox so that user can choose one by one the lines to add to the group. The default action, when nothing is selected, remain the same "select everything".
-
Jérome Perrin authored
This uses a listbox search column, which is not yet supported in ERP5JS, so for now the feature is only available in erp5_xhtml_style.
-
Jérome Perrin authored
Show an empty listbox at the beginning, that will be populated when user start to search. This is required if we want the ?reset=1 from the action URL to really reset the selection.
-
Jérome Perrin authored
This list is currently not sortable, so don't show sort column
-
Jérome Perrin authored
This was often leaving a comment with 'None'
-
Jérome Perrin authored
Checking that for all lines: - bank account is set, for both sides - bank accounts have IBAN and BIC - bank accounts are validated - bank accounts belong to the section (to prevent problem when cloning and not changing the bank account) These constraints are present in a property sheet that have to be associated to accounting transaction movement portal type in a configurator step, and also as assertions in the file generation.
-
Jérome Perrin authored
and only show the generate credit transfer action if the payment mode is correct.
-
Jérome Perrin authored
-
Jérome Perrin authored
For historical reasons, PDF to text involved conversion first of the PDF to png, then this png to tiff and the tiff was sent to tesseract. This works, but it consumes a lot of resources with large PDFs, especially because the intermediate png/tiff are created with a resolution of 300 DPI, which easily needs serveral Go of RAM and temporary disk space. This was obsorved with the PDF created by erp5_document_scanner, which are usually high quality (1 or 2Mo per page) and even a one page PDF sometimes took more than one minute to OCR. Since 9.53 ghostscript integrates tesseract engine directly, we don't need to prepare a tiff beforehand, we can directly send the PDF data to ghostscript. These change use ghostscript if available and otherwise fallback to the same pipeline as before. This will allow the transition until all ERP5 instances are running a recent enough SlapOS with ghostscript 9.54. Fortunately, before SlapOS include ghostscript 9.54, ERP5 software release did not have ghostscript in $PATH, so we don't have to check ghostscript version, we assume that if gs is in $PATH, it means we have a recent enough SlapOS. This new approach was less tolerant regarding broken/password-protected PDFs so we perform a new check that the PDF is valid and not encrypted before trying to use OCR.
-
- 01 Jun, 2021 1 commit
-
-
Rafael Monnerat authored
See merge request nexedi/erp5!1429
-
- 31 May, 2021 17 commits
-
-
Kirill Smelkov authored
Wendelin.core is now integral part of ERP5 (see [1,2]), but nothing inside ERP5 currently uses it. And even though wendelin.core has its own testsuite, integration problems are always possible. -> Add test to erp5_core_test that minimally makes sure that basic wendelin.core operations work. This test currently passes with wendelin.core 1, which is the default. It also passes as live test with wendelin.core 2. However with wendelin.core 2 it currently fails on testnodes like e.g. ValueError: ZODB.MappingStorage.MappingStorage is in-RAM storage in-RAM storages are not supported: a zurl pointing to in-RAM storage in one process would lead to another in-RAM storage in WCFS process. and RuntimeError: wcfs: join file:///srv/slapgrid/slappart8/srv/testnode/djk/test_suite/unit_test.2/var/Data.fs: server not started (https://nexedijs.erp5.net/#/test_result_module/20210530-92EF3124/102) because we need to amend ERP5 test driver 1) to run tests on a real storage instead of in-RAM Mapping Storage(*), and 2) to spawn WCFS server for each such storage. I will try to address those points in a later patch. In the meantime there should be no reason not to merge this, because we do not use wendelin.core 2 yet, and solving "1" and "2" first are preconditions to begin such a usage. /cc @rafael, @tomo, @seb, @jerome, @romain, @vpelletier, @Tyagov, @klaus, @jp (*) Combining Zope and WCFS working together requires data to be on a real storage, not on in-RAM MappingStorage inside Zope's Python process. [1] nexedi/slapos@7f877621 [2] nexedi/slapos!874 (comment 122339)
-
Jérome Perrin authored
For SEPA files "End to End ID" we need a reference on payment transactions. In the first prototype, the reference was set at the time of generating the file, but it's a non common behaviour to generate reference when producing reports, so we changed to ensuring payment has reference when adding to the group.
-
Jérome Perrin authored
Instead of using only setAggregate(), specify a portal type to consider only payment transaction groups.
-
Jérome Perrin authored
Because of the wrong TALES, jump and select was not working on the aggregate relation field on accounting transaction line.
-
Jérome Perrin authored
Support generating pain.001.001.02 credit transfer from payment transaction groups.
-
Jérome Perrin authored
-
Jérome Perrin authored
Having a portal type is required to use the listbox as "Proxy Listbox ID" in a relation field.
-
Jérome Perrin authored
Follow the same rule that allow other organisations from the same group to use bank account from the main section when selecting the payments and displaying the payments from the group.
-
Jérome Perrin authored
This constraint will have to be enabled by configurator/upgrader.
-
Jérome Perrin authored
-
Jérome Perrin authored
Instead of selecting already stopped payments, introduce a new "mode" field in the dialog, where user can choose the previous behavior of selecting stopped payments, or a new behavior where user would select planned or confirmed payments, in that case the payments will be automatically stopped before being added to the group.
-
Jérome Perrin authored
Functional test for erp5_payment_mean with ERP5JS
-
Jérome Perrin authored
Functional test for erp5_payment_mean
-
Jérome Perrin authored
Rename the field, because on xhtml_style, submitting the field with an empty limit now cause an error like: ValueError: invalid literal for int() with base 10: '' and on ERP5JS it is ignoed. Also, make the field required and set a small default value and a range, to prevent accidentally displaying/selecting too much when there's lot of data matching.
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
We don't want to show the ID which has a prefix, but the reference
-