- 11 May, 2021 1 commit
-
-
Jérome Perrin authored
When viewing the worklist page, a request is made to traverse portal_workflow, which translate global worklist actions including the document count. The non regression test was failing with: [u'Draft To Validate (1)'] != ['Draft To Validate'] and in real usage, several messages were added to Localizer.
-
- 10 May, 2021 2 commits
-
-
Jérome Perrin authored
fixup! ERP5Workflow: testPerformance: Object creation is slower so increase maximum acceptable value. 0.0062 was still too much, we had test run taking 0.0064, set the threshold to 0.0066 to be safe.
-
Jérome Perrin authored
Sequence produce lots of useless output, which makes it slow to display test result pages for tests using sequences, like testBusinesTemplate. It must also be taking a lot of disk space on the server and is generally not useful, when a test fail we have the log of the failing test.
-
- 07 May, 2021 4 commits
-
-
Jérome Perrin authored
Let's be consistent and use "Permissions" everywhere.
-
Jérome Perrin authored
See merge request !1405
-
Jérome Perrin authored
In English, "Open" means both the action of openning and the state when something is open. Several workflows have the problem that the "Open" transition is translated to something that does not describe the action, but the state. We have a mechanism to override the translation for a state, by translating `Word [{state_title} state in {workflow_id}]`, but we don't have such mechanism for transitions, so when "Word" exist both as a transition and a state, "Word" should be the translation of the transition and we should have translations in context for all the workflow states.
-
Arnaud Fontaine authored
-
- 06 May, 2021 4 commits
-
-
Jérome Perrin authored
Starting from PAS 1.10.0, assignRoleToPrincipal is private, only manage_assignRoleToPrincipals can be used from restricted python.
-
Jérome Perrin authored
-
Jérome Perrin authored
We do nothing on these methods, but we comply to the interface.
-
Gabriel Monnerat authored
-
- 03 May, 2021 1 commit
-
-
Gabriel Monnerat authored
-
- 30 Apr, 2021 7 commits
-
-
Gabriel Monnerat authored
-
Gabriel Monnerat authored
When there is a invalid field, we trigger a notification if the user tries to save the form. But, if this notification is triggered, we don't trigger an alert when the user clicks in another page to leave. But, if the field is invalid, the user does not click in "Save" and try to leave, the alarm is triggered.
-
Gabriel Monnerat authored
-
Gabriel Monnerat authored
Workflows are ERP5 Document now, we stay inside ERP5JS intead of go to ZMI
-
Gabriel Monnerat authored
-
Gabriel Monnerat authored
erp5_web_renderjs_ui: Display dev action to gadget field and avoid duplicated actions to parallel field And avoid random failures
-
- 29 Apr, 2021 3 commits
-
-
Aurel authored
-
Aurel authored
-
Romain Courteaud authored
-
- 28 Apr, 2021 2 commits
-
-
Romain Courteaud authored
-
Arnaud Fontaine authored
-
- 27 Apr, 2021 3 commits
-
-
Romain Courteaud authored
-
Romain Courteaud authored
This case breaks action calculation between xhtml style and ERP5JS.
-
Xiaowu Zhang authored
See merge request nexedi/erp5!1403
-
- 26 Apr, 2021 3 commits
-
-
Xiaowu Zhang authored
-
Jérome Perrin authored
As per the discussion on nexedi/erp5!1378 (comment 131223) what's important for this test is that the value is high. It seems the test was not updated to the final version. We now have 35, not 36.
-
Jérome Perrin authored
state.getId() now have a prefix, we want to use state.getReference() here.
-
- 23 Apr, 2021 7 commits
-
-
Arnaud Fontaine authored
ERP5Workflow: Remove unused variable_default_value and use variable_default_expression instead (!1378).
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
ERP5Workflow: erp5_configurator_*: Migrate Configurator Workflows from workflow_module to portal_workflow (!1378). Migration Procedure: With your current instance: 1. Update erp5.git 2. Start your instance. 3. Upgrade erp5_property_sheets, erp5_core and erp5_configurator bt5s. 4. Add an External Method for the module migrateWorkflowModuleToPortalWorkflow and the function of the same name as the module. 5. Run the External Method to convert them from workflow_module to portal_workflow. 6. Move all workflow_module from PathTemplateItem of your Business Template to Workflows and commit.
-
Arnaud Fontaine authored
This also moves all Configurator Workflows in workflow_module to portal_workflow (workflow_module was an implementation of Workflows based on ERP5 objects and not using DCWorkflow code). * Workflows are now defined on on portal_workflow._chains_by_type anymore but, as everything else, on the Portal Type itself. * portal_workflow can contain and work at the same time with legacy and new Workflows (ERP5Type/patches/DCWorkflow.py monkey-patching DCWorkflow classes to provide the same API). * Existing Workflow Scripts should work as they are and the code can be updated later on to take advantage of the new API: + With legacy implementation Workflow {Scripts,Transitions,Worklists,States} were in a Folder ({scripts,transitions,worklists,states} attribute) but all of these are now in the Workflow itself and their IDs are prefixed (PropertySheet-style), for example `script_`. Legacy attributes are provided in new implementation to call the new API. + When calling a Workflow Script, `container` was bound to its parent, namely WF.scripts (Folder) and a Workflow Script could call another. Now `container` is bound to the WF itself and Workflow Scripts are in a Workflow directly. New implementation `scripts` attribute handle such use case. + Override portal_workflow.__getattr__ so that a Workflow Script can call another one without prefix. * Worklist are Predicate: Worklist filter objects based on given criterions and thus it makes more sense for a Worklist to be a Predicate (albeit a Predicate with only Identity Criterion and nothing else). + Criterion Properties: * state_variable. * local_roles (SECURITY_PARAMETER_ID). * Any Workflow Variables with for_catalog == 1. erp5_performance_test:testWorkflowPerformance were ran to compare DCWorkflow and ERP5Workflow implementations and it seems to be about 4% slower with the new implementation (legacy: 7.547, 7.593, 7.618, 7.59, 7.514 and new: 7.842, 7.723, 7.902, 7.837, 7.875). Work done by Wenjie Zheng, Isabelle Vallet, Sebastien Robin and myself.
-
Arnaud Fontaine authored
-
Jérome Perrin authored
this is not erp5_accounting data model.
-
- 21 Apr, 2021 2 commits
-
-
Roque authored
ERP5Type.Core.Folder: bundle parameter configurable on folder migration and higher migration priority - to ensure the number of activities doesn't increase infinitely with large module contents and to prevent conflicts on the module itself
- 20 Apr, 2021 1 commit
-
-
Roque authored
new id generation script
-