1. 13 Dec, 2024 2 commits
    • Vincent Pelletier's avatar
      erp5_core: Improve BaseExtensibleTraversableMixin._forceIdentification · c7a4958f
      Vincent Pelletier authored
      Fix bugs:
      - Fix an acquisition context bug: the user found here would be wrapped in
        the acquisition context of self, and as a result SecurityManager.validate
        may consider the user to be outside of the acquisition path of the
        document being checked (ex: when accessing a module while publishing a
        web section).
      - While unusual, there may be multiple users matching a given request,
        which is handled by ZPublisher but was skipped here.
      
      Also:
      Document:
      - Why this method is needed.
      - assumptions made to get simpler code.
      Improve performance:
      - portal_membership._huntUser looks the user up twice, which is expensive.
        Stop using this method.
      - When the request is a fake request (from restrictedTraverse) nothing can
        nor should be done, so bypass the entire logic that case.
      - Assorted tiny improvements: do not retrieve security manager twice, avoid
        extraneous local assignments, ...
      Improve coding style:
      - Stop accessing portal_membership's underware.
      - Stop accessing PluggableAuthenticationService's underware.
      - Simplify disabled cache support: this is exceedingly rare, optimise for
        when it is enabled.
      - Do not hardcode log level, also increase the severity: this really is a
        warning.
      - Do not try to decode Basic-auth, this is the job of the user folder.
        This removes duplicated code.
      c7a4958f
    • Yusei Tahara's avatar
      ods_style: Fix column length. Revert to the previous behavior. · 76bd4921
      Yusei Tahara authored
      Set table:number-columns-spanned to each cell outside listbox/matrixbox.
      76bd4921
  2. 06 Dec, 2024 1 commit
  3. 21 Nov, 2024 1 commit
  4. 20 Nov, 2024 2 commits
  5. 18 Nov, 2024 2 commits
  6. 15 Nov, 2024 1 commit
  7. 14 Nov, 2024 1 commit
    • Nicolas Wavrant's avatar
      erp5_pdm: speed up the Stock view of products · d1c141da
      Nicolas Wavrant authored
      By pre-fetching some catalog entries to retrieve objects UIDs that can directly
      be used in the inventory query, to avoid needless (costly) joins and hinting
      the catalog to use the resource_section_node_uid index of the stock table.
      d1c141da
  8. 12 Nov, 2024 9 commits
  9. 11 Nov, 2024 1 commit
  10. 08 Nov, 2024 8 commits
  11. 07 Nov, 2024 3 commits
  12. 06 Nov, 2024 1 commit
    • Vincent Pelletier's avatar
      erp5_oauth2_authorisation: Do not edit OAuth2 Session on every refresh token issuance · 36768696
      Vincent Pelletier authored
      Malevolent users may decide to only - and repeatedly - present an otherwise
      valid refresh token, causing the issuance of a new access tokens everytime,
      likely along with new refresh tokens, causing many ZODB writes.
      Avoid this by pushing the token expiration date by one lifespan accuracy,
      so there can only be one write per session per lifespan accuracy period.
      36768696
  13. 05 Nov, 2024 6 commits
    • Jérome Perrin's avatar
      accounting: only allow Assignor to restart accounting periods · d7c0baf1
      Jérome Perrin authored
      This partially reverts 8a336dc5 (erp5_accounting: Allow
      Assignor manage Accounting Periods, 2024-09-16) for the restart
      transition, it is intentional that only Assignor can restart
      an accounting period that have been closed.
      The idea was to support a scenario where re-opening a period
      that was closed can not be done directly by the Assignee but
      needs validation from the assignor.
      d7c0baf1
    • Jérome Perrin's avatar
      web_renderjs_ui: fix detection of Base_redirect redirections · ad699c72
      Jérome Perrin authored
      The check was made on the blob response type, which is set from the
      Content-Type header returned by the server, but Safari has a different
      interpretation of the charset parameter from the mime type, with a
      content type set to application/json;charset=utf-8 like Base_redirect
      does today, safari creates a blob with type application/json;charset=utf-8
      and this was not detected as redirection and the json returned by
      Base_redirect was downloaded. Fix this by checking only the essence
      of the type.
      
      This also revealed a potential problem when actually downloading json
      files, in that case we also check that we have the X-Location header,
      that is supposed to be set by Base_redirect before interpreting the json
      and when it's not present we force download.
      ad699c72
    • Jérome Perrin's avatar
      ERP5Workflow: fix adding permissions · 9f3d6a99
      Jérome Perrin authored
      Follow up of ff624fd2 (ERP5Workflow: newly added permission should be
      acquired for all existing states., 2024-11-04) and cbef6282 (ERP5Workflow:
      make sure not create duplicate permissions, 2024-11-05)
      9f3d6a99
    • Jérome Perrin's avatar
      ERP5Workflow: make sure not create duplicate permissions · cbef6282
      Jérome Perrin authored
      Fix a problem introduced in ff624fd2 (ERP5Workflow: newly added
      permission should be acquired for all existing states., 2024-11-04),
      visible in a test failure
      cbef6282
    • Jérome Perrin's avatar
      3a9b16d4
    • Jérome Perrin's avatar
  14. 04 Nov, 2024 2 commits