Fix issue with floating point and deferErrorText erasing input value (!1371) · Merge Requests · nexedi / erp5

Fix issue with floating point and deferErrorText erasing input value

Initial information about how to reproduce the error with FloatFied

1. Create a Foo object and access his "View"
2. If you are using a browser in English, type "1-". If you are in French language, please type "1.1".
3. The value will disappear.
4. If you type again the same thing, it does not disappear and you can save

Technical information

When the new gadget state error_text is modified, onChangeState is called as expected. But this function does not check in detail which state parameters were modified, and it rewrite the full DOM element. ea219b74

ea219b74 This also set the value to an empty string, as from the browser point of view, what the user types was not valid.

[Test Results](https://erp5js.nexedi.net/#/test_result_module?extended_search=%20%22ERP5.UnitTest-1371%22&page=form&view=view)

Initial information about how to reproduce the error with FloatFied
```
1. Create a Foo object and access his "View"
2. If you are using a browser in English, type "1-". If you are in French language, please type "1.1".
3. The value will disappear.
4. If you type again the same thing, it does not disappear and you can save
```

Technical information

When the new gadget state `error_text` is modified, `onChangeState` is called as expected.
But this function does not check in detail which state parameters were modified, and it rewrite the full DOM element.
https://lab.nexedi.com/nexedi/erp5/commit/ea219b746f32e972532ce1b3bcb9680dbc9110b6#39e57165e4463915ac8718d0a6b537ed40d49dd3_51_51

https://lab.nexedi.com/nexedi/erp5/commit/ea219b746f32e972532ce1b3bcb9680dbc9110b6#39e57165e4463915ac8718d0a6b537ed40d49dd3_211_243
This also set the value to an empty string, as from the browser point of view, what the user types was not valid.

Edited Mar 02, 2021 by Gabriel Monnerat

Fix issue with floating point and deferErrorText erasing input value

Revert this commit

Cherry-pick this commit