GitLab

Thanks, this looks good !

Because we sometimes miss "real" failures because of flaky tests, I prefer to explicitly say that this is a real one that we will have to take care of:

======================================================================
FAIL: testNamingConvention (testERP5NamingConvention.TestNamingConvention)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/srv/slapgrid/slappart8/srv/testnode/cbq/soft/f1f00584262fd6d4d3dc4b2d69186d63/parts/erp5/Products/ERP5Type/tests/testERP5NamingConvention.py", line 118, in testNamingConvention
    self.assertEqual(0, len(final_result_list), "\n".join(final_result_list))
AssertionError: erp5_ui_test/Foo_viewManuallyUpdatedRequestDialog : Title of the Form itself : 'update' is not titlecased
erp5_ui_test/Foo_viewManuallyUpdatedRequestDialog : Title of the Form itself : 'request' is not titlecased

The one on erp5_core_test:testWorkflowHistoryList is not related, it seems to be sometimes passing sometimes not.

I tried to reproduce @kazuhiko issue, but failed, as using formulator works as expected when using request.form[xxx] =

I'm really curious to know more about what leads to the fixup. My only guess is that you had some TALES expressions doing request.get.

Anyway, using keep_items parameter should work with this way of accessing the request.

Without that fixup testCRMUpdateCreateNewEventDialogFromNotificationMessage was failing.

added 4 commits

e776280d...b1dfe137 - 2 commits from branch master
f379099c - erp5_hal_json_style: set extra_param_json in request when rendering a form
fdf0509a - erp5_*: use Base_renderForm API to change the REQUEST

Compare with previous version

merged

Use api to update request