Item_getTrackingList assorted cleanups
Several changes to Item_getTrackingList
.
My original goal was to fix a problem happening when users sort the listbox by source_title
column. Because catalog understands it, it adds a join condition which would filter movements not "directly" having a source (ie. having a source by acquisition from parent).
Then I realized this script was doing a lots of catalog queries that are done in a most efficient/safe way on the brain, so I switched to this.
Also add a few missing tests.
I did not add test for my original problem, because the real fix is that listbox should not declare source_title
to be a sortable column, because this method does not support it.