repository_spec.rb 101 KB
Newer Older
1 2
# frozen_string_literal: true

3 4
require 'spec_helper'

5
RSpec.describe Repository do
6
  include RepoHelpers
7 8
  include GitHelpers

9
  TestBlob = Struct.new(:path)
10

11
  let(:project) { create(:project, :repository) }
12
  let(:repository) { project.repository }
13
  let(:broken_repository) { create(:project, :broken_storage).repository }
14
  let(:user) { create(:user) }
15
  let(:git_user) { Gitlab::Git::User.from_gitlab(user) }
16

17
  let(:message) { 'Test message' }
18

Rubén Dávila's avatar
Rubén Dávila committed
19
  let(:merge_commit) do
20
    merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project)
21 22 23 24

    merge_commit_id = repository.merge(user,
                                       merge_request.diff_head_sha,
                                       merge_request,
25
                                       message)
26

27
    repository.commit(merge_commit_id)
28
  end
29

30 31
  let(:author_email) { 'user@example.org' }
  let(:author_name) { 'John Doe' }
32

33 34
  def expect_to_raise_storage_error
    expect { yield }.to raise_error do |exception|
35
      storage_exceptions = [Gitlab::Git::CommandError, GRPC::Unavailable]
36 37 38
      known_exception = storage_exceptions.select { |e| exception.is_a?(e) }

      expect(known_exception).not_to be_nil
39 40 41
    end
  end

42
  describe '#branch_names_contains' do
43
    let_it_be(:project) { create(:project, :repository) }
44

45
    let(:repository) { project.repository }
46

47
    subject { repository.branch_names_contains(sample_commit.id) }
48

49 50 51
    it { is_expected.to include('master') }
    it { is_expected.not_to include('feature') }
    it { is_expected.not_to include('fix') }
52

53
    describe 'when storage is broken', :broken_storage do
54
      it 'raises a storage error' do
55 56
        expect_to_raise_storage_error do
          broken_repository.branch_names_contains(sample_commit.id)
57 58 59
        end
      end
    end
60
  end
61

62
  describe '#tag_names_contains' do
63
    subject { repository.tag_names_contains(sample_commit.id) }
64

65 66
    it { is_expected.to include('v1.1.0') }
    it { is_expected.not_to include('v1.0.0') }
67 68
  end

69
  describe '#tags_sorted_by' do
70 71
    let(:tags_to_compare) { %w[v1.0.0 v1.1.0] }

haseeb's avatar
haseeb committed
72
    context 'name_desc' do
73
      subject { repository.tags_sorted_by('name_desc').map(&:name) & tags_to_compare }
74 75 76 77

      it { is_expected.to eq(['v1.1.0', 'v1.0.0']) }
    end

haseeb's avatar
haseeb committed
78
    context 'name_asc' do
79 80 81
      subject { repository.tags_sorted_by('name_asc', pagination_params).map(&:name) & tags_to_compare }

      let(:pagination_params) { nil }
haseeb's avatar
haseeb committed
82 83

      it { is_expected.to eq(['v1.0.0', 'v1.1.0']) }
84

85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121
      context 'with pagination' do
        context 'with limit' do
          let(:pagination_params) { { limit: 1 } }

          it { is_expected.to eq(['v1.0.0']) }
        end

        context 'with page token and limit' do
          let(:pagination_params) { { page_token: 'refs/tags/v1.0.0', limit: 1 } }

          it { is_expected.to eq(['v1.1.0']) }
        end

        context 'with page token only' do
          let(:pagination_params) { { page_token: 'refs/tags/v1.0.0' } }

          it 'raises an ArgumentError' do
            expect { subject }.to raise_error(ArgumentError)
          end
        end

        context 'with negative limit' do
          let(:pagination_params) { { limit: -1 } }

          it 'returns all tags' do
            is_expected.to eq(['v1.0.0', 'v1.1.0'])
          end
        end

        context 'with unknown token' do
          let(:pagination_params) { { page_token: 'unknown' } }

          it 'raises an ArgumentError' do
            expect { subject }.to raise_error(ArgumentError)
          end
        end
      end
haseeb's avatar
haseeb committed
122 123
    end

124
    context 'updated' do
125 126 127 128 129 130 131 132 133
      let(:latest_tag) { 'v0.0.0' }

      before do
        rugged_repo(repository).tags.create(latest_tag, repository.commit.id)
      end

      after do
        rugged_repo(repository).tags.delete(latest_tag)
      end
134 135

      context 'desc' do
136
        subject { repository.tags_sorted_by('updated_desc').map(&:name) & (tags_to_compare + [latest_tag]) }
137

138
        it { is_expected.to eq([latest_tag, 'v1.1.0', 'v1.0.0']) }
139 140 141
      end

      context 'asc' do
142
        subject { repository.tags_sorted_by('updated_asc').map(&:name) & (tags_to_compare + [latest_tag]) }
143

144
        it { is_expected.to eq(['v1.0.0', 'v1.1.0', latest_tag]) }
145
      end
146 147 148 149

      context 'annotated tag pointing to a blob' do
        let(:annotated_tag_name) { 'annotated-tag' }

150
        subject { repository.tags_sorted_by('updated_asc').map(&:name) & (tags_to_compare + [annotated_tag_name]) }
151 152 153 154

        before do
          options = { message: 'test tag message\n',
                      tagger: { name: 'John Smith', email: 'john@gmail.com' } }
155

156
          rugged_repo(repository).tags.create(annotated_tag_name, 'a48e4fc218069f68ef2e769dd8dfea3991362175', **options)
157
        end
158

159
        it { is_expected.to eq(['v1.0.0', 'v1.1.0', annotated_tag_name]) }
160 161

        after do
162
          rugged_repo(repository).tags.delete(annotated_tag_name)
163 164
        end
      end
165
    end
166 167 168 169 170 171

    context 'unknown option' do
      subject { repository.tags_sorted_by('unknown_desc').map(&:name) & tags_to_compare }

      it { is_expected.to eq(['v1.0.0', 'v1.1.0']) }
    end
172 173
  end

174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193
  describe '#ref_exists?' do
    context 'when ref exists' do
      it 'returns true' do
        expect(repository.ref_exists?('refs/heads/master')).to be true
      end
    end

    context 'when ref does not exist' do
      it 'returns false' do
        expect(repository.ref_exists?('refs/heads/non-existent')).to be false
      end
    end

    context 'when ref format is incorrect' do
      it 'returns false' do
        expect(repository.ref_exists?('refs/heads/invalid:master')).to be false
      end
    end
  end

194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209
  describe '#search_branch_names' do
    subject(:search_branch_names) { repository.search_branch_names('conflict-*') }

    it 'returns matching branch names' do
      expect(search_branch_names).to contain_exactly(
        'conflict-binary-file',
        'conflict-resolvable',
        'conflict-contains-conflict-markers',
        'conflict-missing-side',
        'conflict-start',
        'conflict-non-utf8',
        'conflict-too-large'
      )
    end
  end

210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258
  describe '#list_last_commits_for_tree' do
    let(:path_to_commit) do
      {
        "encoding" => "913c66a37b4a45b9769037c55c2d238bd0942d2e",
        "files" => "570e7b2abdd848b95f2f578043fc23bd6f6fd24d",
        ".gitignore" => "c1acaa58bbcbc3eafe538cb8274ba387047b69f8",
        ".gitmodules" => "6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9",
        "CHANGELOG" => "913c66a37b4a45b9769037c55c2d238bd0942d2e",
        "CONTRIBUTING.md" => "6d394385cf567f80a8fd85055db1ab4c5295806f",
        "Gemfile.zip" => "ae73cb07c9eeaf35924a10f713b364d32b2dd34f",
        "LICENSE" => "1a0b36b3cdad1d2ee32457c102a8c0b7056fa863",
        "MAINTENANCE.md" => "913c66a37b4a45b9769037c55c2d238bd0942d2e",
        "PROCESS.md" => "913c66a37b4a45b9769037c55c2d238bd0942d2e",
        "README.md" => "1a0b36b3cdad1d2ee32457c102a8c0b7056fa863",
        "VERSION" => "913c66a37b4a45b9769037c55c2d238bd0942d2e",
        "gitlab-shell" => "6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9",
        "six" => "cfe32cf61b73a0d5e9f13e774abde7ff789b1660"
      }
    end

    subject { repository.list_last_commits_for_tree(sample_commit.id, '.').id }

    it 'returns the last commits for every entry in the current path' do
      result = repository.list_last_commits_for_tree(sample_commit.id, '.')

      result.each do |key, value|
        result[key] = value.id
      end

      expect(result).to include(path_to_commit)
    end

    it 'returns the last commits for every entry in the current path starting from the offset' do
      result = repository.list_last_commits_for_tree(sample_commit.id, '.', offset: path_to_commit.size - 1)

      expect(result.size).to eq(1)
    end

    it 'returns a limited number of last commits for every entry in the current path starting from the offset' do
      result = repository.list_last_commits_for_tree(sample_commit.id, '.', limit: 1)

      expect(result.size).to eq(1)
    end

    it 'returns an empty hash when offset is out of bounds' do
      result = repository.list_last_commits_for_tree(sample_commit.id, '.', offset: path_to_commit.size)

      expect(result.size).to eq(0)
    end
259 260 261 262 263 264 265 266

    context 'with a commit with invalid UTF-8 path' do
      def create_commit_with_invalid_utf8_path
        rugged = rugged_repo(repository)
        blob_id = Rugged::Blob.from_buffer(rugged, "some contents")
        tree_builder = Rugged::Tree::Builder.new(rugged)
        tree_builder.insert({ oid: blob_id, name: "hello\x80world", filemode: 0100644 })
        tree_id = tree_builder.write
267
        user = { email: "jcai@gitlab.com", time: Time.current.to_time, name: "John Cai" }
268 269 270 271 272 273 274 275 276 277

        Rugged::Commit.create(rugged, message: 'some commit message', parents: [rugged.head.target.oid], tree: tree_id, committer: user, author: user)
      end

      it 'does not raise an error' do
        commit = create_commit_with_invalid_utf8_path

        expect { repository.list_last_commits_for_tree(commit, '.', offset: 0) }.not_to raise_error
      end
    end
278 279
  end

280
  describe '#last_commit_for_path' do
281
    subject { repository.last_commit_for_path(sample_commit.id, '.gitignore').id }
282

283
    it { is_expected.to eq('c1acaa58bbcbc3eafe538cb8274ba387047b69f8') }
284

285
    describe 'when storage is broken', :broken_storage do
286
      it 'raises a storage error' do
287 288
        expect_to_raise_storage_error do
          broken_repository.last_commit_id_for_path(sample_commit.id, '.gitignore')
289 290
        end
      end
291
    end
292

293
    context 'with filename with pathspec characters' do
294 295 296 297 298 299 300 301 302 303 304 305 306
      let(:filename) { ':wq' }
      let(:newrev) { project.repository.commit('master').sha }

      before do
        create_file_in_repo(project, 'master', 'master', filename, 'Test file')
      end

      subject { repository.last_commit_for_path('master', filename, literal_pathspec: true).id }

      it 'returns a commit SHA' do
        expect(subject).to eq(newrev)
      end
    end
307
  end
308

Hiroyuki Sato's avatar
Hiroyuki Sato committed
309
  describe '#last_commit_id_for_path' do
310
    subject { repository.last_commit_id_for_path(sample_commit.id, '.gitignore') }
Hiroyuki Sato's avatar
Hiroyuki Sato committed
311

312 313 314
    it "returns last commit id for a given path" do
      is_expected.to eq('c1acaa58bbcbc3eafe538cb8274ba387047b69f8')
    end
315

316 317 318
    it "caches last commit id for a given path" do
      cache = repository.send(:cache)
      key = "last_commit_id_for_path:#{sample_commit.id}:#{Digest::SHA1.hexdigest('.gitignore')}"
319

320 321 322
      expect(cache).to receive(:fetch).with(key).and_return('c1acaa5')
      is_expected.to eq('c1acaa5')
    end
323

324
    describe 'when storage is broken', :broken_storage do
325
      it 'raises a storage error' do
326 327
        expect_to_raise_storage_error do
          broken_repository.last_commit_for_path(sample_commit.id, '.gitignore').id
328 329
        end
      end
Hiroyuki Sato's avatar
Hiroyuki Sato committed
330
    end
331

332
    context 'with filename with pathspec characters' do
333 334 335 336 337 338 339 340 341 342 343 344 345
      let(:filename) { ':wq' }
      let(:newrev) { project.repository.commit('master').sha }

      before do
        create_file_in_repo(project, 'master', 'master', filename, 'Test file')
      end

      subject { repository.last_commit_id_for_path('master', filename, literal_pathspec: true) }

      it 'returns a commit SHA' do
        expect(subject).to eq(newrev)
      end
    end
Hiroyuki Sato's avatar
Hiroyuki Sato committed
346 347
  end

348
  describe '#commits' do
Tiago Botelho's avatar
Tiago Botelho committed
349 350
    context 'when neither the all flag nor a ref are specified' do
      it 'returns every commit from default branch' do
351
        expect(repository.commits(nil, limit: 60).size).to eq(37)
Tiago Botelho's avatar
Tiago Botelho committed
352
      end
353 354
    end

Tiago Botelho's avatar
Tiago Botelho committed
355 356 357 358
    context 'when ref is passed' do
      it 'returns every commit from the specified ref' do
        expect(repository.commits('master', limit: 60).size).to eq(37)
      end
359

Tiago Botelho's avatar
Tiago Botelho committed
360 361 362 363 364 365 366 367 368 369 370 371 372
      context 'when all' do
        it 'returns every commit from the repository' do
          expect(repository.commits('master', limit: 60, all: true).size).to eq(60)
        end
      end

      context 'with path' do
        it 'sets follow when it is a single path' do
          expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(follow: true)).and_call_original.twice

          repository.commits('master', limit: 1, path: 'README.md')
          repository.commits('master', limit: 1, path: ['README.md'])
        end
373

Tiago Botelho's avatar
Tiago Botelho committed
374 375
        it 'does not set follow when it is multiple paths' do
          expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(follow: false)).and_call_original
376

Tiago Botelho's avatar
Tiago Botelho committed
377 378 379 380 381 382 383 384 385 386 387 388 389
          repository.commits('master', limit: 1, path: ['README.md', 'CHANGELOG'])
        end
      end

      context 'without path' do
        it 'does not set follow' do
          expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(follow: false)).and_call_original

          repository.commits('master', limit: 1)
        end
      end
    end

Robert May's avatar
Robert May committed
390 391
    context "when 'author' is set" do
      it "returns commits from that author" do
392 393 394
        commit = repository.commits(nil, limit: 1).first
        known_author = "#{commit.author_name} <#{commit.author_email}>"

Robert May's avatar
Robert May committed
395
        expect(repository.commits(nil, author: known_author, limit: 1)).not_to be_empty
Robert May's avatar
Robert May committed
396 397 398
      end

      it "doesn't returns commits from an unknown author" do
399 400
        unknown_author = "The Man With No Name <zapp@brannigan.com>"

Robert May's avatar
Robert May committed
401
        expect(repository.commits(nil, author: unknown_author, limit: 1)).to be_empty
Robert May's avatar
Robert May committed
402 403 404
      end
    end

Tiago Botelho's avatar
Tiago Botelho committed
405 406
    context "when 'all' flag is set" do
      it 'returns every commit from the repository' do
407
        expect(repository.commits(nil, all: true, limit: 60).size).to eq(60)
Tiago Botelho's avatar
Tiago Botelho committed
408
      end
409
    end
410 411 412 413 414 415 416 417

    context "when 'order' flag is set" do
      it 'passes order option to perform the query' do
        expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(order: 'topo')).and_call_original

        repository.commits('master', limit: 1, order: 'topo')
      end
    end
418 419
  end

420
  describe '#new_commits' do
421 422
    shared_examples '#new_commits' do
      let_it_be(:project) { create(:project, :repository) }
423

424
      let(:repository) { project.repository }
425

426
      subject { repository.new_commits(rev, allow_quarantine: allow_quarantine) }
427

428 429
      context 'when there are no new commits' do
        let(:rev) { repository.commit.id }
430

431 432 433
        it 'returns an empty array' do
          expect(subject).to eq([])
        end
434 435
      end

436 437 438 439
      context 'when new commits are found' do
        let(:branch) { 'orphaned-branch' }
        let!(:rev) { repository.commit(branch).id }
        let(:allow_quarantine) { false }
440

441 442
        it 'returns the commits' do
          repository.delete_branch(branch)
443

444 445 446 447
          expect(subject).not_to be_empty
          expect(subject).to all( be_a(::Commit) )
          expect(subject.size).to eq(1)
        end
448 449
      end
    end
450 451 452 453 454 455 456 457 458 459 460 461

    context 'with quarantine' do
      let(:allow_quarantine) { true }

      it_behaves_like '#new_commits'
    end

    context 'without quarantine' do
      let(:allow_quarantine) { false }

      it_behaves_like '#new_commits'
    end
462 463
  end

464
  describe '#commits_by' do
465
    let_it_be(:project) { create(:project, :repository) }
466

467
    let(:oids) { TestEnv::BRANCH_SHA.values }
468

469
    subject { project.repository.commits_by(oids: oids) }
470

471 472 473 474
    it 'finds each commit' do
      expect(subject).not_to include(nil)
      expect(subject.size).to eq(oids.size)
    end
475

476 477 478
    it 'returns only Commit instances' do
      expect(subject).to all( be_a(Commit) )
    end
479

480 481
    context 'when some commits are not found ' do
      let(:oids) do
482
        ['deadbeef'] + TestEnv::BRANCH_SHA.each_value.first(10)
483 484
      end

485 486 487
      it 'returns only found commits' do
        expect(subject).not_to include(nil)
        expect(subject.size).to eq(10)
488
      end
489
    end
490

491 492
    context 'when no oids are passed' do
      let(:oids) { [] }
493

494 495
      it 'does not call #batch_by_oid' do
        expect(Gitlab::Git::Commit).not_to receive(:batch_by_oid)
496

497
        subject
498 499 500 501
      end
    end
  end

502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524
  describe '#commits_between' do
    let(:commit) { project.commit }

    it 'delegates to Gitlab::Git::Commit#between, returning decorated commits' do
      expect(Gitlab::Git::Commit)
        .to receive(:between)
        .with(repository.raw_repository, commit.parent_id, commit.id, limit: 5)
        .and_call_original

      result = repository.commits_between(commit.parent_id, commit.id, limit: 5)

      expect(result).to contain_exactly(instance_of(Commit), instance_of(Commit))
    end

    it 'defaults to no limit' do
      expect(Gitlab::Git::Commit)
        .to receive(:between)
        .with(repository.raw_repository, commit.parent_id, commit.id, limit: nil)

      repository.commits_between(commit.parent_id, commit.id)
    end
  end

525
  describe '#find_commits_by_message' do
526 527
    it 'returns commits with messages containing a given string' do
      commit_ids = repository.find_commits_by_message('submodule').map(&:id)
528

529 530 531 532 533 534
      expect(commit_ids).to include(
        '5937ac0a7beb003549fc5fd26fc247adbce4a52e',
        '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9',
        'cfe32cf61b73a0d5e9f13e774abde7ff789b1660'
      )
      expect(commit_ids).not_to include('913c66a37b4a45b9769037c55c2d238bd0942d2e')
535 536
    end

537 538
    it 'is case insensitive' do
      commit_ids = repository.find_commits_by_message('SUBMODULE').map(&:id)
539

540
      expect(commit_ids).to include('5937ac0a7beb003549fc5fd26fc247adbce4a52e')
541
    end
542

543
    describe 'when storage is broken', :broken_storage do
544
      it 'raises a storage error' do
545 546 547
        expect_to_raise_storage_error { broken_repository.find_commits_by_message('s') }
      end
    end
548 549
  end

550
  describe '#blob_at' do
551 552 553 554 555
    context 'blank sha' do
      subject { repository.blob_at(Gitlab::Git::BLANK_SHA, '.gitignore') }

      it { is_expected.to be_nil }
    end
556 557 558 559 560 561 562 563 564 565 566 567

    context 'regular blob' do
      subject { repository.blob_at(repository.head_commit.sha, '.gitignore') }

      it { is_expected.to be_an_instance_of(::Blob) }
    end

    context 'readme blob not on HEAD' do
      subject { repository.blob_at(repository.find_branch('feature').target, 'README.md') }

      it { is_expected.to be_an_instance_of(::Blob) }
    end
568
  end
569

570
  describe '#merged_to_root_ref?' do
571
    context 'merged branch without ff' do
572
      subject { repository.merged_to_root_ref?('branch-merged') }
573 574 575

      it { is_expected.to be_truthy }
    end
576

577 578
    # If the HEAD was ff then it will be false
    context 'merged with ff' do
579 580 581 582
      subject { repository.merged_to_root_ref?('improve/awesome') }

      it { is_expected.to be_truthy }
    end
583

584 585 586 587 588
    context 'not merged branch' do
      subject { repository.merged_to_root_ref?('not-merged-branch') }

      it { is_expected.to be_falsey }
    end
589 590 591 592 593 594

    context 'default branch' do
      subject { repository.merged_to_root_ref?('master') }

      it { is_expected.to be_falsey }
    end
595 596 597 598 599 600 601 602 603 604 605 606

    context 'non merged branch' do
      subject { repository.merged_to_root_ref?('fix') }

      it { is_expected.to be_falsey }
    end

    context 'non existent branch' do
      subject { repository.merged_to_root_ref?('non_existent_branch') }

      it { is_expected.to be_nil }
    end
607 608
  end

609 610 611 612 613 614 615 616 617 618 619 620
  describe "#root_ref_sha" do
    let(:commit) { double("commit", sha: "a94a8fe5ccb19ba61c4c0873d391e987982fbbd3") }

    subject { repository.root_ref_sha }

    before do
      allow(repository).to receive(:commit).with(repository.root_ref) { commit }
    end

    it { is_expected.to eq(commit.sha) }
  end

621 622 623 624 625 626
  describe "#merged_branch_names", :clean_gitlab_redis_cache do
    subject { repository.merged_branch_names(branch_names) }

    let(:branch_names) { %w(test beep boop definitely_merged) }
    let(:already_merged) { Set.new(["definitely_merged"]) }

627
    let(:write_hash) do
628
      {
629 630 631 632
        "test" => Gitlab::Redis::Boolean.new(false).to_s,
        "beep" => Gitlab::Redis::Boolean.new(false).to_s,
        "boop" => Gitlab::Redis::Boolean.new(false).to_s,
        "definitely_merged" => Gitlab::Redis::Boolean.new(true).to_s
633 634 635
      }
    end

636 637 638 639 640 641 642
    let(:read_hash) do
      {
        "test" => Gitlab::Redis::Boolean.new(false).to_s,
        "beep" => Gitlab::Redis::Boolean.new(false).to_s,
        "boop" => Gitlab::Redis::Boolean.new(false).to_s,
        "definitely_merged" => Gitlab::Redis::Boolean.new(true).to_s
      }
643 644
    end

645 646
    let(:cache) { repository.send(:redis_hash_cache) }
    let(:cache_key) { cache.cache_key(:merged_branch_names) }
647 648 649 650 651 652 653 654

    before do
      allow(repository.raw_repository).to receive(:merged_branch_names).with(branch_names).and_return(already_merged)
    end

    it { is_expected.to eq(already_merged) }
    it { is_expected.to be_a(Set) }

655 656 657 658 659 660
    describe "cache expiry" do
      before do
        allow(cache).to receive(:delete).with(anything)
      end

      it "is expired when the branches caches are expired" do
661 662 663
        expect(cache).to receive(:delete) do |*args|
          expect(args).to include(:merged_branch_names)
        end
664

665
        repository.expire_branches_cache
666 667 668
      end

      it "is expired when the repository caches are expired" do
669 670 671
        expect(cache).to receive(:delete) do |*args|
          expect(args).to include(:merged_branch_names)
        end
672

673
        repository.expire_all_method_caches
674 675 676
      end
    end

677 678
    context "cache is empty" do
      before do
679
        cache.delete(:merged_branch_names)
680 681 682 683 684
      end

      it { is_expected.to eq(already_merged) }

      describe "cache values" do
685
        it "writes the values to redis" do
686
          expect(cache).to receive(:write).with(:merged_branch_names, write_hash)
687

688 689 690
          subject
        end

691 692 693
        it "matches the supplied hash" do
          subject

694
          expect(cache.read_members(:merged_branch_names, branch_names)).to eq(read_hash)
695 696 697 698 699 700
        end
      end
    end

    context "cache is not empty" do
      before do
701
        cache.write(:merged_branch_names, write_hash)
702 703 704 705 706 707
      end

      it { is_expected.to eq(already_merged) }

      it "doesn't fetch from the disk" do
        expect(repository.raw_repository).not_to receive(:merged_branch_names)
708

709 710 711 712 713 714 715
        subject
      end
    end

    context "cache is partially complete" do
      before do
        allow(repository.raw_repository).to receive(:merged_branch_names).with(["boop"]).and_return([])
716 717
        hash = write_hash.except("boop")
        cache.write(:merged_branch_names, hash)
718 719 720 721 722 723
      end

      it { is_expected.to eq(already_merged) }

      it "does fetch from the disk" do
        expect(repository.raw_repository).to receive(:merged_branch_names).with(["boop"])
724

725 726 727 728 729 730 731 732 733 734 735
        subject
      end
    end

    context "requested branches array is empty" do
      let(:branch_names) { [] }

      it { is_expected.to eq(already_merged) }
    end
  end

736
  describe '#can_be_merged?' do
737 738
    context 'mergeable branches' do
      subject { repository.can_be_merged?('0b4bc9a49b562e85de7cc9e834518ea6828729b9', 'master') }
739

740 741
      it { is_expected.to be_truthy }
    end
742

743 744
    context 'non-mergeable branches without conflict sides missing' do
      subject { repository.can_be_merged?('bb5206fee213d983da88c47f9cf4cc6caf9c66dc', 'feature') }
745

746 747
      it { is_expected.to be_falsey }
    end
748

749 750
    context 'non-mergeable branches with conflict sides missing' do
      subject { repository.can_be_merged?('conflict-missing-side', 'conflict-start') }
751

752 753
      it { is_expected.to be_falsey }
    end
754

755 756
    context 'submodule changes that confuse rugged' do
      subject { repository.can_be_merged?('update-gitlab-shell-v-6-0-1', 'update-gitlab-shell-v-6-0-3') }
757

758
      it { is_expected.to be_falsey }
759
    end
760 761
  end

762 763 764
  describe '#commit' do
    context 'when ref exists' do
      it 'returns commit object' do
765 766
        expect(repository.commit('master'))
          .to be_an_instance_of Commit
767 768 769 770 771 772 773 774 775
      end
    end

    context 'when ref does not exist' do
      it 'returns nil' do
        expect(repository.commit('non-existent-ref')).to be_nil
      end
    end

776 777 778 779 780 781 782 783
    context 'when ref is not specified' do
      it 'is using a root ref' do
        expect(repository).to receive(:find_commit).with('master')

        repository.commit
      end
    end

784 785 786 787 788 789 790 791 792 793 794 795 796 797 798
    context 'when ref is not valid' do
      context 'when preceding tree element exists' do
        it 'returns nil' do
          expect(repository.commit('master:ref')).to be_nil
        end
      end

      context 'when preceding tree element does not exist' do
        it 'returns nil' do
          expect(repository.commit('non-existent:ref')).to be_nil
        end
      end
    end
  end

Douwe Maan's avatar
Douwe Maan committed
799
  describe "#create_dir" do
800 801
    it "commits a change that creates a new directory" do
      expect do
802
        repository.create_dir(user, 'newdir',
803
          message: 'Create newdir', branch_name: 'master')
804
      end.to change { repository.count_commits(ref: 'master') }.by(1)
805 806 807 808 809

      newdir = repository.tree('master', 'newdir')
      expect(newdir.path).to eq('newdir')
    end

810
    context "when committing to another project" do
811
      let(:forked_project) { create(:project, :repository) }
812 813 814

      it "creates a fork and commit to the forked project" do
        expect do
815
          repository.create_dir(user, 'newdir',
816
            message: 'Create newdir', branch_name: 'patch',
Lin Jen-Shin's avatar
Lin Jen-Shin committed
817
            start_branch_name: 'master', start_project: forked_project)
818
        end.to change { repository.count_commits(ref: 'master') }.by(0)
819 820 821 822 823 824 825 826 827

        expect(repository.branch_exists?('patch')).to be_truthy
        expect(forked_project.repository.branch_exists?('patch')).to be_falsy

        newdir = repository.tree('patch', 'newdir')
        expect(newdir.path).to eq('newdir')
      end
    end

828 829 830
    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
831
          repository.create_dir(user, 'newdir',
832 833 834
            message: 'Add newdir',
            branch_name: 'master',
            author_email: author_email, author_name: author_name)
835
        end.to change { repository.count_commits(ref: 'master') }.by(1)
836 837 838 839 840 841 842 843 844

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

845 846
  describe "#create_file" do
    it 'commits new file successfully' do
847
      expect do
848 849 850
        repository.create_file(user, 'NEWCHANGELOG', 'Changelog!',
                               message: 'Create changelog',
                               branch_name: 'master')
851
      end.to change { repository.count_commits(ref: 'master') }.by(1)
852

853
      blob = repository.blob_at('master', 'NEWCHANGELOG')
854

855
      expect(blob.data).to eq('Changelog!')
856
    end
857

858
    it 'creates new file and dir when file_path has a forward slash' do
859
      expect do
860 861
        repository.create_file(user, 'new_dir/new_file.txt', 'File!',
                               message: 'Create new_file with new_dir',
862
                               branch_name: 'master')
863
      end.to change { repository.count_commits(ref: 'master') }.by(1)
864

865 866
      expect(repository.tree('master', 'new_dir').path).to eq('new_dir')
      expect(repository.blob_at('master', 'new_dir/new_file.txt').data).to eq('File!')
867 868
    end

869
    it 'respects the autocrlf setting' do
870
      repository.create_file(user, 'hello.txt', "Hello,\r\nWorld",
871
                             message: 'Add hello world',
872
                             branch_name: 'master')
873 874 875 876 877 878

      blob = repository.blob_at('master', 'hello.txt')

      expect(blob.data).to eq("Hello,\nWorld")
    end

879 880 881
    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
882
          repository.create_file(user, 'NEWREADME', 'README!',
883 884 885 886
                                 message: 'Add README',
                                 branch_name: 'master',
                                 author_email: author_email,
                                 author_name: author_name)
887
        end.to change { repository.count_commits(ref: 'master') }.by(1)
888 889 890 891 892 893 894

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
895 896
  end

897
  describe "#update_file" do
898 899 900 901 902
    it 'updates file successfully' do
      expect do
        repository.update_file(user, 'CHANGELOG', 'Changelog!',
                               message: 'Update changelog',
                               branch_name: 'master')
903
      end.to change { repository.count_commits(ref: 'master') }.by(1)
904 905 906 907 908 909

      blob = repository.blob_at('master', 'CHANGELOG')

      expect(blob.data).to eq('Changelog!')
    end

910
    it 'updates filename successfully' do
911 912
      expect do
        repository.update_file(user, 'NEWLICENSE', 'Copyright!',
913
                                     branch_name: 'master',
914
                                     previous_path: 'LICENSE',
915
                                     message: 'Changes filename')
916
      end.to change { repository.count_commits(ref: 'master') }.by(1)
917 918 919 920 921 922

      files = repository.ls_files('master')

      expect(files).not_to include('LICENSE')
      expect(files).to include('NEWLICENSE')
    end
923 924 925 926

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
927 928 929 930 931 932
          repository.update_file(user, 'README', 'Updated README!',
                                 branch_name: 'master',
                                 previous_path: 'README',
                                 message: 'Update README',
                                 author_email: author_email,
                                 author_name: author_name)
933
        end.to change { repository.count_commits(ref: 'master') }.by(1)
934 935 936 937 938 939 940 941 942

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

Douwe Maan's avatar
Douwe Maan committed
943
  describe "#delete_file" do
944 945
    it 'removes file successfully' do
      expect do
946
        repository.delete_file(user, 'README',
947
          message: 'Remove README', branch_name: 'master')
948
      end.to change { repository.count_commits(ref: 'master') }.by(1)
949 950 951 952 953 954 955

      expect(repository.blob_at('master', 'README')).to be_nil
    end

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
956
          repository.delete_file(user, 'README',
957 958
            message: 'Remove README', branch_name: 'master',
            author_email: author_email, author_name: author_name)
959
        end.to change { repository.count_commits(ref: 'master') }.by(1)
960 961 962 963 964 965 966 967 968

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

969
  describe "search_files_by_content" do
970
    let(:results) { repository.search_files_by_content('feature', 'master') }
971

972 973 974 975
    subject { results }

    it { is_expected.to be_an Array }

976
    it 'regex-escapes the query string' do
977
      results = repository.search_files_by_content("test\\", 'master')
978 979 980 981

      expect(results.first).not_to start_with('fatal:')
    end

982
    it 'properly handles an unmatched parenthesis' do
983
      results = repository.search_files_by_content("test(", 'master')
984 985 986 987

      expect(results.first).not_to start_with('fatal:')
    end

Valery Sizov's avatar
Valery Sizov committed
988
    it 'properly handles when query is not present' do
989
      results = repository.search_files_by_content('', 'master')
Valery Sizov's avatar
Valery Sizov committed
990 991 992 993 994

      expect(results).to match_array([])
    end

    it 'properly handles query when repo is empty' do
995
      repository = create(:project, :empty_repo).repository
996
      results = repository.search_files_by_content('test', 'master')
Valery Sizov's avatar
Valery Sizov committed
997 998 999 1000

      expect(results).to match_array([])
    end

1001
    describe 'when storage is broken', :broken_storage do
1002
      it 'raises a storage error' do
1003 1004 1005 1006 1007 1008
        expect_to_raise_storage_error do
          broken_repository.search_files_by_content('feature', 'master')
        end
      end
    end

1009 1010 1011 1012
    describe 'result' do
      subject { results.first }

      it { is_expected.to be_an String }
1013
      it { expect(subject.lines[2]).to eq("master:CHANGELOG\x00190\x00  - Feature: Replace teams with group membership\n") }
1014 1015
    end
  end
1016

1017
  describe "search_files_by_name" do
1018 1019 1020 1021 1022 1023
    let(:results) { repository.search_files_by_name('files', 'master') }

    it 'returns result' do
      expect(results.first).to eq('files/html/500.html')
    end

Andrew McCallum's avatar
Andrew McCallum committed
1024 1025
    it 'ignores leading slashes' do
      results = repository.search_files_by_name('/files', 'master')
1026

1027 1028 1029
      expect(results.first).to eq('files/html/500.html')
    end

1030
    it 'properly handles when query is only slashes' do
1031
      results = repository.search_files_by_name('//', 'master')
1032

1033
      expect(results).to match_array([])
1034 1035
    end

1036 1037 1038 1039 1040 1041 1042
    it 'properly handles when query is not present' do
      results = repository.search_files_by_name('', 'master')

      expect(results).to match_array([])
    end

    it 'properly handles query when repo is empty' do
1043
      repository = create(:project, :empty_repo).repository
1044 1045 1046 1047 1048

      results = repository.search_files_by_name('test', 'master')

      expect(results).to match_array([])
    end
1049

1050
    describe 'when storage is broken', :broken_storage do
1051
      it 'raises a storage error' do
1052 1053 1054 1055 1056
        expect_to_raise_storage_error { broken_repository.search_files_by_name('files', 'master') }
      end
    end
  end

1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069
  describe '#search_files_by_wildcard_path' do
    let(:ref) { 'master' }

    subject(:result) { repository.search_files_by_wildcard_path(path, ref) }

    context 'when specifying a normal path' do
      let(:path) { 'files/images/logo-black.png' }

      it 'returns the path' do
        expect(result).to eq(['files/images/logo-black.png'])
      end
    end

1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095
    context 'when specifying a wildcard path' do
      let(:path) { '*.md' }

      it 'returns files matching the path in the root folder' do
        expect(result).to contain_exactly('CONTRIBUTING.md',
                                          'MAINTENANCE.md',
                                          'PROCESS.md',
                                          'README.md')
      end
    end

    context 'when specifying a wildcard path for all' do
      let(:path) { '**.md' }

      it 'returns all matching files in all folders' do
        expect(result).to contain_exactly('CONTRIBUTING.md',
                                          'MAINTENANCE.md',
                                          'PROCESS.md',
                                          'README.md',
                                          'files/markdown/ruby-style-guide.md',
                                          'with space/README.md')
      end
    end

    context 'when specifying a path to subfolders using two asterisks and a slash' do
      let(:path) { 'files/**/*.md' }
1096 1097

      it 'returns all files matching the path' do
1098
        expect(result).to contain_exactly('files/markdown/ruby-style-guide.md')
1099 1100 1101
      end
    end

1102 1103 1104 1105 1106 1107 1108
    context 'when specifying a wildcard path to subfolder with just two asterisks' do
      let(:path) { 'files/**.md' }

      it 'returns all files in the matching path' do
        expect(result).to contain_exactly('files/markdown/ruby-style-guide.md')
      end
    end
1109

1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121
    context 'when specifying a wildcard path to subfolder with one asterisk' do
      let(:path) { 'files/*/*.md' }

      it 'returns all files in the matching path' do
        expect(result).to contain_exactly('files/markdown/ruby-style-guide.md')
      end
    end

    context 'when specifying a wildcard path for an unknown number of subfolder levels' do
      let(:path) { '**/*.rb' }

      it 'returns all matched files in all subfolders' do
1122 1123 1124 1125 1126 1127 1128
        expect(result).to contain_exactly('encoding/russian.rb',
                                          'files/ruby/popen.rb',
                                          'files/ruby/regex.rb',
                                          'files/ruby/version_info.rb')
      end
    end

1129 1130 1131 1132 1133 1134 1135 1136
    context 'when specifying a wildcard path to one level of subfolders' do
      let(:path) { '*/*.rb' }

      it 'returns all matched files in one subfolder' do
        expect(result).to contain_exactly('encoding/russian.rb')
      end
    end

1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154
    context 'when sending regexp' do
      let(:path) { '.*\.rb' }

      it 'ignores the regexp and returns an empty array' do
        expect(result).to eq([])
      end
    end

    context 'when sending another ref' do
      let(:path) { 'files' }
      let(:ref) { 'other-branch' }

      it 'returns an empty array' do
        expect(result).to eq([])
      end
    end
  end

1155 1156 1157
  describe '#fetch_as_mirror' do
    let(:url) { "http://example.com" }

1158 1159 1160
    it 'fetches the URL without creating a remote' do
      expect(repository)
        .to receive(:fetch_remote)
1161
        .with(url, forced: false, prune: true, refmap: :all_refs, http_authorization_header: "")
1162
        .and_return(nil)
1163

1164
      repository.fetch_as_mirror(url)
1165 1166 1167
    end
  end

1168
  describe '#fetch_ref' do
1169
    let(:broken_repository) { create(:project, :broken_storage).repository }
1170

1171
    describe 'when storage is broken', :broken_storage do
1172
      it 'raises a storage error' do
1173 1174 1175
        expect_to_raise_storage_error do
          broken_repository.fetch_ref(broken_repository, source_ref: '1', target_ref: '2')
        end
1176 1177
      end
    end
1178 1179
  end

1180
  describe '#get_raw_changes' do
1181
    context 'with non-UTF8 bytes in paths' do
1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192
      let(:old_rev) { 'd0888d297eadcd7a345427915c309413b1231e65' }
      let(:new_rev) { '19950f03c765f7ac8723a73a0599764095f52fc0' }
      let(:changes) { repository.raw_changes_between(old_rev, new_rev) }

      it 'returns the changes' do
        expect { changes }.not_to raise_error
        expect(changes.first.new_path.bytes).to eq("hello\x80world".bytes)
      end
    end
  end

1193
  describe '#create_ref' do
1194
    it 'redirects the call to write_ref' do
1195 1196
      ref = '1'
      ref_path = '2'
1197

1198
      expect(repository.raw_repository).to receive(:write_ref).with(ref_path, ref)
1199 1200 1201 1202 1203

      repository.create_ref(ref, ref_path)
    end
  end

1204
  describe "#changelog", :use_clean_rails_memory_store_caching do
1205 1206 1207
    it 'accepts changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('changelog')])

1208
      expect(repository.changelog.path).to eq('changelog')
1209 1210 1211 1212 1213
    end

    it 'accepts news instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('news')])

1214
      expect(repository.changelog.path).to eq('news')
1215 1216 1217 1218 1219
    end

    it 'accepts history instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('history')])

1220
      expect(repository.changelog.path).to eq('history')
1221 1222 1223 1224 1225
    end

    it 'accepts changes instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('changes')])

1226
      expect(repository.changelog.path).to eq('changes')
1227 1228 1229 1230 1231
    end

    it 'is case-insensitive' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('CHANGELOG')])

1232
      expect(repository.changelog.path).to eq('CHANGELOG')
1233 1234 1235
    end
  end

1236
  describe "#license_blob", :use_clean_rails_memory_store_caching do
1237
    before do
1238
      repository.delete_file(
1239
        user, 'LICENSE', message: 'Remove LICENSE', branch_name: 'master')
1240 1241
    end

1242
    it 'handles when HEAD points to non-existent ref' do
1243
      repository.create_file(
1244
        user, 'LICENSE', 'Copyright!',
1245
        message: 'Add LICENSE', branch_name: 'master')
1246

1247
      allow(repository).to receive(:root_ref).and_raise(Gitlab::Git::Repository::NoRepository)
1248 1249 1250 1251

      expect(repository.license_blob).to be_nil
    end

1252
    it 'looks in the root_ref only' do
1253
      repository.delete_file(user, 'LICENSE',
1254
        message: 'Remove LICENSE', branch_name: 'markdown')
1255
      repository.create_file(user, 'LICENSE',
1256
        Licensee::License.new('mit').content,
1257
        message: 'Add LICENSE', branch_name: 'markdown')
1258 1259 1260 1261

      expect(repository.license_blob).to be_nil
    end

1262
    it 'detects license file with no recognizable open-source license content' do
1263 1264
      repository.create_file(user, 'LICENSE', 'Copyright!',
        message: 'Add LICENSE', branch_name: 'master')
1265

1266
      expect(repository.license_blob.path).to eq('LICENSE')
1267 1268
    end

1269 1270
    %w[LICENSE LICENCE LiCensE LICENSE.md LICENSE.foo COPYING COPYING.md].each do |filename|
      it "detects '#{filename}'" do
1271
        repository.create_file(user, filename,
1272
          Licensee::License.new('mit').content,
1273
          message: "Add #{filename}", branch_name: 'master')
1274

1275 1276
        expect(repository.license_blob.name).to eq(filename)
      end
1277 1278 1279
    end
  end

1280
  describe '#license_key', :use_clean_rails_memory_store_caching do
1281
    before do
1282
      repository.delete_file(user, 'LICENSE',
1283
        message: 'Remove LICENSE', branch_name: 'master')
1284
    end
1285

1286
    it 'returns nil when no license is detected' do
1287 1288 1289
      expect(repository.license_key).to be_nil
    end

1290 1291 1292
    it 'returns nil when the repository does not exist' do
      expect(repository).to receive(:exists?).and_return(false)

1293 1294 1295
      expect(repository.license_key).to be_nil
    end

1296
    it 'returns other when the content is not recognizable' do
1297
      repository.create_file(user, 'LICENSE', 'Gitlab B.V.',
1298
        message: 'Add LICENSE', branch_name: 'master')
1299

1300
      expect(repository.license_key).to eq('other')
1301
    end
1302

1303 1304 1305 1306 1307 1308
    it 'returns nil when the commit SHA does not exist' do
      allow(repository.head_commit).to receive(:sha).and_return('1' * 40)

      expect(repository.license_key).to be_nil
    end

1309
    it 'returns nil when master does not exist' do
1310 1311
      repository.rm_branch(user, 'master')

1312
      expect(repository.license_key).to be_nil
1313 1314
    end

1315
    it 'returns the license key' do
1316
      repository.create_file(user, 'LICENSE',
1317
        Licensee::License.new('mit').content,
1318
        message: 'Add LICENSE', branch_name: 'master')
1319

1320
      expect(repository.license_key).to eq('mit')
1321
    end
1322
  end
1323

1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339
  describe '#license' do
    before do
      repository.delete_file(user, 'LICENSE',
        message: 'Remove LICENSE', branch_name: 'master')
    end

    it 'returns nil when no license is detected' do
      expect(repository.license).to be_nil
    end

    it 'returns nil when the repository does not exist' do
      expect(repository).to receive(:exists?).and_return(false)

      expect(repository.license).to be_nil
    end

1340 1341
    it 'returns nil when license_key is not recognized' do
      expect(repository).to receive(:license_key).twice.and_return('not-recognized')
1342 1343 1344
      expect(Gitlab::ErrorTracking).to receive(:track_exception) do |ex|
        expect(ex).to be_a(Licensee::InvalidLicense)
      end
1345 1346 1347 1348

      expect(repository.license).to be_nil
    end

1349 1350
    it 'returns other when the content is not recognizable' do
      license = Licensee::License.new('other')
1351
      repository.create_file(user, 'LICENSE', 'Gitlab B.V.',
1352 1353
        message: 'Add LICENSE', branch_name: 'master')

1354
      expect(repository.license).to eq(license)
1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366
    end

    it 'returns the license' do
      license = Licensee::License.new('mit')
      repository.create_file(user, 'LICENSE',
        license.content,
        message: 'Add LICENSE', branch_name: 'master')

      expect(repository.license).to eq(license)
    end
  end

1367
  describe "#gitlab_ci_yml", :use_clean_rails_memory_store_caching do
1368 1369 1370 1371
    it 'returns valid file' do
      files = [TestBlob.new('file'), TestBlob.new('.gitlab-ci.yml'), TestBlob.new('copying')]
      expect(repository.tree).to receive(:blobs).and_return(files)

1372
      expect(repository.gitlab_ci_yml.path).to eq('.gitlab-ci.yml')
1373 1374 1375 1376 1377 1378 1379 1380
    end

    it 'returns nil if not exists' do
      expect(repository.tree).to receive(:blobs).and_return([])
      expect(repository.gitlab_ci_yml).to be_nil
    end

    it 'returns nil for empty repository' do
1381
      allow(repository).to receive(:root_ref).and_raise(Gitlab::Git::Repository::NoRepository)
1382 1383 1384 1385
      expect(repository.gitlab_ci_yml).to be_nil
    end
  end

1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396
  describe '#ambiguous_ref?' do
    let(:ref) { 'ref' }

    subject { repository.ambiguous_ref?(ref) }

    context 'when ref is ambiguous' do
      before do
        repository.add_tag(project.creator, ref, 'master')
        repository.add_branch(project.creator, ref, 'master')
      end

1397
      it 'is true' do
1398 1399 1400 1401 1402 1403 1404 1405 1406
        is_expected.to eq(true)
      end
    end

    context 'when ref is not ambiguous' do
      before do
        repository.add_tag(project.creator, ref, 'master')
      end

1407
      it 'is false' do
1408 1409 1410 1411 1412
        is_expected.to eq(false)
      end
    end
  end

1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426
  describe '#has_ambiguous_refs?' do
    using RSpec::Parameterized::TableSyntax

    where(:branch_names, :tag_names, :result) do
      nil | nil | false
      %w() | %w() | false
      %w(a b) | %w() | false
      %w() | %w(c d) | false
      %w(a b) | %w(c d) | false
      %w(a/b) | %w(c/d) | false
      %w(a b) | %w(c d a/z) | true
      %w(a b c/z) | %w(c d) | true
      %w(a/b/z) | %w(a/b) | false # we only consider refs ambiguous before the first slash
      %w(a/b/z) | %w(a/b a) | true
1427
      %w(ab) | %w(abc/d a b) | false
1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439
    end

    with_them do
      it do
        allow(repository).to receive(:branch_names).and_return(branch_names)
        allow(repository).to receive(:tag_names).and_return(tag_names)

        expect(repository.has_ambiguous_refs?).to eq(result)
      end
    end
  end

1440
  describe '#expand_ref' do
1441 1442
    let(:ref) { 'ref' }

1443
    subject { repository.expand_ref(ref) }
1444

1445
    context 'when ref is not tag or branch name' do
1446 1447
      let(:ref) { 'refs/heads/master' }

1448
      it 'returns nil' do
1449
        is_expected.to be_nil
1450 1451 1452
      end
    end

1453 1454 1455
    context 'when ref is tag name' do
      before do
        repository.add_tag(project.creator, ref, 'master')
1456 1457
      end

1458 1459
      it 'returns the tag ref' do
        is_expected.to eq("refs/tags/#{ref}")
1460
      end
1461
    end
1462

1463 1464 1465 1466
    context 'when ref is branch name' do
      before do
        repository.add_branch(project.creator, ref, 'master')
      end
1467

1468 1469
      it 'returns the branch ref' do
        is_expected.to eq("refs/heads/#{ref}")
1470 1471 1472 1473
      end
    end
  end

1474
  describe '#add_branch' do
1475 1476
    let(:branch_name) { 'new_feature' }
    let(:target) { 'master' }
1477

1478
    subject { repository.add_branch(user, branch_name, target) }
1479

1480 1481 1482 1483
    it "calls Gitaly's OperationService" do
      expect_any_instance_of(Gitlab::GitalyClient::OperationService)
        .to receive(:user_create_branch).with(branch_name, user, target)
        .and_return(nil)
1484

1485
      subject
1486 1487
    end

1488 1489 1490 1491
    it 'creates_the_branch' do
      expect(subject.name).to eq(branch_name)
      expect(repository.find_branch(branch_name)).not_to be_nil
    end
1492

1493 1494
    context 'with a non-existing target' do
      let(:target) { 'fake-target' }
1495

1496 1497 1498
      it "returns false and doesn't create the branch" do
        expect(subject).to be(false)
        expect(repository.find_branch(branch_name)).to be_nil
1499 1500 1501 1502
      end
    end
  end

1503
  shared_examples 'asymmetric cached method' do |method|
1504 1505 1506 1507 1508 1509
    context 'asymmetric caching', :use_clean_rails_memory_store_caching, :request_store do
      let(:cache) { repository.send(:cache) }
      let(:request_store_cache) { repository.send(:request_store_cache) }

      context 'when it returns true' do
        before do
1510
          expect(repository.raw_repository).to receive(method).once.and_return(true)
1511 1512 1513 1514
        end

        it 'caches the output in RequestStore' do
          expect do
1515 1516
            repository.send(method)
          end.to change { request_store_cache.read(method) }.from(nil).to(true)
1517 1518 1519 1520
        end

        it 'caches the output in RepositoryCache' do
          expect do
1521 1522
            repository.send(method)
          end.to change { cache.read(method) }.from(nil).to(true)
1523 1524 1525 1526 1527
        end
      end

      context 'when it returns false' do
        before do
1528
          expect(repository.raw_repository).to receive(method).once.and_return(false)
1529 1530 1531 1532
        end

        it 'caches the output in RequestStore' do
          expect do
1533 1534
            repository.send(method)
          end.to change { request_store_cache.read(method) }.from(nil).to(false)
1535 1536 1537 1538
        end

        it 'does NOT cache the output in RepositoryCache' do
          expect do
1539 1540
            repository.send(method)
          end.not_to change { cache.read(method) }.from(nil)
1541 1542 1543
        end
      end
    end
1544
  end
1545

1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557
  describe '#exists?' do
    it 'returns true when a repository exists' do
      expect(repository.exists?).to be(true)
    end

    it 'returns false if no full path can be constructed' do
      allow(repository).to receive(:full_path).and_return(nil)

      expect(repository.exists?).to be(false)
    end

    context 'with broken storage', :broken_storage do
1558
      it 'raises a storage error' do
1559 1560 1561 1562 1563 1564 1565
        expect_to_raise_storage_error { broken_repository.exists? }
      end
    end

    it_behaves_like 'asymmetric cached method', :exists?
  end

1566
  describe '#has_visible_content?' do
1567
    it 'delegates to raw_repository when true' do
1568
      expect(repository.raw_repository).to receive(:has_visible_content?)
1569
        .and_return(true)
1570

1571
      expect(repository.has_visible_content?).to eq(true)
1572 1573
    end

1574 1575 1576
    it 'delegates to raw_repository when false' do
      expect(repository.raw_repository).to receive(:has_visible_content?)
        .and_return(false)
1577

1578
      expect(repository.has_visible_content?).to eq(false)
1579
    end
1580 1581

    it_behaves_like 'asymmetric cached method', :has_visible_content?
1582 1583
  end

1584
  describe '#branch_exists?' do
1585
    let(:branch) { repository.root_ref }
1586

1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604
    subject { repository.branch_exists?(branch) }

    it 'delegates to branch_names when the cache is empty' do
      repository.expire_branches_cache

      expect(repository).to receive(:branch_names).and_call_original
      is_expected.to eq(true)
    end

    it 'uses redis set caching when the cache is filled' do
      repository.branch_names # ensure the branch name cache is filled

      expect(repository)
        .to receive(:branch_names_include?)
        .with(branch)
        .and_call_original

      is_expected.to eq(true)
1605 1606 1607
    end
  end

1608
  describe '#tag_exists?' do
1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626
    let(:tag) { repository.tags.first.name }

    subject { repository.tag_exists?(tag) }

    it 'delegates to tag_names when the cache is empty' do
      repository.expire_tags_cache

      expect(repository).to receive(:tag_names).and_call_original
      is_expected.to eq(true)
    end

    it 'uses redis set caching when the cache is filled' do
      repository.tag_names # ensure the tag name cache is filled

      expect(repository)
        .to receive(:tag_names_include?)
        .with(tag)
        .and_call_original
1627

1628
      is_expected.to eq(true)
1629 1630 1631
    end
  end

1632
  describe '#branch_names', :clean_gitlab_redis_cache do
1633 1634 1635 1636 1637
    let(:fake_branch_names) { ['foobar'] }

    it 'gets cached across Repository instances' do
      allow(repository.raw_repository).to receive(:branch_names).once.and_return(fake_branch_names)

1638
      expect(repository.branch_names).to match_array(fake_branch_names)
1639 1640 1641 1642 1643

      fresh_repository = Project.find(project.id).repository
      expect(fresh_repository.object_id).not_to eq(repository.object_id)

      expect(fresh_repository.raw_repository).not_to receive(:branch_names)
1644
      expect(fresh_repository.branch_names).to match_array(fake_branch_names)
1645 1646 1647
    end
  end

1648 1649 1650 1651
  describe '#empty?' do
    let(:empty_repository) { create(:project_empty_repo).repository }

    it 'returns true for an empty repository' do
1652
      expect(empty_repository).to be_empty
1653 1654 1655
    end

    it 'returns false for a non-empty repository' do
1656
      expect(repository).not_to be_empty
1657 1658 1659
    end

    it 'caches the output' do
1660
      expect(repository.raw_repository).to receive(:has_visible_content?).once
1661 1662 1663 1664 1665 1666

      repository.empty?
      repository.empty?
    end
  end

1667 1668 1669 1670
  describe '#blobs_at' do
    let(:empty_repository) { create(:project_empty_repo).repository }

    it 'returns empty array for an empty repository' do
1671
      expect(empty_repository.blobs_at(%w[master foobar])).to eq([])
1672 1673 1674 1675 1676
    end

    it 'returns blob array for a non-empty repository' do
      repository.create_file(User.last, 'foobar', 'CONTENT', message: 'message', branch_name: 'master')

1677
      blobs = repository.blobs_at([%w[master foobar]])
1678 1679 1680 1681

      expect(blobs.first.name).to eq('foobar')
      expect(blobs.size).to eq(1)
    end
1682 1683 1684 1685 1686 1687 1688 1689 1690 1691

    context 'when Gitaly returns NoRepository' do
      before do
        allow(repository.raw_repository).to receive(:batch_blobs).and_raise(Gitlab::Git::Repository::NoRepository)
      end

      it 'returns empty array' do
        expect(repository.blobs_at([%w[master foobar]])).to match_array([])
      end
    end
1692 1693
  end

1694 1695 1696 1697 1698 1699
  describe '#root_ref' do
    it 'returns a branch name' do
      expect(repository.root_ref).to be_an_instance_of(String)
    end

    it 'caches the output' do
1700 1701 1702
      expect(repository.raw_repository).to receive(:root_ref)
        .once
        .and_return('master')
1703 1704 1705 1706

      repository.root_ref
      repository.root_ref
    end
1707

1708 1709 1710 1711 1712 1713 1714
    it 'returns nil if the repository does not exist' do
      repository = create(:project).repository

      expect(repository).not_to be_exists
      expect(repository.root_ref).to be_nil
    end

1715
    it_behaves_like 'asymmetric cached method', :root_ref
1716 1717 1718 1719 1720 1721
  end

  describe '#expire_root_ref_cache' do
    it 'expires the root reference cache' do
      repository.root_ref

1722 1723 1724
      expect(repository.raw_repository).to receive(:root_ref)
        .once
        .and_return('foo')
1725 1726 1727 1728 1729 1730 1731

      repository.expire_root_ref_cache

      expect(repository.root_ref).to eq('foo')
    end
  end

1732
  describe '#expire_branch_cache' do
1733 1734 1735 1736 1737
    # This method is private but we need it for testing purposes. Sadly there's
    # no other proper way of testing caching operations.
    let(:cache) { repository.send(:cache) }

    it 'expires the cache for all branches' do
1738 1739 1740
      expect(cache).to receive(:expire)
        .at_least(repository.branches.length * 2)
        .times
1741 1742 1743 1744 1745

      repository.expire_branch_cache
    end

    it 'expires the cache for all branches when the root branch is given' do
1746 1747 1748
      expect(cache).to receive(:expire)
        .at_least(repository.branches.length * 2)
        .times
1749 1750 1751 1752 1753

      repository.expire_branch_cache(repository.root_ref)
    end

    it 'expires the cache for a specific branch' do
1754
      expect(cache).to receive(:expire).twice
1755 1756 1757 1758

      repository.expire_branch_cache('foo')
    end
  end
1759

1760 1761 1762
  describe '#expire_emptiness_caches' do
    let(:cache) { repository.send(:cache) }

1763 1764 1765
    it 'expires the caches for an empty repository' do
      allow(repository).to receive(:empty?).and_return(true)

1766
      expect(cache).to receive(:expire).with(:has_visible_content?)
1767 1768 1769

      repository.expire_emptiness_caches
    end
1770 1771 1772 1773

    it 'does not expire the cache for a non-empty repository' do
      allow(repository).to receive(:empty?).and_return(false)

1774
      expect(cache).not_to receive(:expire).with(:has_visible_content?)
1775 1776 1777

      repository.expire_emptiness_caches
    end
1778 1779 1780 1781 1782 1783

    it 'expires the memoized repository cache' do
      allow(repository.raw_repository).to receive(:expire_has_local_branches_cache).and_call_original

      repository.expire_emptiness_caches
    end
1784 1785
  end

1786
  describe 'skip_merges option' do
1787
    subject { repository.commits(Gitlab::Git::BRANCH_REF_PREFIX + "'test'", limit: 100, skip_merges: true).map { |k| k.id } }
1788 1789 1790

    it { is_expected.not_to include('e56497bb5f03a90a51293fc6d516788730953899') }
  end
1791 1792

  describe '#merge' do
1793
    let(:merge_request) { create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project) }
1794
    let(:message) { 'Test \r\n\r\n message' }
1795

1796 1797 1798 1799
    it 'merges the code and returns the commit id' do
      expect(merge_commit).to be_present
      expect(repository.blob_at(merge_commit.id, 'files/ruby/feature.rb')).to be_present
    end
1800

1801 1802
    it 'sets the `in_progress_merge_commit_sha` flag for the given merge request' do
      merge_commit_id = merge(repository, user, merge_request, message)
1803

1804
      expect(merge_request.in_progress_merge_commit_sha).to eq(merge_commit_id)
1805
    end
1806

1807 1808
    it 'removes carriage returns from commit message' do
      merge_commit_id = merge(repository, user, merge_request, message)
1809

1810
      expect(repository.commit(merge_commit_id).message).to eq(message.delete("\r"))
1811 1812
    end

1813 1814
    def merge(repository, user, merge_request, message)
      repository.merge(user, merge_request.diff_head_sha, merge_request, message)
1815
    end
1816 1817
  end

1818 1819 1820 1821 1822 1823 1824
  describe '#merge_to_ref' do
    let(:merge_request) do
      create(:merge_request, source_branch: 'feature',
                             target_branch: 'master',
                             source_project: project)
    end

1825
    it 'writes merge of source SHA and first parent ref to MR merge_ref_path' do
1826 1827 1828 1829 1830 1831 1832
      merge_commit_id =
        repository.merge_to_ref(user,
          source_sha: merge_request.diff_head_sha,
          branch: merge_request.target_branch,
          target_ref: merge_request.merge_ref_path,
          message: 'Custom message',
          first_parent_ref: merge_request.target_branch_ref)
1833 1834 1835 1836 1837

      merge_commit = repository.commit(merge_commit_id)

      expect(merge_commit.message).to eq('Custom message')
      expect(merge_commit.author_name).to eq(user.name)
1838
      expect(merge_commit.author_email).to eq(user.commit_email_or_default)
1839 1840 1841 1842
      expect(repository.blob_at(merge_commit.id, 'files/ruby/feature.rb')).to be_present
    end
  end

1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870
  describe '#ff_merge' do
    before do
      repository.add_branch(user, 'ff-target', 'feature~5')
    end

    it 'merges the code and return the commit id' do
      merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'ff-target', source_project: project)
      merge_commit_id = repository.ff_merge(user,
                                            merge_request.diff_head_sha,
                                            merge_request.target_branch,
                                            merge_request: merge_request)
      merge_commit = repository.commit(merge_commit_id)

      expect(merge_commit).to be_present
      expect(repository.blob_at(merge_commit.id, 'files/ruby/feature.rb')).to be_present
    end

    it 'sets the `in_progress_merge_commit_sha` flag for the given merge request' do
      merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'ff-target', source_project: project)
      merge_commit_id = repository.ff_merge(user,
                                            merge_request.diff_head_sha,
                                            merge_request.target_branch,
                                            merge_request: merge_request)

      expect(merge_request.in_progress_merge_commit_sha).to eq(merge_commit_id)
    end
  end

1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889
  describe '#rebase' do
    let(:merge_request) { create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project) }

    shared_examples_for 'a method that can rebase successfully' do
      it 'returns the rebase commit sha' do
        rebase_commit_sha = repository.rebase(user, merge_request)
        head_sha = merge_request.source_project.repository.commit(merge_request.source_branch).sha

        expect(rebase_commit_sha).to eq(head_sha)
      end

      it 'sets the `rebase_commit_sha` for the given merge request' do
        rebase_commit_sha = repository.rebase(user, merge_request)

        expect(rebase_commit_sha).not_to be_nil
        expect(merge_request.rebase_commit_sha).to eq(rebase_commit_sha)
      end
    end

1890
    it_behaves_like 'a method that can rebase successfully'
1891

1892 1893
    it 'executes the new Gitaly RPC' do
      expect_any_instance_of(Gitlab::GitalyClient::OperationService).to receive(:rebase)
1894

1895 1896
      repository.rebase(user, merge_request)
    end
1897

1898 1899
    describe 'rolling back the `rebase_commit_sha`' do
      let(:new_sha) { Digest::SHA1.hexdigest('foo') }
1900

1901 1902 1903
      it 'does not rollback when there are no errors' do
        second_response = double(pre_receive_error: nil, git_error: nil)
        mock_gitaly(second_response)
1904

1905
        repository.rebase(user, merge_request)
1906

1907 1908
        expect(merge_request.reload.rebase_commit_sha).to eq(new_sha)
      end
1909

1910 1911 1912
      it 'does rollback when a PreReceiveError is encountered in the second step' do
        second_response = double(pre_receive_error: 'my_error', git_error: nil)
        mock_gitaly(second_response)
1913

1914 1915 1916
        expect do
          repository.rebase(user, merge_request)
        end.to raise_error(Gitlab::Git::PreReceiveError)
1917

1918 1919
        expect(merge_request.reload.rebase_commit_sha).to be_nil
      end
1920

1921 1922 1923
      it 'does rollback when a GitError is encountered in the second step' do
        second_response = double(pre_receive_error: nil, git_error: 'git error')
        mock_gitaly(second_response)
1924

1925 1926 1927
        expect do
          repository.rebase(user, merge_request)
        end.to raise_error(Gitlab::Git::Repository::GitError)
1928

1929
        expect(merge_request.reload.rebase_commit_sha).to be_nil
1930 1931
      end

1932 1933 1934 1935 1936
      def mock_gitaly(second_response)
        responses = [
          double(rebase_sha: new_sha).as_null_object,
          second_response
        ]
1937

1938 1939 1940
        expect_any_instance_of(
          Gitaly::OperationService::Stub
        ).to receive(:user_rebase_confirmable).and_return(responses.each)
1941 1942 1943 1944
      end
    end
  end

1945
  describe '#revert' do
1946 1947 1948
    let(:new_image_commit) { repository.commit('33f3729a45c02fc67d00adb1b8bca394b0e761d9') }
    let(:update_image_commit) { repository.commit('2f63565e7aac07bcdadb654e253078b727143ec4') }
    let(:message) { 'revert message' }
1949

1950 1951 1952
    context 'when there is a conflict' do
      it 'raises an error' do
        expect { repository.revert(user, new_image_commit, 'master', message) }.to raise_error(Gitlab::Git::Repository::CreateTreeError)
1953
      end
1954
    end
1955

1956 1957 1958
    context 'when commit was already reverted' do
      it 'raises an error' do
        repository.revert(user, update_image_commit, 'master', message)
1959

1960
        expect { repository.revert(user, update_image_commit, 'master', message) }.to raise_error(Gitlab::Git::Repository::CreateTreeError)
1961
      end
1962
    end
1963

1964 1965 1966 1967
    context 'when commit can be reverted' do
      it 'reverts the changes' do
        expect(repository.revert(user, update_image_commit, 'master', message)).to be_truthy
      end
1968 1969
    end

1970 1971 1972 1973 1974 1975 1976 1977
    context 'reverting a merge commit' do
      it 'reverts the changes' do
        merge_commit
        expect(repository.blob_at_branch('master', 'files/ruby/feature.rb')).to be_present

        repository.revert(user, merge_commit, 'master', message)
        expect(repository.blob_at_branch('master', 'files/ruby/feature.rb')).not_to be_present
      end
1978
    end
1979
  end
1980

1981
  describe '#cherry_pick' do
1982 1983 1984 1985 1986 1987 1988 1989
    let(:conflict_commit) { repository.commit('c642fe9b8b9f28f9225d7ea953fe14e74748d53b') }
    let(:pickable_commit) { repository.commit('7d3b0f7cff5f37573aea97cebfd5692ea1689924') }
    let(:pickable_merge) { repository.commit('e56497bb5f03a90a51293fc6d516788730953899') }
    let(:message) { 'cherry-pick message' }

    context 'when there is a conflict' do
      it 'raises an error' do
        expect { repository.cherry_pick(user, conflict_commit, 'master', message) }.to raise_error(Gitlab::Git::Repository::CreateTreeError)
1990
      end
1991
    end
1992

1993 1994 1995
    context 'when commit was already cherry-picked' do
      it 'raises an error' do
        repository.cherry_pick(user, pickable_commit, 'master', message)
1996

1997
        expect { repository.cherry_pick(user, pickable_commit, 'master', message) }.to raise_error(Gitlab::Git::Repository::CreateTreeError)
1998
      end
1999
    end
2000

2001 2002 2003
    context 'when commit can be cherry-picked' do
      it 'cherry-picks the changes' do
        expect(repository.cherry_pick(user, pickable_commit, 'master', message)).to be_truthy
2004
      end
2005
    end
2006

2007 2008 2009
    context 'cherry-picking a merge commit' do
      it 'cherry-picks the changes' do
        expect(repository.blob_at_branch('improve/awesome', 'foo/bar/.gitkeep')).to be_nil
2010

2011 2012
        cherry_pick_commit_sha = repository.cherry_pick(user, pickable_merge, 'improve/awesome', message)
        cherry_pick_commit_message = project.commit(cherry_pick_commit_sha).message
2013

2014 2015
        expect(repository.blob_at_branch('improve/awesome', 'foo/bar/.gitkeep')).not_to be_nil
        expect(cherry_pick_commit_message).to eq(message)
2016 2017 2018 2019
      end
    end
  end

2020 2021 2022 2023 2024 2025 2026
  describe '#before_delete' do
    describe 'when a repository does not exist' do
      before do
        allow(repository).to receive(:exists?).and_return(false)
      end

      it 'does not flush caches that depend on repository data' do
2027
        expect(repository).not_to receive(:expire_cache)
2028 2029 2030 2031

        repository.before_delete
      end

2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043
      it 'flushes the tags cache' do
        expect(repository).to receive(:expire_tags_cache)

        repository.before_delete
      end

      it 'flushes the branches cache' do
        expect(repository).to receive(:expire_branches_cache)

        repository.before_delete
      end

2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054
      it 'flushes the root ref cache' do
        expect(repository).to receive(:expire_root_ref_cache)

        repository.before_delete
      end

      it 'flushes the emptiness caches' do
        expect(repository).to receive(:expire_emptiness_caches)

        repository.before_delete
      end
2055 2056

      it 'flushes the exists cache' do
2057
        expect(repository).to receive(:expire_exists_cache).twice
2058 2059 2060

        repository.before_delete
      end
2061 2062 2063 2064 2065 2066 2067
    end

    describe 'when a repository exists' do
      before do
        allow(repository).to receive(:exists?).and_return(true)
      end

2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079
      it 'flushes the tags cache' do
        expect(repository).to receive(:expire_tags_cache)

        repository.before_delete
      end

      it 'flushes the branches cache' do
        expect(repository).to receive(:expire_branches_cache)

        repository.before_delete
      end

2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107
      it 'flushes the root ref cache' do
        expect(repository).to receive(:expire_root_ref_cache)

        repository.before_delete
      end

      it 'flushes the emptiness caches' do
        expect(repository).to receive(:expire_emptiness_caches)

        repository.before_delete
      end
    end
  end

  describe '#before_change_head' do
    it 'flushes the branch cache' do
      expect(repository).to receive(:expire_branch_cache)

      repository.before_change_head
    end

    it 'flushes the root ref cache' do
      expect(repository).to receive(:expire_root_ref_cache)

      repository.before_change_head
    end
  end

2108
  describe '#after_change_head' do
2109
    it 'flushes the method caches' do
2110
      expect(repository).to receive(:expire_method_caches).with([
2111 2112
        :size,
        :commit_count,
2113
        :readme_path,
2114
        :contribution_guide,
2115
        :changelog,
2116 2117
        :license_blob,
        :license_key,
2118
        :gitignore,
2119 2120 2121 2122 2123
        :gitlab_ci_yml,
        :branch_names,
        :tag_names,
        :branch_count,
        :tag_count,
2124
        :avatar,
2125 2126
        :exists?,
        :root_ref,
2127
        :merged_branch_names,
2128
        :has_visible_content?,
2129 2130
        :issue_template_names_hash,
        :merge_request_template_names_hash,
2131
        :user_defined_metrics_dashboard_paths,
2132 2133
        :xcode_project?,
        :has_ambiguous_refs?
2134 2135 2136 2137
      ])

      repository.after_change_head
    end
Mike Kozono's avatar
Mike Kozono committed
2138 2139 2140 2141 2142 2143

    it 'calls after_repository_change_head on container' do
      expect(repository.container).to receive(:after_repository_change_head)

      repository.after_change_head
    end
2144 2145
  end

2146
  describe '#expires_caches_for_tags' do
2147
    it 'flushes the cache' do
2148 2149 2150
      expect(repository).to receive(:expire_statistics_caches)
      expect(repository).to receive(:expire_emptiness_caches)
      expect(repository).to receive(:expire_tags_cache)
2151

2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162
      repository.expire_caches_for_tags
    end
  end

  describe '#before_push_tag' do
    it 'logs an event' do
      expect(repository).not_to receive(:expire_statistics_caches)
      expect(repository).not_to receive(:expire_emptiness_caches)
      expect(repository).not_to receive(:expire_tags_cache)
      expect(repository).to receive(:repository_event).with(:push_tag)

2163
      repository.before_push_tag
2164 2165 2166 2167
    end
  end

  describe '#after_push_commit' do
2168
    it 'expires statistics caches' do
2169 2170
      expect(repository).to receive(:expire_statistics_caches)
        .and_call_original
2171

2172 2173 2174
      expect(repository).to receive(:expire_branch_cache)
        .with('master')
        .and_call_original
2175

2176
      repository.after_push_commit('master')
2177 2178 2179 2180
    end
  end

  describe '#after_create_branch' do
2181
    it 'expires the branch caches' do
2182
      expect(repository).to receive(:expire_branches_cache)
2183 2184 2185

      repository.after_create_branch
    end
2186 2187 2188 2189 2190 2191

    it 'does not expire the branch caches when specified' do
      expect(repository).not_to receive(:expire_branches_cache)

      repository.after_create_branch(expire_cache: false)
    end
2192 2193 2194
  end

  describe '#after_remove_branch' do
2195
    it 'expires the branch caches' do
2196
      expect(repository).to receive(:expire_branches_cache)
2197 2198 2199

      repository.after_remove_branch
    end
2200 2201 2202 2203 2204 2205

    it 'does not expire the branch caches when specified' do
      expect(repository).not_to receive(:expire_branches_cache)

      repository.after_remove_branch(expire_cache: false)
    end
2206
  end
2207

2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223
  describe '#lookup' do
    before do
      allow(repository.raw_repository).to receive(:lookup).and_return('interesting_blob')
    end

    it 'uses the lookup cache' do
      2.times.each { repository.lookup('sha1') }

      expect(repository.raw_repository).to have_received(:lookup).once
    end

    it 'returns the correct value' do
      expect(repository.lookup('sha1')).to eq('interesting_blob')
    end
  end

2224
  describe '#after_create' do
2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238
    it 'calls expire_status_cache' do
      expect(repository).to receive(:expire_status_cache)

      repository.after_create
    end

    it 'logs an event' do
      expect(repository).to receive(:repository_event).with(:create_repository)

      repository.after_create
    end
  end

  describe '#expire_status_cache' do
2239 2240 2241
    it 'flushes the exists cache' do
      expect(repository).to receive(:expire_exists_cache)

2242
      repository.expire_status_cache
2243
    end
2244 2245 2246 2247

    it 'flushes the root ref cache' do
      expect(repository).to receive(:expire_root_ref_cache)

2248
      repository.expire_status_cache
2249 2250 2251 2252 2253
    end

    it 'flushes the emptiness caches' do
      expect(repository).to receive(:expire_emptiness_caches)

2254
      repository.expire_status_cache
2255
    end
2256 2257
  end

2258 2259 2260 2261 2262 2263 2264 2265 2266 2267
  describe "#copy_gitattributes" do
    it 'returns true with a valid ref' do
      expect(repository.copy_gitattributes('master')).to be_truthy
    end

    it 'returns false with an invalid ref' do
      expect(repository.copy_gitattributes('invalid')).to be_falsey
    end
  end

2268 2269
  describe '#before_remove_tag' do
    it 'flushes the tag cache' do
2270 2271
      expect(repository).to receive(:expire_tags_cache).and_call_original
      expect(repository).to receive(:expire_statistics_caches).and_call_original
2272 2273 2274 2275 2276 2277 2278

      repository.before_remove_tag
    end
  end

  describe '#branch_count' do
    it 'returns the number of branches' do
Douwe Maan's avatar
Douwe Maan committed
2279
      expect(repository.branch_count).to be_an(Integer)
Kim "BKC" Carlbäcker's avatar
Kim "BKC" Carlbäcker committed
2280

2281
      rugged_count = rugged_repo(repository).branches.count
Kim "BKC" Carlbäcker's avatar
Kim "BKC" Carlbäcker committed
2282

2283
      expect(repository.branch_count).to eq(rugged_count)
2284 2285 2286 2287 2288
    end
  end

  describe '#tag_count' do
    it 'returns the number of tags' do
Douwe Maan's avatar
Douwe Maan committed
2289
      expect(repository.tag_count).to be_an(Integer)
Kim "BKC" Carlbäcker's avatar
Kim "BKC" Carlbäcker committed
2290

2291
      rugged_count = rugged_repo(repository).tags.count
Kim "BKC" Carlbäcker's avatar
Kim "BKC" Carlbäcker committed
2292

2293
      expect(repository.tag_count).to eq(rugged_count)
2294 2295 2296
    end
  end

2297
  describe '#expire_branches_cache' do
2298
    it 'expires the cache' do
2299
      expect(repository).to receive(:expire_method_caches)
2300
        .with(%i(branch_names merged_branch_names branch_count has_visible_content? has_ambiguous_refs?))
2301
        .and_call_original
2302

2303
      repository.expire_branches_cache
2304 2305 2306
    end
  end

2307
  describe '#expire_tags_cache' do
2308
    it 'expires the cache' do
2309
      expect(repository).to receive(:expire_method_caches)
2310
        .with(%i(tag_names tag_count has_ambiguous_refs?))
2311
        .and_call_original
2312

2313
      repository.expire_tags_cache
2314 2315
    end
  end
2316

2317
  describe '#add_tag' do
2318
    let(:user) { build_stubbed(:user) }
2319

2320 2321 2322
    context 'with a valid target' do
      it 'creates the tag' do
        repository.add_tag(user, '8.5', 'master', 'foo')
2323

2324 2325 2326 2327
        tag = repository.find_tag('8.5')
        expect(tag).to be_present
        expect(tag.message).to eq('foo')
        expect(tag.dereferenced_target.id).to eq(repository.commit('master').id)
2328
      end
2329

2330
      it 'returns a Gitlab::Git::Tag object' do
2331 2332
        tag = repository.add_tag(user, '8.5', 'master', 'foo')

2333 2334 2335
        expect(tag).to be_a(Gitlab::Git::Tag)
      end
    end
2336

2337 2338 2339
    context 'with an invalid target' do
      it 'returns false' do
        expect(repository.add_tag(user, '8.5', 'bar', 'foo')).to be false
2340
      end
2341 2342 2343
    end
  end

2344
  describe '#rm_branch' do
2345 2346 2347
    it 'removes a branch' do
      expect(repository).to receive(:before_remove_branch)
      expect(repository).to receive(:after_remove_branch)
2348

2349
      repository.rm_branch(user, 'feature')
2350
    end
2351

2352 2353 2354 2355
    context 'when pre hooks failed' do
      before do
        allow_any_instance_of(Gitlab::GitalyClient::OperationService)
          .to receive(:user_delete_branch).and_raise(Gitlab::Git::PreReceiveError)
2356 2357
      end

2358 2359 2360 2361
      it 'gets an error and does not delete the branch' do
        expect do
          repository.rm_branch(user, 'feature')
        end.to raise_error(Gitlab::Git::PreReceiveError)
2362

2363
        expect(repository.find_branch('feature')).not_to be_nil
2364
      end
2365 2366
    end
  end
2367 2368

  describe '#rm_tag' do
2369 2370
    it 'removes a tag' do
      expect(repository).to receive(:before_remove_tag)
2371

2372
      repository.rm_tag(build_stubbed(:user), 'v1.1.0')
2373

2374
      expect(repository.find_tag('v1.1.0')).to be_nil
2375 2376
    end
  end
2377

2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413
  describe '#find_tag' do
    before do
      allow(Gitlab::GitalyClient).to receive(:call).and_call_original
    end

    it 'finds a tag with specified name by performing FindTag request' do
      expect(Gitlab::GitalyClient)
        .to receive(:call).with(anything, :ref_service, :find_tag, anything, anything).and_call_original

      expect(repository.find_tag('v1.1.0').name).to eq('v1.1.0')
    end

    it 'does not perform Gitaly call when tags are preloaded' do
      repository.tags

      expect(Gitlab::GitalyClient).not_to receive(:call)

      expect(repository.find_tag('v1.1.0').name).to eq('v1.1.0')
    end

    it 'returns nil when tag does not exists' do
      expect(repository.find_tag('does-not-exist')).to be_nil
    end

    context 'when find_tag_via_gitaly is disabled' do
      it 'fetches all tags' do
        stub_feature_flags(find_tag_via_gitaly: false)

        expect(Gitlab::GitalyClient)
          .to receive(:call).with(anything, :ref_service, :find_all_tags, anything, anything).and_call_original

        expect(repository.find_tag('v1.1.0').name).to eq('v1.1.0')
      end
    end
  end

2414
  describe '#avatar' do
2415
    it 'returns nil if repo does not exist' do
2416
      allow(repository).to receive(:root_ref).and_raise(Gitlab::Git::Repository::NoRepository)
2417

2418
      expect(repository.avatar).to be_nil
2419 2420
    end

2421
    it 'returns the first avatar file found in the repository' do
2422 2423 2424
      expect(repository).to receive(:file_on_head)
        .with(:avatar)
        .and_return(double(:tree, path: 'logo.png'))
2425 2426 2427 2428 2429

      expect(repository.avatar).to eq('logo.png')
    end

    it 'caches the output' do
2430 2431 2432 2433
      expect(repository).to receive(:file_on_head)
        .with(:avatar)
        .once
        .and_return(double(:tree, path: 'logo.png'))
2434

2435
      2.times { expect(repository.avatar).to eq('logo.png') }
2436 2437
    end
  end
2438

2439 2440
  describe '#expire_exists_cache' do
    let(:cache) { repository.send(:cache) }
2441
    let(:request_store_cache) { repository.send(:request_store_cache) }
2442 2443 2444 2445 2446 2447

    it 'expires the cache' do
      expect(cache).to receive(:expire).with(:exists?)

      repository.expire_exists_cache
    end
2448 2449 2450 2451 2452 2453

    it 'expires the request store cache', :request_store do
      expect(request_store_cache).to receive(:expire).with(:exists?)

      repository.expire_exists_cache
    end
2454 2455
  end

2456 2457
  describe '#xcode_project?' do
    before do
2458
      allow(repository).to receive(:tree).with(:head).and_return(double(:tree, trees: [tree]))
2459 2460
    end

2461 2462
    context 'when the root contains a *.xcodeproj directory' do
      let(:tree) { double(:tree, path: 'Foo.xcodeproj') }
2463 2464 2465 2466 2467 2468

      it 'returns true' do
        expect(repository.xcode_project?).to be_truthy
      end
    end

2469 2470
    context 'when the root contains a *.xcworkspace directory' do
      let(:tree) { double(:tree, path: 'Foo.xcworkspace') }
2471 2472 2473 2474 2475 2476

      it 'returns true' do
        expect(repository.xcode_project?).to be_truthy
      end
    end

2477 2478
    context 'when the root contains no Xcode config directory' do
      let(:tree) { double(:tree, path: 'Foo') }
2479 2480 2481 2482 2483 2484 2485

      it 'returns false' do
        expect(repository.xcode_project?).to be_falsey
      end
    end
  end

2486
  describe '#contribution_guide', :use_clean_rails_memory_store_caching do
2487
    it 'returns and caches the output' do
2488 2489 2490 2491
      expect(repository).to receive(:file_on_head)
        .with(:contributing)
        .and_return(Gitlab::Git::Tree.new(path: 'CONTRIBUTING.md'))
        .once
2492 2493

      2.times do
2494 2495
        expect(repository.contribution_guide)
          .to be_an_instance_of(Gitlab::Git::Tree)
2496 2497 2498 2499
      end
    end
  end

2500
  describe '#gitignore', :use_clean_rails_memory_store_caching do
2501
    it 'returns and caches the output' do
2502 2503 2504 2505
      expect(repository).to receive(:file_on_head)
        .with(:gitignore)
        .and_return(Gitlab::Git::Tree.new(path: '.gitignore'))
        .once
2506 2507

      2.times do
2508
        expect(repository.gitignore).to be_an_instance_of(Gitlab::Git::Tree)
2509 2510 2511 2512
      end
    end
  end

2513
  describe '#readme', :use_clean_rails_memory_store_caching do
2514
    context 'with a non-existing repository' do
2515
      let(:project) { create(:project) }
2516

2517
      it 'returns nil' do
2518 2519 2520
        expect(repository.readme).to be_nil
      end
    end
2521

2522
    context 'with an existing repository' do
2523
      context 'when no README exists' do
2524
        let(:project) { create(:project, :empty_repo) }
2525

2526
        it 'returns nil' do
2527 2528 2529
          expect(repository.readme).to be_nil
        end
      end
2530 2531 2532
    end
  end

2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558
  describe '#readme_path', :use_clean_rails_memory_store_caching do
    context 'with a non-existing repository' do
      let(:project) { create(:project) }

      it 'returns nil' do
        expect(repository.readme_path).to be_nil
      end
    end

    context 'with an existing repository' do
      context 'when no README exists' do
        let(:project) { create(:project, :empty_repo) }

        it 'returns nil' do
          expect(repository.readme_path).to be_nil
        end
      end

      context 'when a README exists' do
        let(:project) { create(:project, :repository) }

        it 'returns the README' do
          expect(repository.readme_path).to eq("README.md")
        end

        it 'caches the response' do
2559
          expect(repository.head_tree).to receive(:readme_path).and_call_original.once
2560 2561 2562 2563 2564 2565 2566 2567 2568

          2.times do
            expect(repository.readme_path).to eq("README.md")
          end
        end
      end
    end
  end

2569 2570
  describe '#expire_statistics_caches' do
    it 'expires the caches' do
2571 2572
      expect(repository).to receive(:expire_method_caches)
        .with(%i(size commit_count))
2573

2574 2575 2576 2577 2578 2579
      repository.expire_statistics_caches
    end
  end

  describe '#expire_all_method_caches' do
    it 'expires the caches of all methods' do
2580 2581
      expect(repository).to receive(:expire_method_caches)
        .with(Repository::CACHED_METHODS)
2582 2583 2584

      repository.expire_all_method_caches
    end
2585 2586 2587 2588 2589 2590 2591

    it 'all cache_method definitions are in the lists of method caches' do
      methods = repository.methods.map do |method|
        match = /^_uncached_(.*)/.match(method)
        match[1].to_sym if match
      end.compact

2592
      expect(Repository::CACHED_METHODS + Repository::MEMOIZED_CACHED_METHODS).to include(*methods)
2593
    end
2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614
  end

  describe '#file_on_head' do
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:tree).with(:head).and_return(nil)

        expect(repository.file_on_head(:readme)).to be_nil
      end
    end

    context 'with a repository that has no blobs' do
      it 'returns nil' do
        expect_any_instance_of(Tree).to receive(:blobs).and_return([])

        expect(repository.file_on_head(:readme)).to be_nil
      end
    end

    context 'with an existing repository' do
      it 'returns a Gitlab::Git::Tree' do
2615 2616
        expect(repository.file_on_head(:readme))
          .to be_an_instance_of(Gitlab::Git::Tree)
2617 2618 2619 2620
      end
    end
  end

2621 2622 2623 2624 2625 2626
  describe '#head_tree' do
    context 'with an existing repository' do
      it 'returns a Tree' do
        expect(repository.head_tree).to be_an_instance_of(Tree)
      end
    end
2627

2628 2629 2630 2631 2632
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:head_commit).and_return(nil)

        expect(repository.head_tree).to be_nil
2633 2634 2635 2636
      end
    end
  end

2637
  shared_examples '#tree' do
2638 2639 2640 2641 2642 2643 2644
    subject { repository.tree(sha, path, recursive: recursive, pagination_params: pagination_params) }

    let(:sha) { :head }
    let(:path) { nil }
    let(:recursive) { false }
    let(:pagination_params) { nil }

2645 2646 2647 2648
    context 'using a non-existing repository' do
      before do
        allow(repository).to receive(:head_commit).and_return(nil)
      end
2649

2650 2651 2652 2653
      it { is_expected.to be_nil }

      context 'when path is defined' do
        let(:path) { 'README.md' }
2654

2655
        it { is_expected.to be_nil }
2656 2657 2658 2659
      end
    end

    context 'using an existing repository' do
2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677
      it { is_expected.to be_an_instance_of(Tree) }

      context 'when different sha is set' do
        let(:sha) { 'v1.1.1' }

        it { is_expected.to be_an_instance_of(Tree) }
      end

      context 'when recursive is true' do
        let(:recursive) { true }

        it { is_expected.to be_an_instance_of(Tree) }
      end

      context 'with pagination parameters' do
        let(:pagination_params) { { limit: 10, page_token: nil } }

        it { is_expected.to be_an_instance_of(Tree) }
2678 2679 2680 2681
      end
    end
  end

2682 2683 2684 2685 2686 2687
  it_behaves_like '#tree'

  describe '#tree? with Rugged enabled', :enable_rugged do
    it_behaves_like '#tree'
  end

2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703
  describe '#size' do
    context 'with a non-existing repository' do
      it 'returns 0' do
        expect(repository).to receive(:exists?).and_return(false)

        expect(repository.size).to eq(0.0)
      end
    end

    context 'with an existing repository' do
      it 'returns the repository size as a Float' do
        expect(repository.size).to be_an_instance_of(Float)
      end
    end
  end

2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714
  describe '#local_branches' do
    it 'returns the local branches' do
      masterrev = repository.find_branch('master').dereferenced_target
      create_remote_branch('joe', 'remote_branch', masterrev)
      repository.add_branch(user, 'local_branch', masterrev.id)

      expect(repository.local_branches.any? { |branch| branch.name == 'remote_branch' }).to eq(false)
      expect(repository.local_branches.any? { |branch| branch.name == 'local_branch' }).to eq(true)
    end
  end

2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725
  describe '#commit_count' do
    context 'with a non-existing repository' do
      it 'returns 0' do
        expect(repository).to receive(:root_ref).and_return(nil)

        expect(repository.commit_count).to eq(0)
      end
    end

    context 'with an existing repository' do
      it 'returns the commit count' do
Douwe Maan's avatar
Douwe Maan committed
2726
        expect(repository.commit_count).to be_an(Integer)
2727 2728 2729 2730
      end
    end
  end

2731
  describe '#commit_count_for_ref' do
2732
    let(:project) { create :project }
2733

2734 2735
    context 'with a non-existing repository' do
      it 'returns 0' do
2736 2737 2738 2739 2740 2741 2742 2743
        expect(project.repository.commit_count_for_ref('master')).to eq(0)
      end
    end

    context 'with empty repository' do
      it 'returns 0' do
        project.create_repository
        expect(project.repository.commit_count_for_ref('master')).to eq(0)
2744 2745 2746 2747 2748 2749 2750 2751 2752 2753
      end
    end

    context 'when searching for the root ref' do
      it 'returns the same count as #commit_count' do
        expect(repository.commit_count_for_ref(repository.root_ref)).to eq(repository.commit_count)
      end
    end
  end

2754 2755
  describe '#refresh_method_caches' do
    it 'refreshes the caches of the given types' do
2756
      expect(repository).to receive(:expire_method_caches)
2757
        .with(%i(readme_path license_blob license_key license))
2758

2759
      expect(repository).to receive(:readme_path)
2760 2761
      expect(repository).to receive(:license_blob)
      expect(repository).to receive(:license_key)
2762
      expect(repository).to receive(:license)
2763 2764 2765

      repository.refresh_method_caches(%i(readme license))
    end
2766
  end
Douwe Maan's avatar
Douwe Maan committed
2767 2768 2769

  describe '#gitlab_ci_yml_for' do
    before do
2770
      repository.create_file(User.last, '.gitlab-ci.yml', 'CONTENT', message: 'Add .gitlab-ci.yml', branch_name: 'master')
Douwe Maan's avatar
Douwe Maan committed
2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787
    end

    context 'when there is a .gitlab-ci.yml at the commit' do
      it 'returns the content' do
        expect(repository.gitlab_ci_yml_for(repository.commit.sha)).to eq('CONTENT')
      end
    end

    context 'when there is no .gitlab-ci.yml at the commit' do
      it 'returns nil' do
        expect(repository.gitlab_ci_yml_for(repository.commit.parent.sha)).to be_nil
      end
    end
  end

  describe '#route_map_for' do
    before do
2788
      repository.create_file(User.last, '.gitlab/route-map.yml', 'CONTENT', message: 'Add .gitlab/route-map.yml', branch_name: 'master')
Douwe Maan's avatar
Douwe Maan committed
2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802
    end

    context 'when there is a .gitlab/route-map.yml at the commit' do
      it 'returns the content' do
        expect(repository.route_map_for(repository.commit.sha)).to eq('CONTENT')
      end
    end

    context 'when there is no .gitlab/route-map.yml at the commit' do
      it 'returns nil' do
        expect(repository.route_map_for(repository.commit.parent.sha)).to be_nil
      end
    end
  end
2803

2804
  def create_remote_branch(remote_name, branch_name, target)
2805
    rugged = rugged_repo(repository)
2806 2807 2808
    rugged.references.create("refs/remotes/#{remote_name}/#{branch_name}", target.id)
  end

2809
  shared_examples '#ancestor?' do
2810 2811
    let(:commit) { repository.commit }
    let(:ancestor) { commit.parents.first }
2812

2813
    it 'is an ancestor' do
2814 2815
      expect(repository.ancestor?(ancestor.id, commit.id)).to eq(true)
    end
2816

2817
    it 'is not an ancestor' do
2818
      expect(repository.ancestor?(commit.id, ancestor.id)).to eq(false)
2819
    end
2820

2821 2822 2823 2824
    it 'returns false on nil-values' do
      expect(repository.ancestor?(nil, commit.id)).to eq(false)
      expect(repository.ancestor?(ancestor.id, nil)).to eq(false)
      expect(repository.ancestor?(nil, nil)).to eq(false)
2825
    end
2826

2827 2828 2829
    it 'returns false for invalid commit IDs' do
      expect(repository.ancestor?(commit.id, Gitlab::Git::BLANK_SHA)).to eq(false)
      expect(repository.ancestor?( Gitlab::Git::BLANK_SHA, commit.id)).to eq(false)
2830 2831
    end
  end
2832

2833
  describe '#ancestor? with Gitaly enabled' do
2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858
    let(:commit) { repository.commit }
    let(:ancestor) { commit.parents.first }
    let(:cache_key) { "ancestor:#{ancestor.id}:#{commit.id}" }

    it_behaves_like '#ancestor?'

    context 'caching', :request_store, :clean_gitlab_redis_cache do
      it 'only calls out to Gitaly once' do
        expect(repository.raw_repository).to receive(:ancestor?).once

        2.times { repository.ancestor?(commit.id, ancestor.id) }
      end

      it 'returns the value from the request store' do
        repository.__send__(:request_store_cache).write(cache_key, "it's apparent")

        expect(repository.ancestor?(ancestor.id, commit.id)).to eq("it's apparent")
      end

      it 'returns the value from the redis cache' do
        expect(repository.__send__(:cache)).to receive(:fetch).with(cache_key).and_return("it's apparent")

        expect(repository.ancestor?(ancestor.id, commit.id)).to eq("it's apparent")
      end
    end
2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870
  end

  describe '#ancestor? with Rugged enabled', :enable_rugged do
    it 'calls out to the Rugged implementation' do
      allow_any_instance_of(Rugged).to receive(:merge_base).with(repository.commit.id, Gitlab::Git::BLANK_SHA).and_call_original

      repository.ancestor?(repository.commit.id, Gitlab::Git::BLANK_SHA)
    end

    it_behaves_like '#ancestor?'
  end

2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896
  describe '#archive_metadata' do
    let(:ref) { 'master' }
    let(:storage_path) { '/tmp' }

    let(:prefix) { [project.path, ref].join('-') }
    let(:filename) { prefix + '.tar.gz' }

    subject(:result) { repository.archive_metadata(ref, storage_path, append_sha: false) }

    context 'with hashed storage disabled' do
      let(:project) { create(:project, :repository, :legacy_storage) }

      it 'uses the project path to generate the filename' do
        expect(result['ArchivePrefix']).to eq(prefix)
        expect(File.basename(result['ArchivePath'])).to eq(filename)
      end
    end

    context 'with hashed storage enabled' do
      it 'uses the project path to generate the filename' do
        expect(result['ArchivePrefix']).to eq(prefix)
        expect(File.basename(result['ArchivePath'])).to eq(filename)
      end
    end
  end

2897
  describe 'commit cache' do
2898
    let_it_be(:project) { create(:project, :repository) }
2899 2900 2901 2902 2903

    it 'caches based on SHA' do
      # Gets the commit oid, and warms the cache
      oid = project.commit.id

2904
      expect(Gitlab::Git::Commit).to receive(:find).once
2905

2906
      2.times { project.commit_by(oid: oid) }
2907 2908 2909 2910 2911
    end

    it 'caches nil values' do
      expect(Gitlab::Git::Commit).to receive(:find).once

2912
      2.times { project.commit_by(oid: '1' * 40) }
2913 2914
    end
  end
2915 2916 2917 2918 2919 2920 2921 2922

  describe '#raw_repository' do
    subject { repository.raw_repository }

    it 'returns a Gitlab::Git::Repository representation of the repository' do
      expect(subject).to be_a(Gitlab::Git::Repository)
      expect(subject.relative_path).to eq(project.disk_path + '.git')
      expect(subject.gl_repository).to eq("project-#{project.id}")
2923
      expect(subject.gl_project_path).to eq(project.full_path)
2924 2925 2926 2927 2928 2929 2930 2931 2932
    end

    context 'with a wiki repository' do
      let(:repository) { project.wiki.repository }

      it 'creates a Gitlab::Git::Repository with the proper attributes' do
        expect(subject).to be_a(Gitlab::Git::Repository)
        expect(subject.relative_path).to eq(project.disk_path + '.wiki.git')
        expect(subject.gl_repository).to eq("wiki-#{project.id}")
2933
        expect(subject.gl_project_path).to eq(project.wiki.full_path)
2934 2935 2936
      end
    end
  end
2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949

  describe '#contributors' do
    let(:author_a) { build(:author, email: 'tiagonbotelho@hotmail.com', name: 'tiagonbotelho') }
    let(:author_b) { build(:author, email: 'gitlab@winniehell.de', name: 'Winnie') }
    let(:author_c) { build(:author, email: 'douwe@gitlab.com', name: 'Douwe Maan') }
    let(:stubbed_commits) do
      [build(:commit, author: author_a),
       build(:commit, author: author_a),
       build(:commit, author: author_b),
       build(:commit, author: author_c),
       build(:commit, author: author_c),
       build(:commit, author: author_c)]
    end
2950

2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044
    let(:order_by) { nil }
    let(:sort) { nil }

    before do
      allow(repository).to receive(:commits).with(nil, limit: 2000, offset: 0, skip_merges: true).and_return(stubbed_commits)
    end

    subject { repository.contributors(order_by: order_by, sort: sort) }

    def expect_contributors(*contributors)
      expect(subject.map(&:email)).to eq(contributors.map(&:email))
    end

    it 'returns the array of Gitlab::Contributor for the repository' do
      expect_contributors(author_a, author_b, author_c)
    end

    context 'order_by email' do
      let(:order_by) { 'email' }

      context 'asc' do
        let(:sort) { 'asc' }

        it 'returns all the contributors ordered by email asc case insensitive' do
          expect_contributors(author_c, author_b, author_a)
        end
      end

      context 'desc' do
        let(:sort) { 'desc' }

        it 'returns all the contributors ordered by email desc case insensitive' do
          expect_contributors(author_a, author_b, author_c)
        end
      end
    end

    context 'order_by name' do
      let(:order_by) { 'name' }

      context 'asc' do
        let(:sort) { 'asc' }

        it 'returns all the contributors ordered by name asc case insensitive' do
          expect_contributors(author_c, author_a, author_b)
        end
      end

      context 'desc' do
        let(:sort) { 'desc' }

        it 'returns all the contributors ordered by name desc case insensitive' do
          expect_contributors(author_b, author_a, author_c)
        end
      end
    end

    context 'order_by commits' do
      let(:order_by) { 'commits' }

      context 'asc' do
        let(:sort) { 'asc' }

        it 'returns all the contributors ordered by commits asc' do
          expect_contributors(author_b, author_a, author_c)
        end
      end

      context 'desc' do
        let(:sort) { 'desc' }

        it 'returns all the contributors ordered by commits desc' do
          expect_contributors(author_c, author_a, author_b)
        end
      end
    end

    context 'invalid ordering' do
      let(:order_by) { 'unknown' }

      it 'returns the contributors unsorted' do
        expect_contributors(author_a, author_b, author_c)
      end
    end

    context 'invalid sorting' do
      let(:order_by) { 'name' }
      let(:sort) { 'unknown' }

      it 'returns the contributors unsorted' do
        expect_contributors(author_a, author_b, author_c)
      end
    end
  end
3045 3046

  describe '#merge_base' do
3047
    let_it_be(:project) { create(:project, :repository) }
3048

3049 3050 3051 3052 3053 3054 3055 3056
    subject(:repository) { project.repository }

    it 'only makes one gitaly call' do
      expect(Gitlab::GitalyClient).to receive(:call).once.and_call_original

      repository.merge_base('master', 'fix')
    end
  end
3057 3058 3059 3060 3061 3062 3063 3064 3065

  describe '#create_if_not_exists' do
    let(:project) { create(:project) }
    let(:repository) { project.repository }

    it 'creates the repository if it did not exist' do
      expect { repository.create_if_not_exists }.to change { repository.exists? }.from(false).to(true)
    end

3066 3067 3068 3069
    it 'returns true' do
      expect(repository.create_if_not_exists).to eq(true)
    end

3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083
    it 'calls out to the repository client to create a repo' do
      expect(repository.raw.gitaly_repository_client).to receive(:create_repository)

      repository.create_if_not_exists
    end

    context 'it does nothing if the repository already existed' do
      let(:project) { create(:project, :repository) }

      it 'does nothing if the repository already existed' do
        expect(repository.raw.gitaly_repository_client).not_to receive(:create_repository)

        repository.create_if_not_exists
      end
3084 3085 3086 3087

      it 'returns nil' do
        expect(repository.create_if_not_exists).to be_nil
      end
3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098
    end

    context 'when the repository exists but the cache is not up to date' do
      let(:project) { create(:project, :repository) }

      it 'does not raise errors' do
        allow(repository).to receive(:exists?).and_return(false)
        expect(repository.raw).to receive(:create_repository).and_call_original

        expect { repository.create_if_not_exists }.not_to raise_error
      end
3099 3100 3101 3102

      it 'returns nil' do
        expect(repository.create_if_not_exists).to be_nil
      end
3103 3104 3105
    end
  end

3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144
  describe '#create_from_bundle' do
    let(:project) { create(:project) }
    let(:repository) { project.repository }
    let(:valid_bundle_path) { File.join(Dir.tmpdir, "repo-#{SecureRandom.hex}.bundle") }
    let(:raw_repository) { repository.raw }

    before do
      allow(raw_repository).to receive(:create_from_bundle).and_return({})
    end

    after do
      FileUtils.rm_rf(valid_bundle_path)
    end

    it 'calls out to the raw_repository to create a repo from bundle' do
      expect(raw_repository).to receive(:create_from_bundle)

      repository.create_from_bundle(valid_bundle_path)
    end

    it 'calls after_create' do
      expect(repository).to receive(:after_create)

      repository.create_from_bundle(valid_bundle_path)
    end

    context 'when exception is raised' do
      before do
        allow(raw_repository).to receive(:create_from_bundle).and_raise(::Gitlab::Git::BundleFile::InvalidBundleError)
      end

      it 'after_create is not executed' do
        expect(repository).not_to receive(:after_create)

        expect {repository.create_from_bundle(valid_bundle_path)}.to raise_error(::Gitlab::Git::BundleFile::InvalidBundleError)
      end
    end
  end

3145
  describe "#blobs_metadata" do
3146
    let_it_be(:project) { create(:project, :repository) }
3147

3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173
    let(:repository) { project.repository }

    def expect_metadata_blob(thing)
      expect(thing).to be_a(Blob)
      expect(thing.data).to be_empty
    end

    it "returns blob metadata in batch for HEAD" do
      result = repository.blobs_metadata(["bar/branch-test.txt", "README.md", "does/not/exist"])

      expect_metadata_blob(result.first)
      expect_metadata_blob(result.second)
      expect(result.size).to eq(2)
    end

    it "returns blob metadata for a specified ref" do
      result = repository.blobs_metadata(["files/ruby/feature.rb"], "feature")

      expect_metadata_blob(result.first)
    end

    it "performs a single gitaly call", :request_store do
      expect { repository.blobs_metadata(["bar/branch-test.txt", "readme.txt", "does/not/exist"]) }
        .to change { Gitlab::GitalyClient.get_request_count }.by(1)
    end
  end
3174

3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187
  describe '#project' do
    it 'returns the project for a project snippet' do
      snippet = create(:project_snippet)

      expect(snippet.repository.project).to be(snippet.project)
    end

    it 'returns nil for a personal snippet' do
      snippet = create(:personal_snippet)

      expect(snippet.repository.project).to be_nil
    end

3188 3189 3190 3191 3192 3193
    it 'returns the project for a project wiki' do
      wiki = create(:project_wiki)

      expect(wiki.project).to be(wiki.repository.project)
    end

3194 3195 3196 3197 3198
    it 'returns the container if it is a project' do
      expect(repository.project).to be(project)
    end

    it 'returns nil if the container is not a project' do
3199 3200
      repository.container = Group.new

3201 3202 3203 3204
      expect(repository.project).to be_nil
    end
  end

3205 3206 3207 3208 3209
  describe '#submodule_links' do
    it 'returns an instance of Gitlab::SubmoduleLinks' do
      expect(repository.submodule_links).to be_a(Gitlab::SubmoduleLinks)
    end
  end
3210 3211

  describe '#lfs_enabled?' do
3212
    let_it_be(:project) { create(:project, :repository, :design_repo, lfs_enabled: true) }
3213 3214 3215 3216 3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234

    subject { repository.lfs_enabled? }

    context 'for a project repository' do
      let(:repository) { project.repository }

      it 'returns true when LFS is enabled' do
        stub_lfs_setting(enabled: true)

        is_expected.to be_truthy
      end

      it 'returns false when LFS is disabled' do
        stub_lfs_setting(enabled: false)

        is_expected.to be_falsy
      end
    end

    context 'for a project wiki repository' do
      let(:repository) { project.wiki.repository }

3235 3236
      it 'delegates to the project' do
        expect(project).to receive(:lfs_enabled?).and_return(true)
3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253 3254 3255 3256 3257 3258 3259 3260 3261 3262

        is_expected.to be_truthy
      end
    end

    context 'for a project snippet repository' do
      let(:snippet) { create(:project_snippet, project: project) }
      let(:repository) { snippet.repository }

      it 'returns false when LFS is enabled' do
        stub_lfs_setting(enabled: true)

        is_expected.to be_falsy
      end
    end

    context 'for a personal snippet repository' do
      let(:snippet) { create(:personal_snippet) }
      let(:repository) { snippet.repository }

      it 'returns false when LFS is enabled' do
        stub_lfs_setting(enabled: true)

        is_expected.to be_falsy
      end
    end
3263 3264 3265 3266 3267 3268 3269 3270 3271 3272 3273 3274 3275 3276 3277 3278

    context 'for a design repository' do
      let(:repository) { project.design_repository }

      it 'returns true when LFS is enabled' do
        stub_lfs_setting(enabled: true)

        is_expected.to be_truthy
      end

      it 'returns false when LFS is disabled' do
        stub_lfs_setting(enabled: false)

        is_expected.to be_falsy
      end
    end
3279
  end
3280 3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292 3293 3294 3295 3296 3297 3298 3299 3300 3301 3302 3303 3304 3305 3306 3307 3308 3309 3310 3311 3312 3313 3314 3315 3316 3317 3318 3319 3320 3321 3322 3323 3324 3325 3326

  describe '.pick_storage_shard', :request_store do
    before do
      storages = {
        'default' => Gitlab::GitalyClient::StorageSettings.new('path' => 'tmp/tests/repositories'),
        'picked'  => Gitlab::GitalyClient::StorageSettings.new('path' => 'tmp/tests/repositories')
      }

      allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
      stub_env('IN_MEMORY_APPLICATION_SETTINGS', 'false')
      Gitlab::CurrentSettings.current_application_settings

      update_storages({ 'picked' => 0, 'default' => 100 })
    end

    context 'when expire is false' do
      it 'does not expire existing repository storage value' do
        previous_storage = described_class.pick_storage_shard
        expect(previous_storage).to eq('default')
        expect(Gitlab::CurrentSettings).not_to receive(:expire_current_application_settings)

        update_storages({ 'picked' => 100, 'default' => 0 })

        new_storage = described_class.pick_storage_shard(expire: false)
        expect(new_storage).to eq(previous_storage)
      end
    end

    context 'when expire is true' do
      it 'expires existing repository storage value' do
        previous_storage = described_class.pick_storage_shard
        expect(previous_storage).to eq('default')
        expect(Gitlab::CurrentSettings).to receive(:expire_current_application_settings).and_call_original

        update_storages({ 'picked' => 100, 'default' => 0 })

        new_storage = described_class.pick_storage_shard(expire: true)
        expect(new_storage).to eq('picked')
      end
    end

    def update_storages(storage_hash)
      settings = ApplicationSetting.last
      settings.repository_storages_weighted = storage_hash
      settings.save!
    end
  end
Mike Kozono's avatar
Mike Kozono committed
3327 3328 3329 3330

  describe '#change_head' do
    let(:branch) { repository.container.default_branch }

3331 3332 3333 3334
    context 'when the branch exists' do
      it 'returns truthy' do
        expect(repository.change_head(branch)).to be_truthy
      end
Mike Kozono's avatar
Mike Kozono committed
3335

3336 3337
      it 'does not call container.after_change_head_branch_does_not_exist' do
        expect(repository.container).not_to receive(:after_change_head_branch_does_not_exist)
Mike Kozono's avatar
Mike Kozono committed
3338

3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349 3350 3351 3352
        repository.change_head(branch)
      end

      it 'calls repository hooks' do
        expect(repository).to receive(:before_change_head)
        expect(repository).to receive(:after_change_head)

        repository.change_head(branch)
      end

      it 'copies the gitattributes' do
        expect(repository).to receive(:copy_gitattributes).with(branch)
        repository.change_head(branch)
      end
Mike Kozono's avatar
Mike Kozono committed
3353

3354 3355 3356 3357
      it 'reloads the default branch' do
        expect(repository.container).to receive(:reload_default_branch)
        repository.change_head(branch)
      end
Mike Kozono's avatar
Mike Kozono committed
3358 3359
    end

3360 3361 3362 3363 3364 3365 3366 3367 3368 3369 3370 3371 3372 3373 3374 3375 3376 3377 3378
    context 'when the branch does not exist' do
      let(:branch) { 'non-existent-branch' }

      it 'returns falsey' do
        expect(repository.change_head(branch)).to be_falsey
      end

      it 'calls container.after_change_head_branch_does_not_exist' do
        expect(repository.container).to receive(:after_change_head_branch_does_not_exist).with(branch)

        repository.change_head(branch)
      end

      it 'does not call repository hooks' do
        expect(repository).not_to receive(:before_change_head)
        expect(repository).not_to receive(:after_change_head)

        repository.change_head(branch)
      end
Mike Kozono's avatar
Mike Kozono committed
3379 3380
    end
  end
3381
end