frontend_testing.md 32.1 KB
Newer Older
1 2 3
# Frontend testing standards and style guidelines

There are two types of test suites you'll encounter while developing frontend code
4
at GitLab. We use Karma with Jasmine and Jest for JavaScript unit and integration testing,
5 6 7
and RSpec feature tests with Capybara for e2e (end-to-end) integration testing.

Unit and feature tests need to be written for all new features.
8
Most of the time, you should use [RSpec](https://github.com/rspec/rspec-rails#feature-specs) for your feature tests.
9 10 11 12 13 14 15

Regression tests should be written for bug fixes to prevent them from recurring
in the future.

See the [Testing Standards and Style Guidelines](index.md) page for more
information on general testing practices at GitLab.

16 17
## Vue.js testing

18
If you are looking for a guide on Vue component testing, you can jump right away to this [section](../fe_guide/vue.md#testing-vue-components).
19

20 21
## Jest

22 23
We have started to migrate frontend tests to the [Jest](https://jestjs.io) testing framework (see also the corresponding
[epic](https://gitlab.com/groups/gitlab-org/-/epics/895)).
24 25 26

Jest tests can be found in `/spec/frontend` and `/ee/spec/frontend` in EE.

27 28
> **Note:**
>
Amy Qualls's avatar
Amy Qualls committed
29
> Most examples have a Jest and Karma example. See the Karma examples only as explanation to what's going on in the code, should you stumble over some use cases during your discovery. The Jest examples are the one you should follow.
30 31 32

## Karma test suite

33
While GitLab is switching over to [Jest](https://jestjs.io) you'll still find Karma tests in our application. [Karma](http://karma-runner.github.io/) is a test runner which uses [Jasmine](https://jasmine.github.io/) as its test
34 35 36 37 38 39 40 41 42 43 44 45
framework. Jest also uses Jasmine as foundation, that's why it's looking quite similar.

Karma tests live in `spec/javascripts/` and `/ee/spec/javascripts` in EE.

`app/assets/javascripts/behaviors/autosize.js`
might have a corresponding `spec/javascripts/behaviors/autosize_spec.js` file.

Keep in mind that in a CI environment, these tests are run in a headless
browser and you will not have access to certain APIs, such as
[`Notification`](https://developer.mozilla.org/en-US/docs/Web/API/notification),
which have to be stubbed.

46 47 48 49 50 51
### When should I use Jest over Karma?

If you need to update an existing Karma test file (found in `spec/javascripts`), you do not
need to migrate the whole spec to Jest. Simply updating the Karma spec to test your change
is fine. It is probably more appropriate to migrate to Jest in a separate merge request.

52
If you create a new test file, it needs to be created in Jest. This will
53 54 55 56 57
help support our migration and we think you'll love using Jest.

As always, please use discretion. Jest solves a lot of issues we experienced in Karma and
provides a better developer experience, however there are potentially unexpected issues
which could arise (especially with testing against browser specific features).
58

59 60
### Differences to Karma

Stefan Schmalzhaf's avatar
Stefan Schmalzhaf committed
61
- Jest runs in a Node.js environment, not in a browser. Support for running Jest tests in a browser [is planned](https://gitlab.com/gitlab-org/gitlab/-/issues/26982).
62
- Because Jest runs in a Node.js environment, it uses [jsdom](https://github.com/jsdom/jsdom) by default. See also its [limitations](#limitations-of-jsdom) below.
63
- Jest does not have access to Webpack loaders or aliases.
Amy Qualls's avatar
Amy Qualls committed
64
  The aliases used by Jest are defined in its [own configuration](https://gitlab.com/gitlab-org/gitlab/blob/master/jest.config.js).
65 66
- All calls to `setTimeout` and `setInterval` are mocked away. See also [Jest Timer Mocks](https://jestjs.io/docs/en/timer-mocks).
- `rewire` is not required because Jest supports mocking modules. See also [Manual Mocks](https://jestjs.io/docs/en/manual-mocks).
67 68 69
- No [context object](https://jasmine.github.io/tutorials/your_first_suite#section-The_%3Ccode%3Ethis%3C/code%3E_keyword) is passed to tests in Jest.
  This means sharing `this.something` between `beforeEach()` and `it()` for example does not work.
  Instead you should declare shared variables in the context that they are needed (via `const` / `let`).
70 71 72 73 74
- The following will cause tests to fail in Jest:
  - Unmocked requests.
  - Unhandled Promise rejections.
  - Calls to `console.warn`, including warnings from libraries like Vue.

75 76 77 78 79 80 81 82 83
### Limitations of jsdom

As mentioned [above](#differences-to-karma), Jest uses jsdom instead of a browser for running tests.
This comes with a number of limitations, namely:

- [No scrolling support](https://github.com/jsdom/jsdom/blob/15.1.1/lib/jsdom/browser/Window.js#L623-L625)
- [No element sizes or positions](https://github.com/jsdom/jsdom/blob/15.1.1/lib/jsdom/living/nodes/Element-impl.js#L334-L371)
- [No layout engine](https://github.com/jsdom/jsdom/issues/1322) in general

Stefan Schmalzhaf's avatar
Stefan Schmalzhaf committed
84
See also the issue for [support running Jest tests in browsers](https://gitlab.com/gitlab-org/gitlab/-/issues/26982).
85

86 87 88 89
### Debugging Jest tests

Running `yarn jest-debug` will run Jest in debug mode, allowing you to debug/inspect as described in the [Jest docs](https://jestjs.io/docs/en/troubleshooting#tests-are-failing-and-you-don-t-know-why).

90 91 92
### Timeout error

The default timeout for Jest is set in
93
[`/spec/frontend/test_setup.js`](https://gitlab.com/gitlab-org/gitlab/blob/master/spec/frontend/test_setup.js).
94 95 96 97 98

If your test exceeds that time, it will fail.

If you cannot improve the performance of the tests, you can increase the timeout
for a specific test using
99
[`setTestTimeout`](https://gitlab.com/gitlab-org/gitlab/blob/master/spec/frontend/helpers/timeout.js).
100 101

```javascript
102
import { setTestTimeout } from 'helpers/timeout';
103 104

describe('Component', () => {
105 106 107 108
  it('does something amazing', () => {
    setTestTimeout(500);
    // ...
  });
109 110 111 112 113
});
```

Remember that the performance of each test depends on the environment.

114
## What and how to test
115

116
Before jumping into more gritty details about Jest-specific workflows like mocks and spies, we should briefly cover what to test with Jest.
117

118
### Don't test the library
119

120 121
Libraries are an integral part of any JavaScript developer's life. The general advice would be to not test library internals, but expect that the library knows what it's supposed to do and has test coverage on its own.
A general example could be something like this
122

123 124
```javascript
import { convertToFahrenheit } from 'temperatureLibrary'
125

126 127 128 129
function getFahrenheit(celsius) {
  return convertToFahrenheit(celsius)
}
```
130

131
It does not make sense to test our `getFahrenheit` function because underneath it does nothing else but invoking the library function, and we can expect that one is working as intended. (Simplified, I know)
132

133
Let's take a short look into Vue land. Vue is a critical part of the GitLab JavaScript codebase. When writing specs for Vue components, a common gotcha is to actually end up testing Vue provided functionality, because it appears to be the easiest thing to test. Here's an example taken from our codebase.
134

135 136 137 138 139 140 141 142 143
```javascript
// Component
{
  computed: {
    hasMetricTypes() {
      return this.metricTypes.length;
    },
}
```
144

145
and here's the corresponding spec
146

147 148 149 150 151 152 153 154 155 156 157 158 159 160 161
```javascript
 describe('computed', () => {
    describe('hasMetricTypes', () => {
      it('returns true if metricTypes exist', () => {
        factory({ metricTypes });
        expect(wrapper.vm.hasMetricTypes).toBe(2);
      });

      it('returns true if no metricTypes exist', () => {
        factory();
        expect(wrapper.vm.hasMetricTypes).toBe(0);
      });
    });
});
```
162

163
Testing the `hasMetricTypes` computed prop would seem like a given, but to test if the computed property is returning the length of `metricTypes`, is testing the Vue library itself. There is no value in this, besides it adding to the test suite. Better is to test it in the way the user interacts with it. Probably through the template.
164

165
Keep an eye out for these kinds of tests, as they just make updating logic more fragile and tedious than it needs to be. This is also true for other libraries.
166

Coung Ngo's avatar
Coung Ngo committed
167
Some more examples can be found in the [Frontend unit tests section](testing_levels.md#frontend-unit-tests)
168

169
### Don't test your mock
170

171
Another common gotcha is that the specs end up verifying the mock is working. If you are using mocks, the mock should support the test, but not be the target of the test.
172

173
**Bad:**
174 175

```javascript
176 177
const spy = jest.spyOn(idGenerator, 'create')
spy.mockImplementation = () = '1234'
178

179 180
expect(idGenerator.create()).toBe('1234')
```
181

182
**Good:**
183

184 185 186 187 188 189
```javascript
const spy = jest.spyOn(idGenerator, 'create')
spy.mockImplementation = () = '1234'

// Actually focusing on the logic of your component and just leverage the controllable mocks output
expect(wrapper.find('div').html()).toBe('<div id="1234">...</div>')
190 191
```

192
### Follow the user
193

194
The line between unit and integration tests can be quite blurry in a component heavy world. The most important guideline to give is the following:
195

196 197
- Write clean unit tests if there is actual value in testing a complex piece of logic in isolation to prevent it from breaking in the future
- Otherwise, try to write your specs as close to the user's flow as possible
198

199
For example, it's better to use the generated markup to trigger a button click and validate the markup changed accordingly than to call a method manually and verify data structures or computed properties. There's always the chance of accidentally breaking the user flow, while the tests pass and provide a false sense of security.
200

201
## Common practices
202

Amy Qualls's avatar
Amy Qualls committed
203
Following you'll find some general common practices you will find as part of our test suite. Should you stumble over something not following this guide, ideally fix it right away. 🎉
204

205 206
### How to query DOM elements

Payton Burdette's avatar
Payton Burdette committed
207
When it comes to querying DOM elements in your tests, it is best to uniquely and semantically target the element. Sometimes this cannot be done feasibly. In these cases, adding test attributes to simplify the selectors might be the best option.
208

209 210
Preferentially, in component testing with `@vue/test-utils`, you should query for child components using the component itself. This helps enforce that specific behavior can be covered by that component's individual unit tests. Otherwise, try to use:

Payton Burdette's avatar
Payton Burdette committed
211
- A semantic attribute like `name` (also verifies that `name` was setup properly)
212 213 214 215
- A `data-testid` attribute ([recommended by maintainers of `@vue/test-utils`](https://github.com/vuejs/vue-test-utils/issues/1498#issuecomment-610133465))
- a Vue `ref` (if using `@vue/test-utils`)

Examples:
216 217 218

```javascript
it('exists', () => {
Payton Burdette's avatar
Payton Burdette committed
219
    // Good
220 221
    wrapper.find(FooComponent);
    wrapper.find('input[name=foo]');
222
    wrapper.find('[data-testid="foo"]');
223
    wrapper.find({ ref: 'foo'});
Payton Burdette's avatar
Payton Burdette committed
224 225

    // Bad
226
    wrapper.find('.js-foo');
Payton Burdette's avatar
Payton Burdette committed
227 228 229
    wrapper.find('.btn-primary');
    wrapper.find('.qa-foo-component');
    wrapper.find('[data-qa-selector="foo"]');
230 231 232 233 234 235 236
});
```

It is not recommended that you add `.js-*` classes just for testing purposes. Only do this if there are no other feasible options available.

Do not use a `.qa-*` class or `data-qa-selector` attribute for any tests other than QA end-to-end testing.

237
### Naming unit tests
238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263

When writing describe test blocks to test specific functions/methods,
please use the method name as the describe block name.

```javascript
// Good
describe('methodName', () => {
  it('passes', () => {
    expect(true).toEqual(true);
  });
});

// Bad
describe('#methodName', () => {
  it('passes', () => {
    expect(true).toEqual(true);
  });
});

// Bad
describe('.methodName', () => {
  it('passes', () => {
    expect(true).toEqual(true);
  });
});
```
264

265
### Testing promises
266

267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287
When testing Promises you should always make sure that the test is asynchronous and rejections are handled. It's now possible to use the `async/await` syntax in the test suite:

```javascript
it('tests a promise', async () => {
  const users = await fetchUsers()
  expect(users.length).toBe(42)
});

it('tests a promise rejection', async () => {
  expect.assertions(1);
  try {
    await user.getUserName(1);
  } catch (e) {
    expect(e).toEqual({
      error: 'User with 1 not found.',
    });
  }
});
```

You can also work with Promise chains. In this case, you can make use of the `done` callback and `done.fail` in case an error occurred. Following are some examples:
288 289 290

```javascript
// Good
291
it('tests a promise', done => {
292
  promise
293
    .then(data => {
294 295 296 297 298 299 300
      expect(data).toBe(asExpected);
    })
    .then(done)
    .catch(done.fail);
});

// Good
301
it('tests a promise rejection', done => {
302 303
  promise
    .then(done.fail)
304
    .catch(error => {
305 306 307 308 309 310 311 312
      expect(error).toBe(expectedError);
    })
    .then(done)
    .catch(done.fail);
});

// Bad (missing done callback)
it('tests a promise', () => {
313 314 315
  promise.then(data => {
    expect(data).toBe(asExpected);
  });
316 317 318
});

// Bad (missing catch)
319
it('tests a promise', done => {
320
  promise
321
    .then(data => {
322 323
      expect(data).toBe(asExpected);
    })
324
    .then(done);
325 326 327
});

// Bad (use done.fail in asynchronous tests)
328
it('tests a promise', done => {
329
  promise
330
    .then(data => {
331 332 333
      expect(data).toBe(asExpected);
    })
    .then(done)
334
    .catch(fail);
335 336 337
});

// Bad (missing catch)
338
it('tests a promise rejection', done => {
339
  promise
340
    .catch(error => {
341 342
      expect(error).toBe(expectedError);
    })
343
    .then(done);
344 345 346
});
```

347
### Manipulating Time
348

349
Sometimes we have to test time-sensitive code. For example, recurring events that run every X amount of seconds or similar. Here you'll find some strategies to deal with that:
350

351
#### `setTimeout()` / `setInterval()` in application
352

353 354 355 356
If the application itself is waiting for some time, mock await the waiting. In Jest this is already
[done by default](https://gitlab.com/gitlab-org/gitlab/blob/a2128edfee799e49a8732bfa235e2c5e14949c68/jest.config.js#L47)
(see also [Jest Timer Mocks](https://jestjs.io/docs/en/timer-mocks)). In Karma you can use the
[Jasmine mock clock](https://jasmine.github.io/api/2.9/Clock.html).
357

358 359 360 361 362 363
```javascript
const doSomethingLater = () => {
  setTimeout(() => {
    // do something
  }, 4000);
};
364
```
365

366
**in Jest:**
367

368 369 370 371
```javascript
it('does something', () => {
  doSomethingLater();
  jest.runAllTimers();
372

373
  expect(something).toBe('done');
374 375 376
});
```

377
**in Karma:**
378

379 380 381
```javascript
it('does something', () => {
  jasmine.clock().install();
382

383 384 385 386 387 388 389 390 391
  doSomethingLater();
  jasmine.clock().tick(4000);

  expect(something).toBe('done');
  jasmine.clock().uninstall();
});
```

### Waiting in tests
392

393 394
Sometimes a test needs to wait for something to happen in the application before it continues.
Avoid using [`setTimeout`](https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/setTimeout)
395
because it makes the reason for waiting unclear and if used within Karma with a time larger than zero it will slow down our test suite.
396 397
Instead use one of the following approaches.

398
#### Promises and Ajax calls
399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417

Register handler functions to wait for the `Promise` to be resolved.

```javascript
const askTheServer = () => {
  return axios
    .get('/endpoint')
    .then(response => {
      // do something
    })
    .catch(error => {
      // do something else
    });
};
```

**in Jest:**

```javascript
418 419 420
it('waits for an Ajax call', async () => {
  await askTheServer()
  expect(something).toBe('done');
421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436
});
```

**in Karma:**

```javascript
it('waits for an Ajax call', done => {
  askTheServer()
    .then(() => {
      expect(something).toBe('done');
    })
    .then(done)
    .catch(done.fail);
});
```

437
If you are not able to register handlers to the `Promise`, for example because it is executed in a synchronous Vue life cycle hook, please take a look at the [waitFor](#wait-until-axios-requests-finish) helpers or you can flush all pending `Promise`s:
438 439 440 441 442 443 444 445 446 447 448 449

**in Jest:**

```javascript
it('waits for an Ajax call', () => {
  synchronousFunction();
  jest.runAllTicks();

  expect(something).toBe('done');
});
```

450
#### Vue rendering
451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482

To wait until a Vue component is re-rendered, use either of the equivalent
[`Vue.nextTick()`](https://vuejs.org/v2/api/#Vue-nextTick) or `vm.$nextTick()`.

**in Jest:**

```javascript
it('renders something', () => {
  wrapper.setProps({ value: 'new value' });

  return wrapper.vm.$nextTick().then(() => {
    expect(wrapper.text()).toBe('new value');
  });
});
```

**in Karma:**

```javascript
it('renders something', done => {
  wrapper.setProps({ value: 'new value' });

  wrapper.vm
    .$nextTick()
    .then(() => {
      expect(wrapper.text()).toBe('new value');
    })
    .then(done)
    .catch(done.fail);
});
```

483
#### Events
484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513

If the application triggers an event that you need to wait for in your test, register an event handler which contains
the assertions:

```javascript
it('waits for an event', done => {
  eventHub.$once('someEvent', eventHandler);

  someFunction();

  function eventHandler() {
    expect(something).toBe('done');
    done();
  }
});
```

In Jest you can also use a `Promise` for this:

```javascript
it('waits for an event', () => {
  const eventTriggered = new Promise(resolve => eventHub.$once('someEvent', resolve));

  someFunction();

  return eventTriggered.then(() => {
    expect(something).toBe('done');
  });
});
```
514

515
### Ensuring that tests are isolated
516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545

Tests are normally architected in a pattern which requires a recurring setup and breakdown of the component under test. This is done by making use of the `beforeEach` and `afterEach` hooks.

Example

```javascript
  let wrapper;

  beforeEach(() => {
    wrapper = mount(Component);
  });

  afterEach(() => {
    wrapper.destroy();
  });
```

When looking at this initially you'd suspect that the component is setup before each test and then broken down afterwards, providing isolation between tests.

This is however not entirely true as the `destroy` method does not remove everything which has been mutated on the `wrapper` object. For functional components, destroy only removes the rendered DOM elements from the document.

In order to ensure that a clean wrapper object and DOM are being used in each test, the breakdown of the component should rather be performed as follows:

```javascript
  afterEach(() => {
    wrapper.destroy();
    wrapper = null;
  });
```

546
See also the [Vue Test Utils documentation on `destroy`](https://vue-test-utils.vuejs.org/api/wrapper/#destroy).
547

548 549 550 551 552 553 554 555 556 557
## Factories

TBU

## Mocking Strategies with Jest

### Stubbing and Mocking

Jasmine provides stubbing and mocking capabilities. There are some subtle differences in how to use it within Karma and Jest.

558 559
Stubs or spies are often used synonymously. In Jest it's quite easy thanks to the `.spyOn` method.
[Official docs](https://jestjs.io/docs/en/jest-object#jestspyonobject-methodname)
560 561 562 563
The more challenging part are mocks, which can be used for functions or even dependencies.

### Manual module mocks

564
Manual mocks are used to mock modules across the entire Jest environment. This is a very powerful testing tool that helps simplify
Amy Qualls's avatar
Amy Qualls committed
565
unit testing by mocking out modules which cannot be easily consumed in our test environment.
566

567 568 569
> **WARNING:** Do not use manual mocks if a mock should not be consistently applied in every spec (i.e. it's only needed by a few specs).
> Instead, consider using [`jest.mock(..)`](https://jestjs.io/docs/en/jest-object#jestmockmodulename-factory-options)
> (or a similar mocking function) in the relevant spec file.
570 571 572 573 574 575 576 577 578 579

#### Where should I put manual mocks?

Jest supports [manual module mocks](https://jestjs.io/docs/en/manual-mocks) by placing a mock in a `__mocks__/` directory next to the source module
(e.g. `app/assets/javascripts/ide/__mocks__`). **Don't do this.** We want to keep all of our test-related code in one place (the `spec/` folder).

If a manual mock is needed for a `node_modules` package, please use the `spec/frontend/__mocks__` folder. Here's an example of
a [Jest mock for the package `monaco-editor`](https://gitlab.com/gitlab-org/gitlab/blob/b7f914cddec9fc5971238cdf12766e79fa1629d7/spec/frontend/__mocks__/monaco-editor/index.js#L1).

If a manual mock is needed for a CE module, please place it in `spec/frontend/mocks/ce`.
580 581 582 583

- Files in `spec/frontend/mocks/ce` will mock the corresponding CE module from `app/assets/javascripts`, mirroring the source module's path.
  - Example: `spec/frontend/mocks/ce/lib/utils/axios_utils` will mock the module `~/lib/utils/axios_utils`.
- We don't support mocking EE modules yet.
584
- If a mock is found for which a source module doesn't exist, the test suite will fail. 'Virtual' mocks, or mocks that don't have a 1-to-1 association with a source module, are not supported yet.
585

586
#### Manual mock examples
587

588 589 590
- [`mocks/axios_utils`](https://gitlab.com/gitlab-org/gitlab/blob/bd20aeb64c4eed117831556c54b40ff4aee9bfd1/spec/frontend/mocks/ce/lib/utils/axios_utils.js#L1) -
  This mock is helpful because we don't want any unmocked requests to pass any tests. Also, we are able to inject some test helpers such as `axios.waitForAll`.
- [`__mocks__/mousetrap/index.js`](https://gitlab.com/gitlab-org/gitlab/blob/cd4c086d894226445be9d18294a060ba46572435/spec/frontend/__mocks__/mousetrap/index.js#L1) -
Amy Qualls's avatar
Amy Qualls committed
591
  This mock is helpful because the module itself uses AMD format which webpack understands, but is incompatible with the jest environment. This mock doesn't remove
592 593
  any behavior, only provides a nice es6 compatible wrapper.
- [`__mocks__/monaco-editor/index.js`](https://gitlab.com/gitlab-org/gitlab/blob/b7f914cddec9fc5971238cdf12766e79fa1629d7/spec/frontend/__mocks__/monaco-editor/index.js) -
Amy Qualls's avatar
Amy Qualls committed
594
  This mock is helpful because the Monaco package is completely incompatible in a Jest environment. In fact, webpack requires a special loader to make it work. This mock
595
  simply makes this package consumable by Jest.
596

597
### Keep mocks light
598

599
Global mocks introduce magic and technically can reduce test coverage. When mocking is deemed profitable:
600

601 602
- Keep the mock short and focused.
- Please leave a top-level comment in the mock on why it is necessary.
603

604
### Additional mocking techniques
605

606
Please consult the [official Jest docs](https://jestjs.io/docs/en/jest-object#mock-modules) for a full overview of the available mocking features.
607 608

## Running Frontend Tests
609

610
For running the frontend tests, you need the following commands:
611

612
- `rake frontend:fixtures` (re-)generates [fixtures](#frontend-test-fixtures).
613
- `yarn test` executes the tests.
614
- `yarn jest` executes only the Jest tests.
615

616
As long as the fixtures don't change, `yarn test` is sufficient (and saves you some time).
617

618 619
### Live testing and focused testing -- Jest

Amy Qualls's avatar
Amy Qualls committed
620
While you work on a test suite, you may want to run these specs in watch mode, so they rerun automatically on every save.
621

622
```shell
623 624 625 626 627 628 629 630 631
# Watch and rerun all specs matching the name icon
yarn jest --watch icon

# Watch and rerun one specifc file
yarn jest --watch path/to/spec/file.spec.js
```

You can also run some focused tests without the `--watch` flag

632
```shell
633 634 635 636 637 638 639
# Run specific jest file
yarn jest ./path/to/local_spec.js
# Run specific jest folder
yarn jest ./path/to/folder/
# Run all jest files which path contain term
yarn jest term
```
640

641 642 643 644 645
### Live testing and focused testing -- Karma

Karma allows something similar, but it's way more costly.

Running Karma with `yarn run karma-start` will compile the JavaScript
646
assets and run a server at `http://localhost:9876/` where it will automatically
647
run the tests on any browser which connects to it. You can enter that URL on
648 649
multiple browsers at once to have it run the tests on each in parallel.

650
While Karma is running, any changes you make will instantly trigger a recompile
651
and retest of the **entire test suite**, so you can see instantly if you've broken
652
a test with your changes. You can use [Jasmine focused](https://jasmine.github.io/2.5/focused_specs.html) or
653
excluded tests (with `fdescribe` or `xdescribe`) to get Karma to run only the
654 655 656
tests you want while you're working on a specific feature, but make sure to
remove these directives when you commit your code.

657
It is also possible to only run Karma on specific folders or files by filtering
658
the run tests via the argument `--filter-spec` or short `-f`:
659

660
```shell
661 662 663
# Run all files
yarn karma-start
# Run specific spec files
664
yarn karma-start --filter-spec profile/account/components/update_username_spec.js
665
# Run specific spec folder
666 667 668
yarn karma-start --filter-spec profile/account/components/
# Run all specs which path contain vue_shared or vie
yarn karma-start -f vue_shared -f vue_mr_widget
669 670
```

671 672 673
You can also use glob syntax to match files. Remember to put quotes around the
glob otherwise your shell may split it into multiple arguments:

674
```shell
675 676 677 678
# Run all specs named `file_spec` within the IDE subdirectory
yarn karma -f 'spec/javascripts/ide/**/file_spec.js'
```

679 680 681 682 683
## Frontend test fixtures

Code that is added to HAML templates (in `app/views/`) or makes Ajax requests to the backend has tests that require HTML or JSON from the backend.
Fixtures for these tests are located at:

684 685
- `spec/frontend/fixtures/`, for running tests in CE.
- `ee/spec/frontend/fixtures/`, for running tests in EE.
686 687 688 689 690 691 692 693 694 695

Fixture files in:

- The Karma test suite are served by [jasmine-jquery](https://github.com/velesin/jasmine-jquery).
- Jest use `spec/frontend/helpers/fixtures.js`.

The following are examples of tests that work for both Karma and Jest:

```javascript
it('makes a request', () => {
696
  const responseBody = getJSONFixture('some/fixture.json'); // loads spec/frontend/fixtures/some/fixture.json
697
  axiosMock.onGet(endpoint).reply(200, responseBody);
698

699
  myButton.click();
700

701 702 703 704
  // ...
});

it('uses some HTML element', () => {
705
  loadFixtures('some/page.html'); // loads spec/frontend/fixtures/some/page.html and adds it to the DOM
706

707
  const element = document.getElementById('#my-id');
708

709 710 711 712
  // ...
});
```

713
HTML and JSON fixtures are generated from backend views and controllers using RSpec (see `spec/frontend/fixtures/*.rb`).
714 715

For each fixture, the content of the `response` variable is stored in the output file.
716
This variable gets automatically set if the test is marked as `type: :request` or `type: :controller`.
717
Fixtures are regenerated using the `bin/rake frontend:fixtures` command but you can also generate them individually,
718
for example `bin/rspec spec/frontend/fixtures/merge_requests.rb`.
719 720
When creating a new fixture, it often makes sense to take a look at the corresponding tests for the endpoint in `(ee/)spec/controllers/` or `(ee/)spec/requests/`.

721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766
## Data-driven tests

Similar to [RSpec's parameterized tests](best_practices.md#table-based--parameterized-tests),
Jest supports data-driven tests for:

- Individual tests using [`test.each`](https://jestjs.io/docs/en/api#testeachtable-name-fn-timeout) (aliased to `it.each`).
- Groups of tests using [`describe.each`](https://jestjs.io/docs/en/api#describeeachtable-name-fn-timeout).

These can be useful for reducing repetition within tests. Each option can take an array of
data values or a tagged template literal.

For example:

```javascript
// function to test
const icon = status => status ? 'pipeline-passed' : 'pipeline-failed'
const message = status => status ? 'pipeline-passed' : 'pipeline-failed'

// test with array block
it.each([
    [false, 'pipeline-failed'],
    [true, 'pipeline-passed']
])('icon with %s will return %s',
 (status, icon) => {
    expect(renderPipeline(status)).toEqual(icon)
 }
);
```

```javascript
// test suite with tagged template literal block
describe.each`
    status   | icon                 | message
    ${false} | ${'pipeline-failed'} | ${'Pipeline failed - boo-urns'}
    ${true}  | ${'pipeline-passed'} | ${'Pipeline succeeded - win!'}
`('pipeline component', ({ status, icon, message }) => {
    it(`returns icon ${icon} with status ${status}`, () => {
        expect(icon(status)).toEqual(message)
    })

    it(`returns message ${message} with status ${status}`, () => {
        expect(message(status)).toEqual(message)
    })
});
```

767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797
## Gotchas

### RSpec errors due to JavaScript

By default RSpec unit tests will not run JavaScript in the headless browser
and will simply rely on inspecting the HTML generated by rails.

If an integration test depends on JavaScript to run correctly, you need to make
sure the spec is configured to enable JavaScript when the tests are run. If you
don't do this you'll see vague error messages from the spec runner.

To enable a JavaScript driver in an `rspec` test, add `:js` to the
individual spec or the context block containing multiple specs that need
JavaScript enabled:

```ruby
# For one spec
it 'presents information about abuse report', :js do
  # assertions...
end

describe "Admin::AbuseReports", :js do
  it 'presents information about abuse report' do
    # assertions...
  end
  it 'shows buttons for adding to abuse report' do
    # assertions...
  end
end
```

798 799
## Overview of Frontend Testing Levels

Coung Ngo's avatar
Coung Ngo committed
800 801
Main information on frontend testing levels can be found in the [Testing Levels page](testing_levels.md).

802 803
Tests relevant for frontend development can be found at the following places:

Coung Ngo's avatar
Coung Ngo committed
804 805 806 807 808
- `spec/javascripts/`, for Karma tests
- `spec/frontend/`, for Jest tests
- `spec/features/`, for RSpec tests

RSpec runs complete [feature tests](testing_levels.md#frontend-feature-tests), while the Jest and Karma directories contain [frontend unit tests](testing_levels.md#frontend-unit-tests), [frontend component tests](testing_levels.md#frontend-component-tests), and [frontend integration tests](testing_levels.md#frontend-integration-tests).
809

810
All tests in `spec/javascripts/` will eventually be migrated to `spec/frontend/` (see also [#52483](https://gitlab.com/gitlab-org/gitlab-foss/-/issues/52483)).
811

812
Before May 2018, `features/` also contained feature tests run by Spinach. These tests were removed from the codebase in May 2018 ([#23036](https://gitlab.com/gitlab-org/gitlab-foss/-/issues/23036)).
813

814
See also [Notes on testing Vue components](../fe_guide/vue.md#testing-vue-components).
815 816 817 818 819 820 821

## Test helpers

### Vuex Helper: `testAction`

We have a helper available to make testing actions easier, as per [official documentation](https://vuex.vuejs.org/guide/testing.html):

822
```javascript
823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838
testAction(
  actions.actionName, // action
  { }, // params to be passed to action
  state, // state
  [
    { type: types.MUTATION},
    { type: types.MUTATION_1, payload: {}},
  ], // mutations committed
  [
    { type: 'actionName', payload: {}},
    { type: 'actionName1', payload: {}},
  ] // actions dispatched
  done,
);
```

Amy Qualls's avatar
Amy Qualls committed
839
Check an example in [`spec/javascripts/ide/stores/actions_spec.jsspec/javascripts/ide/stores/actions_spec.js`](https://gitlab.com/gitlab-org/gitlab/blob/master/spec/javascripts/ide/stores/actions_spec.js).
840

Amy Qualls's avatar
Amy Qualls committed
841
### Wait until Axios requests finish
842

Amy Qualls's avatar
Amy Qualls committed
843
The Axios Utils mock module located in `spec/frontend/mocks/ce/lib/utils/axios_utils.js` contains two helper methods for Jest tests that spawn HTTP requests.
844 845 846 847 848 849 850
These are very useful if you don't have a handle to the request's Promise, for example when a Vue component does a request as part of its life cycle.

- `waitFor(url, callback)`: Runs `callback` after a request to `url` finishes (either successfully or unsuccessfully).
- `waitForAll(callback)`: Runs `callback` once all pending requests have finished. If no requests are pending, runs `callback` on the next tick.

Both functions run `callback` on the next tick after the requests finish (using `setImmediate()`), to allow any `.then()` or `.catch()` handlers to run.

851 852
## Testing with older browsers

Amy Qualls's avatar
Amy Qualls committed
853
Some regressions only affect a specific browser version. We can install and test in particular browsers with either Firefox or BrowserStack using the following steps:
854

Amy Qualls's avatar
Amy Qualls committed
855
### BrowserStack
856

Amy Qualls's avatar
Amy Qualls committed
857
[BrowserStack](https://www.browserstack.com/) allows you to test more than 1200 mobile devices and browsers.
858
You can use it directly through the [live app](https://www.browserstack.com/live) or you can install the [chrome extension](https://chrome.google.com/webstore/detail/browserstack/nkihdmlheodkdfojglpcjjmioefjahjb) for easy access.
859 860
Sign in to BrowserStack with the credentials saved in the **Engineering** vault of GitLab's
[shared 1Password account](https://about.gitlab.com/handbook/security/#1password-guide).
861 862 863 864 865 866 867 868 869

### Firefox

#### macOS

You can download any older version of Firefox from the releases FTP server, <https://ftp.mozilla.org/pub/firefox/releases/>:

1. From the website, select a version, in this case `50.0.1`.
1. Go to the mac folder.
Amy Qualls's avatar
Amy Qualls committed
870
1. Select your preferred language, you will find the DMG package inside, download it.
871 872 873 874 875 876
1. Drag and drop the application to any other folder but the `Applications` folder.
1. Rename the application to something like `Firefox_Old`.
1. Move the application to the `Applications` folder.
1. Open up a terminal and run `/Applications/Firefox_Old.app/Contents/MacOS/firefox-bin -profilemanager` to create a new profile specific to that Firefox version.
1. Once the profile has been created, quit the app, and run it again like normal. You now have a working older Firefox version.

877 878 879
---

[Return to Testing documentation](index.md)