user_spec.rb 108 KB
Newer Older
1 2
# frozen_string_literal: true

gitlabhq's avatar
gitlabhq committed
3 4
require 'spec_helper'

5
describe User do
6
  include ProjectForksHelper
7
  include TermsHelper
8

Shinya Maeda's avatar
Shinya Maeda committed
9
  it_behaves_like 'having unique enum values'
Shinya Maeda's avatar
Shinya Maeda committed
10

11 12 13 14 15 16 17
  describe 'modules' do
    subject { described_class }

    it { is_expected.to include_module(Gitlab::ConfigHelper) }
    it { is_expected.to include_module(Referable) }
    it { is_expected.to include_module(Sortable) }
    it { is_expected.to include_module(TokenAuthenticatable) }
18
    it { is_expected.to include_module(BlocksJsonSerialization) }
19 20
  end

21 22 23 24
  describe 'delegations' do
    it { is_expected.to delegate_method(:path).to(:namespace).with_prefix }
  end

25
  describe 'associations' do
26
    it { is_expected.to have_one(:namespace) }
27
    it { is_expected.to have_one(:status) }
28
    it { is_expected.to have_many(:snippets).dependent(:destroy) }
29 30 31
    it { is_expected.to have_many(:members) }
    it { is_expected.to have_many(:project_members) }
    it { is_expected.to have_many(:group_members) }
32 33
    it { is_expected.to have_many(:groups) }
    it { is_expected.to have_many(:keys).dependent(:destroy) }
34
    it { is_expected.to have_many(:deploy_keys).dependent(:nullify) }
35
    it { is_expected.to have_many(:events).dependent(:destroy) }
36
    it { is_expected.to have_many(:issues).dependent(:destroy) }
37 38 39
    it { is_expected.to have_many(:notes).dependent(:destroy) }
    it { is_expected.to have_many(:merge_requests).dependent(:destroy) }
    it { is_expected.to have_many(:identities).dependent(:destroy) }
40
    it { is_expected.to have_many(:spam_logs).dependent(:destroy) }
41
    it { is_expected.to have_many(:todos) }
42
    it { is_expected.to have_many(:award_emoji).dependent(:destroy) }
43
    it { is_expected.to have_many(:triggers).dependent(:destroy) }
44 45
    it { is_expected.to have_many(:builds).dependent(:nullify) }
    it { is_expected.to have_many(:pipelines).dependent(:nullify) }
46
    it { is_expected.to have_many(:chat_names).dependent(:destroy) }
Jan Provaznik's avatar
Jan Provaznik committed
47
    it { is_expected.to have_many(:uploads) }
48
    it { is_expected.to have_many(:reported_abuse_reports).dependent(:destroy).class_name('AbuseReport') }
49
    it { is_expected.to have_many(:custom_attributes).class_name('UserCustomAttribute') }
50
    it { is_expected.to have_many(:releases).dependent(:nullify) }
51

52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77
    describe "#abuse_report" do
      let(:current_user) { create(:user) }
      let(:other_user) { create(:user) }

      it { is_expected.to have_one(:abuse_report) }

      it "refers to the abuse report whose user_id is the current user" do
        abuse_report = create(:abuse_report, reporter: other_user, user: current_user)

        expect(current_user.abuse_report).to eq(abuse_report)
      end

      it "does not refer to the abuse report whose reporter_id is the current user" do
        create(:abuse_report, reporter: current_user, user: other_user)

        expect(current_user.abuse_report).to be_nil
      end

      it "does not update the user_id of an abuse report when the user is updated" do
        abuse_report = create(:abuse_report, reporter: current_user, user: other_user)

        current_user.block

        expect(abuse_report.reload.user).to eq(other_user)
      end
    end
78 79 80 81

    describe '#group_members' do
      it 'does not include group memberships for which user is a requester' do
        user = create(:user)
82
        group = create(:group, :public, :access_requestable)
83 84 85 86 87 88 89 90 91
        group.request_access(user)

        expect(user.group_members).to be_empty
      end
    end

    describe '#project_members' do
      it 'does not include project memberships for which user is a requester' do
        user = create(:user)
92
        project = create(:project, :public, :access_requestable)
93 94 95 96 97
        project.request_access(user)

        expect(user.project_members).to be_empty
      end
    end
98 99 100
  end

  describe 'validations' do
101 102 103 104 105
    describe 'name' do
      it { is_expected.to validate_presence_of(:name) }
      it { is_expected.to validate_length_of(:name).is_at_most(128) }
    end

106 107 108 109 110 111 112 113 114
    describe 'username' do
      it 'validates presence' do
        expect(subject).to validate_presence_of(:username)
      end

      it 'rejects blacklisted names' do
        user = build(:user, username: 'dashboard')

        expect(user).not_to be_valid
115
        expect(user.errors.messages[:username]).to eq ['dashboard is a reserved name']
116 117
      end

118 119 120 121 122 123 124 125 126 127 128 129
      it 'allows child names' do
        user = build(:user, username: 'avatar')

        expect(user).to be_valid
      end

      it 'allows wildcard names' do
        user = build(:user, username: 'blob')

        expect(user).to be_valid
      end

130 131 132 133 134 135 136 137 138 139
      context 'when username is changed' do
        let(:user) { build_stubbed(:user, username: 'old_path', namespace: build_stubbed(:namespace)) }

        it 'validates move_dir is allowed for the namespace' do
          expect(user.namespace).to receive(:any_project_has_container_registry_tags?).and_return(true)
          user.username = 'new_path'
          expect(user).to be_invalid
          expect(user.errors.messages[:username].first).to match('cannot be changed if a personal project has container registry tags')
        end
      end
140

141 142 143 144 145 146 147 148 149
      context 'when the username is in use by another user' do
        let(:username) { 'foo' }
        let!(:other_user) { create(:user, username: username) }

        it 'is invalid' do
          user = build(:user, username: username)

          expect(user).not_to be_valid
          expect(user.errors.full_messages).to eq(['Username has already been taken'])
150 151
        end
      end
152 153
    end

154 155 156 157 158 159 160 161 162 163
    it 'has a DB-level NOT NULL constraint on projects_limit' do
      user = create(:user)

      expect(user.persisted?).to eq(true)

      expect do
        user.update_columns(projects_limit: nil)
      end.to raise_error(ActiveRecord::StatementInvalid)
    end

164 165 166 167
    it { is_expected.to validate_presence_of(:projects_limit) }
    it { is_expected.to validate_numericality_of(:projects_limit) }
    it { is_expected.to allow_value(0).for(:projects_limit) }
    it { is_expected.not_to allow_value(-1).for(:projects_limit) }
168
    it { is_expected.not_to allow_value(Gitlab::Database::MAX_INT_VALUE + 1).for(:projects_limit) }
169

170
    it { is_expected.to validate_length_of(:bio).is_at_most(255) }
171

172 173 174
    it_behaves_like 'an object with email-formated attributes', :email do
      subject { build(:user) }
    end
175

176 177 178
    it_behaves_like 'an object with email-formated attributes', :public_email, :notification_email do
      subject { build(:user).tap { |user| user.emails << build(:email, email: email_value) } }
    end
179

180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195
    describe '#commit_email' do
      subject(:user) { create(:user) }

      it 'defaults to the primary email' do
        expect(user.email).to be_present
        expect(user.commit_email).to eq(user.email)
      end

      it 'defaults to the primary email when the column in the database is null' do
        user.update_column(:commit_email, nil)

        found_user = described_class.find_by(id: user.id)

        expect(found_user.commit_email).to eq(user.email)
      end

196 197 198 199 200 201
      it 'returns the private commit email when commit_email has _private' do
        user.update_column(:commit_email, Gitlab::PrivateCommitEmail::TOKEN)

        expect(user.commit_email).to eq(user.private_commit_email)
      end

202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234
      it 'can be set to a confirmed email' do
        confirmed = create(:email, :confirmed, user: user)
        user.commit_email = confirmed.email

        expect(user).to be_valid
        expect(user.commit_email).to eq(confirmed.email)
      end

      it 'can not be set to an unconfirmed email' do
        unconfirmed = create(:email, user: user)
        user.commit_email = unconfirmed.email

        # This should set the commit_email attribute to the primary email
        expect(user).to be_valid
        expect(user.commit_email).to eq(user.email)
      end

      it 'can not be set to a non-existent email' do
        user.commit_email = 'non-existent-email@nonexistent.nonexistent'

        # This should set the commit_email attribute to the primary email
        expect(user).to be_valid
        expect(user.commit_email).to eq(user.email)
      end

      it 'can not be set to an invalid email, even if confirmed' do
        confirmed = create(:email, :confirmed, :skip_validate, user: user, email: 'invalid')
        user.commit_email = confirmed.email

        expect(user).not_to be_valid
      end
    end

235
    describe 'email' do
236
      context 'when no signup domains whitelisted' do
237
        before do
238
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return([])
239
        end
240

241 242 243 244 245 246
        it 'accepts any email' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end
      end

247
      context 'when a signup domain is whitelisted and subdomains are allowed' do
248
        before do
249
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com', '*.example.com'])
250
        end
251

252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267
        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'accepts info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_valid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
      end

268
      context 'when a signup domain is whitelisted and subdomains are not allowed' do
269
        before do
270
          allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['example.com'])
271
        end
272 273 274 275 276 277 278 279 280 281 282 283 284 285 286

        it 'accepts info@example.com' do
          user = build(:user, email: "info@example.com")
          expect(user).to be_valid
        end

        it 'rejects info@test.example.com' do
          user = build(:user, email: "info@test.example.com")
          expect(user).to be_invalid
        end

        it 'rejects example@test.com' do
          user = build(:user, email: "example@test.com")
          expect(user).to be_invalid
        end
287 288 289 290 291

        it 'accepts example@test.com when added by another user' do
          user = build(:user, email: "example@test.com", created_by_id: 1)
          expect(user).to be_valid
        end
292
      end
293

294 295 296 297 298 299
      context 'domain blacklist' do
        before do
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist_enabled?).and_return(true)
          allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['example.com'])
        end

300
        context 'when a signup domain is blacklisted' do
301 302 303 304 305 306 307 308 309
          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
310 311 312 313 314

          it 'accepts info@example.com when added by another user' do
            user = build(:user, email: 'info@example.com', created_by_id: 1)
            expect(user).to be_valid
          end
315 316
        end

317
        context 'when a signup domain is blacklisted but a wildcard subdomain is allowed' do
318 319
          before do
            allow_any_instance_of(ApplicationSetting).to receive(:domain_blacklist).and_return(['test.example.com'])
320
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['*.example.com'])
321 322
          end

323
          it 'gives priority to whitelist and allow info@test.example.com' do
324 325 326 327 328 329 330
            user = build(:user, email: 'info@test.example.com')
            expect(user).to be_valid
          end
        end

        context 'with both lists containing a domain' do
          before do
331
            allow_any_instance_of(ApplicationSetting).to receive(:domain_whitelist).and_return(['test.com'])
332 333 334 335 336 337 338 339 340 341 342 343 344 345
          end

          it 'accepts info@test.com' do
            user = build(:user, email: 'info@test.com')
            expect(user).to be_valid
          end

          it 'rejects info@example.com' do
            user = build(:user, email: 'info@example.com')
            expect(user).not_to be_valid
          end
        end
      end

346 347 348 349 350 351
      context 'owns_notification_email' do
        it 'accepts temp_oauth_email emails' do
          user = build(:user, email: "temp-email-for-oauth@example.com")
          expect(user).to be_valid
        end
      end
352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385

      context 'set_commit_email' do
        it 'keeps commit email when private commit email is being used' do
          user = create(:user, commit_email: Gitlab::PrivateCommitEmail::TOKEN)

          expect(user.read_attribute(:commit_email)).to eq(Gitlab::PrivateCommitEmail::TOKEN)
        end

        it 'keeps the commit email when nil' do
          user = create(:user, commit_email: nil)

          expect(user.read_attribute(:commit_email)).to be_nil
        end

        it 'reverts to nil when email is not verified' do
          user = create(:user, commit_email: "foo@bar.com")

          expect(user.read_attribute(:commit_email)).to be_nil
        end
      end

      context 'owns_commit_email' do
        it 'accepts private commit email' do
          user = build(:user, commit_email: Gitlab::PrivateCommitEmail::TOKEN)

          expect(user).to be_valid
        end

        it 'accepts nil commit email' do
          user = build(:user, commit_email: nil)

          expect(user).to be_valid
        end
      end
386
    end
387 388 389 390 391 392 393
  end

  describe "scopes" do
    describe ".with_two_factor" do
      it "returns users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
394
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
395 396 397 398 399 400 401 402

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
403
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
404 405 406 407 408 409 410 411

        expect(users_with_two_factor).to include(user_with_2fa.id)
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end

      it "returns users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
412
        users_with_two_factor = described_class.with_two_factor.pluck(:id)
413 414 415 416

        expect(users_with_two_factor).to eq([user_with_2fa.id])
        expect(users_with_two_factor).not_to include(user_without_2fa.id)
      end
417 418 419 420 421 422 423 424

      it 'works with ORDER BY' do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)

        expect(described_class
          .with_two_factor
          .reorder_by_name).to eq([user_with_2fa])
      end
425 426 427 428 429 430
    end

    describe ".without_two_factor" do
      it "excludes users with 2fa enabled via OTP" do
        user_with_2fa = create(:user, :two_factor_via_otp)
        user_without_2fa = create(:user)
431
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
432 433 434 435 436 437 438 439

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via U2F" do
        user_with_2fa = create(:user, :two_factor_via_u2f)
        user_without_2fa = create(:user)
440
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
441 442 443 444 445 446 447 448

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end

      it "excludes users with 2fa enabled via OTP and U2F" do
        user_with_2fa = create(:user, :two_factor_via_otp, :two_factor_via_u2f)
        user_without_2fa = create(:user)
449
        users_without_two_factor = described_class.without_two_factor.pluck(:id)
450 451 452 453 454

        expect(users_without_two_factor).to include(user_without_2fa.id)
        expect(users_without_two_factor).not_to include(user_with_2fa.id)
      end
    end
455

456 457 458 459
    describe '.limit_to_todo_authors' do
      context 'when filtering by todo authors' do
        let(:user1) { create(:user) }
        let(:user2) { create(:user) }
460

461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504
        before do
          create(:todo, user: user1, author: user1, state: :done)
          create(:todo, user: user2, author: user2, state: :pending)
        end

        it 'only returns users that have authored todos' do
          users = described_class.limit_to_todo_authors(
            user: user2,
            with_todos: true,
            todo_state: :pending
          )

          expect(users).to eq([user2])
        end

        it 'ignores users that do not have a todo in the matching state' do
          users = described_class.limit_to_todo_authors(
            user: user1,
            with_todos: true,
            todo_state: :pending
          )

          expect(users).to be_empty
        end
      end

      context 'when not filtering by todo authors' do
        it 'returns the input relation' do
          user1 = create(:user)
          user2 = create(:user)
          rel = described_class.limit_to_todo_authors(user: user1)

          expect(rel).to include(user1, user2)
        end
      end

      context 'when no user is provided' do
        it 'returns the input relation' do
          user1 = create(:user)
          user2 = create(:user)
          rel = described_class.limit_to_todo_authors

          expect(rel).to include(user1, user2)
        end
505 506
      end
    end
507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523

    describe '.by_username' do
      it 'finds users regardless of the case passed' do
        user = create(:user, username: 'CaMeLcAsEd')
        user2 = create(:user, username: 'UPPERCASE')

        expect(described_class.by_username(%w(CAMELCASED uppercase)))
          .to contain_exactly(user, user2)
      end

      it 'finds a single user regardless of the case passed' do
        user = create(:user, username: 'CaMeLcAsEd')

        expect(described_class.by_username('CAMELCASED'))
          .to contain_exactly(user)
      end
    end
gitlabhq's avatar
gitlabhq committed
524 525 526
  end

  describe "Respond to" do
527
    it { is_expected.to respond_to(:admin?) }
528
    it { is_expected.to respond_to(:name) }
Zeger-Jan van de Weg's avatar
Zeger-Jan van de Weg committed
529 530 531 532 533 534 535 536 537 538 539 540 541 542
    it { is_expected.to respond_to(:external?) }
  end

  describe 'before save hook' do
    context 'when saving an external user' do
      let(:user)          { create(:user) }
      let(:external_user) { create(:user, external: true) }

      it "sets other properties aswell" do
        expect(external_user.can_create_team).to be_falsey
        expect(external_user.can_create_group).to be_falsey
        expect(external_user.projects_limit).to be 0
      end
    end
543

544 545
    describe '#check_for_verified_email' do
      let(:user)      { create(:user) }
546 547
      let(:secondary) { create(:email, :confirmed, email: 'secondary@example.com', user: user) }

548
      it 'allows a verfied secondary email to be used as the primary without needing reconfirmation' do
Lin Jen-Shin's avatar
Lin Jen-Shin committed
549
        user.update!(email: secondary.email)
550 551 552 553 554 555
        user.reload
        expect(user.email).to eq secondary.email
        expect(user.unconfirmed_email).to eq nil
        expect(user.confirmed?).to be_truthy
      end
    end
gitlabhq's avatar
gitlabhq committed
556 557
  end

558
  describe 'after commit hook' do
559 560 561 562 563 564 565 566 567 568 569
    describe '#update_emails_with_primary_email' do
      before do
        @user = create(:user, email: 'primary@example.com').tap do |user|
          user.skip_reconfirmation!
        end
        @secondary = create :email, email: 'secondary@example.com', user: @user
        @user.reload
      end

      it 'gets called when email updated' do
        expect(@user).to receive(:update_emails_with_primary_email)
570

Lin Jen-Shin's avatar
Lin Jen-Shin committed
571
        @user.update!(email: 'new_primary@example.com')
572 573
      end

574
      it 'adds old primary to secondary emails when secondary is a new email ' do
Lin Jen-Shin's avatar
Lin Jen-Shin committed
575
        @user.update!(email: 'new_primary@example.com')
576
        @user.reload
577

578 579
        expect(@user.emails.count).to eq 2
        expect(@user.emails.pluck(:email)).to match_array([@secondary.email, 'primary@example.com'])
580 581 582
      end

      it 'adds old primary to secondary emails if secondary is becoming a primary' do
Lin Jen-Shin's avatar
Lin Jen-Shin committed
583
        @user.update!(email: @secondary.email)
584
        @user.reload
585

586 587 588 589 590
        expect(@user.emails.count).to eq 1
        expect(@user.emails.first.email).to eq 'primary@example.com'
      end

      it 'transfers old confirmation values into new secondary' do
Lin Jen-Shin's avatar
Lin Jen-Shin committed
591
        @user.update!(email: @secondary.email)
592
        @user.reload
593

594 595 596 597
        expect(@user.emails.count).to eq 1
        expect(@user.emails.first.confirmed_at).not_to eq nil
      end
    end
598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659

    describe '#update_notification_email' do
      # Regression: https://gitlab.com/gitlab-org/gitlab-ce/issues/22846
      context 'when changing :email' do
        let(:user) { create(:user) }
        let(:new_email) { 'new-email@example.com' }

        it 'sets :unconfirmed_email' do
          expect do
            user.tap { |u| u.update!(email: new_email) }.reload
          end.to change(user, :unconfirmed_email).to(new_email)
        end

        it 'does not change :notification_email' do
          expect do
            user.tap { |u| u.update!(email: new_email) }.reload
          end.not_to change(user, :notification_email)
        end

        it 'updates :notification_email to the new email once confirmed' do
          user.update!(email: new_email)

          expect do
            user.tap(&:confirm).reload
          end.to change(user, :notification_email).to eq(new_email)
        end

        context 'and :notification_email is set to a secondary email' do
          let!(:email_attrs) { attributes_for(:email, :confirmed, user: user) }
          let(:secondary) { create(:email, :confirmed, email: 'secondary@example.com', user: user) }

          before do
            user.emails.create(email_attrs)
            user.tap { |u| u.update!(notification_email: email_attrs[:email]) }.reload
          end

          it 'does not change :notification_email to :email' do
            expect do
              user.tap { |u| u.update!(email: new_email) }.reload
            end.not_to change(user, :notification_email)
          end

          it 'does not change :notification_email to :email once confirmed' do
            user.update!(email: new_email)

            expect do
              user.tap(&:confirm).reload
            end.not_to change(user, :notification_email)
          end
        end
      end
    end

    describe '#update_invalid_gpg_signatures' do
      let(:user) do
        create(:user, email: 'tula.torphy@abshire.ca').tap do |user|
          user.skip_reconfirmation!
        end
      end

      it 'does nothing when the name is updated' do
        expect(user).not_to receive(:update_invalid_gpg_signatures)
Lin Jen-Shin's avatar
Lin Jen-Shin committed
660
        user.update!(name: 'Bette')
661 662 663 664
      end

      it 'synchronizes the gpg keys when the email is updated' do
        expect(user).to receive(:update_invalid_gpg_signatures).at_most(:twice)
Lin Jen-Shin's avatar
Lin Jen-Shin committed
665
        user.update!(email: 'shawnee.ritchie@denesik.com')
666 667
      end
    end
668 669
  end

670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731
  describe '#highest_role' do
    let(:user) { create(:user) }

    let(:group) { create(:group) }

    it 'returns NO_ACCESS if none has been set' do
      expect(user.highest_role).to eq(Gitlab::Access::NO_ACCESS)
    end

    it 'returns MAINTAINER if user is maintainer of a project' do
      create(:project, group: group) do |project|
        project.add_maintainer(user)
      end

      expect(user.highest_role).to eq(Gitlab::Access::MAINTAINER)
    end

    it 'returns the highest role if user is member of multiple projects' do
      create(:project, group: group) do |project|
        project.add_maintainer(user)
      end

      create(:project, group: group) do |project|
        project.add_developer(user)
      end

      expect(user.highest_role).to eq(Gitlab::Access::MAINTAINER)
    end

    it 'returns MAINTAINER if user is maintainer of a group' do
      create(:group) do |group|
        group.add_user(user, GroupMember::MAINTAINER)
      end

      expect(user.highest_role).to eq(Gitlab::Access::MAINTAINER)
    end

    it 'returns the highest role if user is member of multiple groups' do
      create(:group) do |group|
        group.add_user(user, GroupMember::MAINTAINER)
      end

      create(:group) do |group|
        group.add_user(user, GroupMember::DEVELOPER)
      end

      expect(user.highest_role).to eq(Gitlab::Access::MAINTAINER)
    end

    it 'returns the highest role if user is member of multiple groups and projects' do
      create(:group) do |group|
        group.add_user(user, GroupMember::DEVELOPER)
      end

      create(:project, group: group) do |project|
        project.add_maintainer(user)
      end

      expect(user.highest_role).to eq(Gitlab::Access::MAINTAINER)
    end
  end

732
  describe '#update_tracked_fields!', :clean_gitlab_redis_shared_state do
733 734 735 736 737 738 739 740 741 742 743 744 745 746
    let(:request) { OpenStruct.new(remote_ip: "127.0.0.1") }
    let(:user) { create(:user) }

    it 'writes trackable attributes' do
      expect do
        user.update_tracked_fields!(request)
      end.to change { user.reload.current_sign_in_at }
    end

    it 'does not write trackable attributes when called a second time within the hour' do
      user.update_tracked_fields!(request)

      expect do
        user.update_tracked_fields!(request)
747 748 749 750 751 752 753 754 755 756 757
      end.not_to change { user.reload.current_sign_in_at }
    end

    it 'writes trackable attributes for a different user' do
      user2 = create(:user)

      user.update_tracked_fields!(request)

      expect do
        user2.update_tracked_fields!(request)
      end.to change { user2.reload.current_sign_in_at }
758
    end
759 760 761 762 763 764 765 766

    it 'does not write if the DB is in read-only mode' do
      expect(Gitlab::Database).to receive(:read_only?).and_return(true)

      expect do
        user.update_tracked_fields!(request)
      end.not_to change { user.reload.current_sign_in_at }
    end
767 768
  end

769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796
  shared_context 'user keys' do
    let(:user) { create(:user) }
    let!(:key) { create(:key, user: user) }
    let!(:deploy_key) { create(:deploy_key, user: user) }
  end

  describe '#keys' do
    include_context 'user keys'

    context 'with key and deploy key stored' do
      it 'returns stored key, but not deploy_key' do
        expect(user.keys).to include key
        expect(user.keys).not_to include deploy_key
      end
    end
  end

  describe '#deploy_keys' do
    include_context 'user keys'

    context 'with key and deploy key stored' do
      it 'returns stored deploy key, but not normal key' do
        expect(user.deploy_keys).to include deploy_key
        expect(user.deploy_keys).not_to include key
      end
    end
  end

797
  describe '#confirm' do
798 799 800
    before do
      allow_any_instance_of(ApplicationSetting).to receive(:send_user_confirmation_email).and_return(true)
    end
801

802 803 804 805 806 807 808
    let(:user) { create(:user, confirmed_at: nil, unconfirmed_email: 'test@gitlab.com') }

    it 'returns unconfirmed' do
      expect(user.confirmed?).to be_falsey
    end

    it 'confirms a user' do
809
      user.confirm
810 811 812 813
      expect(user.confirmed?).to be_truthy
    end
  end

814 815 816 817 818 819 820 821
  describe '#to_reference' do
    let(:user) { create(:user) }

    it 'returns a String reference to the object' do
      expect(user.to_reference).to eq "@#{user.username}"
    end
  end

822
  describe '#generate_password' do
823
    it "does not generate password by default" do
824
      user = create(:user, password: 'abcdefghe')
825

826
      expect(user.password).to eq('abcdefghe')
827
    end
828 829
  end

830 831 832 833 834 835 836 837 838
  describe 'ensure user preference' do
    it 'has user preference upon user initialization' do
      user = build(:user)

      expect(user.user_preference).to be_present
      expect(user.user_preference).not_to be_persisted
    end
  end

839 840 841
  describe 'ensure incoming email token' do
    it 'has incoming email token' do
      user = create(:user)
842

843 844
      expect(user.incoming_email_token).not_to be_blank
    end
845 846 847 848 849 850 851 852

    it 'uses SecureRandom to generate the incoming email token' do
      expect(SecureRandom).to receive(:hex).and_return('3b8ca303')

      user = create(:user)

      expect(user.incoming_email_token).to eql('gitlab')
    end
853 854
  end

855 856 857 858 859 860 861
  describe '#ensure_user_rights_and_limits' do
    describe 'with external user' do
      let(:user) { create(:user, external: true) }

      it 'receives callback when external changes' do
        expect(user).to receive(:ensure_user_rights_and_limits)

Lin Jen-Shin's avatar
Lin Jen-Shin committed
862
        user.update(external: false)
863 864 865
      end

      it 'ensures correct rights and limits for user' do
866 867
        stub_config_setting(default_can_create_group: true)

Lin Jen-Shin's avatar
Lin Jen-Shin committed
868
        expect { user.update(external: false) }.to change { user.can_create_group }.to(true)
869
          .and change { user.projects_limit }.to(Gitlab::CurrentSettings.default_projects_limit)
870 871 872 873 874 875 876 877 878
      end
    end

    describe 'without external user' do
      let(:user) { create(:user, external: false) }

      it 'receives callback when external changes' do
        expect(user).to receive(:ensure_user_rights_and_limits)

Lin Jen-Shin's avatar
Lin Jen-Shin committed
879
        user.update(external: true)
880 881 882
      end

      it 'ensures correct rights and limits for user' do
Lin Jen-Shin's avatar
Lin Jen-Shin committed
883
        expect { user.update(external: true) }.to change { user.can_create_group }.to(false)
884 885 886 887 888
          .and change { user.projects_limit }.to(0)
      end
    end
  end

889 890 891 892
  describe 'feed token' do
    it 'ensures a feed token on read' do
      user = create(:user, feed_token: nil)
      feed_token = user.feed_token
893

894 895
      expect(feed_token).not_to be_blank
      expect(user.reload.feed_token).to eq feed_token
896 897 898
    end
  end

899
  describe '#recently_sent_password_reset?' do
900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918
    it 'is false when reset_password_sent_at is nil' do
      user = build_stubbed(:user, reset_password_sent_at: nil)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is false when sent more than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: 5.minutes.ago)

      expect(user.recently_sent_password_reset?).to eq false
    end

    it 'is true when sent less than one minute ago' do
      user = build_stubbed(:user, reset_password_sent_at: Time.now)

      expect(user.recently_sent_password_reset?).to eq true
    end
  end

919 920 921 922 923 924 925
  describe '#disable_two_factor!' do
    it 'clears all 2FA-related fields' do
      user = create(:user, :two_factor)

      expect(user).to be_two_factor_enabled
      expect(user.encrypted_otp_secret).not_to be_nil
      expect(user.otp_backup_codes).not_to be_nil
926
      expect(user.otp_grace_period_started_at).not_to be_nil
927 928 929 930 931 932 933 934

      user.disable_two_factor!

      expect(user).not_to be_two_factor_enabled
      expect(user.encrypted_otp_secret).to be_nil
      expect(user.encrypted_otp_secret_iv).to be_nil
      expect(user.encrypted_otp_secret_salt).to be_nil
      expect(user.otp_backup_codes).to be_nil
935
      expect(user.otp_grace_period_started_at).to be_nil
936 937 938
    end
  end

939 940
  describe 'projects' do
    before do
941
      @user = create(:user)
942

943 944
      @project = create(:project, namespace: @user.namespace)
      @project_2 = create(:project, group: create(:group)) do |project|
945
        project.add_maintainer(@user)
946
      end
947
      @project_3 = create(:project, group: create(:group)) do |project|
948 949
        project.add_developer(@user)
      end
950 951
    end

952 953 954 955 956 957 958 959 960
    it { expect(@user.authorized_projects).to include(@project) }
    it { expect(@user.authorized_projects).to include(@project_2) }
    it { expect(@user.authorized_projects).to include(@project_3) }
    it { expect(@user.owned_projects).to include(@project) }
    it { expect(@user.owned_projects).not_to include(@project_2) }
    it { expect(@user.owned_projects).not_to include(@project_3) }
    it { expect(@user.personal_projects).to include(@project) }
    it { expect(@user.personal_projects).not_to include(@project_2) }
    it { expect(@user.personal_projects).not_to include(@project_3) }
961 962 963
  end

  describe 'groups' do
964 965 966
    let(:user) { create(:user) }
    let(:group) { create(:group) }

967
    before do
968
      group.add_owner(user)
969 970
    end

971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996
    it { expect(user.several_namespaces?).to be_truthy }
    it { expect(user.authorized_groups).to eq([group]) }
    it { expect(user.owned_groups).to eq([group]) }
    it { expect(user.namespaces).to contain_exactly(user.namespace, group) }
    it { expect(user.manageable_namespaces).to contain_exactly(user.namespace, group) }

    context 'with child groups', :nested_groups do
      let!(:subgroup) { create(:group, parent: group) }

      describe '#manageable_namespaces' do
        it 'includes all the namespaces the user can manage' do
          expect(user.manageable_namespaces).to contain_exactly(user.namespace, group, subgroup)
        end
      end

      describe '#manageable_groups' do
        it 'includes all the namespaces the user can manage' do
          expect(user.manageable_groups).to contain_exactly(group, subgroup)
        end

        it 'does not include duplicates if a membership was added for the subgroup' do
          subgroup.add_owner(user)

          expect(user.manageable_groups).to contain_exactly(group, subgroup)
        end
      end
997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011

      describe '#manageable_groups_with_routes' do
        it 'eager loads routes from manageable groups' do
          control_count =
            ActiveRecord::QueryRecorder.new(skip_cached: false) do
              user.manageable_groups_with_routes.map(&:route)
            end.count

          create(:group, parent: subgroup)

          expect do
            user.manageable_groups_with_routes.map(&:route)
          end.not_to exceed_all_query_limit(control_count)
        end
      end
1012
    end
1013 1014
  end

1015 1016 1017 1018
  describe 'group multiple owners' do
    before do
      @user = create :user
      @user2 = create :user
1019 1020
      @group = create :group
      @group.add_owner(@user)
1021

1022
      @group.add_user(@user2, GroupMember::OWNER)
1023 1024
    end

1025
    it { expect(@user2.several_namespaces?).to be_truthy }
1026 1027
  end

1028 1029 1030
  describe 'namespaced' do
    before do
      @user = create :user
1031
      @project = create(:project, namespace: @user.namespace)
1032 1033
    end

1034
    it { expect(@user.several_namespaces?).to be_falsey }
1035
    it { expect(@user.namespaces).to eq([@user.namespace]) }
1036 1037 1038 1039 1040
  end

  describe 'blocking user' do
    let(:user) { create(:user, name: 'John Smith') }

1041
    it "blocks user" do
1042
      user.block
1043

1044
      expect(user.blocked?).to be_truthy
1045 1046 1047
    end
  end

1048
  describe '.filter_items' do
1049 1050 1051
    let(:user) { double }

    it 'filters by active users by default' do
1052
      expect(described_class).to receive(:active).and_return([user])
1053

1054
      expect(described_class.filter_items(nil)).to include user
1055 1056
    end

1057
    it 'filters by admins' do
1058
      expect(described_class).to receive(:admins).and_return([user])
1059

1060
      expect(described_class.filter_items('admins')).to include user
1061 1062
    end

1063
    it 'filters by blocked' do
1064
      expect(described_class).to receive(:blocked).and_return([user])
1065

1066
      expect(described_class.filter_items('blocked')).to include user
1067 1068 1069
    end

    it 'filters by two_factor_disabled' do
1070
      expect(described_class).to receive(:without_two_factor).and_return([user])
1071

1072
      expect(described_class.filter_items('two_factor_disabled')).to include user
1073 1074 1075
    end

    it 'filters by two_factor_enabled' do
1076
      expect(described_class).to receive(:with_two_factor).and_return([user])
1077

1078
      expect(described_class.filter_items('two_factor_enabled')).to include user
1079 1080 1081
    end

    it 'filters by wop' do
1082
      expect(described_class).to receive(:without_projects).and_return([user])
1083

1084
      expect(described_class.filter_items('wop')).to include user
1085
    end
1086 1087
  end

1088
  describe '.without_projects' do
1089
    let!(:project) { create(:project, :public, :access_requestable) }
1090 1091 1092 1093 1094 1095
    let!(:user) { create(:user) }
    let!(:user_without_project) { create(:user) }
    let!(:user_without_project2) { create(:user) }

    before do
      # add user to project
1096
      project.add_maintainer(user)
1097 1098 1099 1100 1101 1102 1103 1104

      # create invite to projet
      create(:project_member, :developer, project: project, invite_token: '1234', invite_email: 'inviteduser1@example.com')

      # create request to join project
      project.request_access(user_without_project2)
    end

1105 1106 1107
    it { expect(described_class.without_projects).not_to include user }
    it { expect(described_class.without_projects).to include user_without_project }
    it { expect(described_class.without_projects).to include user_without_project2 }
1108 1109
  end

1110 1111 1112
  describe 'user creation' do
    describe 'normal user' do
      let(:user) { create(:user, name: 'John Smith') }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
1113

1114
      it { expect(user.admin?).to be_falsey }
1115 1116 1117 1118
      it { expect(user.require_ssh_key?).to be_truthy }
      it { expect(user.can_create_group?).to be_truthy }
      it { expect(user.can_create_project?).to be_truthy }
      it { expect(user.first_name).to eq('John') }
1119
      it { expect(user.external).to be_falsey }
1120
    end
1121

Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
1122
    describe 'with defaults' do
1123
      let(:user) { described_class.new }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
1124

1125
      it "applies defaults to user" do
1126 1127
        expect(user.projects_limit).to eq(Gitlab.config.gitlab.default_projects_limit)
        expect(user.can_create_group).to eq(Gitlab.config.gitlab.default_can_create_group)
1128
        expect(user.theme_id).to eq(Gitlab.config.gitlab.default_theme)
Zeger-Jan van de Weg's avatar
Zeger-Jan van de Weg committed
1129
        expect(user.external).to be_falsey
1130 1131 1132
      end
    end

Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
1133
    describe 'with default overrides' do
1134
      let(:user) { described_class.new(projects_limit: 123, can_create_group: false, can_create_team: true) }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
1135

1136
      it "applies defaults to user" do
1137 1138
        expect(user.projects_limit).to eq(123)
        expect(user.can_create_group).to be_falsey
1139
        expect(user.theme_id).to eq(1)
1140
      end
1141 1142 1143 1144 1145 1146 1147

      it 'does not undo projects_limit setting if it matches old DB default of 10' do
        # If the real default project limit is 10 then this test is worthless
        expect(Gitlab.config.gitlab.default_projects_limit).not_to eq(10)
        user = described_class.new(projects_limit: 10)
        expect(user.projects_limit).to eq(10)
      end
1148
    end
1149

1150
    context 'when Gitlab::CurrentSettings.user_default_external is true' do
1151 1152 1153 1154 1155
      before do
        stub_application_setting(user_default_external: true)
      end

      it "creates external user by default" do
1156
        user = create(:user)
1157 1158

        expect(user.external).to be_truthy
1159 1160
        expect(user.can_create_group).to be_falsey
        expect(user.projects_limit).to be 0
1161 1162 1163 1164
      end

      describe 'with default overrides' do
        it "creates a non-external user" do
1165
          user = create(:user, external: false)
1166 1167 1168 1169 1170

          expect(user.external).to be_falsey
        end
      end
    end
1171

1172
    describe '#require_ssh_key?', :use_clean_rails_memory_store_caching do
1173 1174 1175
      protocol_and_expectation = {
        'http' => false,
        'ssh' => true,
1176
        '' => true
1177 1178 1179 1180 1181 1182 1183 1184 1185
      }

      protocol_and_expectation.each do |protocol, expected|
        it "has correct require_ssh_key?" do
          stub_application_setting(enabled_git_access_protocol: protocol)
          user = build(:user)

          expect(user.require_ssh_key?).to eq(expected)
        end
1186
      end
1187 1188 1189 1190 1191 1192

      it 'returns false when the user has 1 or more SSH keys' do
        key = create(:personal_key)

        expect(key.user.require_ssh_key?).to eq(false)
      end
1193
    end
1194
  end
1195

1196 1197 1198 1199 1200 1201 1202 1203
  describe '.find_for_database_authentication' do
    it 'strips whitespace from login' do
      user = create(:user)

      expect(described_class.find_for_database_authentication({ login: " #{user.username} " })).to eq user
    end
  end

1204
  describe '.find_by_any_email' do
1205 1206 1207 1208 1209 1210 1211 1212
    it 'finds user through private commit email' do
      user = create(:user)
      private_email = user.private_commit_email

      expect(described_class.find_by_any_email(private_email)).to eq(user)
      expect(described_class.find_by_any_email(private_email, confirmed: true)).to eq(user)
    end

1213 1214 1215
    it 'finds by primary email' do
      user = create(:user, email: 'foo@example.com')

1216
      expect(described_class.find_by_any_email(user.email)).to eq user
1217
      expect(described_class.find_by_any_email(user.email, confirmed: true)).to eq user
1218 1219
    end

1220 1221 1222 1223 1224 1225 1226
    it 'finds by uppercased email' do
      user = create(:user, email: 'foo@example.com')

      expect(described_class.find_by_any_email(user.email.upcase)).to eq user
      expect(described_class.find_by_any_email(user.email.upcase, confirmed: true)).to eq user
    end

1227 1228
    context 'finds by secondary email' do
      let(:user) { email.user }
1229

1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258
      context 'primary email confirmed' do
        context 'secondary email confirmed' do
          let!(:email) { create(:email, :confirmed, email: 'foo@example.com') }

          it 'finds user respecting the confirmed flag' do
            expect(described_class.find_by_any_email(email.email)).to eq user
            expect(described_class.find_by_any_email(email.email, confirmed: true)).to eq user
          end
        end

        context 'secondary email not confirmed' do
          let!(:email) { create(:email, email: 'foo@example.com') }

          it 'finds user respecting the confirmed flag' do
            expect(described_class.find_by_any_email(email.email)).to eq user
            expect(described_class.find_by_any_email(email.email, confirmed: true)).to be_nil
          end
        end
      end

      context 'primary email not confirmed' do
        let(:user) { create(:user, confirmed_at: nil) }
        let!(:email) { create(:email, :confirmed, user: user, email: 'foo@example.com') }

        it 'finds user respecting the confirmed flag' do
          expect(described_class.find_by_any_email(email.email)).to eq user
          expect(described_class.find_by_any_email(email.email, confirmed: true)).to be_nil
        end
      end
1259 1260 1261
    end

    it 'returns nil when nothing found' do
1262
      expect(described_class.find_by_any_email('')).to be_nil
1263
    end
1264 1265 1266 1267 1268 1269 1270

    it 'returns nil when user is not confirmed' do
      user = create(:user, email: 'foo@example.com', confirmed_at: nil)

      expect(described_class.find_by_any_email(user.email, confirmed: false)).to eq(user)
      expect(described_class.find_by_any_email(user.email, confirmed: true)).to be_nil
    end
1271 1272
  end

1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283
  describe '.by_any_email' do
    it 'returns an ActiveRecord::Relation' do
      expect(described_class.by_any_email('foo@example.com'))
        .to be_a_kind_of(ActiveRecord::Relation)
    end

    it 'returns a relation of users' do
      user = create(:user)

      expect(described_class.by_any_email(user.email)).to eq([user])
    end
1284 1285 1286 1287 1288 1289

    it 'returns a relation of users for confirmed users' do
      user = create(:user)

      expect(described_class.by_any_email(user.email, confirmed: true)).to eq([user])
    end
1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305

    it 'finds user through a private commit email' do
      user = create(:user)
      private_email = user.private_commit_email

      expect(described_class.by_any_email(private_email)).to eq([user])
      expect(described_class.by_any_email(private_email, confirmed: true)).to eq([user])
    end

    it 'finds user through a private commit email in an array' do
      user = create(:user)
      private_email = user.private_commit_email

      expect(described_class.by_any_email([private_email])).to eq([user])
      expect(described_class.by_any_email([private_email], confirmed: true)).to eq([user])
    end
1306 1307
  end

1308
  describe '.search' do
1309 1310
    let!(:user) { create(:user, name: 'user', username: 'usern', email: 'email@gmail.com') }
    let!(:user2) { create(:user, name: 'user name', username: 'username', email: 'someemail@gmail.com') }
1311
    let!(:user3) { create(:user, name: 'us', username: 'se', email: 'foo@gmail.com') }
1312

1313 1314 1315 1316
    describe 'name matching' do
      it 'returns users with a matching name with exact match first' do
        expect(described_class.search(user.name)).to eq([user, user2])
      end
1317

1318
      it 'returns users with a partially matching name' do
1319
        expect(described_class.search(user.name[0..2])).to eq([user, user2])
1320
      end
1321

1322 1323 1324
      it 'returns users with a matching name regardless of the casing' do
        expect(described_class.search(user2.name.upcase)).to eq([user2])
      end
1325 1326 1327 1328 1329 1330 1331 1332

      it 'returns users with a exact matching name shorter than 3 chars' do
        expect(described_class.search(user3.name)).to eq([user3])
      end

      it 'returns users with a exact matching name shorter than 3 chars regardless of the casing' do
        expect(described_class.search(user3.name.upcase)).to eq([user3])
      end
1333 1334
    end

1335 1336
    describe 'email matching' do
      it 'returns users with a matching Email' do
1337
        expect(described_class.search(user.email)).to eq([user])
1338
      end
1339

1340 1341
      it 'does not return users with a partially matching Email' do
        expect(described_class.search(user.email[0..2])).not_to include(user, user2)
1342
      end
1343

1344 1345 1346
      it 'returns users with a matching Email regardless of the casing' do
        expect(described_class.search(user2.email.upcase)).to eq([user2])
      end
1347 1348
    end

1349 1350 1351 1352
    describe 'username matching' do
      it 'returns users with a matching username' do
        expect(described_class.search(user.username)).to eq([user, user2])
      end
1353

1354
      it 'returns users with a partially matching username' do
1355
        expect(described_class.search(user.username[0..2])).to eq([user, user2])
1356
      end
1357

1358 1359 1360
      it 'returns users with a matching username regardless of the casing' do
        expect(described_class.search(user2.username.upcase)).to eq([user2])
      end
1361 1362 1363 1364 1365 1366 1367 1368

      it 'returns users with a exact matching username shorter than 3 chars' do
        expect(described_class.search(user3.username)).to eq([user3])
      end

      it 'returns users with a exact matching username shorter than 3 chars regardless of the casing' do
        expect(described_class.search(user3.username.upcase)).to eq([user3])
      end
1369
    end
1370 1371 1372 1373 1374 1375 1376 1377

    it 'returns no matches for an empty string' do
      expect(described_class.search('')).to be_empty
    end

    it 'returns no matches for nil' do
      expect(described_class.search(nil)).to be_empty
    end
1378 1379 1380
  end

  describe '.search_with_secondary_emails' do
Douwe Maan's avatar
Douwe Maan committed
1381
    delegate :search_with_secondary_emails, to: :described_class
1382

1383 1384
    let!(:user) { create(:user, name: 'John Doe', username: 'john.doe', email: 'john.doe@example.com' ) }
    let!(:another_user) { create(:user, name: 'Albert Smith', username: 'albert.smith', email: 'albert.smith@example.com' ) }
1385 1386 1387
    let!(:email) do
      create(:email, user: another_user, email: 'alias@example.com')
    end
1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404

    it 'returns users with a matching name' do
      expect(search_with_secondary_emails(user.name)).to eq([user])
    end

    it 'returns users with a partially matching name' do
      expect(search_with_secondary_emails(user.name[0..2])).to eq([user])
    end

    it 'returns users with a matching name regardless of the casing' do
      expect(search_with_secondary_emails(user.name.upcase)).to eq([user])
    end

    it 'returns users with a matching email' do
      expect(search_with_secondary_emails(user.email)).to eq([user])
    end

1405 1406
    it 'does not return users with a partially matching email' do
      expect(search_with_secondary_emails(user.email[0..2])).not_to include([user])
1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428
    end

    it 'returns users with a matching email regardless of the casing' do
      expect(search_with_secondary_emails(user.email.upcase)).to eq([user])
    end

    it 'returns users with a matching username' do
      expect(search_with_secondary_emails(user.username)).to eq([user])
    end

    it 'returns users with a partially matching username' do
      expect(search_with_secondary_emails(user.username[0..2])).to eq([user])
    end

    it 'returns users with a matching username regardless of the casing' do
      expect(search_with_secondary_emails(user.username.upcase)).to eq([user])
    end

    it 'returns users with a matching whole secondary email' do
      expect(search_with_secondary_emails(email.email)).to eq([email.user])
    end

1429 1430
    it 'does not return users with a matching part of secondary email' do
      expect(search_with_secondary_emails(email.email[1..4])).not_to include([email.user])
1431
    end
1432 1433 1434 1435 1436 1437 1438 1439

    it 'returns no matches for an empty string' do
      expect(search_with_secondary_emails('')).to be_empty
    end

    it 'returns no matches for nil' do
      expect(search_with_secondary_emails(nil)).to be_empty
    end
1440 1441
  end

1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458
  describe '.find_by_ssh_key_id' do
    context 'using an existing SSH key ID' do
      let(:user) { create(:user) }
      let(:key) { create(:key, user: user) }

      it 'returns the corresponding User' do
        expect(described_class.find_by_ssh_key_id(key.id)).to eq(user)
      end
    end

    context 'using an invalid SSH key ID' do
      it 'returns nil' do
        expect(described_class.find_by_ssh_key_id(-1)).to be_nil
      end
    end
  end

1459 1460 1461 1462
  describe '.by_login' do
    let(:username) { 'John' }
    let!(:user) { create(:user, username: username) }

1463
    it 'gets the correct user' do
1464 1465 1466 1467 1468 1469
      expect(described_class.by_login(user.email.upcase)).to eq user
      expect(described_class.by_login(user.email)).to eq user
      expect(described_class.by_login(username.downcase)).to eq user
      expect(described_class.by_login(username)).to eq user
      expect(described_class.by_login(nil)).to be_nil
      expect(described_class.by_login('')).to be_nil
1470 1471 1472
    end
  end

1473 1474 1475 1476 1477 1478 1479
  describe '.find_by_username' do
    it 'returns nil if not found' do
      expect(described_class.find_by_username('JohnDoe')).to be_nil
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
1480

1481 1482 1483 1484
      expect(described_class.find_by_username('JOHNDOE')).to eq user
    end
  end

1485 1486
  describe '.find_by_username!' do
    it 'raises RecordNotFound' do
1487 1488
      expect { described_class.find_by_username!('JohnDoe') }
        .to raise_error(ActiveRecord::RecordNotFound)
1489 1490 1491 1492
    end

    it 'is case-insensitive' do
      user = create(:user, username: 'JohnDoe')
1493

1494 1495 1496 1497
      expect(described_class.find_by_username!('JOHNDOE')).to eq user
    end
  end

1498 1499 1500 1501 1502 1503 1504
  describe '.find_by_full_path' do
    let!(:user) { create(:user) }

    context 'with a route matching the given path' do
      let!(:route) { user.namespace.route }

      it 'returns the user' do
1505
        expect(described_class.find_by_full_path(route.path)).to eq(user)
1506 1507 1508
      end

      it 'is case-insensitive' do
1509 1510
        expect(described_class.find_by_full_path(route.path.upcase)).to eq(user)
        expect(described_class.find_by_full_path(route.path.downcase)).to eq(user)
1511 1512 1513 1514 1515 1516 1517 1518
      end
    end

    context 'with a redirect route matching the given path' do
      let!(:redirect_route) { user.namespace.redirect_routes.create(path: 'foo') }

      context 'without the follow_redirects option' do
        it 'returns nil' do
1519
          expect(described_class.find_by_full_path(redirect_route.path)).to eq(nil)
1520 1521 1522 1523 1524
        end
      end

      context 'with the follow_redirects option set to true' do
        it 'returns the user' do
1525
          expect(described_class.find_by_full_path(redirect_route.path, follow_redirects: true)).to eq(user)
1526 1527 1528
        end

        it 'is case-insensitive' do
1529 1530
          expect(described_class.find_by_full_path(redirect_route.path.upcase, follow_redirects: true)).to eq(user)
          expect(described_class.find_by_full_path(redirect_route.path.downcase, follow_redirects: true)).to eq(user)
1531 1532 1533 1534 1535 1536 1537
        end
      end
    end

    context 'without a route or a redirect route matching the given path' do
      context 'without the follow_redirects option' do
        it 'returns nil' do
1538
          expect(described_class.find_by_full_path('unknown')).to eq(nil)
1539 1540 1541 1542
        end
      end
      context 'with the follow_redirects option set to true' do
        it 'returns nil' do
1543
          expect(described_class.find_by_full_path('unknown', follow_redirects: true)).to eq(nil)
1544 1545 1546 1547 1548
        end
      end
    end

    context 'with a group route matching the given path' do
1549 1550
      let!(:group) { create(:group, path: 'group_path') }

Michael Kozono's avatar
Michael Kozono committed
1551
      context 'when the group namespace has an owner_id (legacy data)' do
1552 1553 1554
        before do
          group.update!(owner_id: user.id)
        end
1555

Michael Kozono's avatar
Michael Kozono committed
1556
        it 'returns nil' do
1557
          expect(described_class.find_by_full_path('group_path')).to eq(nil)
Michael Kozono's avatar
Michael Kozono committed
1558 1559 1560 1561 1562
        end
      end

      context 'when the group namespace does not have an owner_id' do
        it 'returns nil' do
1563
          expect(described_class.find_by_full_path('group_path')).to eq(nil)
Michael Kozono's avatar
Michael Kozono committed
1564
        end
1565 1566 1567 1568
      end
    end
  end

1569
  describe 'all_ssh_keys' do
1570
    it { is_expected.to have_many(:keys).dependent(:destroy) }
1571

1572
    it "has all ssh keys" do
1573 1574 1575
      user = create :user
      key = create :key, key: "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD33bWLBxu48Sev9Fert1yzEO4WGcWglWF7K/AwblIUFselOt/QdOL9DSjpQGxLagO1s9wl53STIO8qGS4Ms0EJZyIXOEFMjFJ5xmjSy+S37By4sG7SsltQEHMxtbtFOaW5LV2wCrX+rUsRNqLMamZjgjcPO0/EgGCXIGMAYW4O7cwGZdXWYIhQ1Vwy+CsVMDdPkPgBXqK7nR/ey8KMs8ho5fMNgB5hBw/AL9fNGhRw3QTD6Q12Nkhl4VZES2EsZqlpNnJttnPdp847DUsT6yuLRlfiQfz5Cn9ysHFdXObMN5VYIiPFwHeYCZp1X2S4fDZooRE8uOLTfxWHPXwrhqSH", user_id: user.id

1576
      expect(user.all_ssh_keys).to include(a_string_starting_with(key.key))
1577
    end
1578
  end
1579

1580
  describe '#avatar_type' do
1581 1582
    let(:user) { create(:user) }

1583
    it 'is true if avatar is image' do
1584
      user.update_attribute(:avatar, 'uploads/avatar.png')
1585

1586
      expect(user.avatar_type).to be_truthy
1587 1588
    end

1589
    it 'is false if avatar is html page' do
1590
      user.update_attribute(:avatar, 'uploads/avatar.html')
1591

1592
      expect(user.avatar_type).to eq(['file format is not supported. Please try one of the following supported formats: png, jpg, jpeg, gif, bmp, tiff, ico'])
1593 1594
    end
  end
Jerome Dalbert's avatar
Jerome Dalbert committed
1595

1596 1597 1598 1599
  describe '#avatar_url' do
    let(:user) { create(:user, :with_avatar) }

    context 'when avatar file is uploaded' do
1600
      it 'shows correct avatar url' do
1601 1602
        expect(user.avatar_url).to eq(user.avatar.url)
        expect(user.avatar_url(only_path: false)).to eq([Gitlab.config.gitlab.url, user.avatar.url].join)
1603
      end
1604 1605 1606
    end
  end

1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624
  describe '#accept_pending_invitations!' do
    let(:user) { create(:user, email: 'user@email.com') }
    let!(:project_member_invite) { create(:project_member, :invited, invite_email: user.email) }
    let!(:group_member_invite) { create(:group_member, :invited, invite_email: user.email) }
    let!(:external_project_member_invite) { create(:project_member, :invited, invite_email: 'external@email.com') }
    let!(:external_group_member_invite) { create(:group_member, :invited, invite_email: 'external@email.com') }

    it 'accepts all the user members pending invitations and returns the accepted_members' do
      accepted_members = user.accept_pending_invitations!

      expect(accepted_members).to match_array([project_member_invite, group_member_invite])
      expect(group_member_invite.reload).not_to be_invite
      expect(project_member_invite.reload).not_to be_invite
      expect(external_project_member_invite.reload).to be_invite
      expect(external_group_member_invite.reload).to be_invite
    end
  end

1625 1626 1627 1628 1629 1630 1631
  describe '#all_emails' do
    let(:user) { create(:user) }

    it 'returns all emails' do
      email_confirmed   = create :email, user: user, confirmed_at: Time.now
      email_unconfirmed = create :email, user: user
      user.reload
1632

1633 1634 1635 1636 1637 1638
      expect(user.all_emails).to contain_exactly(
        user.email,
        user.private_commit_email,
        email_unconfirmed.email,
        email_confirmed.email
      )
1639 1640 1641
    end
  end

1642
  describe '#verified_emails' do
1643 1644 1645
    let(:user) { create(:user) }

    it 'returns only confirmed emails' do
Brett Walker's avatar
Brett Walker committed
1646 1647
      email_confirmed = create :email, user: user, confirmed_at: Time.now
      create :email, user: user
1648

1649 1650 1651 1652 1653
      expect(user.verified_emails).to contain_exactly(
        user.email,
        user.private_commit_email,
        email_confirmed.email
      )
1654 1655 1656 1657 1658 1659 1660
    end
  end

  describe '#verified_email?' do
    let(:user) { create(:user) }

    it 'returns true when the email is verified/confirmed' do
Brett Walker's avatar
Brett Walker committed
1661 1662
      email_confirmed = create :email, user: user, confirmed_at: Time.now
      create :email, user: user
1663 1664 1665
      user.reload

      expect(user.verified_email?(user.email)).to be_truthy
1666
      expect(user.verified_email?(email_confirmed.email.titlecase)).to be_truthy
1667 1668
    end

1669 1670 1671 1672
    it 'returns true when user is found through private commit email' do
      expect(user.verified_email?(user.private_commit_email)).to be_truthy
    end

1673 1674 1675 1676 1677 1678 1679 1680
    it 'returns true for an outdated private commit email' do
      old_email = user.private_commit_email

      user.update!(username: 'changed-username')

      expect(user.verified_email?(old_email)).to be_truthy
    end

1681 1682 1683 1684 1685 1686 1687 1688
    it 'returns false when the email is not verified/confirmed' do
      email_unconfirmed = create :email, user: user
      user.reload

      expect(user.verified_email?(email_unconfirmed.email)).to be_falsy
    end
  end

1689
  describe '#requires_ldap_check?' do
1690
    let(:user) { described_class.new }
1691

1692 1693
    it 'is false when LDAP is disabled' do
      # Create a condition which would otherwise cause 'true' to be returned
1694
      allow(user).to receive(:ldap_user?).and_return(true)
1695
      user.last_credential_check_at = nil
1696

1697
      expect(user.requires_ldap_check?).to be_falsey
1698 1699
    end

1700
    context 'when LDAP is enabled' do
1701 1702 1703
      before do
        allow(Gitlab.config.ldap).to receive(:enabled).and_return(true)
      end
1704

1705
      it 'is false for non-LDAP users' do
1706
        allow(user).to receive(:ldap_user?).and_return(false)
1707

1708
        expect(user.requires_ldap_check?).to be_falsey
1709 1710
      end

1711
      context 'and when the user is an LDAP user' do
1712 1713 1714
        before do
          allow(user).to receive(:ldap_user?).and_return(true)
        end
1715 1716 1717

        it 'is true when the user has never had an LDAP check before' do
          user.last_credential_check_at = nil
1718

1719
          expect(user.requires_ldap_check?).to be_truthy
1720 1721 1722 1723
        end

        it 'is true when the last LDAP check happened over 1 hour ago' do
          user.last_credential_check_at = 2.hours.ago
1724

1725
          expect(user.requires_ldap_check?).to be_truthy
1726
        end
1727 1728 1729 1730
      end
    end
  end

1731
  context 'ldap synchronized user' do
1732
    describe '#ldap_user?' do
1733 1734
      it 'is true if provider name starts with ldap' do
        user = create(:omniauth_user, provider: 'ldapmain')
1735

1736 1737
        expect(user.ldap_user?).to be_truthy
      end
1738

1739 1740
      it 'is false for other providers' do
        user = create(:omniauth_user, provider: 'other-provider')
1741

1742 1743 1744 1745 1746
        expect(user.ldap_user?).to be_falsey
      end

      it 'is false if no extern_uid is provided' do
        user = create(:omniauth_user, extern_uid: nil)
1747

1748 1749
        expect(user.ldap_user?).to be_falsey
      end
1750 1751
    end

1752
    describe '#ldap_identity' do
1753 1754
      it 'returns ldap identity' do
        user = create :omniauth_user
1755

1756 1757
        expect(user.ldap_identity.provider).not_to be_empty
      end
1758 1759
    end

1760 1761 1762 1763 1764
    describe '#ldap_block' do
      let(:user) { create(:omniauth_user, provider: 'ldapmain', name: 'John Smith') }

      it 'blocks user flaging the action caming from ldap' do
        user.ldap_block
1765

1766 1767 1768
        expect(user.blocked?).to be_truthy
        expect(user.ldap_blocked?).to be_truthy
      end
1769 1770 1771
    end
  end

Jerome Dalbert's avatar
Jerome Dalbert committed
1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810
  describe '#full_website_url' do
    let(:user) { create(:user) }

    it 'begins with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.full_website_url).to eq 'http://test.com'
    end

    it 'begins with https if website url begins with https' do
      user.website_url = 'https://test.com'

      expect(user.full_website_url).to eq 'https://test.com'
    end
  end

  describe '#short_website_url' do
    let(:user) { create(:user) }

    it 'does not begin with http if website url omits it' do
      user.website_url = 'test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with http if website url begins with http' do
      user.website_url = 'http://test.com'

      expect(user.short_website_url).to eq 'test.com'
    end

    it 'does not begin with https if website url begins with https' do
      user.website_url = 'https://test.com'
1811

Jerome Dalbert's avatar
Jerome Dalbert committed
1812 1813
      expect(user.short_website_url).to eq 'test.com'
    end
1814
  end
Ciro Santilli's avatar
Ciro Santilli committed
1815

1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827
  describe '#sanitize_attrs' do
    let(:user) { build(:user, name: 'test & user', skype: 'test&user') }

    it 'encodes HTML entities in the Skype attribute' do
      expect { user.sanitize_attrs }.to change { user.skype }.to('test&amp;user')
    end

    it 'does not encode HTML entities in the name attribute' do
      expect { user.sanitize_attrs }.not_to change { user.name }
    end
  end

1828 1829
  describe '#starred?' do
    it 'determines if user starred a project' do
1830
      user = create :user
1831 1832
      project1 = create(:project, :public)
      project2 = create(:project, :public)
1833

1834 1835
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
1836 1837

      star1 = UsersStarProject.create!(project: project1, user: user)
1838

1839 1840
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_falsey
1841 1842

      star2 = UsersStarProject.create!(project: project2, user: user)
1843

1844 1845
      expect(user.starred?(project1)).to be_truthy
      expect(user.starred?(project2)).to be_truthy
1846 1847

      star1.destroy
1848

1849 1850
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_truthy
1851 1852

      star2.destroy
1853

1854 1855
      expect(user.starred?(project1)).to be_falsey
      expect(user.starred?(project2)).to be_falsey
1856 1857 1858
    end
  end

1859 1860
  describe '#toggle_star' do
    it 'toggles stars' do
Ciro Santilli's avatar
Ciro Santilli committed
1861
      user = create :user
1862
      project = create(:project, :public)
Ciro Santilli's avatar
Ciro Santilli committed
1863

1864
      expect(user.starred?(project)).to be_falsey
1865

Ciro Santilli's avatar
Ciro Santilli committed
1866
      user.toggle_star(project)
1867

1868
      expect(user.starred?(project)).to be_truthy
1869

Ciro Santilli's avatar
Ciro Santilli committed
1870
      user.toggle_star(project)
1871

1872
      expect(user.starred?(project)).to be_falsey
Ciro Santilli's avatar
Ciro Santilli committed
1873 1874
    end
  end
Valery Sizov's avatar
Valery Sizov committed
1875

1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893
  describe '.find_by_private_commit_email' do
    context 'with email' do
      set(:user) { create(:user) }

      it 'returns user through private commit email' do
        expect(described_class.find_by_private_commit_email(user.private_commit_email)).to eq(user)
      end

      it 'returns nil when email other than private_commit_email is used' do
        expect(described_class.find_by_private_commit_email(user.email)).to be_nil
      end
    end

    it 'returns nil when email is nil' do
      expect(described_class.find_by_private_commit_email(nil)).to be_nil
    end
  end

1894
  describe '#sort_by_attribute' do
Valery Sizov's avatar
Valery Sizov committed
1895
    before do
1896
      described_class.delete_all
1897 1898 1899
      @user = create :user, created_at: Date.today, current_sign_in_at: Date.today, name: 'Alpha'
      @user1 = create :user, created_at: Date.today - 1, current_sign_in_at: Date.today - 1, name: 'Omega'
      @user2 = create :user, created_at: Date.today - 2, name: 'Beta'
Valery Sizov's avatar
Valery Sizov committed
1900
    end
1901

1902
    context 'when sort by recent_sign_in' do
1903
      let(:users) { described_class.sort_by_attribute('recent_sign_in') }
1904 1905 1906 1907

      it 'sorts users by recent sign-in time' do
        expect(users.first).to eq(@user)
        expect(users.second).to eq(@user1)
1908 1909 1910
      end

      it 'pushes users who never signed in to the end' do
1911
        expect(users.third).to eq(@user2)
1912
      end
Valery Sizov's avatar
Valery Sizov committed
1913 1914
    end

1915
    context 'when sort by oldest_sign_in' do
1916
      let(:users) { described_class.sort_by_attribute('oldest_sign_in') }
1917

1918
      it 'sorts users by the oldest sign-in time' do
1919 1920
        expect(users.first).to eq(@user1)
        expect(users.second).to eq(@user)
1921 1922 1923
      end

      it 'pushes users who never signed in to the end' do
1924
        expect(users.third).to eq(@user2)
1925
      end
Valery Sizov's avatar
Valery Sizov committed
1926 1927
    end

1928
    it 'sorts users in descending order by their creation time' do
1929
      expect(described_class.sort_by_attribute('created_desc').first).to eq(@user)
Valery Sizov's avatar
Valery Sizov committed
1930 1931
    end

1932
    it 'sorts users in ascending order by their creation time' do
1933
      expect(described_class.sort_by_attribute('created_asc').first).to eq(@user2)
Valery Sizov's avatar
Valery Sizov committed
1934 1935
    end

1936
    it 'sorts users by id in descending order when nil is passed' do
1937
      expect(described_class.sort_by_attribute(nil).first).to eq(@user2)
Valery Sizov's avatar
Valery Sizov committed
1938 1939
    end
  end
1940

1941
  describe "#contributed_projects" do
1942
    subject { create(:user) }
1943
    let!(:project1) { create(:project) }
1944
    let!(:project2) { fork_project(project3) }
1945
    let!(:project3) { create(:project) }
1946
    let!(:merge_request) { create(:merge_request, source_project: project2, target_project: project3, author: subject) }
1947
    let!(:push_event) { create(:push_event, project: project1, author: subject) }
1948
    let!(:merge_event) { create(:event, :created, project: project3, target: merge_request, author: subject) }
1949 1950

    before do
1951 1952
      project1.add_maintainer(subject)
      project2.add_maintainer(subject)
1953 1954 1955
    end

    it "includes IDs for projects the user has pushed to" do
1956
      expect(subject.contributed_projects).to include(project1)
1957 1958 1959
    end

    it "includes IDs for projects the user has had merge requests merged into" do
1960
      expect(subject.contributed_projects).to include(project3)
1961 1962 1963
    end

    it "doesn't include IDs for unrelated projects" do
1964
      expect(subject.contributed_projects).not_to include(project2)
1965 1966
    end
  end
1967

1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984
  describe '#fork_of' do
    let(:user) { create(:user) }

    it "returns a user's fork of a project" do
      project = create(:project, :public)
      user_fork = fork_project(project, user, namespace: user.namespace)

      expect(user.fork_of(project)).to eq(user_fork)
    end

    it 'returns nil if the project does not have a fork network' do
      project = create(:project)

      expect(user.fork_of(project)).to be_nil
    end
  end

1985
  describe '#can_be_removed?' do
1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000
    subject { create(:user) }

    context 'no owned groups' do
      it { expect(subject.can_be_removed?).to be_truthy }
    end

    context 'has owned groups' do
      before do
        group = create(:group)
        group.add_owner(subject)
      end

      it { expect(subject.can_be_removed?).to be_falsey }
    end
  end
2001 2002

  describe "#recent_push" do
2003 2004 2005
    let(:user) { build(:user) }
    let(:project) { build(:project) }
    let(:event) { build(:push_event) }
2006

2007 2008 2009 2010
    it 'returns the last push event for the user' do
      expect_any_instance_of(Users::LastPushEventService)
        .to receive(:last_event_for_user)
        .and_return(event)
2011

2012
      expect(user.recent_push).to eq(event)
2013 2014
    end

2015 2016 2017 2018
    it 'returns the last push event for a project when one is given' do
      expect_any_instance_of(Users::LastPushEventService)
        .to receive(:last_event_for_project)
        .and_return(event)
2019

2020
      expect(user.recent_push(project)).to eq(event)
2021
    end
2022
  end
2023 2024 2025 2026

  describe '#authorized_groups' do
    let!(:user) { create(:user) }
    let!(:private_group) { create(:group) }
2027 2028 2029 2030
    let!(:child_group) { create(:group, parent: private_group) }

    let!(:project_group) { create(:group) }
    let!(:project) { create(:project, group: project_group) }
2031 2032

    before do
2033 2034
      private_group.add_user(user, Gitlab::Access::MAINTAINER)
      project.add_maintainer(user)
2035 2036
    end

2037
    subject { user.authorized_groups }
2038

2039 2040 2041 2042 2043 2044 2045 2046 2047
    it { is_expected.to contain_exactly private_group, project_group }
  end

  describe '#membership_groups' do
    let!(:user) { create(:user) }
    let!(:parent_group) { create(:group) }
    let!(:child_group) { create(:group, parent: parent_group) }

    before do
2048
      parent_group.add_user(user, Gitlab::Access::MAINTAINER)
2049 2050 2051 2052
    end

    subject { user.membership_groups }

2053
    if Group.supports_nested_objects?
2054 2055 2056 2057
      it { is_expected.to contain_exactly parent_group, child_group }
    else
      it { is_expected.to contain_exactly parent_group }
    end
2058 2059
  end

2060 2061 2062 2063 2064 2065
  describe '#authorizations_for_projects' do
    let!(:user) { create(:user) }
    subject { Project.where("EXISTS (?)", user.authorizations_for_projects) }

    it 'includes projects that belong to a user, but no other projects' do
      owned = create(:project, :private, namespace: user.namespace)
2066
      member = create(:project, :private).tap { |p| p.add_maintainer(user) }
2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083
      other = create(:project)

      expect(subject).to include(owned)
      expect(subject).to include(member)
      expect(subject).not_to include(other)
    end

    it 'includes projects a user has access to, but no other projects' do
      other_user = create(:user)
      accessible = create(:project, :private, namespace: other_user.namespace) do |project|
        project.add_developer(user)
      end
      other = create(:project)

      expect(subject).to include(accessible)
      expect(subject).not_to include(other)
    end
2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110

    context 'with min_access_level' do
      let!(:user) { create(:user) }
      let!(:project) { create(:project, :private, namespace: user.namespace) }

      before do
        project.add_developer(user)
      end

      subject { Project.where("EXISTS (?)", user.authorizations_for_projects(min_access_level: min_access_level)) }

      context 'when developer access' do
        let(:min_access_level) { Gitlab::Access::DEVELOPER }

        it 'includes projects a user has access to' do
          expect(subject).to include(project)
        end
      end

      context 'when owner access' do
        let(:min_access_level) { Gitlab::Access::OWNER }

        it 'does not include projects with higher access level' do
          expect(subject).not_to include(project)
        end
      end
    end
2111 2112
  end

2113
  describe '#authorized_projects', :delete do
2114 2115 2116
    context 'with a minimum access level' do
      it 'includes projects for which the user is an owner' do
        user = create(:user)
2117
        project = create(:project, :private, namespace: user.namespace)
2118

2119 2120
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
2121
      end
2122

2123
      it 'includes projects for which the user is a maintainer' do
2124
        user = create(:user)
2125
        project = create(:project, :private)
2126

2127
        project.add_maintainer(user)
2128

2129 2130
        expect(user.authorized_projects(Gitlab::Access::REPORTER))
          .to contain_exactly(project)
2131 2132
      end
    end
2133 2134 2135

    it "includes user's personal projects" do
      user    = create(:user)
2136
      project = create(:project, :private, namespace: user.namespace)
2137 2138 2139 2140 2141 2142 2143

      expect(user.authorized_projects).to include(project)
    end

    it "includes personal projects user has been given access to" do
      user1   = create(:user)
      user2   = create(:user)
2144
      project = create(:project, :private, namespace: user1.namespace)
2145

2146
      project.add_developer(user2)
2147 2148 2149 2150 2151 2152

      expect(user2.authorized_projects).to include(project)
    end

    it "includes projects of groups user has been added to" do
      group   = create(:group)
2153
      project = create(:project, group: group)
2154 2155 2156 2157 2158 2159 2160 2161 2162
      user    = create(:user)

      group.add_developer(user)

      expect(user.authorized_projects).to include(project)
    end

    it "does not include projects of groups user has been removed from" do
      group   = create(:group)
2163
      project = create(:project, group: group)
2164 2165 2166
      user    = create(:user)

      member = group.add_developer(user)
2167

2168 2169 2170
      expect(user.authorized_projects).to include(project)

      member.destroy
2171

2172 2173 2174 2175 2176
      expect(user.authorized_projects).not_to include(project)
    end

    it "includes projects shared with user's group" do
      user    = create(:user)
2177
      project = create(:project, :private)
2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188
      group   = create(:group)

      group.add_reporter(user)
      project.project_group_links.create(group: group)

      expect(user.authorized_projects).to include(project)
    end

    it "does not include destroyed projects user had access to" do
      user1   = create(:user)
      user2   = create(:user)
2189
      project = create(:project, :private, namespace: user1.namespace)
2190

2191
      project.add_developer(user2)
2192

2193 2194 2195
      expect(user2.authorized_projects).to include(project)

      project.destroy
2196

2197 2198 2199 2200 2201
      expect(user2.authorized_projects).not_to include(project)
    end

    it "does not include projects of destroyed groups user had access to" do
      group   = create(:group)
2202
      project = create(:project, namespace: group)
2203 2204 2205
      user    = create(:user)

      group.add_developer(user)
2206

2207 2208 2209
      expect(user.authorized_projects).to include(project)

      group.destroy
2210

2211 2212
      expect(user.authorized_projects).not_to include(project)
    end
2213
  end
2214

2215 2216 2217 2218
  describe '#projects_where_can_admin_issues' do
    let(:user) { create(:user) }

    it 'includes projects for which the user access level is above or equal to reporter' do
2219 2220
      reporter_project  = create(:project) { |p| p.add_reporter(user) }
      developer_project = create(:project) { |p| p.add_developer(user) }
2221
      maintainer_project = create(:project) { |p| p.add_maintainer(user) }
2222

2223 2224
      expect(user.projects_where_can_admin_issues.to_a).to match_array([maintainer_project, developer_project, reporter_project])
      expect(user.can?(:admin_issue, maintainer_project)).to eq(true)
2225 2226 2227 2228 2229
      expect(user.can?(:admin_issue, developer_project)).to eq(true)
      expect(user.can?(:admin_issue, reporter_project)).to eq(true)
    end

    it 'does not include for which the user access level is below reporter' do
2230 2231
      project = create(:project)
      guest_project = create(:project) { |p| p.add_guest(user) }
2232 2233 2234 2235 2236 2237 2238

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, guest_project)).to eq(false)
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include archived projects' do
2239
      project = create(:project, :archived)
2240 2241 2242 2243 2244 2245

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end

    it 'does not include projects for which issues are disabled' do
2246
      project = create(:project, :issues_disabled)
2247 2248 2249 2250 2251 2252

      expect(user.projects_where_can_admin_issues.to_a).to be_empty
      expect(user.can?(:admin_issue, project)).to eq(false)
    end
  end

2253
  describe '#ci_owned_runners' do
2254
    let(:user) { create(:user) }
2255
    let!(:project) { create(:project) }
2256
    let(:runner) { create(:ci_runner, :project, projects: [project]) }
2257

2258
    context 'without any projects nor groups' do
2259
      it 'does not load' do
2260
        expect(user.ci_owned_runners).to be_empty
2261 2262 2263 2264 2265
      end
    end

    context 'with personal projects runners' do
      let(:namespace) { create(:namespace, owner: user) }
2266
      let!(:project) { create(:project, namespace: namespace) }
2267 2268

      it 'loads' do
2269
        expect(user.ci_owned_runners).to contain_exactly(runner)
2270 2271 2272 2273
      end
    end

    context 'with personal group runner' do
2274 2275
      let!(:project) { create(:project) }
      let(:group_runner) { create(:ci_runner, :group, groups: [group]) }
2276
      let!(:group) do
2277
        create(:group).tap do |group|
2278 2279 2280 2281 2282
          group.add_owner(user)
        end
      end

      it 'loads' do
2283
        expect(user.ci_owned_runners).to contain_exactly(group_runner)
2284 2285 2286 2287 2288
      end
    end

    context 'with personal project and group runner' do
      let(:namespace) { create(:namespace, owner: user) }
2289 2290
      let!(:project) { create(:project, namespace: namespace) }
      let!(:group_runner) { create(:ci_runner, :group, groups: [group]) }
2291 2292

      let!(:group) do
2293
        create(:group).tap do |group|
2294 2295 2296 2297 2298
          group.add_owner(user)
        end
      end

      it 'loads' do
2299
        expect(user.ci_owned_runners).to contain_exactly(runner, group_runner)
2300 2301 2302 2303
      end
    end

    shared_examples :member do
2304
      context 'when the user is a maintainer' do
2305
        before do
2306
          add_user(:maintainer)
2307
        end
2308

2309
        it 'loads' do
2310
          expect(user.ci_owned_runners).to contain_exactly(runner)
2311
        end
2312 2313
      end

2314
      context 'when the user is a developer' do
2315
        before do
2316
          add_user(:developer)
2317
        end
2318

2319
        it 'does not load' do
2320
          expect(user.ci_owned_runners).to be_empty
2321
        end
2322 2323 2324 2325 2326
      end
    end

    context 'with groups projects runners' do
      let(:group) { create(:group) }
2327
      let!(:project) { create(:project, group: group) }
2328 2329 2330 2331 2332 2333 2334 2335 2336

      def add_user(access)
        group.add_user(user, access)
      end

      it_behaves_like :member
    end

    context 'with groups runners' do
2337 2338
      let!(:runner) { create(:ci_runner, :group, groups: [group]) }
      let!(:group) { create(:group) }
2339

Lin Jen-Shin's avatar
Lin Jen-Shin committed
2340
      def add_user(access)
2341 2342 2343 2344 2345 2346 2347
        group.add_user(user, access)
      end

      it_behaves_like :member
    end

    context 'with other projects runners' do
2348
      let!(:project) { create(:project) }
2349

Lin Jen-Shin's avatar
Lin Jen-Shin committed
2350
      def add_user(access)
2351
        project.add_role(user, access)
2352 2353 2354 2355
      end

      it_behaves_like :member
    end
2356 2357 2358 2359 2360

    context 'with subgroup with different owner for project runner', :nested_groups do
      let(:group) { create(:group) }
      let(:another_user) { create(:user) }
      let(:subgroup) { create(:group, parent: group) }
2361
      let!(:project) { create(:project, group: subgroup) }
2362 2363 2364 2365 2366 2367 2368 2369 2370

      def add_user(access)
        group.add_user(user, access)
        group.add_user(another_user, :owner)
        subgroup.add_user(another_user, :owner)
      end

      it_behaves_like :member
    end
2371 2372
  end

2373
  describe '#projects_with_reporter_access_limited_to' do
2374 2375
    let(:project1) { create(:project) }
    let(:project2) { create(:project) }
2376 2377 2378
    let(:user) { create(:user) }

    before do
2379 2380
      project1.add_reporter(user)
      project2.add_guest(user)
2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395
    end

    it 'returns the projects when using a single project ID' do
      projects = user.projects_with_reporter_access_limited_to(project1.id)

      expect(projects).to eq([project1])
    end

    it 'returns the projects when using an Array of project IDs' do
      projects = user.projects_with_reporter_access_limited_to([project1.id])

      expect(projects).to eq([project1])
    end

    it 'returns the projects when using an ActiveRecord relation' do
2396 2397
      projects = user
        .projects_with_reporter_access_limited_to(Project.select(:id))
2398 2399 2400 2401 2402 2403 2404 2405 2406 2407

      expect(projects).to eq([project1])
    end

    it 'does not return projects you do not have reporter access to' do
      projects = user.projects_with_reporter_access_limited_to(project2.id)

      expect(projects).to be_empty
    end
  end
2408

2409 2410
  describe '#all_expanded_groups' do
    # foo/bar would also match foo/barbaz instead of just foo/bar and foo/bar/baz
2411 2412
    let!(:user) { create(:user) }

2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428
    #                group
    #        _______ (foo) _______
    #       |                     |
    #       |                     |
    # nested_group_1        nested_group_2
    # (bar)                 (barbaz)
    #       |                     |
    #       |                     |
    # nested_group_1_1      nested_group_2_1
    # (baz)                 (baz)
    #
    let!(:group) { create :group }
    let!(:nested_group_1) { create :group, parent: group, name: 'bar' }
    let!(:nested_group_1_1) { create :group, parent: nested_group_1, name: 'baz' }
    let!(:nested_group_2) { create :group, parent: group, name: 'barbaz' }
    let!(:nested_group_2_1) { create :group, parent: nested_group_2, name: 'baz' }
2429

2430 2431 2432 2433 2434 2435
    subject { user.all_expanded_groups }

    context 'user is not a member of any group' do
      it 'returns an empty array' do
        is_expected.to eq([])
      end
2436 2437
    end

2438 2439
    context 'user is member of all groups' do
      before do
2440 2441 2442 2443 2444
        group.add_reporter(user)
        nested_group_1.add_developer(user)
        nested_group_1_1.add_maintainer(user)
        nested_group_2.add_developer(user)
        nested_group_2_1.add_maintainer(user)
2445
      end
2446

2447 2448 2449 2450 2451 2452 2453 2454
      it 'returns all groups' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1,
          nested_group_2, nested_group_2_1
        ]
      end
    end
2455

2456
    context 'user is member of the top group' do
2457 2458 2459
      before do
        group.add_owner(user)
      end
2460

2461
      if Group.supports_nested_objects?
2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474
        it 'returns all groups' do
          is_expected.to match_array [
            group,
            nested_group_1, nested_group_1_1,
            nested_group_2, nested_group_2_1
          ]
        end
      else
        it 'returns the top-level groups' do
          is_expected.to match_array [group]
        end
      end
    end
2475

2476
    context 'user is member of the first child (internal node), branch 1', :nested_groups do
2477 2478 2479
      before do
        nested_group_1.add_owner(user)
      end
2480

2481 2482 2483 2484 2485 2486 2487 2488 2489
      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1
        ]
      end
    end

    context 'user is member of the first child (internal node), branch 2', :nested_groups do
2490 2491 2492
      before do
        nested_group_2.add_owner(user)
      end
2493

2494 2495 2496 2497 2498 2499
      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_2, nested_group_2_1
        ]
      end
2500 2501
    end

2502
    context 'user is member of the last child (leaf node)', :nested_groups do
2503 2504 2505
      before do
        nested_group_1_1.add_owner(user)
      end
2506 2507 2508 2509 2510 2511 2512 2513

      it 'returns the groups in the hierarchy' do
        is_expected.to match_array [
          group,
          nested_group_1, nested_group_1_1
        ]
      end
    end
2514 2515
  end

2516
  describe '#refresh_authorized_projects', :clean_gitlab_redis_shared_state do
2517 2518
    let(:project1) { create(:project) }
    let(:project2) { create(:project) }
2519 2520 2521
    let(:user) { create(:user) }

    before do
2522 2523
      project1.add_reporter(user)
      project2.add_guest(user)
2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537

      user.project_authorizations.delete_all
      user.refresh_authorized_projects
    end

    it 'refreshes the list of authorized projects' do
      expect(user.project_authorizations.count).to eq(2)
    end

    it 'stores the correct access levels' do
      expect(user.project_authorizations.where(access_level: Gitlab::Access::GUEST).exists?).to eq(true)
      expect(user.project_authorizations.where(access_level: Gitlab::Access::REPORTER).exists?).to eq(true)
    end
  end
Douwe Maan's avatar
Douwe Maan committed
2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570

  describe '#access_level=' do
    let(:user) { build(:user) }

    it 'does nothing for an invalid access level' do
      user.access_level = :invalid_access_level

      expect(user.access_level).to eq(:regular)
      expect(user.admin).to be false
    end

    it "assigns the 'admin' access level" do
      user.access_level = :admin

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end

    it "doesn't clear existing access levels when an invalid access level is passed in" do
      user.access_level = :admin
      user.access_level = :invalid_access_level

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end

    it "accepts string values in addition to symbols" do
      user.access_level = 'admin'

      expect(user.access_level).to eq(:admin)
      expect(user.admin).to be true
    end
  end
2571

2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585
  describe '#full_private_access?' do
    it 'returns false for regular user' do
      user = build(:user)

      expect(user.full_private_access?).to be_falsy
    end

    it 'returns true for admin user' do
      user = build(:user, :admin)

      expect(user.full_private_access?).to be_truthy
    end
  end

2586 2587
  describe '.ghost' do
    it "creates a ghost user if one isn't already present" do
2588
      ghost = described_class.ghost
2589 2590 2591

      expect(ghost).to be_ghost
      expect(ghost).to be_persisted
2592 2593
      expect(ghost.namespace).not_to be_nil
      expect(ghost.namespace).to be_persisted
2594 2595 2596 2597
    end

    it "does not create a second ghost user if one is already present" do
      expect do
2598 2599 2600 2601
        described_class.ghost
        described_class.ghost
      end.to change { described_class.count }.by(1)
      expect(described_class.ghost).to eq(described_class.ghost)
2602 2603 2604 2605 2606
    end

    context "when a regular user exists with the username 'ghost'" do
      it "creates a ghost user with a non-conflicting username" do
        create(:user, username: 'ghost')
2607
        ghost = described_class.ghost
2608 2609

        expect(ghost).to be_persisted
2610
        expect(ghost.username).to eq('ghost1')
2611 2612 2613 2614 2615 2616
      end
    end

    context "when a regular user exists with the email 'ghost@example.com'" do
      it "creates a ghost user with a non-conflicting email" do
        create(:user, email: 'ghost@example.com')
2617
        ghost = described_class.ghost
2618 2619

        expect(ghost).to be_persisted
2620
        expect(ghost.email).to eq('ghost1@example.com')
2621 2622
      end
    end
2623 2624 2625 2626 2627 2628 2629

    context 'when a domain whitelist is in place' do
      before do
        stub_application_setting(domain_whitelist: ['gitlab.com'])
      end

      it 'creates a ghost user' do
2630
        expect(described_class.ghost).to be_persisted
2631 2632
      end
    end
2633
  end
2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649

  describe '#update_two_factor_requirement' do
    let(:user) { create :user }

    context 'with 2FA requirement on groups' do
      let(:group1) { create :group, require_two_factor_authentication: true, two_factor_grace_period: 23 }
      let(:group2) { create :group, require_two_factor_authentication: true, two_factor_grace_period: 32 }

      before do
        group1.add_user(user, GroupMember::OWNER)
        group2.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
2650
        expect(user.require_two_factor_authentication_from_group).to be true
2651 2652 2653 2654 2655 2656 2657
      end

      it 'uses the shortest grace period' do
        expect(user.two_factor_grace_period).to be 23
      end
    end

2658
    context 'with 2FA requirement from expanded groups', :nested_groups do
2659
      let!(:group1) { create :group, require_two_factor_authentication: true }
2660
      let!(:group1a) { create :group, parent: group1 }
2661 2662 2663 2664 2665 2666 2667 2668

      before do
        group1a.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
2669
        expect(user.require_two_factor_authentication_from_group).to be true
2670 2671 2672
      end
    end

2673
    context 'with 2FA requirement on nested child group', :nested_groups do
2674 2675 2676 2677 2678 2679 2680 2681 2682 2683
      let!(:group1) { create :group, require_two_factor_authentication: false }
      let!(:group1a) { create :group, require_two_factor_authentication: true, parent: group1 }

      before do
        group1.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'requires 2FA' do
2684
        expect(user.require_two_factor_authentication_from_group).to be true
2685 2686 2687
      end
    end

2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708
    context "with 2FA requirement from shared project's group" do
      let!(:group1) { create :group, require_two_factor_authentication: true }
      let!(:group2) { create :group }
      let(:shared_project) { create(:project, namespace: group1) }

      before do
        shared_project.project_group_links.create!(
          group: group2,
          group_access: ProjectGroupLink.default_access
        )

        group2.add_user(user, GroupMember::OWNER)
      end

      it 'does not require 2FA' do
        user.update_two_factor_requirement

        expect(user.require_two_factor_authentication_from_group).to be false
      end
    end

2709 2710 2711 2712 2713 2714 2715 2716 2717 2718
    context 'without 2FA requirement on groups' do
      let(:group) { create :group }

      before do
        group.add_user(user, GroupMember::OWNER)

        user.update_two_factor_requirement
      end

      it 'does not require 2FA' do
2719
        expect(user.require_two_factor_authentication_from_group).to be false
2720 2721 2722 2723 2724 2725 2726
      end

      it 'falls back to the default grace period' do
        expect(user.two_factor_grace_period).to be 48
      end
    end
  end
James Lopez's avatar
James Lopez committed
2727 2728 2729

  context '.active' do
    before do
2730
      described_class.ghost
James Lopez's avatar
James Lopez committed
2731 2732 2733 2734 2735
      create(:user, name: 'user', state: 'active')
      create(:user, name: 'user', state: 'blocked')
    end

    it 'only counts active and non internal users' do
2736
      expect(described_class.active.count).to eq(1)
James Lopez's avatar
James Lopez committed
2737 2738
    end
  end
2739 2740 2741 2742 2743 2744 2745 2746

  describe 'preferred language' do
    it 'is English by default' do
      user = create(:user)

      expect(user.preferred_language).to eq('en')
    end
  end
2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774

  context '#invalidate_issue_cache_counts' do
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for issue counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'assigned_open_issues_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_issue_cache_counts
    end
  end

  context '#invalidate_merge_request_cache_counts' do
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for Merge Request counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'assigned_open_merge_requests_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_merge_request_cache_counts
    end
  end
2775

2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789
  context '#invalidate_personal_projects_count' do
    let(:user) { build_stubbed(:user) }

    it 'invalidates cache for personal projects counter' do
      cache_mock = double

      expect(cache_mock).to receive(:delete).with(['users', user.id, 'personal_projects_count'])

      allow(Rails).to receive(:cache).and_return(cache_mock)

      user.invalidate_personal_projects_count
    end
  end

2790
  describe '#allow_password_authentication_for_web?' do
2791 2792 2793
    context 'regular user' do
      let(:user) { build(:user) }

2794 2795
      it 'returns true when password authentication is enabled for the web interface' do
        expect(user.allow_password_authentication_for_web?).to be_truthy
2796 2797
      end

2798 2799
      it 'returns false when password authentication is disabled for the web interface' do
        stub_application_setting(password_authentication_enabled_for_web: false)
2800

2801
        expect(user.allow_password_authentication_for_web?).to be_falsey
2802 2803 2804 2805 2806 2807
      end
    end

    it 'returns false for ldap user' do
      user = create(:omniauth_user, provider: 'ldapmain')

2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830
      expect(user.allow_password_authentication_for_web?).to be_falsey
    end
  end

  describe '#allow_password_authentication_for_git?' do
    context 'regular user' do
      let(:user) { build(:user) }

      it 'returns true when password authentication is enabled for Git' do
        expect(user.allow_password_authentication_for_git?).to be_truthy
      end

      it 'returns false when password authentication is disabled Git' do
        stub_application_setting(password_authentication_enabled_for_git: false)

        expect(user.allow_password_authentication_for_git?).to be_falsey
      end
    end

    it 'returns false for ldap user' do
      user = create(:omniauth_user, provider: 'ldapmain')

      expect(user.allow_password_authentication_for_git?).to be_falsey
2831 2832
    end
  end
2833

2834 2835 2836 2837 2838 2839
  describe '#assigned_open_merge_requests_count' do
    it 'returns number of open merge requests from non-archived projects' do
      user    = create(:user)
      project = create(:project, :public)
      archived_project = create(:project, :public, :archived)

2840 2841 2842
      create(:merge_request, source_project: project, author: user, assignees: [user])
      create(:merge_request, :closed, source_project: project, author: user, assignees: [user])
      create(:merge_request, source_project: archived_project, author: user, assignees: [user])
2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861

      expect(user.assigned_open_merge_requests_count(force: true)).to eq 1
    end
  end

  describe '#assigned_open_issues_count' do
    it 'returns number of open issues from non-archived projects' do
      user    = create(:user)
      project = create(:project, :public)
      archived_project = create(:project, :public, :archived)

      create(:issue, project: project, author: user, assignees: [user])
      create(:issue, :closed, project: project, author: user, assignees: [user])
      create(:issue, project: archived_project, author: user, assignees: [user])

      expect(user.assigned_open_issues_count(force: true)).to eq 1
    end
  end

2862 2863 2864 2865 2866
  describe '#personal_projects_count' do
    it 'returns the number of personal projects using a single query' do
      user = build(:user)
      projects = double(:projects, count: 1)

2867
      expect(user).to receive(:personal_projects).and_return(projects)
2868

2869
      expect(user.personal_projects_count).to eq(1)
2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882
    end
  end

  describe '#projects_limit_left' do
    it 'returns the number of projects that can be created by the user' do
      user = build(:user)

      allow(user).to receive(:projects_limit).and_return(10)
      allow(user).to receive(:personal_projects_count).and_return(5)

      expect(user.projects_limit_left).to eq(5)
    end
  end
2883 2884 2885 2886 2887 2888 2889

  describe '#ensure_namespace_correct' do
    context 'for a new user' do
      let(:user) { build(:user) }

      it 'creates the namespace' do
        expect(user.namespace).to be_nil
2890

2891
        user.save!
2892

2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906
        expect(user.namespace).not_to be_nil
      end
    end

    context 'for an existing user' do
      let(:username) { 'foo' }
      let(:user) { create(:user, username: username) }

      context 'when the user is updated' do
        context 'when the username is changed' do
          let(:new_username) { 'bar' }

          it 'changes the namespace (just to compare to when username is not changed)' do
            expect do
2907
              Timecop.freeze(1.second.from_now) do
2908
                user.update!(username: new_username)
2909
              end
2910 2911 2912 2913
            end.to change { user.namespace.updated_at }
          end

          it 'updates the namespace name' do
Lin Jen-Shin's avatar
Lin Jen-Shin committed
2914
            user.update!(username: new_username)
2915

2916 2917 2918 2919
            expect(user.namespace.name).to eq(new_username)
          end

          it 'updates the namespace path' do
Lin Jen-Shin's avatar
Lin Jen-Shin committed
2920
            user.update!(username: new_username)
2921

2922 2923 2924 2925
            expect(user.namespace.path).to eq(new_username)
          end

          context 'when there is a validation error (namespace name taken) while updating namespace' do
2926
            let!(:conflicting_namespace) { create(:group, path: new_username) }
2927

2928
            it 'causes the user save to fail' do
Lin Jen-Shin's avatar
Lin Jen-Shin committed
2929
              expect(user.update(username: new_username)).to be_falsey
2930
              expect(user.namespace.errors.messages[:path].first).to eq('has already been taken')
2931
            end
2932 2933

            it 'adds the namespace errors to the user' do
Lin Jen-Shin's avatar
Lin Jen-Shin committed
2934
              user.update(username: new_username)
2935

2936
              expect(user.errors.full_messages.first).to eq('Username has already been taken')
2937
            end
2938 2939 2940 2941 2942 2943
          end
        end

        context 'when the username is not changed' do
          it 'does not change the namespace' do
            expect do
Lin Jen-Shin's avatar
Lin Jen-Shin committed
2944
              user.update!(email: 'asdf@asdf.com')
2945 2946 2947 2948 2949 2950
            end.not_to change { user.namespace.updated_at }
          end
        end
      end
    end
  end
2951

2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973
  describe '#username_changed_hook' do
    context 'for a new user' do
      let(:user) { build(:user) }

      it 'does not trigger system hook' do
        expect(user).not_to receive(:system_hook_service)

        user.save!
      end
    end

    context 'for an existing user' do
      let(:user) { create(:user, username: 'old-username') }

      context 'when the username is changed' do
        let(:new_username) { 'very-new-name' }

        it 'triggers the rename system hook' do
          system_hook_service = SystemHooksService.new
          expect(system_hook_service).to receive(:execute_hooks_for).with(user, :rename)
          expect(user).to receive(:system_hook_service).and_return(system_hook_service)

Lin Jen-Shin's avatar
Lin Jen-Shin committed
2974
          user.update!(username: new_username)
2975 2976 2977 2978 2979 2980 2981
        end
      end

      context 'when the username is not changed' do
        it 'does not trigger system hook' do
          expect(user).not_to receive(:system_hook_service)

Lin Jen-Shin's avatar
Lin Jen-Shin committed
2982
          user.update!(email: 'asdf@asdf.com')
2983 2984 2985 2986 2987
        end
      end
    end
  end

2988 2989 2990 2991 2992 2993
  describe '#sync_attribute?' do
    let(:user) { described_class.new }

    context 'oauth user' do
      it 'returns true if name can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(name location))
2994

2995 2996 2997 2998 2999
        expect(user.sync_attribute?(:name)).to be_truthy
      end

      it 'returns true if email can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(name email))
3000

3001 3002 3003 3004 3005
        expect(user.sync_attribute?(:email)).to be_truthy
      end

      it 'returns true if location can be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
3006

3007 3008 3009 3010 3011
        expect(user.sync_attribute?(:email)).to be_truthy
      end

      it 'returns false if name can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
3012

3013 3014 3015 3016 3017
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns false if email can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
3018

3019 3020 3021 3022 3023
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns false if location can not be synced' do
        stub_omniauth_setting(sync_profile_attributes: %w(location email))
3024

3025 3026 3027 3028 3029
        expect(user.sync_attribute?(:name)).to be_falsey
      end

      it 'returns true for all syncable attributes if all syncable attributes can be synced' do
        stub_omniauth_setting(sync_profile_attributes: true)
3030

3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045
        expect(user.sync_attribute?(:name)).to be_truthy
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_truthy
      end

      it 'returns false for all syncable attributes but email if no syncable attributes are declared' do
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_falsey
      end
    end

    context 'ldap user' do
      it 'returns true for email if ldap user' do
        allow(user).to receive(:ldap_user?).and_return(true)
3046

3047 3048 3049 3050 3051 3052 3053 3054
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_falsey
      end

      it 'returns true for email and location if ldap user and location declared as syncable' do
        allow(user).to receive(:ldap_user?).and_return(true)
        stub_omniauth_setting(sync_profile_attributes: %w(location))
3055

3056 3057 3058 3059 3060 3061
        expect(user.sync_attribute?(:name)).to be_falsey
        expect(user.sync_attribute?(:email)).to be_truthy
        expect(user.sync_attribute?(:location)).to be_truthy
      end
    end
  end
3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077

  describe '#confirm_deletion_with_password?' do
    where(
      password_automatically_set: [true, false],
      ldap_user: [true, false],
      password_authentication_disabled: [true, false]
    )

    with_them do
      let!(:user) { create(:user, password_automatically_set: password_automatically_set) }
      let!(:identity) { create(:identity, user: user) if ldap_user }

      # Only confirm deletion with password if all inputs are false
      let(:expected) { !(password_automatically_set || ldap_user || password_authentication_disabled) }

      before do
3078 3079
        stub_application_setting(password_authentication_enabled_for_web: !password_authentication_disabled)
        stub_application_setting(password_authentication_enabled_for_git: !password_authentication_disabled)
3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107
      end

      it 'returns false unless all inputs are true' do
        expect(user.confirm_deletion_with_password?).to eq(expected)
      end
    end
  end

  describe '#delete_async' do
    let(:user) { create(:user) }
    let(:deleted_by) { create(:user) }

    it 'blocks the user then schedules them for deletion if a hard delete is specified' do
      expect(DeleteUserWorker).to receive(:perform_async).with(deleted_by.id, user.id, hard_delete: true)

      user.delete_async(deleted_by: deleted_by, params: { hard_delete: true })

      expect(user).to be_blocked
    end

    it 'schedules user for deletion without blocking them' do
      expect(DeleteUserWorker).to receive(:perform_async).with(deleted_by.id, user.id, {})

      user.delete_async(deleted_by: deleted_by)

      expect(user).not_to be_blocked
    end
  end
3108 3109 3110 3111 3112 3113

  describe '#max_member_access_for_project_ids' do
    shared_examples 'max member access for projects' do
      let(:user) { create(:user) }
      let(:group) { create(:group) }
      let(:owner_project) { create(:project, group: group) }
3114
      let(:maintainer_project) { create(:project) }
3115 3116 3117 3118 3119 3120
      let(:reporter_project) { create(:project) }
      let(:developer_project) { create(:project) }
      let(:guest_project) { create(:project) }
      let(:no_access_project) { create(:project) }

      let(:projects) do
3121
        [owner_project, maintainer_project, reporter_project, developer_project, guest_project, no_access_project].map(&:id)
3122 3123 3124 3125 3126
      end

      let(:expected) do
        {
          owner_project.id => Gitlab::Access::OWNER,
3127
          maintainer_project.id => Gitlab::Access::MAINTAINER,
3128 3129 3130 3131 3132 3133 3134 3135 3136
          reporter_project.id => Gitlab::Access::REPORTER,
          developer_project.id => Gitlab::Access::DEVELOPER,
          guest_project.id => Gitlab::Access::GUEST,
          no_access_project.id => Gitlab::Access::NO_ACCESS
        }
      end

      before do
        create(:group_member, user: user, group: group)
3137
        maintainer_project.add_maintainer(user)
3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163
        reporter_project.add_reporter(user)
        developer_project.add_developer(user)
        guest_project.add_guest(user)
      end

      it 'returns correct roles for different projects' do
        expect(user.max_member_access_for_project_ids(projects)).to eq(expected)
      end
    end

    context 'with RequestStore enabled', :request_store do
      include_examples 'max member access for projects'

      def access_levels(projects)
        user.max_member_access_for_project_ids(projects)
      end

      it 'does not perform extra queries when asked for projects who have already been found' do
        access_levels(projects)

        expect { access_levels(projects) }.not_to exceed_query_limit(0)

        expect(access_levels(projects)).to eq(expected)
      end

      it 'only requests the extra projects when uncached projects are passed' do
3164
        second_maintainer_project = create(:project)
3165
        second_developer_project = create(:project)
3166
        second_maintainer_project.add_maintainer(user)
3167 3168
        second_developer_project.add_developer(user)

3169
        all_projects = projects + [second_maintainer_project.id, second_developer_project.id]
3170

3171
        expected_all = expected.merge(second_maintainer_project.id => Gitlab::Access::MAINTAINER,
3172 3173 3174 3175 3176 3177 3178
                                      second_developer_project.id => Gitlab::Access::DEVELOPER)

        access_levels(projects)

        queries = ActiveRecord::QueryRecorder.new { access_levels(all_projects) }

        expect(queries.count).to eq(1)
3179
        expect(queries.log_message).to match(/\W(#{second_maintainer_project.id}, #{second_developer_project.id})\W/)
3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192
        expect(access_levels(all_projects)).to eq(expected_all)
      end
    end

    context 'with RequestStore disabled' do
      include_examples 'max member access for projects'
    end
  end

  describe '#max_member_access_for_group_ids' do
    shared_examples 'max member access for groups' do
      let(:user) { create(:user) }
      let(:owner_group) { create(:group) }
3193
      let(:maintainer_group) { create(:group) }
3194 3195 3196 3197 3198 3199
      let(:reporter_group) { create(:group) }
      let(:developer_group) { create(:group) }
      let(:guest_group) { create(:group) }
      let(:no_access_group) { create(:group) }

      let(:groups) do
3200
        [owner_group, maintainer_group, reporter_group, developer_group, guest_group, no_access_group].map(&:id)
3201 3202 3203 3204 3205
      end

      let(:expected) do
        {
          owner_group.id => Gitlab::Access::OWNER,
3206
          maintainer_group.id => Gitlab::Access::MAINTAINER,
3207 3208 3209 3210 3211 3212 3213 3214 3215
          reporter_group.id => Gitlab::Access::REPORTER,
          developer_group.id => Gitlab::Access::DEVELOPER,
          guest_group.id => Gitlab::Access::GUEST,
          no_access_group.id => Gitlab::Access::NO_ACCESS
        }
      end

      before do
        owner_group.add_owner(user)
3216
        maintainer_group.add_maintainer(user)
3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242
        reporter_group.add_reporter(user)
        developer_group.add_developer(user)
        guest_group.add_guest(user)
      end

      it 'returns correct roles for different groups' do
        expect(user.max_member_access_for_group_ids(groups)).to eq(expected)
      end
    end

    context 'with RequestStore enabled', :request_store do
      include_examples 'max member access for groups'

      def access_levels(groups)
        user.max_member_access_for_group_ids(groups)
      end

      it 'does not perform extra queries when asked for groups who have already been found' do
        access_levels(groups)

        expect { access_levels(groups) }.not_to exceed_query_limit(0)

        expect(access_levels(groups)).to eq(expected)
      end

      it 'only requests the extra groups when uncached groups are passed' do
3243
        second_maintainer_group = create(:group)
3244
        second_developer_group = create(:group)
3245
        second_maintainer_group.add_maintainer(user)
3246 3247
        second_developer_group.add_developer(user)

3248
        all_groups = groups + [second_maintainer_group.id, second_developer_group.id]
3249

3250
        expected_all = expected.merge(second_maintainer_group.id => Gitlab::Access::MAINTAINER,
3251 3252 3253 3254 3255 3256 3257
                                      second_developer_group.id => Gitlab::Access::DEVELOPER)

        access_levels(groups)

        queries = ActiveRecord::QueryRecorder.new { access_levels(all_groups) }

        expect(queries.count).to eq(1)
3258
        expect(queries.log_message).to match(/\W(#{second_maintainer_group.id}, #{second_developer_group.id})\W/)
3259 3260 3261 3262 3263 3264 3265 3266
        expect(access_levels(all_groups)).to eq(expected_all)
      end
    end

    context 'with RequestStore disabled' do
      include_examples 'max member access for groups'
    end
  end
3267

3268 3269
  context 'changing a username' do
    let(:user) { create(:user, username: 'foo') }
3270

3271 3272 3273
    it 'creates a redirect route' do
      expect { user.update!(username: 'bar') }
        .to change { RedirectRoute.where(path: 'foo').count }.by(1)
3274 3275
    end

3276 3277 3278 3279 3280
    it 'deletes the redirect when a user with the old username was created' do
      user.update!(username: 'bar')

      expect { create(:user, username: 'foo') }
        .to change { RedirectRoute.where(path: 'foo').count }.by(-1)
3281 3282
    end
  end
3283 3284 3285 3286 3287 3288 3289 3290 3291 3292 3293 3294 3295 3296 3297 3298 3299 3300 3301 3302 3303 3304 3305 3306 3307 3308

  describe '#required_terms_not_accepted?' do
    let(:user) { build(:user) }
    subject { user.required_terms_not_accepted? }

    context "when terms are not enforced" do
      it { is_expected.to be_falsy }
    end

    context "when terms are enforced and accepted by the user" do
      before do
        enforce_terms
        accept_terms(user)
      end

      it { is_expected.to be_falsy }
    end

    context "when terms are enforced but the user has not accepted" do
      before do
        enforce_terms
      end

      it { is_expected.to be_truthy }
    end
  end
3309 3310 3311 3312 3313 3314 3315 3316 3317 3318 3319 3320 3321 3322

  describe '#increment_failed_attempts!' do
    subject(:user) { create(:user, failed_attempts: 0) }

    it 'logs failed sign-in attempts' do
      expect { user.increment_failed_attempts! }.to change(user, :failed_attempts).from(0).to(1)
    end

    it 'does not log failed sign-in attempts when in a GitLab read-only instance' do
      allow(Gitlab::Database).to receive(:read_only?) { true }

      expect { user.increment_failed_attempts! }.not_to change(user, :failed_attempts)
    end
  end
Jan Provaznik's avatar
Jan Provaznik committed
3323

3324 3325 3326 3327 3328 3329 3330 3331 3332 3333 3334 3335 3336 3337 3338 3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349 3350 3351 3352 3353 3354 3355 3356 3357 3358 3359 3360 3361 3362 3363 3364 3365
  describe '#requires_usage_stats_consent?' do
    let(:user) { create(:user, created_at: 8.days.ago) }

    before do
      allow(user).to receive(:has_current_license?).and_return false
    end

    context 'in single-user environment' do
      it 'requires user consent after one week' do
        create(:user, ghost: true)

        expect(user.requires_usage_stats_consent?).to be true
      end

      it 'requires user consent after one week if there is another ghost user' do
        expect(user.requires_usage_stats_consent?).to be true
      end

      it 'does not require consent in the first week' do
        user.created_at = 6.days.ago

        expect(user.requires_usage_stats_consent?).to be false
      end

      it 'does not require consent if usage stats were set by this user' do
        allow(Gitlab::CurrentSettings).to receive(:usage_stats_set_by_user_id).and_return(user.id)

        expect(user.requires_usage_stats_consent?).to be false
      end
    end

    context 'in multi-user environment' do
      before do
        create(:user)
      end

      it 'does not require consent' do
        expect(user.requires_usage_stats_consent?).to be false
      end
    end
  end

Jan Provaznik's avatar
Jan Provaznik committed
3366
  context 'with uploads' do
3367
    it_behaves_like 'model with uploads', false do
Jan Provaznik's avatar
Jan Provaznik committed
3368 3369 3370 3371 3372
      let(:model_object) { create(:user, :with_avatar) }
      let(:upload_attribute) { :avatar }
      let(:uploader_class) { AttachmentUploader }
    end
  end
3373 3374 3375 3376 3377 3378 3379 3380 3381 3382 3383 3384 3385 3386 3387 3388 3389 3390 3391 3392 3393 3394 3395 3396 3397 3398 3399 3400 3401 3402 3403 3404 3405 3406 3407 3408 3409 3410 3411 3412 3413 3414 3415 3416 3417 3418 3419 3420 3421 3422 3423 3424 3425 3426 3427 3428 3429 3430 3431 3432 3433 3434 3435 3436 3437 3438 3439 3440 3441 3442 3443 3444 3445 3446 3447 3448 3449 3450 3451 3452 3453 3454

  describe '.union_with_user' do
    context 'when no user ID is provided' do
      it 'returns the input relation' do
        user = create(:user)

        expect(described_class.union_with_user).to eq([user])
      end
    end

    context 'when a user ID is provided' do
      it 'includes the user object in the returned relation' do
        user1 = create(:user)
        user2 = create(:user)
        users = described_class.where(id: user1.id).union_with_user(user2.id)

        expect(users).to include(user1)
        expect(users).to include(user2)
      end

      it 'does not re-apply any WHERE conditions on the outer query' do
        relation = described_class.where(id: 1).union_with_user(2)

        expect(relation.arel.where_sql).to be_nil
      end
    end
  end

  describe '.optionally_search' do
    context 'using nil as the argument' do
      it 'returns the current relation' do
        user = create(:user)

        expect(described_class.optionally_search).to eq([user])
      end
    end

    context 'using an empty String as the argument' do
      it 'returns the current relation' do
        user = create(:user)

        expect(described_class.optionally_search('')).to eq([user])
      end
    end

    context 'using a non-empty String' do
      it 'returns users matching the search query' do
        user1 = create(:user)
        create(:user)

        expect(described_class.optionally_search(user1.name)).to eq([user1])
      end
    end
  end

  describe '.where_not_in' do
    context 'without an argument' do
      it 'returns the current relation' do
        user = create(:user)

        expect(described_class.where_not_in).to eq([user])
      end
    end

    context 'using a list of user IDs' do
      it 'excludes the users from the returned relation' do
        user1 = create(:user)
        user2 = create(:user)

        expect(described_class.where_not_in([user2.id])).to eq([user1])
      end
    end
  end

  describe '.reorder_by_name' do
    it 'reorders the input relation' do
      user1 = create(:user, name: 'A')
      user2 = create(:user, name: 'B')

      expect(described_class.reorder_by_name).to eq([user1, user2])
    end
  end
gitlabhq's avatar
gitlabhq committed
3455
end