repository_spec.rb 74.9 KB
Newer Older
1 2
# frozen_string_literal: true

3 4
require 'spec_helper'

5
describe Repository do
6
  include RepoHelpers
7 8
  include GitHelpers

9
  TestBlob = Struct.new(:path)
10

11
  let(:project) { create(:project, :repository) }
12
  let(:repository) { project.repository }
13
  let(:broken_repository) { create(:project, :broken_storage).repository }
14
  let(:user) { create(:user) }
15
  let(:git_user) { Gitlab::Git::User.from_gitlab(user) }
16

17
  let(:message) { 'Test message' }
18

Rubén Dávila's avatar
Rubén Dávila committed
19
  let(:merge_commit) do
20
    merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project)
21 22 23 24

    merge_commit_id = repository.merge(user,
                                       merge_request.diff_head_sha,
                                       merge_request,
25
                                       message)
26

27
    repository.commit(merge_commit_id)
28
  end
29

30 31
  let(:author_email) { 'user@example.org' }
  let(:author_name) { 'John Doe' }
32

33 34
  def expect_to_raise_storage_error
    expect { yield }.to raise_error do |exception|
35
      storage_exceptions = [Gitlab::Git::CommandError, GRPC::Unavailable]
36 37 38
      known_exception = storage_exceptions.select { |e| exception.is_a?(e) }

      expect(known_exception).not_to be_nil
39 40 41
    end
  end

42
  describe '#branch_names_contains' do
43 44
    set(:project) { create(:project, :repository) }
    let(:repository) { project.repository }
45

46
    subject { repository.branch_names_contains(sample_commit.id) }
47

48 49 50
    it { is_expected.to include('master') }
    it { is_expected.not_to include('feature') }
    it { is_expected.not_to include('fix') }
51

52
    describe 'when storage is broken', :broken_storage do
53
      it 'raises a storage error' do
54 55
        expect_to_raise_storage_error do
          broken_repository.branch_names_contains(sample_commit.id)
56 57 58
        end
      end
    end
59
  end
60

61
  describe '#tag_names_contains' do
62
    subject { repository.tag_names_contains(sample_commit.id) }
63

64 65
    it { is_expected.to include('v1.1.0') }
    it { is_expected.not_to include('v1.0.0') }
66 67
  end

68
  describe 'tags_sorted_by' do
haseeb's avatar
haseeb committed
69 70
    context 'name_desc' do
      subject { repository.tags_sorted_by('name_desc').map(&:name) }
71 72 73 74

      it { is_expected.to eq(['v1.1.0', 'v1.0.0']) }
    end

haseeb's avatar
haseeb committed
75 76 77 78 79 80
    context 'name_asc' do
      subject { repository.tags_sorted_by('name_asc').map(&:name) }

      it { is_expected.to eq(['v1.0.0', 'v1.1.0']) }
    end

81 82 83 84 85 86 87 88 89 90 91
    context 'updated' do
      let(:tag_a) { repository.find_tag('v1.0.0') }
      let(:tag_b) { repository.find_tag('v1.1.0') }

      context 'desc' do
        subject { repository.tags_sorted_by('updated_desc').map(&:name) }

        before do
          double_first = double(committed_date: Time.now)
          double_last = double(committed_date: Time.now - 1.second)

92 93
          allow(tag_a).to receive(:dereferenced_target).and_return(double_first)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_last)
94
          allow(repository).to receive(:tags).and_return([tag_a, tag_b])
95 96 97 98 99 100 101 102 103 104 105 106
        end

        it { is_expected.to eq(['v1.0.0', 'v1.1.0']) }
      end

      context 'asc' do
        subject { repository.tags_sorted_by('updated_asc').map(&:name) }

        before do
          double_first = double(committed_date: Time.now - 1.second)
          double_last = double(committed_date: Time.now)

107 108
          allow(tag_a).to receive(:dereferenced_target).and_return(double_last)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_first)
109
          allow(repository).to receive(:tags).and_return([tag_a, tag_b])
110 111 112 113
        end

        it { is_expected.to eq(['v1.1.0', 'v1.0.0']) }
      end
114 115 116 117 118 119 120 121 122

      context 'annotated tag pointing to a blob' do
        let(:annotated_tag_name) { 'annotated-tag' }

        subject { repository.tags_sorted_by('updated_asc').map(&:name) }

        before do
          options = { message: 'test tag message\n',
                      tagger: { name: 'John Smith', email: 'john@gmail.com' } }
123

124
          rugged_repo(repository).tags.create(annotated_tag_name, 'a48e4fc218069f68ef2e769dd8dfea3991362175', options)
125 126 127 128 129 130 131 132 133 134 135

          double_first = double(committed_date: Time.now - 1.second)
          double_last = double(committed_date: Time.now)

          allow(tag_a).to receive(:dereferenced_target).and_return(double_last)
          allow(tag_b).to receive(:dereferenced_target).and_return(double_first)
        end

        it { is_expected.to eq(['v1.1.0', 'v1.0.0', annotated_tag_name]) }

        after do
136
          rugged_repo(repository).tags.delete(annotated_tag_name)
137 138
        end
      end
139 140 141
    end
  end

142
  describe '#ref_name_for_sha' do
143
    it 'returns the ref' do
144 145
      allow(repository.raw_repository).to receive(:ref_name_for_sha)
        .and_return('refs/environments/production/77')
146

147
      expect(repository.ref_name_for_sha('bla', '0' * 40)).to eq 'refs/environments/production/77'
148 149 150
    end
  end

151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170
  describe '#ref_exists?' do
    context 'when ref exists' do
      it 'returns true' do
        expect(repository.ref_exists?('refs/heads/master')).to be true
      end
    end

    context 'when ref does not exist' do
      it 'returns false' do
        expect(repository.ref_exists?('refs/heads/non-existent')).to be false
      end
    end

    context 'when ref format is incorrect' do
      it 'returns false' do
        expect(repository.ref_exists?('refs/heads/invalid:master')).to be false
      end
    end
  end

171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219
  describe '#list_last_commits_for_tree' do
    let(:path_to_commit) do
      {
        "encoding" => "913c66a37b4a45b9769037c55c2d238bd0942d2e",
        "files" => "570e7b2abdd848b95f2f578043fc23bd6f6fd24d",
        ".gitignore" => "c1acaa58bbcbc3eafe538cb8274ba387047b69f8",
        ".gitmodules" => "6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9",
        "CHANGELOG" => "913c66a37b4a45b9769037c55c2d238bd0942d2e",
        "CONTRIBUTING.md" => "6d394385cf567f80a8fd85055db1ab4c5295806f",
        "Gemfile.zip" => "ae73cb07c9eeaf35924a10f713b364d32b2dd34f",
        "LICENSE" => "1a0b36b3cdad1d2ee32457c102a8c0b7056fa863",
        "MAINTENANCE.md" => "913c66a37b4a45b9769037c55c2d238bd0942d2e",
        "PROCESS.md" => "913c66a37b4a45b9769037c55c2d238bd0942d2e",
        "README.md" => "1a0b36b3cdad1d2ee32457c102a8c0b7056fa863",
        "VERSION" => "913c66a37b4a45b9769037c55c2d238bd0942d2e",
        "gitlab-shell" => "6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9",
        "six" => "cfe32cf61b73a0d5e9f13e774abde7ff789b1660"
      }
    end

    subject { repository.list_last_commits_for_tree(sample_commit.id, '.').id }

    it 'returns the last commits for every entry in the current path' do
      result = repository.list_last_commits_for_tree(sample_commit.id, '.')

      result.each do |key, value|
        result[key] = value.id
      end

      expect(result).to include(path_to_commit)
    end

    it 'returns the last commits for every entry in the current path starting from the offset' do
      result = repository.list_last_commits_for_tree(sample_commit.id, '.', offset: path_to_commit.size - 1)

      expect(result.size).to eq(1)
    end

    it 'returns a limited number of last commits for every entry in the current path starting from the offset' do
      result = repository.list_last_commits_for_tree(sample_commit.id, '.', limit: 1)

      expect(result.size).to eq(1)
    end

    it 'returns an empty hash when offset is out of bounds' do
      result = repository.list_last_commits_for_tree(sample_commit.id, '.', offset: path_to_commit.size)

      expect(result.size).to eq(0)
    end
220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238

    context 'with a commit with invalid UTF-8 path' do
      def create_commit_with_invalid_utf8_path
        rugged = rugged_repo(repository)
        blob_id = Rugged::Blob.from_buffer(rugged, "some contents")
        tree_builder = Rugged::Tree::Builder.new(rugged)
        tree_builder.insert({ oid: blob_id, name: "hello\x80world", filemode: 0100644 })
        tree_id = tree_builder.write
        user = { email: "jcai@gitlab.com", time: Time.now, name: "John Cai" }

        Rugged::Commit.create(rugged, message: 'some commit message', parents: [rugged.head.target.oid], tree: tree_id, committer: user, author: user)
      end

      it 'does not raise an error' do
        commit = create_commit_with_invalid_utf8_path

        expect { repository.list_last_commits_for_tree(commit, '.', offset: 0) }.not_to raise_error
      end
    end
239 240
  end

241
  describe '#last_commit_for_path' do
242
    subject { repository.last_commit_for_path(sample_commit.id, '.gitignore').id }
243

244
    it { is_expected.to eq('c1acaa58bbcbc3eafe538cb8274ba387047b69f8') }
245

246
    describe 'when storage is broken', :broken_storage do
247
      it 'raises a storage error' do
248 249
        expect_to_raise_storage_error do
          broken_repository.last_commit_id_for_path(sample_commit.id, '.gitignore')
250 251
        end
      end
252
    end
253
  end
254

Hiroyuki Sato's avatar
Hiroyuki Sato committed
255
  describe '#last_commit_id_for_path' do
256
    subject { repository.last_commit_id_for_path(sample_commit.id, '.gitignore') }
Hiroyuki Sato's avatar
Hiroyuki Sato committed
257

258 259 260
    it "returns last commit id for a given path" do
      is_expected.to eq('c1acaa58bbcbc3eafe538cb8274ba387047b69f8')
    end
261

262 263 264
    it "caches last commit id for a given path" do
      cache = repository.send(:cache)
      key = "last_commit_id_for_path:#{sample_commit.id}:#{Digest::SHA1.hexdigest('.gitignore')}"
265

266 267 268
      expect(cache).to receive(:fetch).with(key).and_return('c1acaa5')
      is_expected.to eq('c1acaa5')
    end
269

270
    describe 'when storage is broken', :broken_storage do
271
      it 'raises a storage error' do
272 273
        expect_to_raise_storage_error do
          broken_repository.last_commit_for_path(sample_commit.id, '.gitignore').id
274 275
        end
      end
Hiroyuki Sato's avatar
Hiroyuki Sato committed
276
    end
Hiroyuki Sato's avatar
Hiroyuki Sato committed
277 278
  end

279
  describe '#commits' do
Tiago Botelho's avatar
Tiago Botelho committed
280 281 282 283
    context 'when neither the all flag nor a ref are specified' do
      it 'returns every commit from default branch' do
        expect(repository.commits(limit: 60).size).to eq(37)
      end
284 285
    end

Tiago Botelho's avatar
Tiago Botelho committed
286 287 288 289
    context 'when ref is passed' do
      it 'returns every commit from the specified ref' do
        expect(repository.commits('master', limit: 60).size).to eq(37)
      end
290

Tiago Botelho's avatar
Tiago Botelho committed
291 292 293 294 295 296 297 298 299 300 301 302 303
      context 'when all' do
        it 'returns every commit from the repository' do
          expect(repository.commits('master', limit: 60, all: true).size).to eq(60)
        end
      end

      context 'with path' do
        it 'sets follow when it is a single path' do
          expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(follow: true)).and_call_original.twice

          repository.commits('master', limit: 1, path: 'README.md')
          repository.commits('master', limit: 1, path: ['README.md'])
        end
304

Tiago Botelho's avatar
Tiago Botelho committed
305 306
        it 'does not set follow when it is multiple paths' do
          expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(follow: false)).and_call_original
307

Tiago Botelho's avatar
Tiago Botelho committed
308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324
          repository.commits('master', limit: 1, path: ['README.md', 'CHANGELOG'])
        end
      end

      context 'without path' do
        it 'does not set follow' do
          expect(Gitlab::Git::Commit).to receive(:where).with(a_hash_including(follow: false)).and_call_original

          repository.commits('master', limit: 1)
        end
      end
    end

    context "when 'all' flag is set" do
      it 'returns every commit from the repository' do
        expect(repository.commits(all: true, limit: 60).size).to eq(60)
      end
325 326 327
    end
  end

328
  describe '#new_commits' do
329 330
    set(:project) { create(:project, :repository) }
    let(:repository) { project.repository }
331

332
    subject { repository.new_commits(rev) }
333

334 335
    context 'when there are no new commits' do
      let(:rev) { repository.commit.id }
336

337 338
      it 'returns an empty array' do
        expect(subject).to eq([])
339
      end
340
    end
341

342 343 344
    context 'when new commits are found' do
      let(:branch) { 'orphaned-branch' }
      let!(:rev) { repository.commit(branch).id }
345

346 347
      it 'returns the commits' do
        repository.delete_branch(branch)
348

349 350 351
        expect(subject).not_to be_empty
        expect(subject).to all( be_a(::Commit) )
        expect(subject.size).to eq(1)
352 353
      end
    end
354 355
  end

356 357
  describe '#commits_by' do
    set(:project) { create(:project, :repository) }
358
    let(:oids) { TestEnv::BRANCH_SHA.values }
359

360
    subject { project.repository.commits_by(oids: oids) }
361

362 363 364 365
    it 'finds each commit' do
      expect(subject).not_to include(nil)
      expect(subject.size).to eq(oids.size)
    end
366

367 368 369
    it 'returns only Commit instances' do
      expect(subject).to all( be_a(Commit) )
    end
370

371 372 373
    context 'when some commits are not found ' do
      let(:oids) do
        ['deadbeef'] + TestEnv::BRANCH_SHA.values.first(10)
374 375
      end

376 377 378
      it 'returns only found commits' do
        expect(subject).not_to include(nil)
        expect(subject.size).to eq(10)
379
      end
380
    end
381

382 383
    context 'when no oids are passed' do
      let(:oids) { [] }
384

385 386
      it 'does not call #batch_by_oid' do
        expect(Gitlab::Git::Commit).not_to receive(:batch_by_oid)
387

388
        subject
389 390 391 392
      end
    end
  end

393
  describe '#find_commits_by_message' do
394 395
    it 'returns commits with messages containing a given string' do
      commit_ids = repository.find_commits_by_message('submodule').map(&:id)
396

397 398 399 400 401 402
      expect(commit_ids).to include(
        '5937ac0a7beb003549fc5fd26fc247adbce4a52e',
        '6f6d7e7ed97bb5f0054f2b1df789b39ca89b6ff9',
        'cfe32cf61b73a0d5e9f13e774abde7ff789b1660'
      )
      expect(commit_ids).not_to include('913c66a37b4a45b9769037c55c2d238bd0942d2e')
403 404
    end

405 406
    it 'is case insensitive' do
      commit_ids = repository.find_commits_by_message('SUBMODULE').map(&:id)
407

408
      expect(commit_ids).to include('5937ac0a7beb003549fc5fd26fc247adbce4a52e')
409
    end
410

411
    describe 'when storage is broken', :broken_storage do
412
      it 'raises a storage error' do
413 414 415
        expect_to_raise_storage_error { broken_repository.find_commits_by_message('s') }
      end
    end
416 417
  end

418
  describe '#blob_at' do
419 420 421 422 423
    context 'blank sha' do
      subject { repository.blob_at(Gitlab::Git::BLANK_SHA, '.gitignore') }

      it { is_expected.to be_nil }
    end
424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441

    context 'regular blob' do
      subject { repository.blob_at(repository.head_commit.sha, '.gitignore') }

      it { is_expected.to be_an_instance_of(::Blob) }
    end

    context 'readme blob on HEAD' do
      subject { repository.blob_at(repository.head_commit.sha, 'README.md') }

      it { is_expected.to be_an_instance_of(::ReadmeBlob) }
    end

    context 'readme blob not on HEAD' do
      subject { repository.blob_at(repository.find_branch('feature').target, 'README.md') }

      it { is_expected.to be_an_instance_of(::Blob) }
    end
442
  end
443

444
  describe '#merged_to_root_ref?' do
445
    context 'merged branch without ff' do
446
      subject { repository.merged_to_root_ref?('branch-merged') }
447 448 449

      it { is_expected.to be_truthy }
    end
450

451 452
    # If the HEAD was ff then it will be false
    context 'merged with ff' do
453 454 455 456
      subject { repository.merged_to_root_ref?('improve/awesome') }

      it { is_expected.to be_truthy }
    end
457

458 459 460 461 462
    context 'not merged branch' do
      subject { repository.merged_to_root_ref?('not-merged-branch') }

      it { is_expected.to be_falsey }
    end
463 464 465 466 467 468

    context 'default branch' do
      subject { repository.merged_to_root_ref?('master') }

      it { is_expected.to be_falsey }
    end
469 470 471 472 473 474 475 476 477 478 479 480

    context 'non merged branch' do
      subject { repository.merged_to_root_ref?('fix') }

      it { is_expected.to be_falsey }
    end

    context 'non existent branch' do
      subject { repository.merged_to_root_ref?('non_existent_branch') }

      it { is_expected.to be_nil }
    end
481 482
  end

483
  describe '#can_be_merged?' do
484 485
    context 'mergeable branches' do
      subject { repository.can_be_merged?('0b4bc9a49b562e85de7cc9e834518ea6828729b9', 'master') }
486

487 488
      it { is_expected.to be_truthy }
    end
489

490 491
    context 'non-mergeable branches without conflict sides missing' do
      subject { repository.can_be_merged?('bb5206fee213d983da88c47f9cf4cc6caf9c66dc', 'feature') }
492

493 494
      it { is_expected.to be_falsey }
    end
495

496 497
    context 'non-mergeable branches with conflict sides missing' do
      subject { repository.can_be_merged?('conflict-missing-side', 'conflict-start') }
498

499 500
      it { is_expected.to be_falsey }
    end
501

502 503
    context 'submodule changes that confuse rugged' do
      subject { repository.can_be_merged?('update-gitlab-shell-v-6-0-1', 'update-gitlab-shell-v-6-0-3') }
504

505
      it { is_expected.to be_falsey }
506
    end
507 508
  end

509 510 511
  describe '#commit' do
    context 'when ref exists' do
      it 'returns commit object' do
512 513
        expect(repository.commit('master'))
          .to be_an_instance_of Commit
514 515 516 517 518 519 520 521 522
      end
    end

    context 'when ref does not exist' do
      it 'returns nil' do
        expect(repository.commit('non-existent-ref')).to be_nil
      end
    end

523 524 525 526 527 528 529 530
    context 'when ref is not specified' do
      it 'is using a root ref' do
        expect(repository).to receive(:find_commit).with('master')

        repository.commit
      end
    end

531 532 533 534 535 536 537 538 539 540 541 542 543 544 545
    context 'when ref is not valid' do
      context 'when preceding tree element exists' do
        it 'returns nil' do
          expect(repository.commit('master:ref')).to be_nil
        end
      end

      context 'when preceding tree element does not exist' do
        it 'returns nil' do
          expect(repository.commit('non-existent:ref')).to be_nil
        end
      end
    end
  end

Douwe Maan's avatar
Douwe Maan committed
546
  describe "#create_dir" do
547 548
    it "commits a change that creates a new directory" do
      expect do
549
        repository.create_dir(user, 'newdir',
550
          message: 'Create newdir', branch_name: 'master')
551
      end.to change { repository.count_commits(ref: 'master') }.by(1)
552 553 554 555 556

      newdir = repository.tree('master', 'newdir')
      expect(newdir.path).to eq('newdir')
    end

557
    context "when committing to another project" do
558
      let(:forked_project) { create(:project, :repository) }
559 560 561

      it "creates a fork and commit to the forked project" do
        expect do
562
          repository.create_dir(user, 'newdir',
563
            message: 'Create newdir', branch_name: 'patch',
Lin Jen-Shin's avatar
Lin Jen-Shin committed
564
            start_branch_name: 'master', start_project: forked_project)
565
        end.to change { repository.count_commits(ref: 'master') }.by(0)
566 567 568 569 570 571 572 573 574

        expect(repository.branch_exists?('patch')).to be_truthy
        expect(forked_project.repository.branch_exists?('patch')).to be_falsy

        newdir = repository.tree('patch', 'newdir')
        expect(newdir.path).to eq('newdir')
      end
    end

575 576 577
    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
578
          repository.create_dir(user, 'newdir',
579 580 581
            message: 'Add newdir',
            branch_name: 'master',
            author_email: author_email, author_name: author_name)
582
        end.to change { repository.count_commits(ref: 'master') }.by(1)
583 584 585 586 587 588 589 590 591

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

592 593
  describe "#create_file" do
    it 'commits new file successfully' do
594
      expect do
595 596 597
        repository.create_file(user, 'NEWCHANGELOG', 'Changelog!',
                               message: 'Create changelog',
                               branch_name: 'master')
598
      end.to change { repository.count_commits(ref: 'master') }.by(1)
599

600
      blob = repository.blob_at('master', 'NEWCHANGELOG')
601

602
      expect(blob.data).to eq('Changelog!')
603
    end
604

605
    it 'creates new file and dir when file_path has a forward slash' do
606
      expect do
607 608
        repository.create_file(user, 'new_dir/new_file.txt', 'File!',
                               message: 'Create new_file with new_dir',
609
                               branch_name: 'master')
610
      end.to change { repository.count_commits(ref: 'master') }.by(1)
611

612 613
      expect(repository.tree('master', 'new_dir').path).to eq('new_dir')
      expect(repository.blob_at('master', 'new_dir/new_file.txt').data).to eq('File!')
614 615
    end

616
    it 'respects the autocrlf setting' do
617
      repository.create_file(user, 'hello.txt', "Hello,\r\nWorld",
618
                             message: 'Add hello world',
619
                             branch_name: 'master')
620 621 622 623 624 625

      blob = repository.blob_at('master', 'hello.txt')

      expect(blob.data).to eq("Hello,\nWorld")
    end

626 627 628
    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
629
          repository.create_file(user, 'NEWREADME', 'README!',
630 631 632 633
                                 message: 'Add README',
                                 branch_name: 'master',
                                 author_email: author_email,
                                 author_name: author_name)
634
        end.to change { repository.count_commits(ref: 'master') }.by(1)
635 636 637 638 639 640 641

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
642 643
  end

644
  describe "#update_file" do
645 646 647 648 649
    it 'updates file successfully' do
      expect do
        repository.update_file(user, 'CHANGELOG', 'Changelog!',
                               message: 'Update changelog',
                               branch_name: 'master')
650
      end.to change { repository.count_commits(ref: 'master') }.by(1)
651 652 653 654 655 656

      blob = repository.blob_at('master', 'CHANGELOG')

      expect(blob.data).to eq('Changelog!')
    end

657
    it 'updates filename successfully' do
658 659
      expect do
        repository.update_file(user, 'NEWLICENSE', 'Copyright!',
660
                                     branch_name: 'master',
661
                                     previous_path: 'LICENSE',
662
                                     message: 'Changes filename')
663
      end.to change { repository.count_commits(ref: 'master') }.by(1)
664 665 666 667 668 669

      files = repository.ls_files('master')

      expect(files).not_to include('LICENSE')
      expect(files).to include('NEWLICENSE')
    end
670 671 672 673

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
674 675 676 677 678 679
          repository.update_file(user, 'README', 'Updated README!',
                                 branch_name: 'master',
                                 previous_path: 'README',
                                 message: 'Update README',
                                 author_email: author_email,
                                 author_name: author_name)
680
        end.to change { repository.count_commits(ref: 'master') }.by(1)
681 682 683 684 685 686 687 688 689

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

Douwe Maan's avatar
Douwe Maan committed
690
  describe "#delete_file" do
691 692
    it 'removes file successfully' do
      expect do
693
        repository.delete_file(user, 'README',
694
          message: 'Remove README', branch_name: 'master')
695
      end.to change { repository.count_commits(ref: 'master') }.by(1)
696 697 698 699 700 701 702

      expect(repository.blob_at('master', 'README')).to be_nil
    end

    context "when an author is specified" do
      it "uses the given email/name to set the commit's author" do
        expect do
703
          repository.delete_file(user, 'README',
704 705
            message: 'Remove README', branch_name: 'master',
            author_email: author_email, author_name: author_name)
706
        end.to change { repository.count_commits(ref: 'master') }.by(1)
707 708 709 710 711 712 713 714 715

        last_commit = repository.commit

        expect(last_commit.author_email).to eq(author_email)
        expect(last_commit.author_name).to eq(author_name)
      end
    end
  end

716
  describe "search_files_by_content" do
717
    let(:results) { repository.search_files_by_content('feature', 'master') }
718 719 720 721
    subject { results }

    it { is_expected.to be_an Array }

722
    it 'regex-escapes the query string' do
723
      results = repository.search_files_by_content("test\\", 'master')
724 725 726 727

      expect(results.first).not_to start_with('fatal:')
    end

728
    it 'properly handles an unmatched parenthesis' do
729
      results = repository.search_files_by_content("test(", 'master')
730 731 732 733

      expect(results.first).not_to start_with('fatal:')
    end

Valery Sizov's avatar
Valery Sizov committed
734
    it 'properly handles when query is not present' do
735
      results = repository.search_files_by_content('', 'master')
Valery Sizov's avatar
Valery Sizov committed
736 737 738 739 740

      expect(results).to match_array([])
    end

    it 'properly handles query when repo is empty' do
741
      repository = create(:project, :empty_repo).repository
742
      results = repository.search_files_by_content('test', 'master')
Valery Sizov's avatar
Valery Sizov committed
743 744 745 746

      expect(results).to match_array([])
    end

747
    describe 'when storage is broken', :broken_storage do
748
      it 'raises a storage error' do
749 750 751 752 753 754
        expect_to_raise_storage_error do
          broken_repository.search_files_by_content('feature', 'master')
        end
      end
    end

755 756 757 758
    describe 'result' do
      subject { results.first }

      it { is_expected.to be_an String }
759
      it { expect(subject.lines[2]).to eq("master:CHANGELOG\x00190\x00  - Feature: Replace teams with group membership\n") }
760 761
    end
  end
762

763
  describe "search_files_by_name" do
764 765 766 767 768 769
    let(:results) { repository.search_files_by_name('files', 'master') }

    it 'returns result' do
      expect(results.first).to eq('files/html/500.html')
    end

Andrew McCallum's avatar
Andrew McCallum committed
770 771
    it 'ignores leading slashes' do
      results = repository.search_files_by_name('/files', 'master')
772

773 774 775
      expect(results.first).to eq('files/html/500.html')
    end

776
    it 'properly handles when query is only slashes' do
777
      results = repository.search_files_by_name('//', 'master')
778

779
      expect(results).to match_array([])
780 781
    end

782 783 784 785 786 787 788
    it 'properly handles when query is not present' do
      results = repository.search_files_by_name('', 'master')

      expect(results).to match_array([])
    end

    it 'properly handles query when repo is empty' do
789
      repository = create(:project, :empty_repo).repository
790 791 792 793 794

      results = repository.search_files_by_name('test', 'master')

      expect(results).to match_array([])
    end
795

796
    describe 'when storage is broken', :broken_storage do
797
      it 'raises a storage error' do
798 799 800 801 802
        expect_to_raise_storage_error { broken_repository.search_files_by_name('files', 'master') }
      end
    end
  end

803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834
  describe '#async_remove_remote' do
    before do
      masterrev = repository.find_branch('master').dereferenced_target
      create_remote_branch('joe', 'remote_branch', masterrev)
    end

    context 'when worker is scheduled successfully' do
      before do
        masterrev = repository.find_branch('master').dereferenced_target
        create_remote_branch('remote_name', 'remote_branch', masterrev)

        allow(RepositoryRemoveRemoteWorker).to receive(:perform_async).and_return('1234')
      end

      it 'returns job_id' do
        expect(repository.async_remove_remote('joe')).to eq('1234')
      end
    end

    context 'when worker does not schedule successfully' do
      before do
        allow(RepositoryRemoveRemoteWorker).to receive(:perform_async).and_return(nil)
      end

      it 'returns nil' do
        expect(Rails.logger).to receive(:info).with("Remove remote job failed to create for #{project.id} with remote name joe.")

        expect(repository.async_remove_remote('joe')).to be_nil
      end
    end
  end

835
  describe '#fetch_ref' do
836
    let(:broken_repository) { create(:project, :broken_storage).repository }
837

838
    describe 'when storage is broken', :broken_storage do
839
      it 'raises a storage error' do
840 841 842
        expect_to_raise_storage_error do
          broken_repository.fetch_ref(broken_repository, source_ref: '1', target_ref: '2')
        end
843 844
      end
    end
845 846
  end

847
  describe '#create_ref' do
848
    it 'redirects the call to write_ref' do
849 850
      ref, ref_path = '1', '2'

851
      expect(repository.raw_repository).to receive(:write_ref).with(ref_path, ref)
852 853 854 855 856

      repository.create_ref(ref, ref_path)
    end
  end

857
  describe "#changelog", :use_clean_rails_memory_store_caching do
858 859 860
    it 'accepts changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('changelog')])

861
      expect(repository.changelog.path).to eq('changelog')
862 863 864 865 866
    end

    it 'accepts news instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('news')])

867
      expect(repository.changelog.path).to eq('news')
868 869 870 871 872
    end

    it 'accepts history instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('history')])

873
      expect(repository.changelog.path).to eq('history')
874 875 876 877 878
    end

    it 'accepts changes instead of changelog' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('changes')])

879
      expect(repository.changelog.path).to eq('changes')
880 881 882 883 884
    end

    it 'is case-insensitive' do
      expect(repository.tree).to receive(:blobs).and_return([TestBlob.new('CHANGELOG')])

885
      expect(repository.changelog.path).to eq('CHANGELOG')
886 887 888
    end
  end

889
  describe "#license_blob", :use_clean_rails_memory_store_caching do
890
    before do
891
      repository.delete_file(
892
        user, 'LICENSE', message: 'Remove LICENSE', branch_name: 'master')
893 894
    end

895
    it 'handles when HEAD points to non-existent ref' do
896
      repository.create_file(
897
        user, 'LICENSE', 'Copyright!',
898
        message: 'Add LICENSE', branch_name: 'master')
899

900
      allow(repository).to receive(:root_ref).and_raise(Gitlab::Git::Repository::NoRepository)
901 902 903 904

      expect(repository.license_blob).to be_nil
    end

905
    it 'looks in the root_ref only' do
906
      repository.delete_file(user, 'LICENSE',
907
        message: 'Remove LICENSE', branch_name: 'markdown')
908
      repository.create_file(user, 'LICENSE',
909
        Licensee::License.new('mit').content,
910
        message: 'Add LICENSE', branch_name: 'markdown')
911 912 913 914

      expect(repository.license_blob).to be_nil
    end

915
    it 'detects license file with no recognizable open-source license content' do
916 917
      repository.create_file(user, 'LICENSE', 'Copyright!',
        message: 'Add LICENSE', branch_name: 'master')
918

919
      expect(repository.license_blob.path).to eq('LICENSE')
920 921
    end

922 923
    %w[LICENSE LICENCE LiCensE LICENSE.md LICENSE.foo COPYING COPYING.md].each do |filename|
      it "detects '#{filename}'" do
924
        repository.create_file(user, filename,
925
          Licensee::License.new('mit').content,
926
          message: "Add #{filename}", branch_name: 'master')
927

928 929
        expect(repository.license_blob.name).to eq(filename)
      end
930 931 932
    end
  end

933
  describe '#license_key', :use_clean_rails_memory_store_caching do
934
    before do
935
      repository.delete_file(user, 'LICENSE',
936
        message: 'Remove LICENSE', branch_name: 'master')
937
    end
938

939
    it 'returns nil when no license is detected' do
940 941 942
      expect(repository.license_key).to be_nil
    end

943 944 945
    it 'returns nil when the repository does not exist' do
      expect(repository).to receive(:exists?).and_return(false)

946 947 948
      expect(repository.license_key).to be_nil
    end

949
    it 'returns nil when the content is not recognizable' do
950
      repository.create_file(user, 'LICENSE', 'Gitlab B.V.',
951
        message: 'Add LICENSE', branch_name: 'master')
952 953

      expect(repository.license_key).to be_nil
954
    end
955

956 957 958 959 960 961
    it 'returns nil when the commit SHA does not exist' do
      allow(repository.head_commit).to receive(:sha).and_return('1' * 40)

      expect(repository.license_key).to be_nil
    end

962
    it 'returns nil when master does not exist' do
963 964
      repository.rm_branch(user, 'master')

965
      expect(repository.license_key).to be_nil
966 967
    end

968
    it 'returns the license key' do
969
      repository.create_file(user, 'LICENSE',
970
        Licensee::License.new('mit').content,
971
        message: 'Add LICENSE', branch_name: 'master')
972

973
      expect(repository.license_key).to eq('mit')
974
    end
975
  end
976

977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993
  describe '#license' do
    before do
      repository.delete_file(user, 'LICENSE',
        message: 'Remove LICENSE', branch_name: 'master')
    end

    it 'returns nil when no license is detected' do
      expect(repository.license).to be_nil
    end

    it 'returns nil when the repository does not exist' do
      expect(repository).to receive(:exists?).and_return(false)

      expect(repository.license).to be_nil
    end

    it 'returns nil when the content is not recognizable' do
994
      repository.create_file(user, 'LICENSE', 'Gitlab B.V.',
995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009
        message: 'Add LICENSE', branch_name: 'master')

      expect(repository.license).to be_nil
    end

    it 'returns the license' do
      license = Licensee::License.new('mit')
      repository.create_file(user, 'LICENSE',
        license.content,
        message: 'Add LICENSE', branch_name: 'master')

      expect(repository.license).to eq(license)
    end
  end

1010
  describe "#gitlab_ci_yml", :use_clean_rails_memory_store_caching do
1011 1012 1013 1014
    it 'returns valid file' do
      files = [TestBlob.new('file'), TestBlob.new('.gitlab-ci.yml'), TestBlob.new('copying')]
      expect(repository.tree).to receive(:blobs).and_return(files)

1015
      expect(repository.gitlab_ci_yml.path).to eq('.gitlab-ci.yml')
1016 1017 1018 1019 1020 1021 1022 1023
    end

    it 'returns nil if not exists' do
      expect(repository.tree).to receive(:blobs).and_return([])
      expect(repository.gitlab_ci_yml).to be_nil
    end

    it 'returns nil for empty repository' do
1024
      allow(repository).to receive(:root_ref).and_raise(Gitlab::Git::Repository::NoRepository)
1025 1026 1027 1028
      expect(repository.gitlab_ci_yml).to be_nil
    end
  end

1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039
  describe '#ambiguous_ref?' do
    let(:ref) { 'ref' }

    subject { repository.ambiguous_ref?(ref) }

    context 'when ref is ambiguous' do
      before do
        repository.add_tag(project.creator, ref, 'master')
        repository.add_branch(project.creator, ref, 'master')
      end

1040
      it 'is true' do
1041 1042 1043 1044 1045 1046 1047 1048 1049
        is_expected.to eq(true)
      end
    end

    context 'when ref is not ambiguous' do
      before do
        repository.add_tag(project.creator, ref, 'master')
      end

1050
      it 'is false' do
1051 1052 1053 1054 1055
        is_expected.to eq(false)
      end
    end
  end

1056
  describe '#expand_ref' do
1057 1058
    let(:ref) { 'ref' }

1059
    subject { repository.expand_ref(ref) }
1060

1061
    context 'when ref is not tag or branch name' do
1062 1063
      let(:ref) { 'refs/heads/master' }

1064 1065
      it 'returns nil' do
        is_expected.to eq(nil)
1066 1067 1068
      end
    end

1069 1070 1071
    context 'when ref is tag name' do
      before do
        repository.add_tag(project.creator, ref, 'master')
1072 1073
      end

1074 1075
      it 'returns the tag ref' do
        is_expected.to eq("refs/tags/#{ref}")
1076
      end
1077
    end
1078

1079 1080 1081 1082
    context 'when ref is branch name' do
      before do
        repository.add_branch(project.creator, ref, 'master')
      end
1083

1084 1085
      it 'returns the branch ref' do
        is_expected.to eq("refs/heads/#{ref}")
1086 1087 1088 1089
      end
    end
  end

1090
  describe '#add_branch' do
1091 1092
    let(:branch_name) { 'new_feature' }
    let(:target) { 'master' }
1093

1094
    subject { repository.add_branch(user, branch_name, target) }
1095

1096 1097 1098 1099
    it "calls Gitaly's OperationService" do
      expect_any_instance_of(Gitlab::GitalyClient::OperationService)
        .to receive(:user_create_branch).with(branch_name, user, target)
        .and_return(nil)
1100

1101
      subject
1102 1103
    end

1104 1105 1106 1107
    it 'creates_the_branch' do
      expect(subject.name).to eq(branch_name)
      expect(repository.find_branch(branch_name)).not_to be_nil
    end
1108

1109 1110
    context 'with a non-existing target' do
      let(:target) { 'fake-target' }
1111

1112 1113 1114
      it "returns false and doesn't create the branch" do
        expect(subject).to be(false)
        expect(repository.find_branch(branch_name)).to be_nil
1115 1116 1117 1118
      end
    end
  end

1119
  shared_examples 'asymmetric cached method' do |method|
1120 1121 1122 1123 1124 1125
    context 'asymmetric caching', :use_clean_rails_memory_store_caching, :request_store do
      let(:cache) { repository.send(:cache) }
      let(:request_store_cache) { repository.send(:request_store_cache) }

      context 'when it returns true' do
        before do
1126
          expect(repository.raw_repository).to receive(method).once.and_return(true)
1127 1128 1129 1130
        end

        it 'caches the output in RequestStore' do
          expect do
1131 1132
            repository.send(method)
          end.to change { request_store_cache.read(method) }.from(nil).to(true)
1133 1134 1135 1136
        end

        it 'caches the output in RepositoryCache' do
          expect do
1137 1138
            repository.send(method)
          end.to change { cache.read(method) }.from(nil).to(true)
1139 1140 1141 1142 1143
        end
      end

      context 'when it returns false' do
        before do
1144
          expect(repository.raw_repository).to receive(method).once.and_return(false)
1145 1146 1147 1148
        end

        it 'caches the output in RequestStore' do
          expect do
1149 1150
            repository.send(method)
          end.to change { request_store_cache.read(method) }.from(nil).to(false)
1151 1152 1153 1154
        end

        it 'does NOT cache the output in RepositoryCache' do
          expect do
1155 1156
            repository.send(method)
          end.not_to change { cache.read(method) }.from(nil)
1157 1158 1159
        end
      end
    end
1160
  end
1161

1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173
  describe '#exists?' do
    it 'returns true when a repository exists' do
      expect(repository.exists?).to be(true)
    end

    it 'returns false if no full path can be constructed' do
      allow(repository).to receive(:full_path).and_return(nil)

      expect(repository.exists?).to be(false)
    end

    context 'with broken storage', :broken_storage do
1174
      it 'raises a storage error' do
1175 1176 1177 1178 1179 1180 1181
        expect_to_raise_storage_error { broken_repository.exists? }
      end
    end

    it_behaves_like 'asymmetric cached method', :exists?
  end

1182
  describe '#has_visible_content?' do
1183 1184 1185 1186 1187 1188 1189
    before do
      # If raw_repository.has_visible_content? gets called more than once then
      # caching is broken. We don't want that.
      expect(repository.raw_repository).to receive(:has_visible_content?)
        .once
        .and_return(result)
    end
1190

1191 1192
    context 'when true' do
      let(:result) { true }
1193

1194 1195 1196 1197 1198
      it 'returns true and caches it' do
        expect(repository.has_visible_content?).to eq(true)
        # Second call hits the cache
        expect(repository.has_visible_content?).to eq(true)
      end
1199 1200
    end

1201 1202
    context 'when false' do
      let(:result) { false }
1203

1204 1205 1206 1207
      it 'returns false and caches it' do
        expect(repository.has_visible_content?).to eq(false)
        # Second call hits the cache
        expect(repository.has_visible_content?).to eq(false)
1208 1209 1210 1211
      end
    end
  end

1212 1213 1214 1215 1216 1217 1218 1219 1220
  describe '#branch_exists?' do
    it 'uses branch_names' do
      allow(repository).to receive(:branch_names).and_return(['foobar'])

      expect(repository.branch_exists?('foobar')).to eq(true)
      expect(repository.branch_exists?('master')).to eq(false)
    end
  end

1221 1222 1223 1224 1225 1226 1227 1228 1229
  describe '#tag_exists?' do
    it 'uses tag_names' do
      allow(repository).to receive(:tag_names).and_return(['foobar'])

      expect(repository.tag_exists?('foobar')).to eq(true)
      expect(repository.tag_exists?('master')).to eq(false)
    end
  end

1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245
  describe '#branch_names', :use_clean_rails_memory_store_caching do
    let(:fake_branch_names) { ['foobar'] }

    it 'gets cached across Repository instances' do
      allow(repository.raw_repository).to receive(:branch_names).once.and_return(fake_branch_names)

      expect(repository.branch_names).to eq(fake_branch_names)

      fresh_repository = Project.find(project.id).repository
      expect(fresh_repository.object_id).not_to eq(repository.object_id)

      expect(fresh_repository.raw_repository).not_to receive(:branch_names)
      expect(fresh_repository.branch_names).to eq(fake_branch_names)
    end
  end

1246 1247 1248 1249
  describe '#empty?' do
    let(:empty_repository) { create(:project_empty_repo).repository }

    it 'returns true for an empty repository' do
1250
      expect(empty_repository).to be_empty
1251 1252 1253
    end

    it 'returns false for a non-empty repository' do
1254
      expect(repository).not_to be_empty
1255 1256 1257
    end

    it 'caches the output' do
1258
      expect(repository.raw_repository).to receive(:has_visible_content?).once
1259 1260 1261 1262 1263 1264

      repository.empty?
      repository.empty?
    end
  end

1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285
  describe '#blobs_at' do
    let(:empty_repository) { create(:project_empty_repo).repository }

    it 'returns empty array for an empty repository' do
      # rubocop:disable Style/WordArray
      expect(empty_repository.blobs_at(['master', 'foobar'])).to eq([])
      # rubocop:enable Style/WordArray
    end

    it 'returns blob array for a non-empty repository' do
      repository.create_file(User.last, 'foobar', 'CONTENT', message: 'message', branch_name: 'master')

      # rubocop:disable Style/WordArray
      blobs = repository.blobs_at([['master', 'foobar']])
      # rubocop:enable Style/WordArray

      expect(blobs.first.name).to eq('foobar')
      expect(blobs.size).to eq(1)
    end
  end

1286 1287 1288 1289 1290 1291
  describe '#root_ref' do
    it 'returns a branch name' do
      expect(repository.root_ref).to be_an_instance_of(String)
    end

    it 'caches the output' do
1292 1293 1294
      expect(repository.raw_repository).to receive(:root_ref)
        .once
        .and_return('master')
1295 1296 1297 1298

      repository.root_ref
      repository.root_ref
    end
1299 1300

    it_behaves_like 'asymmetric cached method', :root_ref
1301 1302 1303 1304 1305 1306
  end

  describe '#expire_root_ref_cache' do
    it 'expires the root reference cache' do
      repository.root_ref

1307 1308 1309
      expect(repository.raw_repository).to receive(:root_ref)
        .once
        .and_return('foo')
1310 1311 1312 1313 1314 1315 1316

      repository.expire_root_ref_cache

      expect(repository.root_ref).to eq('foo')
    end
  end

1317
  describe '#expire_branch_cache' do
1318 1319 1320 1321 1322
    # This method is private but we need it for testing purposes. Sadly there's
    # no other proper way of testing caching operations.
    let(:cache) { repository.send(:cache) }

    it 'expires the cache for all branches' do
1323 1324 1325
      expect(cache).to receive(:expire)
        .at_least(repository.branches.length * 2)
        .times
1326 1327 1328 1329 1330

      repository.expire_branch_cache
    end

    it 'expires the cache for all branches when the root branch is given' do
1331 1332 1333
      expect(cache).to receive(:expire)
        .at_least(repository.branches.length * 2)
        .times
1334 1335 1336 1337 1338

      repository.expire_branch_cache(repository.root_ref)
    end

    it 'expires the cache for a specific branch' do
1339
      expect(cache).to receive(:expire).twice
1340 1341 1342 1343

      repository.expire_branch_cache('foo')
    end
  end
1344

1345 1346 1347
  describe '#expire_emptiness_caches' do
    let(:cache) { repository.send(:cache) }

1348 1349 1350
    it 'expires the caches for an empty repository' do
      allow(repository).to receive(:empty?).and_return(true)

1351
      expect(cache).to receive(:expire).with(:has_visible_content?)
1352 1353 1354

      repository.expire_emptiness_caches
    end
1355 1356 1357 1358

    it 'does not expire the cache for a non-empty repository' do
      allow(repository).to receive(:empty?).and_return(false)

1359
      expect(cache).not_to receive(:expire).with(:has_visible_content?)
1360 1361 1362

      repository.expire_emptiness_caches
    end
1363 1364 1365 1366 1367 1368

    it 'expires the memoized repository cache' do
      allow(repository.raw_repository).to receive(:expire_has_local_branches_cache).and_call_original

      repository.expire_emptiness_caches
    end
1369 1370
  end

1371
  describe 'skip_merges option' do
1372
    subject { repository.commits(Gitlab::Git::BRANCH_REF_PREFIX + "'test'", limit: 100, skip_merges: true).map { |k| k.id } }
1373 1374 1375

    it { is_expected.not_to include('e56497bb5f03a90a51293fc6d516788730953899') }
  end
1376 1377

  describe '#merge' do
1378
    let(:merge_request) { create(:merge_request, source_branch: 'feature', target_branch: 'master', source_project: project) }
1379
    let(:message) { 'Test \r\n\r\n message' }
1380

1381 1382 1383 1384
    it 'merges the code and returns the commit id' do
      expect(merge_commit).to be_present
      expect(repository.blob_at(merge_commit.id, 'files/ruby/feature.rb')).to be_present
    end
1385

1386 1387
    it 'sets the `in_progress_merge_commit_sha` flag for the given merge request' do
      merge_commit_id = merge(repository, user, merge_request, message)
1388

1389
      expect(merge_request.in_progress_merge_commit_sha).to eq(merge_commit_id)
1390
    end
1391

1392 1393
    it 'removes carriage returns from commit message' do
      merge_commit_id = merge(repository, user, merge_request, message)
1394

1395
      expect(repository.commit(merge_commit_id).message).to eq(message.delete("\r"))
1396 1397
    end

1398 1399
    def merge(repository, user, merge_request, message)
      repository.merge(user, merge_request.diff_head_sha, merge_request, message)
1400
    end
1401 1402
  end

1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425
  describe '#merge_to_ref' do
    let(:merge_request) do
      create(:merge_request, source_branch: 'feature',
                             target_branch: 'master',
                             source_project: project)
    end

    it 'writes merge of source and target to MR merge_ref_path' do
      merge_commit_id = repository.merge_to_ref(user,
                                                merge_request.diff_head_sha,
                                                merge_request,
                                                merge_request.merge_ref_path,
                                                'Custom message')

      merge_commit = repository.commit(merge_commit_id)

      expect(merge_commit.message).to eq('Custom message')
      expect(merge_commit.author_name).to eq(user.name)
      expect(merge_commit.author_email).to eq(user.commit_email)
      expect(repository.blob_at(merge_commit.id, 'files/ruby/feature.rb')).to be_present
    end
  end

1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453
  describe '#ff_merge' do
    before do
      repository.add_branch(user, 'ff-target', 'feature~5')
    end

    it 'merges the code and return the commit id' do
      merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'ff-target', source_project: project)
      merge_commit_id = repository.ff_merge(user,
                                            merge_request.diff_head_sha,
                                            merge_request.target_branch,
                                            merge_request: merge_request)
      merge_commit = repository.commit(merge_commit_id)

      expect(merge_commit).to be_present
      expect(repository.blob_at(merge_commit.id, 'files/ruby/feature.rb')).to be_present
    end

    it 'sets the `in_progress_merge_commit_sha` flag for the given merge request' do
      merge_request = create(:merge_request, source_branch: 'feature', target_branch: 'ff-target', source_project: project)
      merge_commit_id = repository.ff_merge(user,
                                            merge_request.diff_head_sha,
                                            merge_request.target_branch,
                                            merge_request: merge_request)

      expect(merge_request.in_progress_merge_commit_sha).to eq(merge_commit_id)
    end
  end

1454
  describe '#revert' do
1455 1456 1457
    let(:new_image_commit) { repository.commit('33f3729a45c02fc67d00adb1b8bca394b0e761d9') }
    let(:update_image_commit) { repository.commit('2f63565e7aac07bcdadb654e253078b727143ec4') }
    let(:message) { 'revert message' }
1458

1459 1460 1461
    context 'when there is a conflict' do
      it 'raises an error' do
        expect { repository.revert(user, new_image_commit, 'master', message) }.to raise_error(Gitlab::Git::Repository::CreateTreeError)
1462
      end
1463
    end
1464

1465 1466 1467
    context 'when commit was already reverted' do
      it 'raises an error' do
        repository.revert(user, update_image_commit, 'master', message)
1468

1469
        expect { repository.revert(user, update_image_commit, 'master', message) }.to raise_error(Gitlab::Git::Repository::CreateTreeError)
1470
      end
1471
    end
1472

1473 1474 1475 1476
    context 'when commit can be reverted' do
      it 'reverts the changes' do
        expect(repository.revert(user, update_image_commit, 'master', message)).to be_truthy
      end
1477 1478
    end

1479 1480 1481 1482 1483 1484 1485 1486
    context 'reverting a merge commit' do
      it 'reverts the changes' do
        merge_commit
        expect(repository.blob_at_branch('master', 'files/ruby/feature.rb')).to be_present

        repository.revert(user, merge_commit, 'master', message)
        expect(repository.blob_at_branch('master', 'files/ruby/feature.rb')).not_to be_present
      end
1487
    end
1488
  end
1489

1490
  describe '#cherry_pick' do
1491 1492 1493 1494 1495 1496 1497 1498
    let(:conflict_commit) { repository.commit('c642fe9b8b9f28f9225d7ea953fe14e74748d53b') }
    let(:pickable_commit) { repository.commit('7d3b0f7cff5f37573aea97cebfd5692ea1689924') }
    let(:pickable_merge) { repository.commit('e56497bb5f03a90a51293fc6d516788730953899') }
    let(:message) { 'cherry-pick message' }

    context 'when there is a conflict' do
      it 'raises an error' do
        expect { repository.cherry_pick(user, conflict_commit, 'master', message) }.to raise_error(Gitlab::Git::Repository::CreateTreeError)
1499
      end
1500
    end
1501

1502 1503 1504
    context 'when commit was already cherry-picked' do
      it 'raises an error' do
        repository.cherry_pick(user, pickable_commit, 'master', message)
1505

1506
        expect { repository.cherry_pick(user, pickable_commit, 'master', message) }.to raise_error(Gitlab::Git::Repository::CreateTreeError)
1507
      end
1508
    end
1509

1510 1511 1512
    context 'when commit can be cherry-picked' do
      it 'cherry-picks the changes' do
        expect(repository.cherry_pick(user, pickable_commit, 'master', message)).to be_truthy
1513
      end
1514
    end
1515

1516 1517 1518
    context 'cherry-picking a merge commit' do
      it 'cherry-picks the changes' do
        expect(repository.blob_at_branch('improve/awesome', 'foo/bar/.gitkeep')).to be_nil
1519

1520 1521
        cherry_pick_commit_sha = repository.cherry_pick(user, pickable_merge, 'improve/awesome', message)
        cherry_pick_commit_message = project.commit(cherry_pick_commit_sha).message
1522

1523 1524
        expect(repository.blob_at_branch('improve/awesome', 'foo/bar/.gitkeep')).not_to be_nil
        expect(cherry_pick_commit_message).to eq(message)
1525 1526 1527 1528
      end
    end
  end

1529 1530 1531 1532 1533 1534 1535
  describe '#before_delete' do
    describe 'when a repository does not exist' do
      before do
        allow(repository).to receive(:exists?).and_return(false)
      end

      it 'does not flush caches that depend on repository data' do
1536
        expect(repository).not_to receive(:expire_cache)
1537 1538 1539 1540

        repository.before_delete
      end

1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552
      it 'flushes the tags cache' do
        expect(repository).to receive(:expire_tags_cache)

        repository.before_delete
      end

      it 'flushes the branches cache' do
        expect(repository).to receive(:expire_branches_cache)

        repository.before_delete
      end

1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563
      it 'flushes the root ref cache' do
        expect(repository).to receive(:expire_root_ref_cache)

        repository.before_delete
      end

      it 'flushes the emptiness caches' do
        expect(repository).to receive(:expire_emptiness_caches)

        repository.before_delete
      end
1564 1565

      it 'flushes the exists cache' do
1566
        expect(repository).to receive(:expire_exists_cache).twice
1567 1568 1569

        repository.before_delete
      end
1570 1571 1572 1573 1574 1575 1576
    end

    describe 'when a repository exists' do
      before do
        allow(repository).to receive(:exists?).and_return(true)
      end

1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588
      it 'flushes the tags cache' do
        expect(repository).to receive(:expire_tags_cache)

        repository.before_delete
      end

      it 'flushes the branches cache' do
        expect(repository).to receive(:expire_branches_cache)

        repository.before_delete
      end

1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616
      it 'flushes the root ref cache' do
        expect(repository).to receive(:expire_root_ref_cache)

        repository.before_delete
      end

      it 'flushes the emptiness caches' do
        expect(repository).to receive(:expire_emptiness_caches)

        repository.before_delete
      end
    end
  end

  describe '#before_change_head' do
    it 'flushes the branch cache' do
      expect(repository).to receive(:expire_branch_cache)

      repository.before_change_head
    end

    it 'flushes the root ref cache' do
      expect(repository).to receive(:expire_root_ref_cache)

      repository.before_change_head
    end
  end

1617
  describe '#after_change_head' do
1618
    it 'flushes the method caches' do
1619
      expect(repository).to receive(:expire_method_caches).with([
1620 1621 1622
        :size,
        :commit_count,
        :rendered_readme,
1623
        :readme_path,
1624
        :contribution_guide,
1625
        :changelog,
1626 1627
        :license_blob,
        :license_key,
1628
        :gitignore,
1629 1630 1631 1632 1633
        :gitlab_ci_yml,
        :branch_names,
        :tag_names,
        :branch_count,
        :tag_count,
1634
        :avatar,
1635 1636 1637 1638 1639
        :exists?,
        :root_ref,
        :has_visible_content?,
        :issue_template_names,
        :merge_request_template_names,
Rémy Coutable's avatar
Rémy Coutable committed
1640
        :xcode_project?
1641 1642 1643 1644 1645 1646
      ])

      repository.after_change_head
    end
  end

1647
  describe '#before_push_tag' do
1648
    it 'flushes the cache' do
1649 1650 1651
      expect(repository).to receive(:expire_statistics_caches)
      expect(repository).to receive(:expire_emptiness_caches)
      expect(repository).to receive(:expire_tags_cache)
1652

1653
      repository.before_push_tag
1654 1655 1656 1657
    end
  end

  describe '#after_import' do
1658 1659
    it 'flushes and builds the cache' do
      expect(repository).to receive(:expire_content_cache)
1660 1661 1662

      repository.after_import
    end
1663 1664 1665
  end

  describe '#after_push_commit' do
1666
    it 'expires statistics caches' do
1667 1668
      expect(repository).to receive(:expire_statistics_caches)
        .and_call_original
1669

1670 1671 1672
      expect(repository).to receive(:expire_branch_cache)
        .with('master')
        .and_call_original
1673

1674
      repository.after_push_commit('master')
1675 1676 1677 1678
    end
  end

  describe '#after_create_branch' do
1679
    it 'expires the branch caches' do
1680
      expect(repository).to receive(:expire_branches_cache)
1681 1682 1683 1684 1685 1686

      repository.after_create_branch
    end
  end

  describe '#after_remove_branch' do
1687
    it 'expires the branch caches' do
1688
      expect(repository).to receive(:expire_branches_cache)
1689 1690 1691 1692

      repository.after_remove_branch
    end
  end
1693

1694 1695 1696 1697 1698 1699
  describe '#after_create' do
    it 'flushes the exists cache' do
      expect(repository).to receive(:expire_exists_cache)

      repository.after_create
    end
1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711

    it 'flushes the root ref cache' do
      expect(repository).to receive(:expire_root_ref_cache)

      repository.after_create
    end

    it 'flushes the emptiness caches' do
      expect(repository).to receive(:expire_emptiness_caches)

      repository.after_create
    end
1712 1713
  end

1714 1715 1716 1717 1718 1719 1720 1721 1722 1723
  describe "#copy_gitattributes" do
    it 'returns true with a valid ref' do
      expect(repository.copy_gitattributes('master')).to be_truthy
    end

    it 'returns false with an invalid ref' do
      expect(repository.copy_gitattributes('invalid')).to be_falsey
    end
  end

1724 1725
  describe '#before_remove_tag' do
    it 'flushes the tag cache' do
1726 1727
      expect(repository).to receive(:expire_tags_cache).and_call_original
      expect(repository).to receive(:expire_statistics_caches).and_call_original
1728 1729 1730 1731 1732 1733 1734

      repository.before_remove_tag
    end
  end

  describe '#branch_count' do
    it 'returns the number of branches' do
Douwe Maan's avatar
Douwe Maan committed
1735
      expect(repository.branch_count).to be_an(Integer)
Kim "BKC" Carlbäcker's avatar
Kim "BKC" Carlbäcker committed
1736

1737
      rugged_count = rugged_repo(repository).branches.count
Kim "BKC" Carlbäcker's avatar
Kim "BKC" Carlbäcker committed
1738

1739
      expect(repository.branch_count).to eq(rugged_count)
1740 1741 1742 1743 1744
    end
  end

  describe '#tag_count' do
    it 'returns the number of tags' do
Douwe Maan's avatar
Douwe Maan committed
1745
      expect(repository.tag_count).to be_an(Integer)
Kim "BKC" Carlbäcker's avatar
Kim "BKC" Carlbäcker committed
1746

1747
      rugged_count = rugged_repo(repository).tags.count
Kim "BKC" Carlbäcker's avatar
Kim "BKC" Carlbäcker committed
1748

1749
      expect(repository.tag_count).to eq(rugged_count)
1750 1751 1752
    end
  end

1753
  describe '#expire_branches_cache' do
1754
    it 'expires the cache' do
1755
      expect(repository).to receive(:expire_method_caches)
1756
        .with(%i(branch_names branch_count has_visible_content?))
1757
        .and_call_original
1758

1759
      repository.expire_branches_cache
1760 1761 1762
    end
  end

1763
  describe '#expire_tags_cache' do
1764
    it 'expires the cache' do
1765 1766 1767
      expect(repository).to receive(:expire_method_caches)
        .with(%i(tag_names tag_count))
        .and_call_original
1768

1769
      repository.expire_tags_cache
1770 1771
    end
  end
1772

1773
  describe '#add_tag' do
1774
    let(:user) { build_stubbed(:user) }
1775

1776 1777 1778
    context 'with a valid target' do
      it 'creates the tag' do
        repository.add_tag(user, '8.5', 'master', 'foo')
1779

1780 1781 1782 1783
        tag = repository.find_tag('8.5')
        expect(tag).to be_present
        expect(tag.message).to eq('foo')
        expect(tag.dereferenced_target.id).to eq(repository.commit('master').id)
1784
      end
1785

1786
      it 'returns a Gitlab::Git::Tag object' do
1787 1788
        tag = repository.add_tag(user, '8.5', 'master', 'foo')

1789 1790 1791
        expect(tag).to be_a(Gitlab::Git::Tag)
      end
    end
1792

1793 1794 1795
    context 'with an invalid target' do
      it 'returns false' do
        expect(repository.add_tag(user, '8.5', 'bar', 'foo')).to be false
1796
      end
1797 1798 1799
    end
  end

1800
  describe '#rm_branch' do
1801 1802 1803
    it 'removes a branch' do
      expect(repository).to receive(:before_remove_branch)
      expect(repository).to receive(:after_remove_branch)
1804

1805
      repository.rm_branch(user, 'feature')
1806
    end
1807

1808 1809 1810 1811
    context 'when pre hooks failed' do
      before do
        allow_any_instance_of(Gitlab::GitalyClient::OperationService)
          .to receive(:user_delete_branch).and_raise(Gitlab::Git::PreReceiveError)
1812 1813
      end

1814 1815 1816 1817
      it 'gets an error and does not delete the branch' do
        expect do
          repository.rm_branch(user, 'feature')
        end.to raise_error(Gitlab::Git::PreReceiveError)
1818

1819
        expect(repository.find_branch('feature')).not_to be_nil
1820
      end
1821 1822
    end
  end
1823 1824

  describe '#rm_tag' do
1825 1826
    it 'removes a tag' do
      expect(repository).to receive(:before_remove_tag)
1827

1828
      repository.rm_tag(build_stubbed(:user), 'v1.1.0')
1829

1830
      expect(repository.find_tag('v1.1.0')).to be_nil
1831 1832
    end
  end
1833 1834

  describe '#avatar' do
1835
    it 'returns nil if repo does not exist' do
1836
      allow(repository).to receive(:root_ref).and_raise(Gitlab::Git::Repository::NoRepository)
1837 1838 1839 1840

      expect(repository.avatar).to eq(nil)
    end

1841
    it 'returns the first avatar file found in the repository' do
1842 1843 1844
      expect(repository).to receive(:file_on_head)
        .with(:avatar)
        .and_return(double(:tree, path: 'logo.png'))
1845 1846 1847 1848 1849

      expect(repository.avatar).to eq('logo.png')
    end

    it 'caches the output' do
1850 1851 1852 1853
      expect(repository).to receive(:file_on_head)
        .with(:avatar)
        .once
        .and_return(double(:tree, path: 'logo.png'))
1854

1855
      2.times { expect(repository.avatar).to eq('logo.png') }
1856 1857
    end
  end
1858

1859 1860
  describe '#expire_exists_cache' do
    let(:cache) { repository.send(:cache) }
1861
    let(:request_store_cache) { repository.send(:request_store_cache) }
1862 1863 1864 1865 1866 1867

    it 'expires the cache' do
      expect(cache).to receive(:expire).with(:exists?)

      repository.expire_exists_cache
    end
1868 1869 1870 1871 1872 1873

    it 'expires the request store cache', :request_store do
      expect(request_store_cache).to receive(:expire).with(:exists?)

      repository.expire_exists_cache
    end
1874 1875
  end

1876 1877
  describe '#xcode_project?' do
    before do
1878
      allow(repository).to receive(:tree).with(:head).and_return(double(:tree, trees: [tree]))
1879 1880
    end

1881 1882
    context 'when the root contains a *.xcodeproj directory' do
      let(:tree) { double(:tree, path: 'Foo.xcodeproj') }
1883 1884 1885 1886 1887 1888

      it 'returns true' do
        expect(repository.xcode_project?).to be_truthy
      end
    end

1889 1890
    context 'when the root contains a *.xcworkspace directory' do
      let(:tree) { double(:tree, path: 'Foo.xcworkspace') }
1891 1892 1893 1894 1895 1896

      it 'returns true' do
        expect(repository.xcode_project?).to be_truthy
      end
    end

1897 1898
    context 'when the root contains no Xcode config directory' do
      let(:tree) { double(:tree, path: 'Foo') }
1899 1900 1901 1902 1903 1904 1905

      it 'returns false' do
        expect(repository.xcode_project?).to be_falsey
      end
    end
  end

1906
  describe "#keep_around" do
1907 1908 1909 1910
    it "does not fail if we attempt to reference bad commit" do
      expect(repository.kept_around?('abc1234')).to be_falsey
    end

1911 1912 1913 1914 1915
    it "stores a reference to the specified commit sha so it isn't garbage collected" do
      repository.keep_around(sample_commit.id)

      expect(repository.kept_around?(sample_commit.id)).to be_truthy
    end
1916 1917 1918 1919

    it "attempting to call keep_around on truncated ref does not fail" do
      repository.keep_around(sample_commit.id)
      ref = repository.send(:keep_around_ref_name, sample_commit.id)
1920 1921 1922 1923

      path = Gitlab::GitalyClient::StorageSettings.allow_disk_access do
        File.join(repository.path, ref)
      end
1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934
      # Corrupt the reference
      File.truncate(path, 0)

      expect(repository.kept_around?(sample_commit.id)).to be_falsey

      repository.keep_around(sample_commit.id)

      expect(repository.kept_around?(sample_commit.id)).to be_falsey

      File.delete(path)
    end
1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952

    context 'for multiple SHAs' do
      it 'skips non-existent SHAs' do
        repository.keep_around('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa', sample_commit.id)

        expect(repository.kept_around?(sample_commit.id)).to be_truthy
      end

      it 'skips already-kept-around SHAs' do
        repository.keep_around(sample_commit.id)

        expect(repository.raw_repository).to receive(:write_ref).exactly(1).and_call_original

        repository.keep_around(sample_commit.id, another_sample_commit.id)

        expect(repository.kept_around?(another_sample_commit.id)).to be_truthy
      end
    end
1953
  end
1954

1955
  describe '#contribution_guide', :use_clean_rails_memory_store_caching do
1956
    it 'returns and caches the output' do
1957 1958 1959 1960
      expect(repository).to receive(:file_on_head)
        .with(:contributing)
        .and_return(Gitlab::Git::Tree.new(path: 'CONTRIBUTING.md'))
        .once
1961 1962

      2.times do
1963 1964
        expect(repository.contribution_guide)
          .to be_an_instance_of(Gitlab::Git::Tree)
1965 1966 1967 1968
      end
    end
  end

1969
  describe '#gitignore', :use_clean_rails_memory_store_caching do
1970
    it 'returns and caches the output' do
1971 1972 1973 1974
      expect(repository).to receive(:file_on_head)
        .with(:gitignore)
        .and_return(Gitlab::Git::Tree.new(path: '.gitignore'))
        .once
1975 1976

      2.times do
1977
        expect(repository.gitignore).to be_an_instance_of(Gitlab::Git::Tree)
1978 1979 1980 1981
      end
    end
  end

1982
  describe '#readme', :use_clean_rails_memory_store_caching do
1983
    context 'with a non-existing repository' do
1984
      let(:project) { create(:project) }
1985

1986
      it 'returns nil' do
1987 1988 1989
        expect(repository.readme).to be_nil
      end
    end
1990

1991
    context 'with an existing repository' do
1992
      context 'when no README exists' do
1993
        let(:project) { create(:project, :empty_repo) }
1994

1995
        it 'returns nil' do
1996 1997 1998 1999 2000
          expect(repository.readme).to be_nil
        end
      end

      context 'when a README exists' do
2001 2002
        let(:project) { create(:project, :repository) }

2003 2004 2005
        it 'returns the README' do
          expect(repository.readme).to be_an_instance_of(ReadmeBlob)
        end
2006 2007 2008 2009
      end
    end
  end

2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045
  describe '#readme_path', :use_clean_rails_memory_store_caching do
    context 'with a non-existing repository' do
      let(:project) { create(:project) }

      it 'returns nil' do
        expect(repository.readme_path).to be_nil
      end
    end

    context 'with an existing repository' do
      context 'when no README exists' do
        let(:project) { create(:project, :empty_repo) }

        it 'returns nil' do
          expect(repository.readme_path).to be_nil
        end
      end

      context 'when a README exists' do
        let(:project) { create(:project, :repository) }

        it 'returns the README' do
          expect(repository.readme_path).to eq("README.md")
        end

        it 'caches the response' do
          expect(repository).to receive(:readme).and_call_original.once

          2.times do
            expect(repository.readme_path).to eq("README.md")
          end
        end
      end
    end
  end

2046 2047
  describe '#expire_statistics_caches' do
    it 'expires the caches' do
2048 2049
      expect(repository).to receive(:expire_method_caches)
        .with(%i(size commit_count))
2050

2051 2052 2053 2054 2055 2056
      repository.expire_statistics_caches
    end
  end

  describe '#expire_all_method_caches' do
    it 'expires the caches of all methods' do
2057 2058
      expect(repository).to receive(:expire_method_caches)
        .with(Repository::CACHED_METHODS)
2059 2060 2061

      repository.expire_all_method_caches
    end
2062 2063 2064 2065 2066 2067 2068

    it 'all cache_method definitions are in the lists of method caches' do
      methods = repository.methods.map do |method|
        match = /^_uncached_(.*)/.match(method)
        match[1].to_sym if match
      end.compact

2069
      expect(Repository::CACHED_METHODS + Repository::MEMOIZED_CACHED_METHODS).to include(*methods)
2070
    end
2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091
  end

  describe '#file_on_head' do
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:tree).with(:head).and_return(nil)

        expect(repository.file_on_head(:readme)).to be_nil
      end
    end

    context 'with a repository that has no blobs' do
      it 'returns nil' do
        expect_any_instance_of(Tree).to receive(:blobs).and_return([])

        expect(repository.file_on_head(:readme)).to be_nil
      end
    end

    context 'with an existing repository' do
      it 'returns a Gitlab::Git::Tree' do
2092 2093
        expect(repository.file_on_head(:readme))
          .to be_an_instance_of(Gitlab::Git::Tree)
2094 2095 2096 2097
      end
    end
  end

2098 2099 2100 2101 2102 2103
  describe '#head_tree' do
    context 'with an existing repository' do
      it 'returns a Tree' do
        expect(repository.head_tree).to be_an_instance_of(Tree)
      end
    end
2104

2105 2106 2107 2108 2109
    context 'with a non-existing repository' do
      it 'returns nil' do
        expect(repository).to receive(:head_commit).and_return(nil)

        expect(repository.head_tree).to be_nil
2110 2111 2112 2113
      end
    end
  end

2114 2115 2116 2117 2118
  describe '#tree' do
    context 'using a non-existing repository' do
      before do
        allow(repository).to receive(:head_commit).and_return(nil)
      end
2119

2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151
      it 'returns nil' do
        expect(repository.tree(:head)).to be_nil
      end

      it 'returns nil when using a path' do
        expect(repository.tree(:head, 'README.md')).to be_nil
      end
    end

    context 'using an existing repository' do
      it 'returns a Tree' do
        expect(repository.tree(:head)).to be_an_instance_of(Tree)
      end
    end
  end

  describe '#size' do
    context 'with a non-existing repository' do
      it 'returns 0' do
        expect(repository).to receive(:exists?).and_return(false)

        expect(repository.size).to eq(0.0)
      end
    end

    context 'with an existing repository' do
      it 'returns the repository size as a Float' do
        expect(repository.size).to be_an_instance_of(Float)
      end
    end
  end

2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162
  describe '#local_branches' do
    it 'returns the local branches' do
      masterrev = repository.find_branch('master').dereferenced_target
      create_remote_branch('joe', 'remote_branch', masterrev)
      repository.add_branch(user, 'local_branch', masterrev.id)

      expect(repository.local_branches.any? { |branch| branch.name == 'remote_branch' }).to eq(false)
      expect(repository.local_branches.any? { |branch| branch.name == 'local_branch' }).to eq(true)
    end
  end

2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173
  describe '#commit_count' do
    context 'with a non-existing repository' do
      it 'returns 0' do
        expect(repository).to receive(:root_ref).and_return(nil)

        expect(repository.commit_count).to eq(0)
      end
    end

    context 'with an existing repository' do
      it 'returns the commit count' do
Douwe Maan's avatar
Douwe Maan committed
2174
        expect(repository.commit_count).to be_an(Integer)
2175 2176 2177 2178
      end
    end
  end

2179
  describe '#commit_count_for_ref' do
2180
    let(:project) { create :project }
2181

2182 2183
    context 'with a non-existing repository' do
      it 'returns 0' do
2184 2185 2186 2187 2188 2189 2190 2191
        expect(project.repository.commit_count_for_ref('master')).to eq(0)
      end
    end

    context 'with empty repository' do
      it 'returns 0' do
        project.create_repository
        expect(project.repository.commit_count_for_ref('master')).to eq(0)
2192 2193 2194 2195 2196 2197 2198 2199 2200 2201
      end
    end

    context 'when searching for the root ref' do
      it 'returns the same count as #commit_count' do
        expect(repository.commit_count_for_ref(repository.root_ref)).to eq(repository.commit_count)
      end
    end
  end

2202 2203 2204 2205 2206 2207 2208 2209 2210
  describe '#diverging_commit_counts' do
    it 'returns the commit counts behind and ahead of default branch' do
      result = repository.diverging_commit_counts(
        repository.find_branch('fix'))

      expect(result).to eq(behind: 29, ahead: 2)
    end
  end

2211 2212
  describe '#refresh_method_caches' do
    it 'refreshes the caches of the given types' do
2213
      expect(repository).to receive(:expire_method_caches)
2214
        .with(%i(rendered_readme readme_path license_blob license_key license))
2215

2216
      expect(repository).to receive(:rendered_readme)
2217
      expect(repository).to receive(:readme_path)
2218 2219
      expect(repository).to receive(:license_blob)
      expect(repository).to receive(:license_key)
2220
      expect(repository).to receive(:license)
2221 2222 2223

      repository.refresh_method_caches(%i(readme license))
    end
2224
  end
Douwe Maan's avatar
Douwe Maan committed
2225 2226 2227

  describe '#gitlab_ci_yml_for' do
    before do
2228
      repository.create_file(User.last, '.gitlab-ci.yml', 'CONTENT', message: 'Add .gitlab-ci.yml', branch_name: 'master')
Douwe Maan's avatar
Douwe Maan committed
2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245
    end

    context 'when there is a .gitlab-ci.yml at the commit' do
      it 'returns the content' do
        expect(repository.gitlab_ci_yml_for(repository.commit.sha)).to eq('CONTENT')
      end
    end

    context 'when there is no .gitlab-ci.yml at the commit' do
      it 'returns nil' do
        expect(repository.gitlab_ci_yml_for(repository.commit.parent.sha)).to be_nil
      end
    end
  end

  describe '#route_map_for' do
    before do
2246
      repository.create_file(User.last, '.gitlab/route-map.yml', 'CONTENT', message: 'Add .gitlab/route-map.yml', branch_name: 'master')
Douwe Maan's avatar
Douwe Maan committed
2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260
    end

    context 'when there is a .gitlab/route-map.yml at the commit' do
      it 'returns the content' do
        expect(repository.route_map_for(repository.commit.sha)).to eq('CONTENT')
      end
    end

    context 'when there is no .gitlab/route-map.yml at the commit' do
      it 'returns nil' do
        expect(repository.route_map_for(repository.commit.parent.sha)).to be_nil
      end
    end
  end
2261

2262
  def create_remote_branch(remote_name, branch_name, target)
2263
    rugged = rugged_repo(repository)
2264 2265 2266
    rugged.references.create("refs/remotes/#{remote_name}/#{branch_name}", target.id)
  end

2267
  shared_examples '#ancestor?' do
2268 2269
    let(:commit) { repository.commit }
    let(:ancestor) { commit.parents.first }
2270

2271
    it 'is an ancestor' do
2272 2273
      expect(repository.ancestor?(ancestor.id, commit.id)).to eq(true)
    end
2274

2275
    it 'is not an ancestor' do
2276
      expect(repository.ancestor?(commit.id, ancestor.id)).to eq(false)
2277
    end
2278

2279 2280 2281 2282
    it 'returns false on nil-values' do
      expect(repository.ancestor?(nil, commit.id)).to eq(false)
      expect(repository.ancestor?(ancestor.id, nil)).to eq(false)
      expect(repository.ancestor?(nil, nil)).to eq(false)
2283
    end
2284

2285 2286 2287
    it 'returns false for invalid commit IDs' do
      expect(repository.ancestor?(commit.id, Gitlab::Git::BLANK_SHA)).to eq(false)
      expect(repository.ancestor?( Gitlab::Git::BLANK_SHA, commit.id)).to eq(false)
2288 2289
    end
  end
2290

2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304
  describe '#ancestor? with Gitaly enabled' do
    it_behaves_like "#ancestor?"
  end

  describe '#ancestor? with Rugged enabled', :enable_rugged do
    it 'calls out to the Rugged implementation' do
      allow_any_instance_of(Rugged).to receive(:merge_base).with(repository.commit.id, Gitlab::Git::BLANK_SHA).and_call_original

      repository.ancestor?(repository.commit.id, Gitlab::Git::BLANK_SHA)
    end

    it_behaves_like '#ancestor?'
  end

2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330
  describe '#archive_metadata' do
    let(:ref) { 'master' }
    let(:storage_path) { '/tmp' }

    let(:prefix) { [project.path, ref].join('-') }
    let(:filename) { prefix + '.tar.gz' }

    subject(:result) { repository.archive_metadata(ref, storage_path, append_sha: false) }

    context 'with hashed storage disabled' do
      let(:project) { create(:project, :repository, :legacy_storage) }

      it 'uses the project path to generate the filename' do
        expect(result['ArchivePrefix']).to eq(prefix)
        expect(File.basename(result['ArchivePath'])).to eq(filename)
      end
    end

    context 'with hashed storage enabled' do
      it 'uses the project path to generate the filename' do
        expect(result['ArchivePrefix']).to eq(prefix)
        expect(File.basename(result['ArchivePath'])).to eq(filename)
      end
    end
  end

2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349
  describe 'commit cache' do
    set(:project) { create(:project, :repository) }

    it 'caches based on SHA' do
      # Gets the commit oid, and warms the cache
      oid = project.commit.id

      expect(Gitlab::Git::Commit).not_to receive(:find).once

      project.commit_by(oid: oid)
    end

    it 'caches nil values' do
      expect(Gitlab::Git::Commit).to receive(:find).once

      project.commit_by(oid: '1' * 40)
      project.commit_by(oid: '1' * 40)
    end
  end
2350 2351 2352 2353 2354 2355 2356 2357

  describe '#raw_repository' do
    subject { repository.raw_repository }

    it 'returns a Gitlab::Git::Repository representation of the repository' do
      expect(subject).to be_a(Gitlab::Git::Repository)
      expect(subject.relative_path).to eq(project.disk_path + '.git')
      expect(subject.gl_repository).to eq("project-#{project.id}")
2358
      expect(subject.gl_project_path).to eq(project.full_path)
2359 2360 2361 2362 2363 2364 2365 2366 2367
    end

    context 'with a wiki repository' do
      let(:repository) { project.wiki.repository }

      it 'creates a Gitlab::Git::Repository with the proper attributes' do
        expect(subject).to be_a(Gitlab::Git::Repository)
        expect(subject.relative_path).to eq(project.disk_path + '.wiki.git')
        expect(subject.gl_repository).to eq("wiki-#{project.id}")
2368
        expect(subject.gl_project_path).to eq(project.full_path)
2369 2370 2371
      end
    end
  end
2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478

  describe '#contributors' do
    let(:author_a) { build(:author, email: 'tiagonbotelho@hotmail.com', name: 'tiagonbotelho') }
    let(:author_b) { build(:author, email: 'gitlab@winniehell.de', name: 'Winnie') }
    let(:author_c) { build(:author, email: 'douwe@gitlab.com', name: 'Douwe Maan') }
    let(:stubbed_commits) do
      [build(:commit, author: author_a),
       build(:commit, author: author_a),
       build(:commit, author: author_b),
       build(:commit, author: author_c),
       build(:commit, author: author_c),
       build(:commit, author: author_c)]
    end
    let(:order_by) { nil }
    let(:sort) { nil }

    before do
      allow(repository).to receive(:commits).with(nil, limit: 2000, offset: 0, skip_merges: true).and_return(stubbed_commits)
    end

    subject { repository.contributors(order_by: order_by, sort: sort) }

    def expect_contributors(*contributors)
      expect(subject.map(&:email)).to eq(contributors.map(&:email))
    end

    it 'returns the array of Gitlab::Contributor for the repository' do
      expect_contributors(author_a, author_b, author_c)
    end

    context 'order_by email' do
      let(:order_by) { 'email' }

      context 'asc' do
        let(:sort) { 'asc' }

        it 'returns all the contributors ordered by email asc case insensitive' do
          expect_contributors(author_c, author_b, author_a)
        end
      end

      context 'desc' do
        let(:sort) { 'desc' }

        it 'returns all the contributors ordered by email desc case insensitive' do
          expect_contributors(author_a, author_b, author_c)
        end
      end
    end

    context 'order_by name' do
      let(:order_by) { 'name' }

      context 'asc' do
        let(:sort) { 'asc' }

        it 'returns all the contributors ordered by name asc case insensitive' do
          expect_contributors(author_c, author_a, author_b)
        end
      end

      context 'desc' do
        let(:sort) { 'desc' }

        it 'returns all the contributors ordered by name desc case insensitive' do
          expect_contributors(author_b, author_a, author_c)
        end
      end
    end

    context 'order_by commits' do
      let(:order_by) { 'commits' }

      context 'asc' do
        let(:sort) { 'asc' }

        it 'returns all the contributors ordered by commits asc' do
          expect_contributors(author_b, author_a, author_c)
        end
      end

      context 'desc' do
        let(:sort) { 'desc' }

        it 'returns all the contributors ordered by commits desc' do
          expect_contributors(author_c, author_a, author_b)
        end
      end
    end

    context 'invalid ordering' do
      let(:order_by) { 'unknown' }

      it 'returns the contributors unsorted' do
        expect_contributors(author_a, author_b, author_c)
      end
    end

    context 'invalid sorting' do
      let(:order_by) { 'name' }
      let(:sort) { 'unknown' }

      it 'returns the contributors unsorted' do
        expect_contributors(author_a, author_b, author_c)
      end
    end
  end
2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489

  describe '#merge_base' do
    set(:project) { create(:project, :repository) }
    subject(:repository) { project.repository }

    it 'only makes one gitaly call' do
      expect(Gitlab::GitalyClient).to receive(:call).once.and_call_original

      repository.merge_base('master', 'fix')
    end
  end
2490
end