package_spec.rb 11.1 KB
Newer Older
1
# frozen_string_literal: true
2
require 'spec_helper'
3 4

RSpec.describe Packages::Package, type: :model do
5 6
  include SortingHelper

7 8
  describe 'relationships' do
    it { is_expected.to belong_to(:project) }
9
    it { is_expected.to have_many(:package_files).dependent(:destroy) }
10
    it { is_expected.to have_many(:dependency_links).inverse_of(:package) }
11
    it { is_expected.to have_many(:tags).inverse_of(:package) }
12 13
    it { is_expected.to have_one(:conan_metadatum).inverse_of(:package) }
    it { is_expected.to have_one(:maven_metadatum).inverse_of(:package) }
14 15
  end

16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70
  describe '.sort_by_attribute' do
    let_it_be(:group) { create(:group, :public) }
    let_it_be(:project) { create(:project, :public, namespace: group, name: 'project A') }
    let!(:package1) { create(:npm_package, project: project, version: '3.1.0', name: "@#{project.root_namespace.path}/foo1") }
    let!(:package2) { create(:nuget_package, project: project, version: '2.0.4') }
    let(:package3) { create(:maven_package, project: project, version: '1.1.1', name: 'zzz') }

    before do
      travel_to(1.day.ago) do
        package3
      end
    end

    RSpec.shared_examples 'package sorting by attribute' do |order_by|
      subject { described_class.where(id: packages.map(&:id)).sort_by_attribute("#{order_by}_#{sort}").to_a }

      context "sorting by #{order_by}" do
        context 'ascending order' do
          let(:sort) { 'asc' }

          it { is_expected.to eq packages }
        end

        context 'descending order' do
          let(:sort) { 'desc' }

          it { is_expected.to eq packages.reverse }
        end
      end
    end

    it_behaves_like 'package sorting by attribute', 'name' do
      let(:packages) { [package1, package2, package3] }
    end

    it_behaves_like 'package sorting by attribute', 'created_at' do
      let(:packages) { [package3, package1, package2] }
    end

    it_behaves_like 'package sorting by attribute', 'version' do
      let(:packages) { [package3, package2, package1] }
    end

    it_behaves_like 'package sorting by attribute', 'type' do
      let(:packages) { [package3, package1, package2] }
    end

    it_behaves_like 'package sorting by attribute', 'project_path' do
      let(:another_project) { create(:project, :public, namespace: group, name: 'project B') }
      let!(:package4) { create(:npm_package, project: another_project, version: '3.1.0', name: "@#{project.root_namespace.path}/bar") }

      let(:packages) { [package1, package2, package3, package4] }
    end
  end

71
  describe 'validations' do
72 73
    subject { create(:package) }

74
    it { is_expected.to validate_presence_of(:project) }
75
    it { is_expected.to validate_uniqueness_of(:name).scoped_to(:project_id, :version, :package_type) }
76 77 78 79

    describe '#name' do
      it { is_expected.to allow_value("my/domain/com/my-app").for(:name) }
      it { is_expected.to allow_value("my.app-11.07.2018").for(:name) }
80
      it { is_expected.not_to allow_value("my(dom$$$ain)com.my-app").for(:name) }
81
    end
82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103

    describe '#package_already_taken' do
      context 'npm package' do
        let!(:package) { create(:npm_package) }

        it 'will not allow a package of the same name' do
          new_package = build(:npm_package, name: package.name)

          expect(new_package).not_to be_valid
        end
      end

      context 'maven package' do
        let!(:package) { create(:maven_package) }

        it 'will allow a package of the same name' do
          new_package = build(:maven_package, name: package.name)

          expect(new_package).to be_valid
        end
      end
    end
104

105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121
    context "recipe uniqueness for conan packages" do
      let!(:package) { create('conan_package') }

      it "will allow a conan package with same project, name, version and package_type" do
        new_package = build('conan_package', project: package.project, name: package.name, version: package.version)
        new_package.conan_metadatum.package_channel = 'beta'
        expect(new_package).to be_valid
      end

      it "will not allow a conan package with same recipe (name, version, metadatum.package_channel, metadatum.package_username, and package_type)" do
        new_package = build('conan_package', project: package.project, name: package.name, version: package.version)
        expect(new_package).not_to be_valid
        expect(new_package.errors.to_a).to include("Package recipe already exists")
      end
    end

    Packages::Package.package_types.keys.without('conan').each do |pt|
122 123 124 125 126 127 128 129 130 131
      context "project id, name, version and package type uniqueness for package type #{pt}" do
        let(:package) { create("#{pt}_package") }

        it "will not allow a #{pt} package with same project, name, version and package_type" do
          new_package = build("#{pt}_package", project: package.project, name: package.name, version: package.version)
          expect(new_package).not_to be_valid
          expect(new_package.errors.to_a).to include("Name has already been taken")
        end
      end
    end
132
  end
133

134 135 136 137 138 139 140 141 142 143 144 145
  describe '#destroy' do
    let(:package) { create(:npm_package) }
    let(:package_file) { package.package_files.first }
    let(:project_statistics) { ProjectStatistics.for_project_ids(package.project.id).first }

    it 'affects project statistics' do
      expect { package.destroy! }
        .to change { project_statistics.reload.packages_size }
              .from(package_file.size).to(0)
    end
  end

146 147 148 149 150 151 152 153 154 155 156 157 158 159 160
  describe '.by_name_and_file_name' do
    let!(:package) { create(:npm_package) }
    let!(:package_file) { package.package_files.first }

    subject { described_class }

    it 'finds a package with correct arguiments' do
      expect(subject.by_name_and_file_name(package.name, package_file.file_name)).to eq(package)
    end

    it 'will raise error if not found' do
      expect { subject.by_name_and_file_name('foo', 'foo-5.5.5.tgz') }.to raise_error(ActiveRecord::RecordNotFound)
    end
  end

161
  context 'version scopes' do
162 163 164 165
    let!(:package1) { create(:npm_package, version: '1.0.0') }
    let!(:package2) { create(:npm_package, version: '1.0.1') }
    let!(:package3) { create(:npm_package, version: '1.0.1') }

166 167
    describe '.last_of_each_version' do
      subject { described_class.last_of_each_version }
168

169 170 171 172
      it 'includes only latest package per version' do
        is_expected.to include(package1, package3)
        is_expected.not_to include(package2)
      end
173
    end
174

175 176 177 178 179 180 181 182 183
    describe '.has_version' do
      let!(:package4) { create(:npm_package, version: nil) }

      subject { described_class.has_version }

      it 'includes only packages with version attribute' do
        is_expected.to match_array([package1, package2, package3])
      end
    end
184

185 186
    describe '.with_version' do
      subject { described_class.with_version('1.0.1') }
187

188 189 190
      it 'includes only packages with specified version' do
        is_expected.to match_array([package2, package3])
      end
191
    end
192 193 194 195 196 197 198 199 200 201

    describe '.without_version_like' do
      let(:version_pattern) { '%.0.0%' }

      subject { described_class.without_version_like(version_pattern) }

      it 'includes packages without the version pattern' do
        is_expected.to match_array([package2, package3])
      end
    end
202
  end
203

204 205
  context 'conan scopes' do
    let!(:package) { create(:conan_package) }
206

207
    describe '.with_conan_channel' do
208
      subject { described_class.with_conan_channel('stable') }
209

210
      it 'includes only packages with specified version' do
211
        is_expected.to include(package)
212
      end
213
    end
Steve Abrams's avatar
Steve Abrams committed
214

215 216 217 218 219 220
    describe '.with_conan_username' do
      subject do
        described_class.with_conan_username(
          Packages::ConanMetadatum.package_username_from(full_path: package.project.full_path)
        )
      end
221

222 223 224
      it 'includes only packages with specified version' do
        is_expected.to match_array([package])
      end
Steve Abrams's avatar
Steve Abrams committed
225 226
    end
  end
227

228 229 230 231 232 233 234 235 236 237 238
  describe '.without_nuget_temporary_name' do
    let!(:package1) { create(:nuget_package) }
    let!(:package2) { create(:nuget_package, name: Packages::Nuget::CreatePackageService::TEMPORARY_PACKAGE_NAME) }

    subject { described_class.without_nuget_temporary_name }

    it 'does not include nuget temporary packages' do
      expect(subject).to eq([package1])
    end
  end

239 240 241 242 243 244 245
  describe '.processed' do
    let!(:package1) { create(:nuget_package) }
    let!(:package2) { create(:npm_package) }
    let!(:package3) { create(:nuget_package) }

    subject { described_class.processed }

246
    it { is_expected.to match_array([package1, package2, package3]) }
247 248 249 250

    context 'with temporary packages' do
      let!(:package1) { create(:nuget_package, name: Packages::Nuget::CreatePackageService::TEMPORARY_PACKAGE_NAME) }

251
      it { is_expected.to match_array([package2, package3]) }
252 253
    end
  end
254 255 256 257 258 259 260 261 262 263

  describe '.limit_recent' do
    let!(:package1) { create(:nuget_package) }
    let!(:package2) { create(:nuget_package) }
    let!(:package3) { create(:nuget_package) }

    subject { described_class.limit_recent(2) }

    it { is_expected.to match_array([package3, package2]) }
  end
264 265

  context 'with several packages' do
266 267
    let_it_be(:package1) { create(:nuget_package, name: 'FooBar') }
    let_it_be(:package2) { create(:nuget_package, name: 'foobar') }
268
    let_it_be(:package3) { create(:npm_package) }
269
    let_it_be(:package4) { create(:npm_package) }
270 271

    describe '.pluck_names' do
272
      subject { described_class.pluck_names }
273

274
      it { is_expected.to match_array([package1, package2, package3, package4].map(&:name)) }
275 276 277
    end

    describe '.pluck_versions' do
278
      subject { described_class.pluck_versions }
279

280
      it { is_expected.to match_array([package1, package2, package3, package4].map(&:version)) }
281 282 283
    end

    describe '.with_name_like' do
284
      subject { described_class.with_name_like(name_term) }
285 286

      context 'with downcase name' do
287
        let(:name_term) { 'foobar' }
288

289
        it { is_expected.to match_array([package1, package2]) }
290 291 292
      end

      context 'with prefix wildcard' do
293
        let(:name_term) { '%ar' }
294

295
        it { is_expected.to match_array([package1, package2]) }
296 297 298
      end

      context 'with suffix wildcard' do
299
        let(:name_term) { 'foo%' }
300

301
        it { is_expected.to match_array([package1, package2]) }
302 303 304
      end

      context 'with surrounding wildcards' do
305
        let(:name_term) { '%ooba%' }
306

307
        it { is_expected.to match_array([package1, package2]) }
308 309
      end
    end
310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333

    describe '.search_by_name' do
      let(:query) { 'oba' }

      subject { described_class.search_by_name(query) }

      it { is_expected.to match_array([package1, package2]) }
    end
  end

  describe '.select_distinct_name' do
    let_it_be(:nuget_package) { create(:nuget_package) }
    let_it_be(:nuget_packages) { create_list(:nuget_package, 3, name: nuget_package.name, project: nuget_package.project) }
    let_it_be(:maven_package) { create(:maven_package) }
    let_it_be(:maven_packages) { create_list(:maven_package, 3, name: maven_package.name, project: maven_package.project) }

    subject { described_class.select_distinct_name }

    it 'returns only distinct names' do
      packages = subject

      expect(packages.size).to eq(2)
      expect(packages.pluck(:name)).to match_array([nuget_package.name, maven_package.name])
    end
334
  end
335
end