Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
000be31b
Commit
000be31b
authored
Apr 16, 2020
by
Luke Duncalfe
Committed by
Peter Leitzen
Apr 16, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove design_management_resize_images flag
https://gitlab.com/gitlab-org/gitlab/-/issues/207351/
parent
7b5ad03d
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
18 deletions
+5
-18
ee/app/workers/design_management/new_version_worker.rb
ee/app/workers/design_management/new_version_worker.rb
+0
-2
ee/changelogs/unreleased/207351-remove-design_management_resize_images-feature-flag.yml
...1-remove-design_management_resize_images-feature-flag.yml
+5
-0
ee/spec/workers/design_management/new_version_worker_spec.rb
ee/spec/workers/design_management/new_version_worker_spec.rb
+0
-16
No files found.
ee/app/workers/design_management/new_version_worker.rb
View file @
000be31b
...
@@ -25,8 +25,6 @@ module DesignManagement
...
@@ -25,8 +25,6 @@ module DesignManagement
end
end
def
generate_image_versions
(
version
)
def
generate_image_versions
(
version
)
return
unless
::
Feature
.
enabled?
(
:design_management_resize_images
,
version
.
project
)
DesignManagement
::
GenerateImageVersionsService
.
new
(
version
).
execute
DesignManagement
::
GenerateImageVersionsService
.
new
(
version
).
execute
end
end
end
end
...
...
ee/changelogs/unreleased/207351-remove-design_management_resize_images-feature-flag.yml
0 → 100644
View file @
000be31b
---
title
:
Generate smaller versions of Design Management design files
merge_request
:
29215
author
:
type
:
added
ee/spec/workers/design_management/new_version_worker_spec.rb
View file @
000be31b
...
@@ -6,10 +6,6 @@ describe DesignManagement::NewVersionWorker do
...
@@ -6,10 +6,6 @@ describe DesignManagement::NewVersionWorker do
describe
'#perform'
do
describe
'#perform'
do
let
(
:worker
)
{
described_class
.
new
}
let
(
:worker
)
{
described_class
.
new
}
before
do
stub_feature_flags
(
design_management_resize_images:
true
)
end
context
'the id is wrong or out-of-date'
do
context
'the id is wrong or out-of-date'
do
let
(
:version_id
)
{
-
1
}
let
(
:version_id
)
{
-
1
}
...
@@ -53,18 +49,6 @@ describe DesignManagement::NewVersionWorker do
...
@@ -53,18 +49,6 @@ describe DesignManagement::NewVersionWorker do
worker
.
perform
(
version
.
id
)
worker
.
perform
(
version
.
id
)
end
end
context
'when the `design_management_resize_images` flag is disabled'
do
before
do
stub_feature_flags
(
design_management_resize_images:
false
)
end
it
'does not invoke GenerateImageVersionsService'
do
expect
(
DesignManagement
::
GenerateImageVersionsService
).
not_to
receive
(
:new
)
worker
.
perform
(
version
.
id
)
end
end
end
end
context
'the version includes multiple types of action'
do
context
'the version includes multiple types of action'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment