Commit 00f359c2 authored by David O'Regan's avatar David O'Regan

Merge branch 'update-table-pb' into 'master'

Update table and ellipsis button in performance bar metrics modal

See merge request gitlab-org/gitlab!52762
parents 10e685da efbb2bf5
<script> <script>
import { GlButton, GlIcon, GlModal, GlModalDirective } from '@gitlab/ui'; import { GlButton, GlModal, GlModalDirective } from '@gitlab/ui';
import RequestWarning from './request_warning.vue'; import RequestWarning from './request_warning.vue';
export default { export default {
...@@ -7,7 +7,6 @@ export default { ...@@ -7,7 +7,6 @@ export default {
RequestWarning, RequestWarning,
GlButton, GlButton,
GlModal, GlModal,
GlIcon,
}, },
directives: { directives: {
'gl-modal': GlModalDirective, 'gl-modal': GlModalDirective,
...@@ -97,7 +96,7 @@ export default { ...@@ -97,7 +96,7 @@ export default {
<span class="gl-text-blue-300 gl-font-weight-bold">{{ metricDetailsLabel }}</span> <span class="gl-text-blue-300 gl-font-weight-bold">{{ metricDetailsLabel }}</span>
</gl-button> </gl-button>
<gl-modal :modal-id="modalId" :title="header" size="lg" footer-class="d-none" scrollable> <gl-modal :modal-id="modalId" :title="header" size="lg" footer-class="d-none" scrollable>
<table class="table"> <table class="table gl-table">
<template v-if="detailsList.length"> <template v-if="detailsList.length">
<tr v-for="(item, index) in detailsList" :key="index"> <tr v-for="(item, index) in detailsList" :key="index">
<td> <td>
...@@ -110,20 +109,22 @@ export default { ...@@ -110,20 +109,22 @@ export default {
<div <div
v-for="(key, keyIndex) in keys" v-for="(key, keyIndex) in keys"
:key="key" :key="key"
class="break-word" class="break-word gl-text-black-normal"
:class="{ 'mb-3 bold': keyIndex == 0 }" :class="{ 'mb-3 bold': keyIndex == 0 }"
> >
{{ item[key] }} {{ item[key] }}
<gl-button <gl-button
v-if="keyIndex == 0 && item.backtrace" v-if="keyIndex == 0 && item.backtrace"
class="btn-sm gl-ml-3" class="gl-ml-3 button-ellipsis-horizontal"
data-testid="backtrace-expand-btn" data-testid="backtrace-expand-btn"
type="button" category="primary"
variant="default"
icon="ellipsis_h"
size="small"
:selected="itemHasOpenedBacktrace(index)"
:aria-label="__('Toggle backtrace')" :aria-label="__('Toggle backtrace')"
@click="toggleBacktrace(index)" @click="toggleBacktrace(index)"
> />
<gl-icon :size="12" name="ellipsis_h" />
</gl-button>
</div> </div>
<pre v-if="itemHasOpenedBacktrace(index)" class="backtrace-row mt-2">{{ <pre v-if="itemHasOpenedBacktrace(index)" class="backtrace-row mt-2">{{
item.backtrace item.backtrace
......
---
title: Update table and ellipsis button in performance bar metrics modal
merge_request: 52762
author: Yogi (@yo)
type: other
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment