Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
0171dac6
Commit
0171dac6
authored
Dec 01, 2020
by
Peter Leitzen
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Speed up EE project helpers by using let_it_be for project factory
parent
71c1db7a
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
8 deletions
+6
-8
ee/spec/helpers/projects_helper_spec.rb
ee/spec/helpers/projects_helper_spec.rb
+6
-8
No files found.
ee/spec/helpers/projects_helper_spec.rb
View file @
0171dac6
...
...
@@ -3,7 +3,7 @@
require
'spec_helper'
RSpec
.
describe
ProjectsHelper
do
let
(
:project
)
{
create
(
:project
)
}
let
_it_be_with_refind
(
:project
)
{
create
(
:project
)
}
before
do
helper
.
instance_variable_set
(
:@project
,
project
)
...
...
@@ -40,13 +40,11 @@ RSpec.describe ProjectsHelper do
describe
'#show_compliance_framework_badge?'
do
it
'returns false if compliance framework setting is not present'
do
project
=
build
(
:project
)
expect
(
helper
.
show_compliance_framework_badge?
(
project
)).
to
be_falsey
end
it
'returns true if compliance framework setting is present'
do
project
=
build
(
:project
,
:with_compliance_framework
)
project
=
build
_stubbed
(
:project
,
:with_compliance_framework
)
expect
(
helper
.
show_compliance_framework_badge?
(
project
)).
to
be_truthy
end
...
...
@@ -276,8 +274,7 @@ RSpec.describe ProjectsHelper do
end
with_them
do
let
(
:project
)
{
create
(
:project
)
}
let
(
:user
)
{
create
(
:user
)
}
let_it_be
(
:user
)
{
create
(
:user
)
}
before
do
allow
(
helper
).
to
receive
(
:can?
)
{
false
}
...
...
@@ -416,11 +413,12 @@ RSpec.describe ProjectsHelper do
describe
'#show_discover_project_security?'
do
using
RSpec
::
Parameterized
::
TableSyntax
let
(
:user
)
{
create
(
:user
)
}
let_it_be
(
:user
)
{
create
(
:user
)
}
where
(
gitlab_com?:
[
true
,
false
],
user?:
[
true
,
false
],
user?:
[
true
,
false
],
security_dashboard_feature_available?:
[
true
,
false
],
can_admin_namespace?:
[
true
,
false
]
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment