Merge branch 'rspec-empty-line-after-letitbe-ee-spec-services-geo' into 'master'

Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/services/geo

See merge request gitlab-org/gitlab!58348

.rubocop_manual_todo.yml

@@ -731,11 +731,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - ee/spec/services/external_approval_rules/create_service_spec.rb
     - ee/spec/services/external_approval_rules/destroy_service_spec.rb
     - ee/spec/services/external_approval_rules/update_service_spec.rb
-    - ee/spec/services/geo/blob_download_service_spec.rb
-    - ee/spec/services/geo/design_repository_sync_service_spec.rb
-    - ee/spec/services/geo/event_service_spec.rb
-    - ee/spec/services/geo/file_registry_removal_service_spec.rb
-    - ee/spec/services/geo/project_housekeeping_service_spec.rb
     - ee/spec/services/gitlab_subscriptions/activate_service_spec.rb
     - ee/spec/services/gitlab_subscriptions/apply_trial_service_spec.rb
     - ee/spec/services/groups/autocomplete_service_spec.rb

ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-geo.yml

+---
+title: Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/services/geo
+merge_request: 58348
+author: Abdul Wadood @abdulwd
+type: fixed

ee/spec/services/geo/blob_download_service_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe Geo::BlobDownloadService do
 
   let_it_be(:primary) { create(:geo_node, :primary) }
   let_it_be(:secondary) { create(:geo_node) }
+
   let(:model_record) { create(:package_file, :npm) }
   let(:replicator) { model_record.replicator }
   let(:registry_class) { replicator.registry_class }

ee/spec/services/geo/design_repository_sync_service_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe Geo::DesignRepositorySyncService do
 
   let_it_be(:primary) { create(:geo_node, :primary) }
   let_it_be(:secondary) { create(:geo_node) }
+
   let(:user) { create(:user) }
   let(:project) { create(:project_empty_repo, namespace: create(:namespace, owner: user)) }
 

ee/spec/services/geo/event_service_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe Geo::EventService do
 
   let_it_be(:primary) { create(:geo_node, :primary) }
   let_it_be(:secondary) { create(:geo_node) }
+
   let(:model_record) { create(:package_file, :npm) }
 
   subject { described_class.new('package_file', 'created', { 'model_record_id' => model_record.id }) }

ee/spec/services/geo/file_registry_removal_service_spec.rb

@@ -324,6 +324,7 @@ RSpec.describe Geo::FileRegistryRemovalService, :geo do
 
     context 'with namespace_file' do
       let_it_be(:group) { create(:group) }
+
       let(:file) { fixture_file_upload('spec/fixtures/dk.png', 'image/png') }
       let!(:upload) do
         NamespaceFileUploader.new(group).store!(file)

ee/spec/services/geo/project_housekeeping_service_spec.rb

@@ -9,6 +9,7 @@ RSpec.describe Geo::ProjectHousekeepingService do
   subject(:service) { described_class.new(project) }
 
   let_it_be(:project) { create(:project, :repository) }
+
   let(:registry) { service.registry }
 
   before do