Merge branch 'mc/backstage/use-lint-object-ci-lint-api' into 'master'

Use Gitlab::Ci::Lint in /ci/lint API endpoint

See merge request gitlab-org/gitlab!68860

lib/api/lint.rb

@@ -13,18 +13,13 @@ module API
       post '/lint' do
         unauthorized! if (Gitlab::CurrentSettings.signup_disabled? || Gitlab::CurrentSettings.signup_limited?) && current_user.nil?
 
-        result = Gitlab::Ci::YamlProcessor.new(params[:content], user: current_user).execute
+        result = Gitlab::Ci::Lint.new(project: nil, current_user: current_user)
+          .validate(params[:content], dry_run: false)
 
         status 200
-
-        response = if result.errors.empty?
-                     { status: 'valid', errors: [], warnings: result.warnings }
-                   else
-                     { status: 'invalid', errors: result.errors, warnings: result.warnings }
-                   end
-
-        response.tap do |response|
-          response[:merged_yaml] = result.merged_yaml if params[:include_merged_yaml]
+        Entities::Ci::Lint::Result.represent(result, current_user: current_user).serializable_hash.tap do |presented_result|
+          presented_result[:status] = presented_result[:valid] ? 'valid' : 'invalid'
+          presented_result.delete(:merged_yaml) unless params[:include_merged_yaml]
         end
       end
     end

lib/gitlab/ci/lint.rb

@@ -21,7 +21,7 @@ module Gitlab
       def initialize(project:, current_user:, sha: nil)
         @project = project
         @current_user = current_user
-        @sha = sha || project.repository.commit&.sha
+        @sha = sha || project&.repository&.commit&.sha
       end
 
       def validate(content, dry_run: false)

spec/requests/api/lint_spec.rb

@@ -113,7 +113,6 @@ RSpec.describe API::Lint do
           expect(response).to have_gitlab_http_status(:ok)
           expect(json_response['status']).to eq('valid')
           expect(json_response['warnings']).not_to be_empty
-          expect(json_response['status']).to eq('valid')
           expect(json_response['errors']).to eq([])
         end
       end