Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
02787532
Commit
02787532
authored
Mar 06, 2020
by
Robert Speicher
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove `remote_mirrors_api` feature flag
parent
7f052e3e
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
0 additions
and
29 deletions
+0
-29
lib/api/remote_mirrors.rb
lib/api/remote_mirrors.rb
+0
-3
spec/requests/api/remote_mirrors_spec.rb
spec/requests/api/remote_mirrors_spec.rb
+0
-26
No files found.
lib/api/remote_mirrors.rb
View file @
02787532
...
...
@@ -5,9 +5,6 @@ module API
include
PaginationParams
before
do
# TODO: Remove flag: https://gitlab.com/gitlab-org/gitlab/issues/38121
not_found!
unless
Feature
.
enabled?
(
:remote_mirrors_api
,
user_project
)
unauthorized!
unless
can?
(
current_user
,
:admin_remote_mirror
,
user_project
)
end
...
...
spec/requests/api/remote_mirrors_spec.rb
View file @
02787532
...
...
@@ -24,19 +24,6 @@ describe API::RemoteMirrors do
expect
(
response
).
to
have_gitlab_http_status
(
:success
)
expect
(
response
).
to
match_response_schema
(
'remote_mirrors'
)
end
# TODO: Remove flag: https://gitlab.com/gitlab-org/gitlab/issues/38121
context
'with the `remote_mirrors_api` feature disabled'
do
before
do
stub_feature_flags
(
remote_mirrors_api:
false
)
end
it
'responds with `not_found`'
do
get
api
(
route
,
user
)
expect
(
response
).
to
have_gitlab_http_status
(
:not_found
)
end
end
end
describe
'POST /projects/:id/remote_mirrors'
do
...
...
@@ -109,18 +96,5 @@ describe API::RemoteMirrors do
expect
(
json_response
[
'enabled'
]).
to
eq
(
false
)
expect
(
json_response
[
'only_protected_branches'
]).
to
eq
(
true
)
end
# TODO: Remove flag: https://gitlab.com/gitlab-org/gitlab/issues/38121
context
'with the `remote_mirrors_api` feature disabled'
do
before
do
stub_feature_flags
(
remote_mirrors_api:
false
)
end
it
'responds with `not_found`'
do
put
api
(
route
[
mirror
.
id
],
user
)
expect
(
response
).
to
have_gitlab_http_status
(
:not_found
)
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment