Address code review changes

- Update specs
- Improve fileUrl function

ee/app/assets/javascripts/security_dashboard/components/vulnerability_list.vue

@@ -249,9 +249,14 @@ export default {
       return identifiers?.length - 1;
     },
     fileUrl(vulnerability) {
-      const { startLine: start, endLine: end } = vulnerability.location;
+      const { startLine: start, endLine: end, blobPath } = vulnerability.location;
       const lineNumber = end > start ? `${start}-${end}` : start;
-      return (vulnerability.location.blobPath || '') + (lineNumber ? `#L${lineNumber}` : '');
+
+      if (!blobPath) {
+        return '';
+      }
+
+      return `${blobPath}${lineNumber ? `#L${lineNumber}` : ''}`;
     },
     primaryIdentifier(identifiers) {
       return getPrimaryIdentifier(identifiers, 'externalType');
@@ -427,9 +432,10 @@ export default {
             {{ item.project.nameWithNamespace }}
           </div>
           <div v-if="shouldShowVulnerabilityPath(item)">
-            <gl-link :href="fileUrl(item)">
+            <gl-link v-if="item.location.blobPath" :href="fileUrl(item)">
               <gl-truncate :text="createLocationString(item.location)" position="middle" />
             </gl-link>
+            <gl-truncate v-else :text="createLocationString(item.location)" position="middle" />
           </div>
         </div>
       </template>

ee/spec/frontend/security_dashboard/components/vulnerability_list_spec.js

@@ -46,6 +46,7 @@ describe('Vulnerability list component', () => {
     );
   };
 
+  const locationText = ({ file, startLine }) => `${file}:${startLine}`;
   const findTable = () => wrapper.findComponent(GlTable);
   const findSortableColumn = () => wrapper.find('[aria-sort="descending"]');
   const findCell = (label) => wrapper.find(`.js-${label}`);
@@ -62,6 +63,7 @@ describe('Vulnerability list component', () => {
     findRow(row).findComponent(VulnerabilityCommentIcon);
   const findDataCell = (label) => wrapper.findByTestId(label);
   const findDataCells = (label) => wrapper.findAll(`[data-testid="${label}"]`);
+  const findLocationCell = (id) => wrapper.findByTestId(`location-${id}`);
   const findLocationTextWrapper = (cell) => cell.find(GlTruncate);
   const findFiltersProducedNoResults = () => wrapper.findComponent(FiltersProducedNoResults);
   const findDashboardHasNoVulnerabilities = () =>
@@ -232,7 +234,7 @@ describe('Vulnerability list component', () => {
 
     it('should display the vulnerability locations for images', () => {
       const { id, project, location } = newVulnerabilities[0];
-      const cell = findDataCell(`location-${id}`);
+      const cell = findLocationCell(id);
       expect(cell.text()).toContain(project.nameWithNamespace);
       expect(findLocationTextWrapper(cell).props()).toEqual({
         text: location.image,
@@ -242,17 +244,17 @@ describe('Vulnerability list component', () => {
 
     it('should display the vulnerability locations for code', () => {
       const { id, project, location } = newVulnerabilities[1];
-      const cell = findDataCell(`location-${id}`);
+      const cell = findLocationCell(id);
       expect(cell.text()).toContain(project.nameWithNamespace);
       expect(findLocationTextWrapper(cell).props()).toEqual({
-        text: `${location.file}:${location.startLine}`,
+        text: locationText(location),
         position: 'middle',
       });
     });
 
     it('should display the vulnerability locations for code with no line data', () => {
       const { id, project, location } = newVulnerabilities[2];
-      const cell = findDataCell(`location-${id}`);
+      const cell = findLocationCell(id);
       expect(cell.text()).toContain(project.nameWithNamespace);
       expect(findLocationTextWrapper(cell).props()).toEqual({
         text: location.file,
@@ -262,14 +264,14 @@ describe('Vulnerability list component', () => {
 
     it('should not display the vulnerability locations for vulnerabilities without a location', () => {
       const { id, project } = newVulnerabilities[4];
-      const cellText = findDataCell(`location-${id}`).text();
+      const cellText = findLocationCell(id).text();
       expect(cellText).toEqual(project.nameWithNamespace);
       expect(cellText).not.toContain(':');
     });
 
     it('should display the vulnerability locations for path', () => {
       const { id, project, location } = newVulnerabilities[5];
-      const cell = findDataCell(`location-${id}`);
+      const cell = findLocationCell(id);
       expect(cell.text()).toContain(project.nameWithNamespace);
       expect(findLocationTextWrapper(cell).props()).toEqual({
         text: location.path,
@@ -293,7 +295,7 @@ describe('Vulnerability list component', () => {
 
     it('should not display the vulnerability group/project locations for images', () => {
       const { id, project, location } = newVulnerabilities[0];
-      const cell = findDataCell(`location-${id}`);
+      const cell = findLocationCell(id);
       expect(cell.text()).not.toContain(project.nameWithNamespace);
       expect(findLocationTextWrapper(cell).props()).toEqual({
         text: location.image,
@@ -310,23 +312,29 @@ describe('Vulnerability list component', () => {
 
     it('should display the vulnerability locations for code', () => {
       const { id, project, location } = newVulnerabilities[1];
-      const cell = findDataCell(`location-${id}`);
+      const cell = findLocationCell(id);
       expect(cell.text()).not.toContain(project.nameWithNamespace);
       expect(findLocationTextWrapper(cell).props()).toEqual({
-        text: `${location.file}:${location.startLine}`,
+        text: locationText(location),
         position: 'middle',
       });
     });
 
     it('should make the file path linkable', () => {
       const { id, location } = newVulnerabilities[1];
-      const cell = findDataCell(`location-${id}`);
+      const cell = findLocationCell(id);
       expect(cell.find('a').attributes('href')).toBe(`${location.blobPath}#L${location.startLine}`);
     });
 
+    it('should not make the file path linkable if blobPath is missing', () => {
+      const { id } = newVulnerabilities[0];
+      const cell = findLocationCell(id);
+      expect(cell.find('a').exists()).toBe(false);
+    });
+
     it('should not display the vulnerability group/project locations for code with no line data', () => {
       const { id, project, location } = newVulnerabilities[2];
-      const cell = findDataCell(`location-${id}`);
+      const cell = findLocationCell(id);
       expect(cell.text()).not.toContain(project.nameWithNamespace);
       expect(findLocationTextWrapper(cell).props()).toEqual({
         text: location.file,