Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
0430007e
Commit
0430007e
authored
Aug 01, 2017
by
Marin Jankovski
Committed by
Rémy Coutable
Aug 01, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add code review guidelines related to Build [CI skip].
parent
1814fef8
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
0 deletions
+3
-0
doc/development/code_review.md
doc/development/code_review.md
+3
-0
No files found.
doc/development/code_review.md
View file @
0430007e
...
@@ -11,6 +11,8 @@ There are a few rules to get your merge request accepted:
...
@@ -11,6 +11,8 @@ There are a few rules to get your merge request accepted:
**approved by a [frontend maintainer][projects]**
.
**approved by a [frontend maintainer][projects]**
.
1.
If your merge request includes frontend and backend changes [^1], it must
1.
If your merge request includes frontend and backend changes [^1], it must
be
**approved by a [frontend and a backend maintainer][projects]**
.
be
**approved by a [frontend and a backend maintainer][projects]**
.
1.
If your merge request includes a new dependency or a filesystem change, it must
be
**approved by a [Build team member][team]**
. See
[
how to work with the Build team
][
build handbook
]
for more details.
1.
To lower the amount of merge requests maintainers need to review, you can
1.
To lower the amount of merge requests maintainers need to review, you can
ask or assign any
[
reviewers
][
projects
]
for a first review.
ask or assign any
[
reviewers
][
projects
]
for a first review.
1.
If you need some guidance (e.g. it's your first merge request), feel free
1.
If you need some guidance (e.g. it's your first merge request), feel free
...
@@ -194,3 +196,4 @@ Largely based on the [thoughtbot code review guide].
...
@@ -194,3 +196,4 @@ Largely based on the [thoughtbot code review guide].
[
projects
]:
https://about.gitlab.com/handbook/engineering/projects/
[
projects
]:
https://about.gitlab.com/handbook/engineering/projects/
[
team
]:
https://about.gitlab.com/team/
[
team
]:
https://about.gitlab.com/team/
[
build handbook
]:
https://about.gitlab.com/handbook/build/handbook/build#how-to-work-with-build
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment