Merge branch '9519-kerberos-spnego-authentication-is-broken-since-a-code-refactoring' into 'master'

Fix Kerberos authentication

Closes #9519

See merge request gitlab-org/gitlab-ee!9390

ee/app/helpers/ee/kerberos_spnego_helper.rb

@@ -66,7 +66,7 @@ module EE
       # pass service name to acquire_credentials explicitly to support the special meaning of nil
       gss_service_name =
         if ::Gitlab.config.kerberos.service_principal_name.present?
-          gss.import_name(Gitlab.config.kerberos.service_principal_name)
+          gss.import_name(::Gitlab.config.kerberos.service_principal_name)
         else
           nil # accept any valid service principal name from keytab
         end

ee/changelogs/unreleased/9519-kerberos-spnego-authentication-is-broken-since-a-code-refactoring.yml

+---
+title: Fix Kerberos authentication
+merge_request: 9390
+author:
+type: fixed

ee/spec/helpers/kerberos_spnego_helper_spec.rb

+require 'spec_helper'
+require 'gssapi'
+
+describe KerberosSpnegoHelper do
+  describe '#spnego_credentials!' do
+    let(:gss) { double('GSSAPI::Simple') }
+    let(:gss_service_name) { 'gss_service_name' }
+    subject { Class.new { include KerberosSpnegoHelper }.new }
+
+    before do
+      expect(GSSAPI::Simple).to receive(:new)
+        .with(nil, nil, ::Gitlab.config.kerberos.keytab)
+        .and_return(gss)
+    end
+
+    shared_examples 'a method that decodes a spnego token' do
+      let(:gss_result) { true }
+      let(:spnego_response_token) { nil }
+
+      it 'decodes the given spnego token' do
+        token = 'abc123'
+        gss_display_name = 'gss_display_name'
+
+        expect(gss).to receive(:acquire_credentials).with(gss_service_name)
+        expect(gss).to receive(:accept_context).with(token).and_return(gss_result)
+        expect(gss).to receive(:display_name).and_return(gss_display_name)
+
+        expect(subject.spnego_credentials!(token)).to eq(gss_display_name)
+        expect(subject.spnego_response_token).to eq(spnego_response_token)
+      end
+    end
+
+    context 'with Kerberos service_principal_name present' do
+      before do
+        kerberos_service_principal_name = 'default'
+        stub_kerberos_setting(service_principal_name: kerberos_service_principal_name)
+        expect(gss).to receive(:import_name).with(kerberos_service_principal_name).and_return(gss_service_name)
+      end
+
+      it_behaves_like 'a method that decodes a spnego token'
+
+      context 'when gss_result is not true' do
+        it_behaves_like 'a method that decodes a spnego token' do
+          let(:gss_result) { 'gss_result' }
+          let(:spnego_response_token) { gss_result }
+        end
+      end
+    end
+
+    context 'with Kerberos service_principal_name missing' do
+      before do
+        expect(gss).not_to receive(:import_name)
+      end
+
+      it_behaves_like 'a method that decodes a spnego token' do
+        let(:gss_service_name) { nil }
+      end
+    end
+  end
+end