Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
04b8f3d3
Commit
04b8f3d3
authored
Jul 14, 2020
by
Himanshu Kapoor
Committed by
Kushal Pandya
Jul 14, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Cleanup async actions
Use return instead of calling done() and done.fail()
parent
4529939f
Changes
3
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
117 additions
and
205 deletions
+117
-205
app/assets/javascripts/ide/stores/actions/file.js
app/assets/javascripts/ide/stores/actions/file.js
+5
-3
changelogs/unreleased/223928-page-title-editorconfig.yml
changelogs/unreleased/223928-page-title-editorconfig.yml
+5
-0
spec/frontend/ide/stores/actions/file_spec.js
spec/frontend/ide/stores/actions/file_spec.js
+107
-202
No files found.
app/assets/javascripts/ide/stores/actions/file.js
View file @
04b8f3d3
...
...
@@ -79,11 +79,13 @@ export const getFileData = (
return
service
.
getFileData
(
url
)
.
then
(({
data
})
=>
{
setPageTitleForFile
(
state
,
file
);
if
(
data
)
commit
(
types
.
SET_FILE_DATA
,
{
data
,
file
});
if
(
openFile
)
commit
(
types
.
TOGGLE_FILE_OPEN
,
path
);
if
(
makeFileActive
)
dispatch
(
'
setFileActive
'
,
path
);
if
(
makeFileActive
)
{
setPageTitleForFile
(
state
,
file
);
dispatch
(
'
setFileActive
'
,
path
);
}
})
.
catch
(()
=>
{
dispatch
(
'
setErrorMessage
'
,
{
...
...
changelogs/unreleased/223928-page-title-editorconfig.yml
0 → 100644
View file @
04b8f3d3
---
title
:
'
Web
IDE:
Page
title
should
not
be
.editorconfig
when
the
IDE
is
first
loaded.'
merge_request
:
36783
author
:
type
:
fixed
spec/frontend/ide/stores/actions/file_spec.js
View file @
04b8f3d3
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment