Merge branch 'rc/enable_rspec_cops_1' into 'master'

Enable RSpec/ReceiveCounts and RSpec/ContextMethod cops

See merge request gitlab-org/gitlab!23456

.rubocop.yml

@@ -301,12 +301,6 @@ RSpec/AnyInstanceOf:
   Enabled: false
 
 # Cops for upgrade to gitlab-styles 3.1.0
-RSpec/ReceiveCounts:
-  Enabled: false
-
-RSpec/ContextMethod:
-  Enabled: false
-
 RSpec/ImplicitSubject:
   Enabled: false
 

.rubocop_todo.yml

@@ -782,3 +782,129 @@ Style/UnneededSort:
   Exclude:
     - 'app/models/concerns/resolvable_discussion.rb'
     - 'lib/gitlab/highlight.rb'
+
+RSpec/ReceiveCounts:
+  Exclude:
+    - 'ee/spec/models/broadcast_message_spec.rb'
+    - 'ee/spec/services/geo/project_housekeeping_service_spec.rb'
+    - 'ee/spec/services/geo/repository_sync_service_spec.rb'
+    - 'spec/lib/gitlab/ci/build/rules/rule/clause/exists_spec.rb'
+    - 'spec/lib/gitlab/ci/trace/section_parser_spec.rb'
+    - 'spec/lib/gitlab/cleanup/project_uploads_spec.rb'
+    - 'spec/lib/gitlab/danger/teammate_spec.rb'
+    - 'spec/lib/gitlab/git_access_spec.rb'
+    - 'spec/lib/gitlab/gpg_spec.rb'
+    - 'spec/lib/gitlab/legacy_github_import/importer_spec.rb'
+    - 'spec/lib/gitlab/sanitizers/exif_spec.rb'
+    - 'spec/models/concerns/avatarable_spec.rb'
+    - 'spec/models/concerns/triggerable_hooks_spec.rb'
+    - 'spec/requests/api/graphql_spec.rb'
+    - 'spec/services/ci/ensure_stage_service_spec.rb'
+    - 'spec/services/clusters/cleanup/app_service_spec.rb'
+    - 'spec/services/notification_service_spec.rb'
+    - 'spec/services/projects/housekeeping_service_spec.rb'
+    - 'spec/tasks/gitlab/cleanup_rake_spec.rb'
+    - 'spec/uploaders/gitlab_uploader_spec.rb'
+    - 'spec/workers/create_gpg_signature_worker_spec.rb'
+
+RSpec/ContextMethod:
+  Exclude:
+    - 'ee/spec/controllers/ee/projects/autocomplete_sources_controller_spec.rb'
+    - 'ee/spec/controllers/groups/autocomplete_sources_controller_spec.rb'
+    - 'ee/spec/finders/geo/file_registry_finder_spec.rb'
+    - 'ee/spec/helpers/feature_flags_helper_spec.rb'
+    - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb'
+    - 'ee/spec/lib/ee/gitlab/ci/config/entry/trigger_spec.rb'
+    - 'ee/spec/lib/elastic/latest/snippet_instance_proxy_spec.rb'
+    - 'ee/spec/lib/gitlab/contribution_analytics/data_collector_spec.rb'
+    - 'ee/spec/lib/gitlab/geo/replication/file_transfer_spec.rb'
+    - 'ee/spec/lib/gitlab/geo/replication/job_artifact_downloader_spec.rb'
+    - 'ee/spec/lib/gitlab/geo/replication/job_artifact_retriever_spec.rb'
+    - 'ee/spec/lib/gitlab/geo/replication/job_artifact_transfer_spec.rb'
+    - 'ee/spec/lib/gitlab/geo/replication/lfs_downloader_spec.rb'
+    - 'ee/spec/lib/gitlab/geo/replication/lfs_retriever_spec.rb'
+    - 'ee/spec/lib/gitlab/geo/replication/lfs_transfer_spec.rb'
+    - 'ee/spec/lib/gitlab/geo_spec.rb'
+    - 'ee/spec/models/approval_state_spec.rb'
+    - 'ee/spec/models/approval_wrapped_any_approver_rule_spec.rb'
+    - 'ee/spec/models/concerns/approval_rule_like_spec.rb'
+    - 'ee/spec/models/concerns/elastic/issue_spec.rb'
+    - 'ee/spec/models/concerns/elastic/note_spec.rb'
+    - 'ee/spec/models/concerns/elastic/project_spec.rb'
+    - 'ee/spec/models/concerns/epic_tree_sorting_spec.rb'
+    - 'ee/spec/models/concerns/has_timelogs_report_spec.rb'
+    - 'ee/spec/models/ee/clusters/applications/prometheus_spec.rb'
+    - 'ee/spec/models/ee/clusters/platforms/kubernetes_spec.rb'
+    - 'ee/spec/models/user_spec.rb'
+    - 'ee/spec/presenters/ci/pipeline_presenter_spec.rb'
+    - 'ee/spec/requests/api/epics_spec.rb'
+    - 'ee/spec/services/boards/update_service_spec.rb'
+    - 'ee/spec/services/ee/boards/issues/list_service_spec.rb'
+    - 'ee/spec/services/ee/merge_requests/refresh_service_spec.rb'
+    - 'ee/spec/services/groups/update_service_spec.rb'
+    - 'ee/spec/services/projects/create_from_template_service_spec.rb'
+    - 'ee/spec/services/projects/update_service_spec.rb'
+    - 'ee/spec/services/update_build_minutes_service_spec.rb'
+    - 'ee/spec/support/shared_examples/features/gold_trial_callout_shared_examples.rb'
+    - 'ee/spec/support/shared_examples/models/concerns/elastic/limited_indexing_shared_examples.rb'
+    - 'qa/spec/ee/scenario/test/integration/group_saml_spec.rb'
+    - 'qa/spec/resource/api_fabricator_spec.rb'
+    - 'qa/spec/scenario/test/integration/github_spec.rb'
+    - 'qa/spec/scenario/test/integration/instance_saml_spec.rb'
+    - 'qa/spec/scenario/test/integration/kubernetes_spec.rb'
+    - 'qa/spec/scenario/test/integration/ldap_spec.rb'
+    - 'qa/spec/scenario/test/integration/mattermost_spec.rb'
+    - 'qa/spec/scenario/test/integration/oauth_spec.rb'
+    - 'qa/spec/scenario/test/integration/object_storage_spec.rb'
+    - 'qa/spec/specs/runner_spec.rb'
+    - 'spec/controllers/application_controller_spec.rb'
+    - 'spec/controllers/projects/milestones_controller_spec.rb'
+    - 'spec/features/projects/blobs/blob_show_spec.rb'
+    - 'spec/finders/concerns/finder_with_cross_project_access_spec.rb'
+    - 'spec/helpers/diff_helper_spec.rb'
+    - 'spec/helpers/nav_helper_spec.rb'
+    - 'spec/helpers/sourcegraph_helper_spec.rb'
+    - 'spec/lib/container_registry/registry_spec.rb'
+    - 'spec/lib/container_registry/tag_spec.rb'
+    - 'spec/lib/gitlab/ci/trace/chunked_io_spec.rb'
+    - 'spec/lib/gitlab/content_security_policy/config_loader_spec.rb'
+    - 'spec/lib/gitlab/database/count_spec.rb'
+    - 'spec/lib/gitlab/git/rugged_impl/use_rugged_spec.rb'
+    - 'spec/lib/gitlab/git_ref_validator_spec.rb'
+    - 'spec/lib/gitlab/private_commit_email_spec.rb'
+    - 'spec/lib/gitlab/rugged_instrumentation_spec.rb'
+    - 'spec/lib/omni_auth/strategies/jwt_spec.rb'
+    - 'spec/lib/safe_zip/entry_spec.rb'
+    - 'spec/lib/safe_zip/extract_spec.rb'
+    - 'spec/models/badge_spec.rb'
+    - 'spec/models/badges/project_badge_spec.rb'
+    - 'spec/models/ci/artifact_blob_spec.rb'
+    - 'spec/models/ci/persistent_ref_spec.rb'
+    - 'spec/models/ci/runner_spec.rb'
+    - 'spec/models/concerns/routable_spec.rb'
+    - 'spec/models/deployment_spec.rb'
+    - 'spec/models/issue_spec.rb'
+    - 'spec/models/notification_recipient_spec.rb'
+    - 'spec/models/project_services/bamboo_service_spec.rb'
+    - 'spec/models/project_services/buildkite_service_spec.rb'
+    - 'spec/models/project_services/chat_message/issue_message_spec.rb'
+    - 'spec/models/project_services/drone_ci_service_spec.rb'
+    - 'spec/models/project_services/hipchat_service_spec.rb'
+    - 'spec/models/project_services/jira_service_spec.rb'
+    - 'spec/models/project_spec.rb'
+    - 'spec/models/remote_mirror_spec.rb'
+    - 'spec/models/user_spec.rb'
+    - 'spec/models/wiki_page_spec.rb'
+    - 'spec/requests/api/issues/get_group_issues_spec.rb'
+    - 'spec/requests/api/merge_requests_spec.rb'
+    - 'spec/serializers/diff_file_entity_spec.rb'
+    - 'spec/services/branches/delete_merged_service_spec.rb'
+    - 'spec/services/labels/available_labels_service_spec.rb'
+    - 'spec/services/projects/batch_open_issues_count_service_spec.rb'
+    - 'spec/services/projects/destroy_service_spec.rb'
+    - 'spec/services/projects/hashed_storage/migrate_attachments_service_spec.rb'
+    - 'spec/services/projects/hashed_storage/rollback_attachments_service_spec.rb'
+    - 'spec/services/projects/open_issues_count_service_spec.rb'
+    - 'spec/services/quick_actions/interpret_service_spec.rb'
+    - 'spec/support/shared_examples/services/boards/issues_list_service_shared_examples.rb'
+    - 'spec/uploaders/namespace_file_uploader_spec.rb'
\ No newline at end of file