Introduce feature flag for cancel on delete

Introduce canceling on delete flag and start

to move some logic to be sync. Do not enable
the feature flag without completing TODO.

app/services/ci/destroy_pipeline_service.rb

@@ -7,6 +7,8 @@ module Ci
 
       Ci::ExpirePipelineCacheService.new.execute(pipeline, delete: true)
 
+      pipeline.cancel_running if pipeline.cancelable? && ::Feature.enabled?(:cancel_pipelines_prior_to_destroy, default_enabled: :yaml)
+
       pipeline.destroy!
 
       ServiceResponse.success(message: 'Pipeline not found')

config/feature_flags/development/cancel_pipelines_prior_to_destroy.yml

+---
+name: cancel_pipelines_prior_to_destroy
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/65586
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/335338
+milestone: '14.1'
+type: development
+group: group::continuous integration
+default_enabled: false

ee/app/models/ee/ci/build.rb

@@ -48,6 +48,21 @@ module EE
             .for_ref(ref)
             .for_project_paths(project_path)
         end
+
+        state_machine :status do
+          after_transition any => [:success, :failed, :canceled] do |build|
+            build.run_after_commit do
+              # TODO(Issue #331891): before enabling this feature flag. Move update consumption to async while keeping consumption calculation sync.
+              # This will ensure consumption is calculated before related records are deleted.
+              if ::Feature.enabled?(:cancel_pipelines_prior_to_destroy, default_enabled: :yaml)
+                ::Ci::Minutes::UpdateBuildMinutesService.new(build.project, nil).execute(build)
+                # We need to use `reset` on `project` because their AR associations have been cached
+                # and `Namespace#namespace_statistics` will return stale data.
+                ::Ci::Minutes::EmailNotificationService.new(build.project.reset).execute if ::Gitlab.com?
+              end
+            end
+          end
+        end
       end
 
       override :variables

ee/app/workers/ee/build_finished_worker.rb

@@ -3,10 +3,12 @@
 module EE
   module BuildFinishedWorker
     def process_build(build)
-      ::Ci::Minutes::UpdateBuildMinutesService.new(build.project, nil).execute(build)
-      # We need to use `reset` on `project` because their AR associations have been cached
-      # and `Namespace#namespace_statistics` will return stale data.
-      ::Ci::Minutes::EmailNotificationService.new(build.project.reset).execute if ::Gitlab.com?
+      unless ::Feature.enabled?(:cancel_pipelines_prior_to_destroy, default_enabled: :yaml)
+        ::Ci::Minutes::UpdateBuildMinutesService.new(build.project, nil).execute(build)
+        # We need to use `reset` on `project` because their AR associations have been cached
+        # and `Namespace#namespace_statistics` will return stale data.
+        ::Ci::Minutes::EmailNotificationService.new(build.project.reset).execute if ::Gitlab.com?
+      end
 
       RequirementsManagement::ProcessRequirementsReportsWorker.perform_async(build.id)
 

ee/spec/models/ci/build_spec.rb

@@ -88,19 +88,33 @@ RSpec.describe Ci::Build do
     it_behaves_like 'depends on runner presence and type'
   end
 
-  context 'updates pipeline minutes' do
-    let(:job) { create(:ci_build, :running, pipeline: pipeline) }
+  shared_context 'updates minutes' do
+    context 'updates pipeline minutes' do
+      let(:job) { create(:ci_build, :running, pipeline: pipeline) }
 
-    %w(success drop cancel).each do |event|
-      it "for event #{event}", :sidekiq_might_not_need_inline do
-        expect(Ci::Minutes::UpdateBuildMinutesService)
-          .to receive(:new).and_call_original
+      %w(success drop cancel).each do |event|
+        it "for event #{event}" do
+          expect(Ci::Minutes::UpdateBuildMinutesService)
+            .to receive(:new).and_call_original
 
-        job.public_send(event)
+          job.public_send(event)
+        end
       end
     end
   end
 
+  context 'when cancel_pipelines_prior_to_destroy is enabled' do
+    include_context 'updates minutes'
+  end
+
+  context 'when cancel_pipelines_prior_to_destroy is disabled', :sidekiq_inline do
+    before do
+      stub_feature_flags(cancel_pipelines_prior_to_destroy: false)
+    end
+
+    include_context 'updates minutes'
+  end
+
   describe '#variables' do
     subject { job.variables }
 

ee/spec/workers/build_finished_worker_spec.rb

@@ -27,21 +27,27 @@ RSpec.describe BuildFinishedWorker do
         allow_any_instance_of(EE::Project).to receive(:shared_runners_minutes_limit_enabled?).and_return(true)
       end
 
-      it 'updates the project stats' do
-        expect { subject }.to change { project_stats.reload.shared_runners_seconds }
-      end
+      context 'when cancel_pipelines_prior_to_destroy is disabled' do
+        before do
+          stub_feature_flags(cancel_pipelines_prior_to_destroy: false)
+        end
 
-      it 'updates the namespace stats' do
-        expect { subject }.to change { namespace_stats.reload.shared_runners_seconds }
-      end
+        it 'updates the project stats' do
+          expect { subject }.to change { project_stats.reload.shared_runners_seconds }
+        end
 
-      it 'notifies the owners of Groups' do
-        namespace.update_attribute(:shared_runners_minutes_limit, 2000)
-        namespace_stats.update_attribute(:shared_runners_seconds, 2100 * 60)
+        it 'updates the namespace stats' do
+          expect { subject }.to change { namespace_stats.reload.shared_runners_seconds }
+        end
 
-        expect(CiMinutesUsageMailer).to receive(:notify).once.with(namespace, [namespace.owner.email]).and_return(spy)
+        it 'notifies the owners of Groups' do
+          namespace.update_attribute(:shared_runners_minutes_limit, 2000)
+          namespace_stats.update_attribute(:shared_runners_seconds, 2100 * 60)
 
-        subject
+          expect(CiMinutesUsageMailer).to receive(:notify).once.with(namespace, [namespace.owner.email]).and_return(spy)
+
+          subject
+        end
       end
     end
 

spec/services/ci/destroy_pipeline_service_spec.rb

@@ -67,6 +67,30 @@ RSpec.describe ::Ci::DestroyPipelineService do
         end
       end
     end
+
+    context 'when pipeline is in cancelable state' do
+      before do
+        allow(pipeline).to receive(:cancelable?).and_return(true)
+      end
+
+      it 'cancels the pipeline' do
+        expect(pipeline).to receive(:cancel_running)
+
+        subject
+      end
+
+      context 'when cancel_pipelines_prior_to_destroy is disabled' do
+        before do
+          stub_feature_flags(cancel_pipelines_prior_to_destroy: false)
+        end
+
+        it "doesn't cancel the pipeline" do
+          expect(pipeline).not_to receive(:cancel_running)
+
+          subject
+        end
+      end
+    end
   end
 
   context 'user is not owner' do