Merge branch 'vs/ci-add-graphql-linting-with-apollo' into 'master'

Add new CI job for linting GraphQL with Apollo

See merge request gitlab-org/gitlab!75220

.eslintrc.yml

@@ -138,4 +138,4 @@ overrides:
       #'@graphql-eslint/known-type-names': error
       '@graphql-eslint/no-anonymous-operations': error
       '@graphql-eslint/unique-operation-name': error
-      # '@graphql-eslint/require-id-when-available': error
+      '@graphql-eslint/require-id-when-available': error

.gitignore

@@ -95,7 +95,6 @@ jsdoc/
 webpack-dev-server.json
 /.nvimrc
 .solargraph.yml
-apollo.config.js
 /tmp/matching_foss_tests.txt
 /tmp/matching_tests.txt
 ee/changelogs/unreleased-ee

.gitlab/ci/static-analysis.gitlab-ci.yml

@@ -10,6 +10,7 @@
     # Disable warnings in browserslist which can break on backports
     # https://github.com/browserslist/browserslist/blob/a287ec6/node.js#L367-L384
     BROWSERSLIST_IGNORE_OLD_DATA: "true"
+    GRAPHQL_SCHEMA_APOLLO_FILE: "tmp/tests/graphql/gitlab_schema_apollo.graphql"
 
 update-static-analysis-cache:
   extends:
@@ -47,17 +48,34 @@ static-verification-with-database:
   variables:
     SETUP_DB: "true"
 
+generate-apollo-graphl-schema:
+  extends:
+    - .static-analysis-base
+    - .frontend:rules:default-frontend-jobs
+  image:
+    name: registry.gitlab.com/gitlab-org/gitlab-build-images:apollo
+    entrypoint: [""]
+  needs: ['graphql-schema-dump']
+  variables:
+    USE_BUNDLE_INSTALL: "false"
+  script:
+    - apollo client:download-schema --config=config/apollo.config.js ${GRAPHQL_SCHEMA_APOLLO_FILE}
+  artifacts:
+    name: graphql-schema-apollo
+    paths:
+      - "${GRAPHQL_SCHEMA_APOLLO_FILE}"
+
 eslint:
   extends:
     - .static-analysis-base
     - .yarn-cache
-    - .static-analysis:rules:ee
-  needs: []
+    - .frontend:rules:default-frontend-jobs
+  needs: ['generate-apollo-graphl-schema']
   variables:
     USE_BUNDLE_INSTALL: "false"
   script:
     - run_timed_command "retry yarn install --frozen-lockfile"
-    - run_timed_command "yarn run lint:eslint:all"
+    - run_timed_command "yarn run lint:eslint:all --parser-options=schema:${GRAPHQL_SCHEMA_APOLLO_FILE}"
 
 eslint as-if-foss:
   extends:

app/assets/javascripts/alerts_settings/graphql/mutations/create_http_integration.mutation.graphql

@@ -4,8 +4,7 @@ mutation createHttpIntegration($projectPath: ID!, $name: String!, $active: Boole
   httpIntegrationCreate(input: { projectPath: $projectPath, name: $name, active: $active }) {
     errors
     # We have ID in a deeply nested fragment
-    # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-    # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+    # eslint-disable-next-line @graphql-eslint/require-id-when-available
     integration {
       ...HttpIntegrationItem
     }

app/assets/javascripts/alerts_settings/graphql/mutations/destroy_http_integration.mutation.graphql

@@ -4,8 +4,7 @@ mutation destroyHttpIntegration($id: ID!) {
   httpIntegrationDestroy(input: { id: $id }) {
     errors
     # We have ID in a deeply nested fragment
-    # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-    # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+    # eslint-disable-next-line @graphql-eslint/require-id-when-available
     integration {
       ...HttpIntegrationItem
     }

app/assets/javascripts/alerts_settings/graphql/mutations/reset_http_token.mutation.graphql

@@ -4,8 +4,7 @@ mutation resetHttpIntegrationToken($id: ID!) {
   httpIntegrationResetToken(input: { id: $id }) {
     errors
     # We have ID in a deeply nested fragment
-    # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-    # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+    # eslint-disable-next-line @graphql-eslint/require-id-when-available
     integration {
       ...HttpIntegrationItem
     }

app/assets/javascripts/alerts_settings/graphql/mutations/update_http_integration.mutation.graphql

@@ -4,8 +4,7 @@ mutation updateHttpIntegration($id: ID!, $name: String!, $active: Boolean!) {
   httpIntegrationUpdate(input: { id: $id, name: $name, active: $active }) {
     errors
     # We have ID in a deeply nested fragment
-    # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-    # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+    # eslint-disable-next-line @graphql-eslint/require-id-when-available
     integration {
       ...HttpIntegrationItem
     }

app/assets/javascripts/boards/graphql/board_list_create.mutation.graphql

@@ -3,8 +3,7 @@
 mutation createBoardList($boardId: BoardID!, $backlog: Boolean, $labelId: LabelID) {
   boardListCreate(input: { boardId: $boardId, backlog: $backlog, labelId: $labelId }) {
     # We have ID in a deeply nested fragment
-    # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-    # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+    # eslint-disable-next-line @graphql-eslint/require-id-when-available
     list {
       ...BoardListFragment
     }

app/assets/javascripts/boards/graphql/board_list_update.mutation.graphql

@@ -3,8 +3,7 @@
 mutation UpdateBoardList($listId: ID!, $position: Int, $collapsed: Boolean) {
   updateBoardList(input: { listId: $listId, position: $position, collapsed: $collapsed }) {
     # We have ID in a deeply nested fragment
-    # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-    # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+    # eslint-disable-next-line @graphql-eslint/require-id-when-available
     list {
       ...BoardListFragment
     }

app/assets/javascripts/boards/graphql/board_lists.query.graphql

@@ -14,8 +14,7 @@ query BoardLists(
       hideBacklogList
       lists(issueFilters: $filters) {
         # We have ID in a deeply nested fragment
-        # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-        # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+        # eslint-disable-next-line @graphql-eslint/require-id-when-available
         nodes {
           ...BoardListFragment
         }
@@ -29,8 +28,7 @@ query BoardLists(
       hideBacklogList
       lists(issueFilters: $filters) {
         # We have ID in a deeply nested fragment
-        # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-        # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+        # eslint-disable-next-line @graphql-eslint/require-id-when-available
         nodes {
           ...BoardListFragment
         }

app/assets/javascripts/design_management/graphql/mutations/upload_design.mutation.graphql

@@ -3,8 +3,7 @@
 
 mutation uploadDesign($files: [Upload!]!, $projectPath: ID!, $iid: ID!) {
   designManagementUpload(input: { projectPath: $projectPath, iid: $iid, files: $files }) {
-    # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-    # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+    # eslint-disable-next-line @graphql-eslint/require-id-when-available
     designs {
       ...DesignItem
       versions {

app/assets/javascripts/design_management/graphql/queries/get_design.query.graphql

@@ -13,8 +13,7 @@ query getDesign(
       id
       designCollection {
         designs(atVersion: $atVersion, filenames: $filenames) {
-          # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-          # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+          # eslint-disable-next-line @graphql-eslint/require-id-when-available
           nodes {
             ...DesignItem
             issue {

app/assets/javascripts/graphql_shared/fragments/user_availability.fragment.graphql

-# TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-# # eslint-disable-next-line @graphql-eslint/require-id-when-available
+# eslint-disable-next-line @graphql-eslint/require-id-when-available
 fragment UserAvailability on User {
   status {
     availability

app/assets/javascripts/incidents/graphql/fragments/incident_fields.fragment.graphql

-# TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-# # eslint-disable-next-line @graphql-eslint/require-id-when-available
+# eslint-disable-next-line @graphql-eslint/require-id-when-available
 fragment IncidentFields on Issue {
   severity
 }

app/assets/javascripts/runner/graphql/get_runner.query.graphql

@@ -2,8 +2,7 @@
 
 query getRunner($id: CiRunnerID!) {
   # We have an id in deeply nested fragment
-  # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-  # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+  # eslint-disable-next-line @graphql-eslint/require-id-when-available
   runner(id: $id) {
     ...RunnerDetails
   }

app/assets/javascripts/runner/graphql/runner_update.mutation.graphql

@@ -6,8 +6,7 @@
 mutation runnerUpdate($input: RunnerUpdateInput!) {
   runnerUpdate(input: $input) {
     # We have an id in deep nested fragment
-    # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-    # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+    # eslint-disable-next-line @graphql-eslint/require-id-when-available
     runner {
       ...RunnerDetails
     }

app/graphql/queries/epic/epic_children.query.graphql

@@ -72,8 +72,7 @@ query childItems(
         edges {
           __typename
           # We have an id in deeply nested fragment
-          # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-          # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+          # eslint-disable-next-line @graphql-eslint/require-id-when-available
           node {
             __typename
             ...EpicNode

config/apollo.config.js

+module.exports = {
+  client: {
+    service: {
+      name: 'gitlab',
+      localSchemaFile: './tmp/tests/graphql/gitlab_schema.graphql',
+    },
+    includes: ['../{ee/,jh/,}app/assets/javascripts/**/*.{js,graphql}'],
+    excludes: ['../{ee/,jh/,}spec/{frontend,frontend_integration}/**/*'],
+  },
+};

ee/app/assets/javascripts/alerts_settings/graphql/mutations/create_http_integration.mutation.graphql

@@ -18,8 +18,7 @@ mutation createHttpIntegrationEE(
   ) {
     errors
     # We have an id in deeply nested fragment
-    # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-    # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+    # eslint-disable-next-line @graphql-eslint/require-id-when-available
     integration {
       ...HttpIntegrationItem
     }

ee/app/assets/javascripts/alerts_settings/graphql/mutations/update_http_integration.mutation.graphql

@@ -18,8 +18,7 @@ mutation updateHttpIntegrationEE(
   ) {
     errors
     # We have an id in deeply nested fragment
-    # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-    # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+    # eslint-disable-next-line @graphql-eslint/require-id-when-available
     integration {
       ...HttpIntegrationItem
     }

ee/app/assets/javascripts/boards/graphql/board_list_create.mutation.graphql

@@ -19,8 +19,7 @@ mutation createBoardListEE(
     }
   ) {
     # We have an id in deeply nested fragment
-    # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-    # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+    # eslint-disable-next-line @graphql-eslint/require-id-when-available
     list {
       ...BoardListFragment
     }

ee/app/assets/javascripts/boards/graphql/board_lists.query.graphql

@@ -14,8 +14,7 @@ query ListIssues(
       hideBacklogList
       lists(issueFilters: $filters) {
         # We have an id in deeply nested fragment
-        # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-        # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+        # eslint-disable-next-line @graphql-eslint/require-id-when-available
         nodes {
           ...BoardListFragment
         }
@@ -29,8 +28,7 @@ query ListIssues(
       hideBacklogList
       lists(issueFilters: $filters) {
         # We have an id in deeply nested fragment
-        # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-        # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+        # eslint-disable-next-line @graphql-eslint/require-id-when-available
         nodes {
           ...BoardListFragment
         }

ee/app/assets/javascripts/boards/graphql/epic_create.mutation.graphql

@@ -4,8 +4,7 @@
 mutation CreateEpic($input: CreateEpicInput!) {
   createEpic(input: $input) {
     # We have an id in deeply nested fragment
-    # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-    # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+    # eslint-disable-next-line @graphql-eslint/require-id-when-available
     epic {
       ...EpicNode
       labels {

ee/app/assets/javascripts/boards/graphql/list_update_limit_metrics.mutation.graphql

@@ -3,8 +3,7 @@
 mutation boardListUpdateLimitMetrics($input: BoardListUpdateLimitMetricsInput!) {
   boardListUpdateLimitMetrics(input: $input) {
     # We have an id in deeply nested fragment
-    # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-    # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+    # eslint-disable-next-line @graphql-eslint/require-id-when-available
     list {
       ...BoardListFragment
     }

ee/app/assets/javascripts/boards/graphql/lists_epics.query.graphql

@@ -19,8 +19,7 @@ query epicBoardListEpics(
           epics(first: $first, after: $after, filters: $filters) {
             edges {
               # We have an id in deeply nested fragment
-              # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-              # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+              # eslint-disable-next-line @graphql-eslint/require-id-when-available
               node {
                 ...EpicNode
                 relativePosition

ee/app/assets/javascripts/incidents/graphql/fragments/incident_fields.fragment.graphql

-# TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-# # eslint-disable-next-line @graphql-eslint/require-id-when-available
+# eslint-disable-next-line @graphql-eslint/require-id-when-available
 fragment IncidentFields on Issue {
   severity
   statusPagePublishedIncident

ee/app/assets/javascripts/oncall_schedules/graphql/queries/get_oncall_schedules_with_rotations_shifts.query.graphql

@@ -7,8 +7,7 @@ query getShiftsForRotations($projectPath: ID!, $startsAt: Time!, $endsAt: Time!,
       nodes {
         rotations {
           # We have an id in deeply nested fragment
-          # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-          # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+          # eslint-disable-next-line @graphql-eslint/require-id-when-available
           nodes {
             ...OnCallRotationWithShifts
           }

ee/app/assets/javascripts/security_dashboard/graphql/fragments/project_vulnerability_severities_count.fragment.graphql

 #import "ee/security_dashboard/graphql/fragments/vulnerability_severities_count.fragment.graphql"
-# TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-# # eslint-disable-next-line @graphql-eslint/require-id-when-available
+# eslint-disable-next-line @graphql-eslint/require-id-when-available
 fragment ProjectVulnerabilitySeveritiesCount on Project {
   vulnerabilitySeveritiesCount(state: [DETECTED, CONFIRMED]) {
     ...VulnerabilitySeveritiesCount

ee/app/assets/javascripts/vue_shared/components/filtered_search_bar/queries/search_epics.query.graphql

@@ -10,8 +10,7 @@ query searchEpics($fullPath: ID!, $search: String, $state: EpicState) {
       includeDescendantGroups: false
     ) {
       # We have an id in deeply nested fragment
-      # TODO: Uncomment next line when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75220 is merged and the rule is enabled
-      # # eslint-disable-next-line @graphql-eslint/require-id-when-available
+      # eslint-disable-next-line @graphql-eslint/require-id-when-available
       nodes {
         ...EpicNode
       }